searching for reviewer(mstange)
c3a29fe74237d76e685b5324ba74e726285a538c: Bug 1558642 - Remove synthesizeNativeOSXClick and consumer tests. r?mstange draft
pulselistener - Tue, 18 Jun 2019 19:08:04 +0000 - rev 2103156
Push 379032 by reviewbot at Tue, 18 Jun 2019 19:08:47 +0000
Bug 1558642 - Remove synthesizeNativeOSXClick and consumer tests. r?mstange synthesizeNativeOSXClick uses CGEventPost, that needs "Accessibility Access (Events)" on macOS 10.14 or later, and cannot be tested in automation without human interaction to add the access. Differential Diff: PHID-DIFF-q3zk27qk6hs7zakc67xw
1930f9790328a9003b4d0749aed2a1c3837b7822: Bug 1556556 - Remove many uses of IgnoreRootScrollFrame. r=mstange draft
Botond Ballo <botond@mozilla.com> - Fri, 14 Jun 2019 18:49:32 -0400 - rev 2065156
Push 378459 by bballo@mozilla.com at Fri, 14 Jun 2019 22:51:37 +0000
Bug 1556556 - Remove many uses of IgnoreRootScrollFrame. r=mstange
fb967567fa1fa1127955d19bb4332fa87d7a5666: Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 13 Jun 2019 08:12:55 -0400 - rev 2064830
Push 378335 by kgupta@mozilla.com at Fri, 14 Jun 2019 18:54:33 +0000
Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange Differential Revision: https://phabricator.services.mozilla.com/D34889
c1a70ae022cd2a9090d24d977e735e8ec5dfa6bf: Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange draft
pulselistener - Thu, 13 Jun 2019 15:27:48 +0000 - rev 2061652
Push 377514 by reviewbot at Thu, 13 Jun 2019 15:28:54 +0000
Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange Differential Diff: PHID-DIFF-zivqe7wfiqsi7kdkscrt
9a19d4484d5e02988beb66f6902e5f8ca754db71: Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 13 Jun 2019 08:12:55 -0400 - rev 2061405
Push 377434 by kgupta@mozilla.com at Thu, 13 Jun 2019 12:27:11 +0000
Bug 1549052 - Avoid using CGEventPost for synthesizing wheel events on macOS. r?mstange
8a9bcdc1dfaf9c170edb1cf508ad4fd94e793a3b: Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:41:38 +0000 - rev 2060470
Push 377164 by reviewbot at Thu, 13 Jun 2019 01:42:07 +0000
Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange Now that Gecko Profiler only registers its entry&exit functions when running, and it ensures that Base Profiler is stopped beforehand, Base Profiler can now register its own entry&exit functions to capture labels before xpcom starts. Differential Diff: PHID-DIFF-3cdjbc3u7tirgfwagk6y
b8a35516c2692001a111146d42c35218af446f87: Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:41:33 +0000 - rev 2060469
Push 377164 by reviewbot at Thu, 13 Jun 2019 01:42:07 +0000
Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange Instead of setting entry&exit function when Gecko Profiler is initialized, we now set them when profiling actually starts, and reset them when profiling stops. AutoProfilerLabel should not be called outside of profiling sessions anyway, and edge cases (missing or unneeded labels at the very start or end of a session) are not an issue. Differential Diff: PHID-DIFF-yzsy5jvleuxwp2hn7zlu
392b89c47c8c68f58780648eef64979226895ed7: Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:41:29 +0000 - rev 2060468
Push 377164 by reviewbot at Thu, 13 Jun 2019 01:42:07 +0000
Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange Profilers will soon be able to set/reset entry&exit functions at different times, but simultaneously other code may want to use AutoProfilerLabel, so we need to make this all thread-safe. All shared static information is now encapsulated in an RAII class that enforces proper locking before giving access to this information. Also added a "generation" count, so that if an AutoProfilerLabel is in-flight when entry&exit functions are changed, the context given by the old entry function will not be passed to a mismatched new exit function. Differential Diff: PHID-DIFF-4kynnzqf6jcs4nucyarq
5b7918bfe134b428dc7ed8539d2a8dbd8082d5fa: Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:41:24 +0000 - rev 2060467
Push 377164 by reviewbot at Thu, 13 Jun 2019 01:42:07 +0000
Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange `ProfilingStack*` happens to be the information that the current Gecko Profiler entry function wants to forward to the exit function, but AutoProfilerLabel does not really need to know about that. Changing it to `void*`, so that we can later use different entry/exit functions that use different context types. Differential Diff: PHID-DIFF-txqnl7pf3poyff2qxe4g
2b9da23b13e7feed58246d842ae70a832751b3e4: Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:37:37 +0000 - rev 2060463
Push 377162 by reviewbot at Thu, 13 Jun 2019 01:38:04 +0000
Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange Instead of setting entry&exit function when Gecko Profiler is initialized, we now set them when profiling actually starts, and reset them when profiling stops. AutoProfilerLabel should not be called outside of profiling sessions anyway, and edge cases (missing or unneeded labels at the very start or end of a session) are not an issue. Differential Diff: PHID-DIFF-yzsy5jvleuxwp2hn7zlu
de94d8921971abc9a5dec4b91ed40d501d9f7054: Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:37:33 +0000 - rev 2060462
Push 377162 by reviewbot at Thu, 13 Jun 2019 01:38:04 +0000
Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange Profilers will soon be able to set/reset entry&exit functions at different times, but simultaneously other code may want to use AutoProfilerLabel, so we need to make this all thread-safe. All shared static information is now encapsulated in an RAII class that enforces proper locking before giving access to this information. Also added a "generation" count, so that if an AutoProfilerLabel is in-flight when entry&exit functions are changed, the context given by the old entry function will not be passed to a mismatched new exit function. Differential Diff: PHID-DIFF-4kynnzqf6jcs4nucyarq
8fc329dee19717a0cd42d82c7f81bb8991f56107: Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:37:28 +0000 - rev 2060461
Push 377162 by reviewbot at Thu, 13 Jun 2019 01:38:04 +0000
Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange `ProfilingStack*` happens to be the information that the current Gecko Profiler entry function wants to forward to the exit function, but AutoProfilerLabel does not really need to know about that. Changing it to `void*`, so that we can later use different entry/exit functions that use different context types. Differential Diff: PHID-DIFF-txqnl7pf3poyff2qxe4g
e95f0dd6c4de1919c8af2f5a3954578c97b2a619: Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:39:22 +1000 - rev 2060459
Push 377161 by gsquelart@mozilla.com at Thu, 13 Jun 2019 01:36:50 +0000
Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange Now that Gecko Profiler only registers its entry&exit functions when running, and it ensures that Base Profiler is stopped beforehand, Base Profiler can now register its own entry&exit functions to capture labels before xpcom starts. Differential Revision: https://phabricator.services.mozilla.com/D34810
9e859372ff61138d59f0646b61a70104a461b963: Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:32:08 +1000 - rev 2060458
Push 377161 by gsquelart@mozilla.com at Thu, 13 Jun 2019 01:36:50 +0000
Bug 1559000 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange Instead of setting entry&exit function when Gecko Profiler is initialized, we now set them when profiling actually starts, and reset them when profiling stops. AutoProfilerLabel should not be called outside of profiling sessions anyway, and edge cases (missing or unneeded labels at the very start or end of a session) are not an issue. Differential Revision: https://phabricator.services.mozilla.com/D34808
9b39b996090d096c2a8d3539f0092b2a37363c60: Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:26:47 +1000 - rev 2060457
Push 377161 by gsquelart@mozilla.com at Thu, 13 Jun 2019 01:36:50 +0000
Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange Profilers will soon be able to set/reset entry&exit functions at different times, but simultaneously other code may want to use AutoProfilerLabel, so we need to make this all thread-safe. All shared static information is now encapsulated in an RAII class that enforces proper locking before giving access to this information. Also added a "generation" count, so that if an AutoProfilerLabel is in-flight when entry&exit functions are changed, the context given by the old entry function will not be passed to a mismatched new exit function. Differential Revision: https://phabricator.services.mozilla.com/D34807
abe6179d3b0943cd6fbf079af017036c6e7dea62: Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 15:21:25 +1000 - rev 2060456
Push 377161 by gsquelart@mozilla.com at Thu, 13 Jun 2019 01:36:50 +0000
Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange `ProfilingStack*` happens to be the information that the current Gecko Profiler entry function wants to forward to the exit function, but AutoProfilerLabel does not really need to know about that. Changing it to `void*`, so that we can later use different entry/exit functions that use different context types. Differential Revision: https://phabricator.services.mozilla.com/D34806
45d7154f1c5d2d12fad636b0d62c9c180c0725bc: Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:35:54 +0000 - rev 2060454
Push 377160 by reviewbot at Thu, 13 Jun 2019 01:36:29 +0000
Bug 1559000 - Make AutoProfilerLabel thread-safe - r?mstange Profilers will soon be able to set/reset entry&exit functions at different times, but simultaneously other code may want to use AutoProfilerLabel, so we need to make this all thread-safe. All shared static information is now encapsulated in an RAII class that enforces proper locking before giving access to this information. Also added a "generation" count, so that if an AutoProfilerLabel is in-flight when entry&exit functions are changed, the context given by the old entry function will not be passed to a mismatched new exit function. Differential Diff: PHID-DIFF-4kynnzqf6jcs4nucyarq
5b9f34569f17b784d9810c8788d17686bb56736c: Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:35:50 +0000 - rev 2060453
Push 377160 by reviewbot at Thu, 13 Jun 2019 01:36:29 +0000
Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange `ProfilingStack*` happens to be the information that the current Gecko Profiler entry function wants to forward to the exit function, but AutoProfilerLabel does not really need to know about that. Changing it to `void*`, so that we can later use different entry/exit functions that use different context types. Differential Diff: PHID-DIFF-txqnl7pf3poyff2qxe4g
23875c2ca9c4e3e72bb5d800c381beec5bc3cc67: Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
pulselistener - Thu, 13 Jun 2019 01:33:54 +0000 - rev 2060451
Push 377159 by reviewbot at Thu, 13 Jun 2019 01:34:32 +0000
Bug 1559000 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange `ProfilingStack*` happens to be the information that the current Gecko Profiler entry function wants to forward to the exit function, but AutoProfilerLabel does not really need to know about that. Changing it to `void*`, so that we can later use different entry/exit functions that use different context types. Differential Diff: PHID-DIFF-txqnl7pf3poyff2qxe4g
bbb557a5c9dc067917dd8bba3b99a8504bfb3ca9: Bug 1556556 - Axe the 'ignoringThisScrollFrame' codepath in ScrollFrameHelper::BuildDisplayList. r=mstange draft
Botond Ballo <botond@mozilla.com> - Wed, 12 Jun 2019 19:52:43 -0400 - rev 2060119
Push 377094 by bballo@mozilla.com at Wed, 12 Jun 2019 23:53:40 +0000
Bug 1556556 - Axe the 'ignoringThisScrollFrame' codepath in ScrollFrameHelper::BuildDisplayList. r=mstange
f608a15c24dad2bf2349432d797048f7a543a679: Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange draft
pulselistener - Wed, 12 Jun 2019 23:16:14 +0000 - rev 2060019
Push 377065 by reviewbot at Wed, 12 Jun 2019 23:16:52 +0000
Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange This would've made my life a lot easier. There's a couple things that don't match the spec that I've left as comments. Depends on D31150 Differential Revision: https://phabricator.services.mozilla.com/D31151 Differential Diff: PHID-DIFF-liiyor7tcyjfuyvtaktz
da1a0b9288272a20d7c59810788c8a7b2aee66cc: Bug 1551716 - Deindent some IntersectionObserver code. r=mstange draft
pulselistener - Wed, 12 Jun 2019 23:16:10 +0000 - rev 2060018
Push 377065 by reviewbot at Wed, 12 Jun 2019 23:16:52 +0000
Bug 1551716 - Deindent some IntersectionObserver code. r=mstange Just trying to make it slightly nicer. Probably should get a function to get the root target document frame. Will file a bug for fission since I _suspect_ fission is going to do something about IntersectionObserver. Depends on D31149 Differential Revision: https://phabricator.services.mozilla.com/D31150 Differential Diff: PHID-DIFF-g6d3eil4ue232swwkm2d
37226df0bd95fc94568e5f8946130cdf668ff039: Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange draft
pulselistener - Wed, 12 Jun 2019 23:06:36 +0000 - rev 2059988
Push 377058 by reviewbot at Wed, 12 Jun 2019 23:07:14 +0000
Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange This would've made my life a lot easier. There's a couple things that don't match the spec that I've left as comments. Differential Revision: https://phabricator.services.mozilla.com//D31151 Depends on D31150 Differential Diff: PHID-DIFF-4gy2snebthwxusnkmjd7
b4309e3377685e6f3e372d9c0d1f0dfa440e6a6d: Bug 1551716 - Deindent some IntersectionObserver code. r=mstange draft
pulselistener - Wed, 12 Jun 2019 23:06:31 +0000 - rev 2059987
Push 377058 by reviewbot at Wed, 12 Jun 2019 23:07:14 +0000
Bug 1551716 - Deindent some IntersectionObserver code. r=mstange Just trying to make it slightly nicer. Probably should get a function to get the root target document frame. Will file a bug for fission since I _suspect_ fission is going to do something about IntersectionObserver. Depends on D31149 Differential Revision: https://phabricator.services.mozilla.com/D31150 Differential Diff: PHID-DIFF-g6d3eil4ue232swwkm2d
7a7f225f86bfe2e1eb47e8e435a2b907ac97f722: Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 May 2019 17:01:04 +0200 - rev 2058852
Push 376712 by emilio@crisal.io at Wed, 12 Jun 2019 14:59:57 +0000
Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange This would've made my life a lot easier. There's a couple things that don't match the spec that I've left as comments. Differential Revision: https://phabricator.services.mozilla.com//D31151 Depends on D31150
a6155e9eba95d8bdfe817be36fd6f7c3d324c835: Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 May 2019 17:01:04 +0200 - rev 2058432
Push 376570 by emilio@crisal.io at Wed, 12 Jun 2019 10:50:10 +0000
Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange This would've made my life a lot easier. There's a couple things that don't match the spec that I've left as comments. Differential Revision: https://phabricator.services.mozilla.com//D31151 Depends on D31150
a4c29e2e88245d34304bcf41efafbcab16fb2a37: Bug 1524625 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:39:22 +1000 - rev 2058060
Push 376456 by gsquelart@mozilla.com at Wed, 12 Jun 2019 07:14:29 +0000
Bug 1524625 - Enable/disable mozglue's AutoProfilerLabel when Base Profiler starts/stops - r?mstange
20a03cda32a640c7df11967e4104748e45e16c38: Bug 1524625 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:32:08 +1000 - rev 2058059
Push 376456 by gsquelart@mozilla.com at Wed, 12 Jun 2019 07:14:29 +0000
Bug 1524625 - Enable/disable mozglue's AutoProfilerLabel when Gecko Profiler starts/stops - r?mstange
d347ca6a85b335884fe87f89fe182e15640e1d65: Bug 1524625 - Make AutoProfilerLabel thread-safe - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 16:26:47 +1000 - rev 2058058
Push 376456 by gsquelart@mozilla.com at Wed, 12 Jun 2019 07:14:29 +0000
Bug 1524625 - Make AutoProfilerLabel thread-safe - r?mstange
41f197d286a37b8545795459fe7b6f3e94ca365c: Bug 1524625 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 15:21:25 +1000 - rev 2058057
Push 376456 by gsquelart@mozilla.com at Wed, 12 Jun 2019 07:14:29 +0000
Bug 1524625 - mozglue's AutoProfilerLabel doesn't need to know about ProfilingStack - r?mstange
bdb43da73c351267fc68378904ec56d9a1286516: Bug 1554022 - Use the current position in CSS pixels for the start point of ScrollBy. r=botond,mstange
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 11 Jun 2019 22:43:34 +0000 - rev 2058006
Push 376441 by opoprus@mozilla.com at Wed, 12 Jun 2019 06:04:59 +0000
Bug 1554022 - Use the current position in CSS pixels for the start point of ScrollBy. r=botond,mstange Otherwise clamped positions in layer pixels might cause 1-pixel difference in CSS pixels on Android. Note that there is a fundamental issue on the interaction between the layer-pixel alignment and scrolling APIs (bug 1556685), once we fix the bug properly, we should use the scrolled position, which was given by the scrolling APIs, for the current position. Differential Revision: https://phabricator.services.mozilla.com/D32779
a0de989fbe9a46145d2f50d2f8b791423d1a5bf0: Bug 1556556 - Don't divide the composition bounds clip by the resolution during event delivery either. r=mstange draft
Botond Ballo <botond@mozilla.com> - Mon, 10 Jun 2019 17:29:24 -0400 - rev 2054630
Push 375485 by bballo@mozilla.com at Mon, 10 Jun 2019 21:30:33 +0000
Bug 1556556 - Don't divide the composition bounds clip by the resolution during event delivery either. r=mstange
61b74216fec086031bb9741e6c5739d5eb754768: Bug 1551355 - Use TimeStamp::NowUnfuzzed() instead of TimeStamp::Now() during gecko profiling r=mstange
Denis Palmeiro <dpalmeiro@mozilla.com> - Mon, 10 Jun 2019 17:35:42 +0000 - rev 2054566
Push 375463 by reviewbot at Mon, 10 Jun 2019 20:56:30 +0000
Bug 1551355 - Use TimeStamp::NowUnfuzzed() instead of TimeStamp::Now() during gecko profiling r=mstange The profiler will require non-fuzzed timers for accuracy. Making the switch early will avoid surprises when FuzzyFox is enabled. Differential Revision: https://phabricator.services.mozilla.com/D31010
5a608649393bef07f165cba9526c5e859b9da090: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 19:56:51 +0000 - rev 2052302
Push 374851 by reviewbot at Sat, 08 Jun 2019 08:27:43 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
3a818ef50028d1dab8d9f82c367b036281277990: Bug 1554813 - Size the scroll parts clip to the scroll frame's true outer size. r=mstange draft
Botond Ballo <botond@mozilla.com> - Fri, 31 May 2019 16:12:03 -0400 - rev 2051859
Push 374737 by bballo@mozilla.com at Sat, 08 Jun 2019 00:04:53 +0000
Bug 1554813 - Size the scroll parts clip to the scroll frame's true outer size. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D33377
28f00537218f219f82dbf8ce31b85c3233dca5e3: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
pulselistener - Fri, 07 Jun 2019 21:37:12 +0000 - rev 2051524
Push 374639 by reviewbot at Fri, 07 Jun 2019 21:37:44 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927 Differential Diff: PHID-DIFF-daj72jumtcmosc3q7uw5
056887894f252894ea8b58b71e83aeece09ae011: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 21:54:56 +0200 - rev 2051314
Push 374571 by tziade@mozilla.com at Fri, 07 Jun 2019 19:59:24 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927
0635eeb2fad4f1bae96a51c85f8adddc11693e41: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 07:48:37 +0000 - rev 2051036
Push 374490 by ntim.bugs@gmail.com at Fri, 07 Jun 2019 18:01:26 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
c83dbcc4dade59208e1291208e1fad72543b503d: Bug 1464032 Part 5: Make sure the DrawTarget can create a similar DrawTarget when falling back to empty surface. r=mstange
Bob Owen <bobowencode@gmail.com> - Sun, 02 Dec 2018 14:14:19 +0000 - rev 2050191
Push 374266 by reviewbot at Fri, 07 Jun 2019 12:20:20 +0000
Bug 1464032 Part 5: Make sure the DrawTarget can create a similar DrawTarget when falling back to empty surface. r=mstange Otherwise, we crash in the content process when we try to record this.
10214f6917a7a13baaa9825a2951cb7e560d263c: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 09:47:17 +0200 - rev 2049849
Push 374156 by tziade@mozilla.com at Fri, 07 Jun 2019 07:53:00 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927
8754afab55417795e21f5479548a90540bcc72af: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
pulselistener - Fri, 07 Jun 2019 07:49:24 +0000 - rev 2049847
Push 374155 by reviewbot at Fri, 07 Jun 2019 07:50:56 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927 Differential Diff: PHID-DIFF-2zfmiq6l2je3xqhklhrx
85479a836d98d43bba45ff69aee9acc37ff5feb1: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
Tarek Ziadé <tarek@mozilla.com> - Thu, 06 Jun 2019 18:58:32 +0200 - rev 2049828
Push 374146 by tziade@mozilla.com at Fri, 07 Jun 2019 07:33:06 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927
9d17364a7fcbd0231f2d0cb88efa56c1a28680a1: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
Tarek Ziadé <tarek@mozilla.com> - Thu, 06 Jun 2019 18:58:32 +0200 - rev 2049724
Push 374115 by tziade@mozilla.com at Fri, 07 Jun 2019 05:29:26 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927
12e24a60dfd797fd8f4f1e18427ebd8f6c7476db: Bug 1551992 - Compress profile data before sending to perf-html; r?mstange draft
pulselistener - Thu, 06 Jun 2019 20:42:09 +0000 - rev 2048872
Push 373854 by reviewbot at Thu, 06 Jun 2019 20:43:11 +0000
Bug 1551992 - Compress profile data before sending to perf-html; r?mstange Differential Revision: https://phabricator.services.mozilla.com/D33399 Differential Diff: PHID-DIFF-fnbsj4quvlkt4iogak6m
a40fab0b4398e572b31b86d19ffac1f6cc473db5: Bug 1556421. Fix DrawTargetOffset::GetRect. r=mstange
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 06 Jun 2019 14:11:10 +0000 - rev 2048641
Push 373769 by reviewbot at Thu, 06 Jun 2019 18:56:39 +0000
Bug 1556421. Fix DrawTargetOffset::GetRect. r=mstange We want to ensure that we include the underlying DrawTarget's origin. Differential Revision: https://phabricator.services.mozilla.com/D33518
3c6929ada62be8fb77ba48cb474e3425f67f1332: Bug 1556466. Fix into DrawTargetOffset::IntoLuminanceSource. r=mstange
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 06 Jun 2019 14:11:27 +0000 - rev 2048640
Push 373769 by reviewbot at Thu, 06 Jun 2019 18:56:39 +0000
Bug 1556466. Fix into DrawTargetOffset::IntoLuminanceSource. r=mstange Use the underlying mDrawTarget instead of the base class. Differential Revision: https://phabricator.services.mozilla.com/D33520
2d1aee4b08dce145e96fabaf8cadc3cc69a296f8: Bug 1556468. Use the DrawTarget's offset when calculating the clip. r=mstange
Jeff Muizelaar <jrmuizel@gmail.com> - Thu, 06 Jun 2019 14:12:31 +0000 - rev 2048639
Push 373769 by reviewbot at Thu, 06 Jun 2019 18:56:39 +0000
Bug 1556468. Use the DrawTarget's offset when calculating the clip. r=mstange The code currently assumes an offset of 0,0 Differential Revision: https://phabricator.services.mozilla.com/D33525
701963435bc0c4932ae2f9a66520f688834d433e: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
pulselistener - Thu, 06 Jun 2019 17:51:35 +0000 - rev 2048493
Push 373716 by reviewbot at Thu, 06 Jun 2019 17:52:25 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927 Differential Diff: PHID-DIFF-y7iaufh7yip2jhxdil47
499441b1e37e041fa8165bb110cfd16323b53956: Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange draft
pulselistener - Wed, 05 Jun 2019 20:11:42 +0000 - rev 2046212
Push 372985 by reviewbot at Wed, 05 Jun 2019 20:12:12 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r?jld,mstange Summary: To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we pass it along in GetProcInfo() Tags: #secure-revision Reviewers: jld,mstange Bug #: 1529023 Differential Revision: https://phabricator.services.mozilla.com/D25927 Differential Diff: PHID-DIFF-ajkc74zffagyy5xwsgil
b58a59871bca61224e9219c4df5be6163adffe45: Bug 1552785. Remove macOS print dialog UI for selecting frameset behavior. r=mstange
Jonathan Watt <jwatt@jwatt.org> - Tue, 14 May 2019 17:04:37 +0100 - rev 2044407
Push 372553 by jwatt@jwatt.org at Wed, 05 Jun 2019 07:42:32 +0000
Bug 1552785. Remove macOS print dialog UI for selecting frameset behavior. r=mstange The 85 pixel change in y-axis offset is the distance between the "Print Background Images" checkbox and (removed) "Each Frame on Separate Pages" radio button. Differential Revision: https://phabricator.services.mozilla.com/D33379