searching for reviewer(karlt)
85228e5172e3c45a2e4a7397e922d79dc2a94221: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Wed, 19 Jun 2019 23:06:33 +0000 - rev 2106158
Push 379805 by reviewbot at Thu, 20 Jun 2019 11:16:04 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
d5a6a97abef4df56fc7ed27fc60395d6d62c1a6f: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Wed, 19 Jun 2019 23:06:31 +0000 - rev 2106157
Push 379805 by reviewbot at Thu, 20 Jun 2019 11:16:04 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
cb7df1a95bb954364c0040bae2bc4ed8ede56714: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons draft
pulselistener - Thu, 20 Jun 2019 00:01:57 +0000 - rev 2105853
Push 379685 by reviewbot at Thu, 20 Jun 2019 00:02:33 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175 Differential Diff: PHID-DIFF-umb4yxhq2wzdt36p4bfk
6bfdfef00fcaea218033cb2355babb7088db79f5: Bug 1056706 - Reenable a couple tests on Android. r=karlt
Paul Adenot <paul@paul.cx> - Wed, 19 Jun 2019 22:15:25 +0000 - rev 2105851
Push 379685 by reviewbot at Thu, 20 Jun 2019 00:02:33 +0000
Bug 1056706 - Reenable a couple tests on Android. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D35289
1489aac9f73fb58198e7f2bccce60a0a410ce061: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:01:17 +0200 - rev 2104580
Push 379468 by paul@paul.cx at Wed, 19 Jun 2019 18:01:03 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
ec19824e801393840ce1864aff952c311e6f9b7f: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:04:37 +0200 - rev 2104579
Push 379468 by paul@paul.cx at Wed, 19 Jun 2019 18:01:03 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
8dd6c8c8a610719913e9738daae139e003b45d1d: Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt a=jcristau
Martin Stransky <stransky@redhat.com> - Thu, 23 May 2019 07:12:58 +0000 - rev 2103869
Push 379243 by reviewbot at Wed, 19 Jun 2019 02:05:19 +0000
Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt a=jcristau Use standard Gtk/Gnome way to set Firefox Gtk theme. Gtk theme of web content can be still configured by widget.content.allow-gtk-dark-theme and widget.content.gtk-theme-override. Depends on D29823 Differential Revision: https://phabricator.services.mozilla.com/D30919
ca5607bbcad3ed768cd576cebcc6b1f69b3e624c: Bug 1527048 - [Linux/GTK] Fallback to Adwaita light GTK theme for content when system theme has no light variant, r=karlt a=jcristau
Martin Stransky <stransky@redhat.com> - Tue, 28 May 2019 06:51:36 +0000 - rev 2103868
Push 379243 by reviewbot at Wed, 19 Jun 2019 02:05:19 +0000
Bug 1527048 - [Linux/GTK] Fallback to Adwaita light GTK theme for content when system theme has no light variant, r=karlt a=jcristau We previously disabled system dark themes for Firefox chrome and content by gtk-application-prefer-dark-theme settings. That option is no longer preferred by gnome project and was removed from tweaks tools. Theme makers are encouraged to use a different name for the dark theme variants, like Adwaita-dark, Yaru-dark and so on. This option also does not work when the GTK theme is missing the light variant completely. To address that, this patch implements heuristics based on https://www.w3.org/TR/AERT/#color-contrast to check if the system GTK theme has good contrast/visibility with default HTML colors (white background and black text). If widget.content.gtk-theme-override is empty and the system theme fails the test with gtk-application-prefer-dark-theme set to false, then Adwaita:light theme is used. This patch was tested with some distro default light themes (Ambiance, Radiance, Yaru - Ubuntu, Arc - KDE, Menta - MATE) and dark/light themes are recognized correctly. Differential Revision: https://phabricator.services.mozilla.com/D29823
f077b20ba58f48c4ac52671e7a647356aa53be9d: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:01:17 +0200 - rev 2063797
Push 378092 by paul@paul.cx at Fri, 14 Jun 2019 12:03:39 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
829f0819b2e75f97455f96dae1f100f584b330d3: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:04:37 +0200 - rev 2063796
Push 378092 by paul@paul.cx at Fri, 14 Jun 2019 12:03:39 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
f1863eb94d50aaafb79c9dbe95d1c77f326ed1e5: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:01:17 +0200 - rev 2058824
Push 376701 by paul@paul.cx at Wed, 12 Jun 2019 14:44:24 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
d1de31851d8d3a5f1f49af163fd4039c6735ace9: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:04:37 +0200 - rev 2058823
Push 376701 by paul@paul.cx at Wed, 12 Jun 2019 14:44:24 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
992d3dd0cee045520f093b21e8ed1746fcee112a: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Tue, 11 Jun 2019 09:51:21 +0000 - rev 2058721
Push 376672 by reviewbot at Wed, 12 Jun 2019 14:11:03 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
fad5e3bf0695fa9b172053617eaf618bdab2b9de: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Tue, 11 Jun 2019 09:51:14 +0000 - rev 2058720
Push 376672 by reviewbot at Wed, 12 Jun 2019 14:11:03 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
955483f397134a0b024e543f1440eeea29a4243d: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:01:17 +0200 - rev 2055716
Push 375809 by paul@paul.cx at Tue, 11 Jun 2019 10:12:24 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r?pehrsons,karlt It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
3fe5f779291b81f50216c0e94b3f3ff6e24af275: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons draft
Paul Adenot <paul@paul.cx> - Wed, 22 May 2019 19:04:37 +0200 - rev 2055715
Push 375809 by paul@paul.cx at Tue, 11 Jun 2019 10:12:24 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r?karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
71154c8ef814a3e6b10c9789325d4ed5529cf641: Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Mon, 10 Jun 2019 15:33:12 +0000 - rev 2053861
Push 375286 by reviewbot at Mon, 10 Jun 2019 16:44:27 +0000
Bug 1553215 - Implement the correct behaviour for MediaStreamAudioSource. r=karlt,pehrsons It should pick and lock to the right track, regardless of if it's still in the MediaStream. The test fix is because we don't expose tracks until the HTMLMediaElement has loaded loading I think. This alignes with a couple spec changes: - https://github.com/WebAudio/web-audio-api/issues/264 - https://github.com/WebAudio/web-audio-api/pull/1829/files and also throws when no valid track are found in the MediaStream, either because it's all video tracks or because it has no tracks. Differential Revision: https://phabricator.services.mozilla.com/D32176
80181b642f8195e0788009b4e1aa7af23e11009c: Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons
Paul Adenot <paul@paul.cx> - Mon, 10 Jun 2019 15:33:13 +0000 - rev 2053860
Push 375286 by reviewbot at Mon, 10 Jun 2019 16:44:27 +0000
Bug 1553215 - Start testing MediaStreamAudioSourceNode in WPT. r=karlt,pehrsons It's not complete I think, but it covers the constructor and some bits of behaviour. Differential Revision: https://phabricator.services.mozilla.com/D32175
fe938642436ba3f8994eb8000aa698c2591118f5: Bug 1557398 - Set audioworklet-suspend.https.html to expected fail for release and beta because audio worklet is only enabled for Nightly r=karlt draft
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 07 Jun 2019 04:51:21 +0000 - rev 2050132
Push 374246 by malexandru@mozilla.com at Fri, 07 Jun 2019 11:44:55 +0000
Bug 1557398 - Set audioworklet-suspend.https.html to expected fail for release and beta because audio worklet is only enabled for Nightly r=karlt Differential Revision: https://phabricator.services.mozilla.com/D34037
fc543afd6ee7a25d69502baee6eae672427bbce9: Bug 1557398 - Set audioworklet-suspend.https.html to expected fail for release and beta because audio worklet is only enabled for Nightly r=karlt
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 07 Jun 2019 04:51:21 +0000 - rev 2049861
Push 374159 by emilio@crisal.io at Fri, 07 Jun 2019 08:01:38 +0000
Bug 1557398 - Set audioworklet-suspend.https.html to expected fail for release and beta because audio worklet is only enabled for Nightly r=karlt Differential Revision: https://phabricator.services.mozilla.com/D34037
bd02bdaa03ca60e9f404230503f43258e28a1af0: Bug 1557060 - Update webaudio test result for release/beta build; r=karlt
Edgar Chen <echen@mozilla.com> - Thu, 06 Jun 2019 08:58:19 +0000 - rev 2048192
Push 373612 by reviewbot at Thu, 06 Jun 2019 15:53:18 +0000
Bug 1557060 - Update webaudio test result for release/beta build; r=karlt Differential Revision: https://phabricator.services.mozilla.com/D33854
d9fe316eb3b4d94739352e16ee80bfda6292c0c1: Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt
Jonathan Watt <jwatt@jwatt.org> - Wed, 15 May 2019 20:13:46 +0100 - rev 2044409
Push 372553 by jwatt@jwatt.org at Wed, 05 Jun 2019 07:42:32 +0000
Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D33390
cf725f00d9a6b8e8903bb472193efaeb65eade69: Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt draft
Jonathan Watt <jwatt@jwatt.org> - Wed, 15 May 2019 20:13:46 +0100 - rev 2043640
Push 372369 by jwatt@jwatt.org at Tue, 04 Jun 2019 23:18:11 +0000
Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D33390
adcdd2e076b49533150fb79616535522e2cae7d9: Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt draft
Jonathan Watt <jwatt@jwatt.org> - Tue, 21 May 2019 23:53:31 +0100 - rev 2043246
Push 372248 by jwatt@jwatt.org at Tue, 04 Jun 2019 20:37:39 +0000
Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D33390
b58837adc6624829a99ff45bf75354eaf71705f1: Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt draft
pulselistener - Fri, 31 May 2019 23:50:43 +0000 - rev 2037609
Push 370899 by reviewbot at Fri, 31 May 2019 23:51:18 +0000
Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt Differential Diff: PHID-DIFF-qnfsv5nbhb27aeeku7n3
3d5496d6b0aec6936186e1d1441a61d10fae6c44: Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt draft
Jonathan Watt <jwatt@jwatt.org> - Tue, 21 May 2019 23:53:31 +0100 - rev 2036814
Push 370652 by jwatt@jwatt.org at Fri, 31 May 2019 17:19:57 +0000
Bug 1552785. Remove Linux print dialog UI for selecting frameset behavior. r=karlt
a8aaf1f97d670b5c5ae24e02c9f74608fc19e89e: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt draft
pulselistener - Thu, 30 May 2019 17:27:53 +0000 - rev 2034037
Push 369957 by reviewbot at Thu, 30 May 2019 17:28:34 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt Differential Revision: https://phabricator.services.mozilla.com/D33085 Differential Diff: PHID-DIFF-emdamsjrywgmjj4rph6g
ce21500c025e1435eb0dc2bdf168674d38a11b1f: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 May 2019 08:38:18 +0000 - rev 2034011
Push 369948 by reviewbot at Thu, 30 May 2019 17:12:44 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt Differential Revision: https://phabricator.services.mozilla.com/D33085
aa4c3799c45ea2f4c4cf59079924623b0209a872: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt draft
pulselistener - Thu, 30 May 2019 01:12:44 +0000 - rev 2032695
Push 369663 by reviewbot at Thu, 30 May 2019 01:13:14 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt Differential Revision: https://phabricator.services.mozilla.com/D33085 Differential Diff: PHID-DIFF-5wuizpz7iuir5sn5j4tl
81a182a39cdcd30a01009227af95d0c8280a6463: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt draft
pulselistener - Wed, 29 May 2019 22:48:21 +0000 - rev 2032436
Push 369584 by reviewbot at Wed, 29 May 2019 22:49:05 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt Differential Revision: https://phabricator.services.mozilla.com/D33085 Differential Diff: PHID-DIFF-etfovdowqqb33kjplwtb
85ae71f3c26ccbfaea50127224fbe47c42d48803: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt draft
pulselistener - Wed, 29 May 2019 22:46:21 +0000 - rev 2032434
Push 369583 by reviewbot at Wed, 29 May 2019 22:46:57 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt Differential Diff: PHID-DIFF-3takjpqxfy6n7vpopzwe
f1b43e410440afe45f3ae6f24d42aba530ee2ecd: Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt draft
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 29 May 2019 14:25:13 -0400 - rev 2031845
Push 369403 by bzbarsky@mozilla.com at Wed, 29 May 2019 18:25:43 +0000
Bug 1485842. Fix pref handling in the wpt harness to deal with prefs that aren't set already. r=jgraham,karlt
167a564b3fda4eb8f853b3b69abbe31db671e1a5: Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt
Martin Stransky <stransky@redhat.com> - Thu, 23 May 2019 07:12:58 +0000 - rev 2028571
Push 368541 by reviewbot at Tue, 28 May 2019 14:27:35 +0000
Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt Use standard Gtk/Gnome way to set Firefox Gtk theme. Gtk theme of web content can be still configured by widget.content.allow-gtk-dark-theme and widget.content.gtk-theme-override. Depends on D29823 Differential Revision: https://phabricator.services.mozilla.com/D30919
03970b83ea43d59feb24a24dc37f33a5460b61da: Bug 1527048 - [Linux/GTK] Fallback to Adwaita light GTK theme for content when system theme has no light variant, r=karlt
Martin Stransky <stransky@redhat.com> - Tue, 28 May 2019 06:51:36 +0000 - rev 2028570
Push 368541 by reviewbot at Tue, 28 May 2019 14:27:35 +0000
Bug 1527048 - [Linux/GTK] Fallback to Adwaita light GTK theme for content when system theme has no light variant, r=karlt We previously disabled system dark themes for Firefox chrome and content by gtk-application-prefer-dark-theme settings. That option is no longer preferred by gnome project and was removed from tweaks tools. Theme makers are encouraged to use a different name for the dark theme variants, like Adwaita-dark, Yaru-dark and so on. This option also does not work when the GTK theme is missing the light variant completely. To address that, this patch implements heuristics based on https://www.w3.org/TR/AERT/#color-contrast to check if the system GTK theme has good contrast/visibility with default HTML colors (white background and black text). If widget.content.gtk-theme-override is empty and the system theme fails the test with gtk-application-prefer-dark-theme set to false, then Adwaita:light theme is used. This patch was tested with some distro default light themes (Ambiance, Radiance, Yaru - Ubuntu, Arc - KDE, Menta - MATE) and dark/light themes are recognized correctly. Differential Revision: https://phabricator.services.mozilla.com/D29823
bc404207024e09688db6eea62137cf500ae247cc: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 25 May 2019 10:13:02 +0000 - rev 2025300
Push 367723 by reviewbot at Sun, 26 May 2019 14:48:54 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
509567d4662f933bafe24cdb56dd45a7de05a449: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 May 2019 04:13:16 +0000 - rev 2025077
Push 367681 by jyavenard@mozilla.com at Sun, 26 May 2019 11:27:02 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
9c23b070a8d9960045698a51b662e065851b1b2c: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 17 May 2019 00:01:48 +1000 - rev 2024905
Push 367630 by jyavenard@mozilla.com at Sun, 26 May 2019 02:21:25 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
a5d9e5204547230f723cf5ab20c76662bf1cae29: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 17 May 2019 00:01:48 +1000 - rev 2024840
Push 367618 by jyavenard@mozilla.com at Sun, 26 May 2019 01:41:58 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
49a635e08f56d42227b249ac3c3f4eb7b8e64dc1: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 17 May 2019 00:01:48 +1000 - rev 2024266
Push 367499 by jyavenard@mozilla.com at Sat, 25 May 2019 10:26:58 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
d7ba4a18dd5483aad960798c5d2ae092089680d6: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 May 2019 04:13:16 +0000 - rev 2024108
Push 367439 by reviewbot at Sat, 25 May 2019 02:03:50 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
f9699ae30f4d5256b6af7c8493e84984aadb4568: Bug 1213601 - Implement kinetic/inertial scrolling (fling) for Gtk touchpads. r=botond,karlt
myfreeweb <greg@unrelenting.technology> - Fri, 24 May 2019 13:31:34 -0400 - rev 2023561
Push 367301 by reviewbot at Fri, 24 May 2019 20:03:17 +0000
Bug 1213601 - Implement kinetic/inertial scrolling (fling) for Gtk touchpads. r=botond,karlt
5002228d6269b548dc854041fe706c14998d8185: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 17 May 2019 00:01:48 +1000 - rev 2022655
Push 367087 by jyavenard@mozilla.com at Fri, 24 May 2019 14:39:45 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
6c9bac811f2c48a829b8e65b27e413da793833ab: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 17 May 2019 00:01:48 +1000 - rev 2021827
Push 366846 by jyavenard@mozilla.com at Fri, 24 May 2019 06:51:54 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
ad2cf8abb957c036a2ffc6a6e05ee37562066283: Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt draft
pulselistener - Thu, 23 May 2019 07:28:37 +0000 - rev 2019849
Push 366197 by reviewbot at Thu, 23 May 2019 07:29:06 +0000
Bug 1527048 - [Linux/Gtk] Remove MOZ_ALLOW_GTK_DARK_THEME and widget.chrome.allow-gtk-dark-theme configuration keys, r=karlt Use standard Gtk/Gnome way to set Firefox Gtk theme. Gtk theme of web content can be still configured by widget.content.allow-gtk-dark-theme and widget.content.gtk-theme-override. Differential Revision: https://phabricator.services.mozilla.com/D30919 Differential Diff: PHID-DIFF-b2l67ypqsjo3757p3j4z
fd801de4c943f3bb69361f59c9d7759a48b117b4: Bug 1527048 - [Linux/Gtk] Fallback Web content to Adwaita theme when switching to light GTK theme fails. r=karlt draft
pulselistener - Thu, 23 May 2019 07:28:31 +0000 - rev 2019848
Push 366197 by reviewbot at Thu, 23 May 2019 07:29:06 +0000
Bug 1527048 - [Linux/Gtk] Fallback Web content to Adwaita theme when switching to light GTK theme fails. r=karlt We recently disable system dark themes for Firefox chrome and content by gtk-application-prefer-dark-theme settings. That option is no longer prefered by gnome project and was removed from tweaks tools. Theme makers are encouraged to use a different name for the dark theme variants, like Adwaita-dark, Yaru-dark and so on. This option also does not work when the Gtk theme si missing the light variant completelly. To address that this patch implements a heuristicts based on https://www.w3.org/TR/AERT/#color-contrast to check if the recent system Gtk theme has good contrast/visibility with default HTML colors (white background and black text). If the system theme fails the test we try to check and set gtk-application-prefer-dark-theme to false. If that also fails we use Gtk theme defined by widget.content.gtk-theme-override for content. If widget.content.gtk-theme-override is empty Adwaita:light theme is used. This Gtk theme automation can be disabled by widget.content.gtk-dark-theme-autodetection preference. When set to false the old widget.content.allow-gtk-dark-theme, widget.chrome.allow-gtk-dark-theme and widget.content.gtk-theme-override work as before this patch. This patch was tested with some distro default light themes (Ambiance, Radiance, Yaru - Ubuntu, Arc - KDE, Menta - MATE) and dark/light themes are recognized correctly. Differential Revision: https://phabricator.services.mozilla.com/D29823 Differential Diff: PHID-DIFF-h56lyxnmvglgd6mu7emq
0f54138de6d5a8fcd3de94ac94c1adfa0b22b742: Bug 1527048 - [Linux/Gtk] Fallback Web content to Adwaita theme when switching to light GTK theme fails. r=karlt draft
pulselistener - Thu, 23 May 2019 07:26:45 +0000 - rev 2019844
Push 366195 by reviewbot at Thu, 23 May 2019 07:27:28 +0000
Bug 1527048 - [Linux/Gtk] Fallback Web content to Adwaita theme when switching to light GTK theme fails. r=karlt We recently disable system dark themes for Firefox chrome and content by gtk-application-prefer-dark-theme settings. That option is no longer prefered by gnome project and was removed from tweaks tools. Theme makers are encouraged to use a different name for the dark theme variants, like Adwaita-dark, Yaru-dark and so on. This option also does not work when the Gtk theme si missing the light variant completelly. To address that this patch implements a heuristicts based on https://www.w3.org/TR/AERT/#color-contrast to check if the recent system Gtk theme has good contrast/visibility with default HTML colors (white background and black text). If the system theme fails the test we try to check and set gtk-application-prefer-dark-theme to false. If that also fails we use Gtk theme defined by widget.content.gtk-theme-override for content. If widget.content.gtk-theme-override is empty Adwaita:light theme is used. This Gtk theme automation can be disabled by widget.content.gtk-dark-theme-autodetection preference. When set to false the old widget.content.allow-gtk-dark-theme, widget.chrome.allow-gtk-dark-theme and widget.content.gtk-theme-override work as before this patch. This patch was tested with some distro default light themes (Ambiance, Radiance, Yaru - Ubuntu, Arc - KDE, Menta - MATE) and dark/light themes are recognized correctly. Differential Revision: https://phabricator.services.mozilla.com/D29823 Differential Diff: PHID-DIFF-h56lyxnmvglgd6mu7emq
02fc788900325441a731e7222e7a9e157a997391: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 22 May 2019 21:41:26 +0000 - rev 2019764
Push 366191 by reviewbot at Thu, 23 May 2019 07:15:23 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D31971
b90b826b38dafa33122f34fbcb47bed30399dbf0: Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt draft
pulselistener - Wed, 22 May 2019 22:14:04 +0000 - rev 2019078
Push 366036 by reviewbot at Wed, 22 May 2019 22:16:14 +0000
Bug 1550422 - P0. Use X11UndefineNone.h to avoid conflicts with the macro None from X11/X.h. r?karlt Differential Revision: https://phabricator.services.mozilla.com/D31971 Differential Diff: PHID-DIFF-luf742ltwtm4tmqwlrd4
f9964c8d2f8ab473dfdc0024410d5d103cd16593: Bug 1550422 - P0. Fix Linux compilation. r?karlt! draft
pulselistener - Wed, 22 May 2019 13:03:59 +0000 - rev 2017574
Push 365717 by reviewbot at Wed, 22 May 2019 13:05:09 +0000
Bug 1550422 - P0. Fix Linux compilation. r?karlt! This would be required somewhere along the following patch stack. The nsGDKErrorHandler.h header includes system header doing #define None 0 The None word is used thorough the code, particularly in enums. So we prevent unified compilation on the related files and move the inclusion of the header as late as possible so there's no conflict with files such as webrender_ffi_generated.h Differential Revision: https://phabricator.services.mozilla.com/D31464 Differential Diff: PHID-DIFF-v4g67nrvwo5guf3c36jz
771238e5ae6b6f6ea88fefc7666a4ef4f586105b: Bug 1550422 - P0. Fix Linux compilation. r?karlt! draft
pulselistener - Wed, 22 May 2019 13:01:46 +0000 - rev 2017561
Push 365716 by reviewbot at Wed, 22 May 2019 13:02:53 +0000
Bug 1550422 - P0. Fix Linux compilation. r?karlt! This would be required somewhere along the following patch stack. The nsGDKErrorHandler.h header includes system header doing #define None 0 The None word is used thorough the code, particularly in enums. So we prevent unified compilation on the related files and move the inclusion of the header as late as possible so there's no conflict with files such as webrender_ffi_generated.h Differential Revision: https://phabricator.services.mozilla.com/D31464 Differential Diff: PHID-DIFF-v4g67nrvwo5guf3c36jz