searching for reviewer(bzbarsky)
f12d21ad24e42eb6c037b5e876681205768a885e: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 26 May 2020 14:06:28 +0000 - rev 2917905
Push 543576 by reviewbot at Tue, 26 May 2020 22:15:27 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
1e0019c4062818733b5a43ef92b97cfb9d63ba47: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky draft
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 26 May 2020 14:09:04 +0000 - rev 2916795
Push 543194 by reviewbot at Tue, 26 May 2020 14:09:25 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Summary: Differential Revision: https://phabricator.services.mozilla.com/D21719 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1529203 Differential Diff: PHID-DIFF-jnqtqdcieq3zp5vc3yn7
fdbdc6af039d060bd6603f398dede54fd7031a35: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky draft
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 22 May 2020 08:08:42 +0000 - rev 2916133
Push 543040 by jcoppeard@mozilla.com at Tue, 26 May 2020 10:53:45 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
a6179badcf2bb8be041ec73fdeb705412ec6e91d: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky draft
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 22 May 2020 08:08:42 +0000 - rev 2915704
Push 542951 by jcoppeard@mozilla.com at Tue, 26 May 2020 08:30:18 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
9133eeb54db8be5f55e51576ae07a1113d48f1f5: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 22 May 2020 08:08:42 +0000 - rev 2911910
Push 541924 by reviewbot at Fri, 22 May 2020 21:47:59 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
d09e97499640658b7eb65249abbe017cc633a966: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky! draft
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 22 May 2020 09:08:02 +0100 - rev 2910188
Push 541513 by jcoppeard@mozilla.com at Fri, 22 May 2020 08:10:32 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky! Differential Revision: https://phabricator.services.mozilla.com/D21719
f3b4666175d67db6e558a467c08c337c9192e621: Bug 1612891 - Use IgnoredErrorResult as the parsing easing error result. r=bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Fri, 06 Mar 2020 21:04:07 +0000 - rev 2682016
Push 499112 by wptsync@mozilla.com at Sat, 07 Mar 2020 01:35:48 +0000
Bug 1612891 - Use IgnoredErrorResult as the parsing easing error result. r=bzbarsky IgnoredErrorResult works well as the auto suppressor class and it's cleaner. Differential Revision: https://phabricator.services.mozilla.com/D65810
71c5127f60f660bd06c6e37213aa6a16cfc144ac: Bug 1619821 - Turn on dom.animations-api.getAnimations.enabled unconditionally; r?bzbarsky draft
Brian Birtles <birtles@gmail.com> - Fri, 06 Mar 2020 07:53:24 +0900 - rev 2678343
Push 498207 by bbirtles.birchill@mozilla.com at Thu, 05 Mar 2020 23:29:19 +0000
Bug 1619821 - Turn on dom.animations-api.getAnimations.enabled unconditionally; r?bzbarsky This also removes the comment about CSSPseudoElement since that is now covered by a separate pref: dom.css_pseudo_element.enabled.
436c85047eaf7f20cce47ea91293470845b9d7c1: Bug 1592037 - part6 : implement a chrome-only method for accessing current active media metadata during testing. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 05 Mar 2020 19:43:50 +0000 - rev 2677851
Push 498102 by wptsync@mozilla.com at Thu, 05 Mar 2020 21:39:32 +0000
Bug 1592037 - part6 : implement a chrome-only method for accessing current active media metadata during testing. r=bzbarsky Create a chrome-only method to get the current media metadata to know if we correctly update the media metadata or not. That method would only be used for testing. Differential Revision: https://phabricator.services.mozilla.com/D64849
11b25704ce8c8177096852b58aef341d4ee7fc7d: Bug 1612308. r=bzbarsky a=tjr
Jeff Walden <jwalden@mit.edu> - Sat, 29 Feb 2020 04:02:51 +0000 - rev 2676004
Push 497637 by malexandru@mozilla.com at Thu, 05 Mar 2020 10:14:24 +0000
Bug 1612308. r=bzbarsky a=tjr Differential Revision: https://phabricator.services.mozilla.com/D61478
0ab5e28f8dc7189ba2e93c4156fe02a2101f8b9f: Bug 1612308. r=bzbarsky a=tjr FENNEC_68_6b4_BUILD2 FENNEC_68_6b4_RELEASE
Jeff Walden <jwalden@mit.edu> - Fri, 14 Feb 2020 19:17:53 -0800 - rev 2672946
Push 496811 by dschubert@mozilla.com at Wed, 04 Mar 2020 09:03:22 +0000
Bug 1612308. r=bzbarsky a=tjr Differential Revision: https://phabricator.services.mozilla.com/D64879
6f6b962a1feef908c55f2ddc3307833d9f5337a5: Bug 1612308. r=bzbarsky a=tjr
Jeff Walden <jwalden@mit.edu> - Fri, 14 Feb 2020 19:17:53 -0800 - rev 2672944
Push 496811 by dschubert@mozilla.com at Wed, 04 Mar 2020 09:03:22 +0000
Bug 1612308. r=bzbarsky a=tjr
095b8239929e1b5eb9b89cbb4b067cc6bfcb5977: Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r=bzbarsky
Brian Birtles <birtles@gmail.com> - Wed, 04 Mar 2020 03:00:38 +0000 - rev 2672916
Push 496810 by reviewbot at Wed, 04 Mar 2020 08:58:17 +0000
Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D65251
4c5e854bc9339d1cb549c16946c103d5e975bda1: Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r?bzbarsky draft
Brian Birtles <birtles@gmail.com> - Wed, 04 Mar 2020 01:01:06 +0000 - rev 2672178
Push 496630 by reviewbot at Wed, 04 Mar 2020 01:01:26 +0000
Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r?bzbarsky Summary: Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1619178 Differential Diff: PHID-DIFF-spbhjyxuciy6poyhwyxn
5f121e61730d5b7f6dd5951f2386f9220fd7bf0b: Bug 1619171 - Don't prefix warnings with Error: in the console. r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Tue, 03 Mar 2020 18:14:00 +0000 - rev 2671880
Push 496543 by nnethercote@mozilla.com at Tue, 03 Mar 2020 23:06:36 +0000
Bug 1619171 - Don't prefix warnings with Error: in the console. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D65091
2fac2f15d6404a4e37c9dc5c19ef58fd2018174f: Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Tue, 03 Mar 2020 18:21:15 +0000 - rev 2671002
Push 496294 by reviewbot at Tue, 03 Mar 2020 18:21:44 +0000
Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky Summary: Differential Revision: https://phabricator.services.mozilla.com/D65091 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1619171 Differential Diff: PHID-DIFF-g6pkfuripdmab6jvfyhd
313815a62001f1f3c3653e230acf744ee94f4104: Bug 1617154 - [intersection-observer] Accept a Document as an explicit root. r=emilio,bzbarsky
Frederic Wang <fred.wang@free.fr> - Tue, 03 Mar 2020 12:25:30 +0000 - rev 2670266
Push 496079 by wptsync@mozilla.com at Tue, 03 Mar 2020 13:38:02 +0000
Bug 1617154 - [intersection-observer] Accept a Document as an explicit root. r=emilio,bzbarsky This patch allows users to specify a Document as an explicit root of an intersection observer. For rationale, see the intent-to thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/64nDLTAZGzY It is implemented under a preference option enabled in Nightly: dom.IntersectionObserverExplicitDocumentRoot.enabled When disabled, the current TypeError exception is preserved so that people can continue to feature detect the support. The enhancement is tested by and enabled for the following test: https://w3c-test.org/intersection-observer/document-scrolling-element-root.html Differential Revision: https://phabricator.services.mozilla.com/D63766
377aed10330f0c240d4361d1f54243e970ee4711: Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Tue, 03 Mar 2020 12:20:11 +0000 - rev 2669884
Push 496018 by reviewbot at Tue, 03 Mar 2020 12:20:32 +0000
Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky Summary: Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1619171 Differential Diff: PHID-DIFF-lbeubxm665wdlog4luni
a1d9de6e26750ec68da250c80a2fa27e65955db3: Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Mar 2020 16:11:45 +0000 - rev 2668272
Push 495643 by reviewbot at Mon, 02 Mar 2020 21:36:58 +0000
Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky This is legal with C++17. It's not too important for the ancestor iterators because they're just a pointer anyway, but it's nice for ShadowIncludingTreeIterator, which has an AutoTArray and what not. Depends on D63594 Differential Revision: https://phabricator.services.mozilla.com/D64355
98b5ec33fcdd45c3fac590a268412cb03691cf85: Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Mon, 02 Mar 2020 14:21:12 +0100 - rev 2666955
Push 495268 by evilpies@gmail.com at Mon, 02 Mar 2020 13:21:45 +0000
Bug 1619171 - Don't prefix warnings with Error: in the console. r?bzbarsky
4d937c2686c471180cb4df0d7e83b60ce6455979: Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 01 Mar 2020 23:14:24 +0000 - rev 2665447
Push 494995 by reviewbot at Sun, 01 Mar 2020 23:14:42 +0000
Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky Summary: This is legal with C++17. It's not too important for the ancestor iterators because they're just a pointer anyway, but it's nice for ShadowIncludingTreeIterator, which has an AutoTArray and what not. Differential Revision: https://phabricator.services.mozilla.com/D64355 Depends on D63594 Depends on D63594 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1617084 Differential Diff: PHID-DIFF-rqsqqrz67wkul3tbgott
d3b95145566b4cc07e7b11539d0c88ad6de5d7d4: Bug 1612308. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Sat, 29 Feb 2020 04:02:51 +0000 - rev 2664547
Push 494755 by reviewbot at Sat, 29 Feb 2020 10:00:29 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
b869fa686ae9153a9c179d2d329626a89aa003eb: Bug 1612308. r=bzbarsky draft
Jeff Walden <jwalden@mit.edu> - Fri, 14 Feb 2020 17:01:23 -0800 - rev 2664198
Push 494658 by jwalden@mit.edu at Fri, 28 Feb 2020 23:14:01 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
d2722b64543975fd0f0a44533df9fcc2b3bbf270: Bug 1408122 - Apply prefers-color-scheme: dark to top-level about:blank. r=emilio,bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 13:43:02 +0000 - rev 2663752
Push 494514 by jlaster@mozilla.com at Fri, 28 Feb 2020 19:05:57 +0000
Bug 1408122 - Apply prefers-color-scheme: dark to top-level about:blank. r=emilio,bzbarsky I think during the All Hands in Berlin you might have suggested to do this in nsPresContext::DefaultBackgroundColor, but this seems a bit more targeted and not a header. I haven't try tested this yet, so this more of a feedback? Differential Revision: https://phabricator.services.mozilla.com/D63801
fc9d28ae4655254a6ef8a57ac6577545b2a42ca7: Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:13:49 +0000 - rev 2663332
Push 494385 by rcaliman@mozilla.com at Fri, 28 Feb 2020 15:47:13 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415
4bdb67b0a4f58d41158520892a459894f9990bd4: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:13:49 +0000 - rev 2663331
Push 494385 by rcaliman@mozilla.com at Fri, 28 Feb 2020 15:47:13 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350
af20c1062645b6d6a9789457553aaeb4451eda52: Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 15:03:04 +0000 - rev 2663167
Push 494345 by reviewbot at Fri, 28 Feb 2020 15:03:35 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Differential Diff: PHID-DIFF-wxpuqo2l6w23ca6wopzy
f071f24c4b7ce3eb8ab51bb6208b3107a7e28f52: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 15:03:01 +0000 - rev 2663166
Push 494345 by reviewbot at Fri, 28 Feb 2020 15:03:35 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350 Differential Diff: PHID-DIFF-tizrzfvpticivbme6uiy
a77069b3e03ef5ba543ffe9ce2af4ba8e1cbc6bc: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:14:44 +0000 - rev 2662901
Push 494262 by reviewbot at Fri, 28 Feb 2020 12:15:23 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Depends on D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-uh746y7om4bgomhfw2gh
e05dd1fdebdeff029e59c7806542d0d0a6423fa2: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:14:40 +0000 - rev 2662900
Push 494262 by reviewbot at Fri, 28 Feb 2020 12:15:23 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky Summary: We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-knirgw7zzhx6tlvgpnih
a41352c472c096ef5251667ec29f7e31625c1615: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:13:34 +0000 - rev 2662895
Push 494260 by reviewbot at Fri, 28 Feb 2020 12:13:56 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Depends on D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-uh746y7om4bgomhfw2gh
b4603978d92b6084e3424ae28658ff0f4650ea34: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:12:16 +0000 - rev 2662886
Push 494258 by reviewbot at Fri, 28 Feb 2020 12:12:43 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky Summary: We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-knirgw7zzhx6tlvgpnih
9c528a390d2ae20362e78d4b31bef1a74ea520b3: Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Feb 2020 18:44:33 +0000 - rev 2661360
Push 493929 by xeonchen@gmail.com at Fri, 28 Feb 2020 00:38:59 +0000
Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky a=pascalc The code in nsIFrame::IsFocusable works for non-number input elements, because of the `IsRootOfNativeAnonymousSubtree` check, but doesn't work for `<input type=number>`, as the scrollable area is wrapped in a flex container (see nsNumberControlFrame::CreateAnonymousContent). It used to work (kinda) before bug 981248 because of the weird focus-manager redirection code to the inner <input> that was causing problems and which that bug removed. Make the check a bit more explicit, and add a test. Differential Revision: https://phabricator.services.mozilla.com/D64432
ff3125134c9355727730c53561d2b29144270e25: Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Feb 2020 18:44:33 +0000 - rev 2660768
Push 493820 by jlaster@mozilla.com at Thu, 27 Feb 2020 21:48:26 +0000
Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky The code in nsIFrame::IsFocusable works for non-number input elements, because of the `IsRootOfNativeAnonymousSubtree` check, but doesn't work for `<input type=number>`, as the scrollable area is wrapped in a flex container (see nsNumberControlFrame::CreateAnonymousContent). It used to work (kinda) before bug 981248 because of the weird focus-manager redirection code to the inner <input> that was causing problems and which that bug removed. Make the check a bit more explicit, and add a test. Differential Revision: https://phabricator.services.mozilla.com/D64432
969f7e067f2017bd7f4189bd8fdf3051d7e61bc8: Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Feb 2020 18:47:59 +0000 - rev 2660069
Push 493654 by reviewbot at Thu, 27 Feb 2020 18:48:17 +0000
Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky Summary: The code in nsIFrame::IsFocusable works for non-number input elements, because of the `IsRootOfNativeAnonymousSubtree` check, but doesn't work for `<input type=number>`, as the scrollable area is wrapped in a flex container (see nsNumberControlFrame::CreateAnonymousContent). It used to work (kinda) before bug 981248 because of the weird focus-manager redirection code to the inner <input> that was causing problems and which that bug removed. Make the check a bit more explicit, and add a test. Differential Revision: https://phabricator.services.mozilla.com/D64432 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1617342 Differential Diff: PHID-DIFF-ecqa7makl6t42yjjhjxr
09c4ce98063699f8b2b8dd53ebadad58e37f1331: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Thu, 27 Feb 2020 14:42:51 +0000 - rev 2658853
Push 493464 by reviewbot at Thu, 27 Feb 2020 14:43:34 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Depends on D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-xop2gzfsdc7tdeuverxb
d0ed552383b7884502d66f7091dba30ad3b42907: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Thu, 27 Feb 2020 14:42:55 +0000 - rev 2658850
Push 493463 by reviewbot at Thu, 27 Feb 2020 14:43:19 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Depends on D64350 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-xop2gzfsdc7tdeuverxb
9a98eb9023c9ecc1ec4b0cb226518b30563d87b2: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Thu, 27 Feb 2020 14:40:43 +0000 - rev 2658846
Push 493461 by reviewbot at Thu, 27 Feb 2020 14:41:12 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r?bzbarsky Summary: We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350 Depends on D64220 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-h7gvazgnu27omgxotgxw
23d1ef4868df10374d6d421341f71e066955030e: Bug 1531289 - target=_blank with a download properly closes the download tab, r=bzbarsky draft
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 26 Feb 2020 16:17:54 +0100 - rev 2658818
Push 493450 by amarchesini@mozilla.com at Thu, 27 Feb 2020 14:26:36 +0000
Bug 1531289 - target=_blank with a download properly closes the download tab, r=bzbarsky This patch is based on a patch written by Erica Wright <ewright@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D64547
f14b564688c07fb7d449fd6d744aa205611ff166: Bug 1531289 - target=_blank with a download properly closes the download tab, r=bzbarsky draft
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 27 Feb 2020 10:13:04 +0000 - rev 2658054
Push 493303 by reviewbot at Thu, 27 Feb 2020 10:13:28 +0000
Bug 1531289 - target=_blank with a download properly closes the download tab, r=bzbarsky This patch is based on a patch written by Erica Wright <ewright@mozilla.com> Differential Diff: PHID-DIFF-7shyrddqyxvv7clfhwac
44784c593075da98ab89039cd1729e79e090b91a: Bug 1612308. r=bzbarsky draft
Jeff Walden <jwalden@mit.edu> - Fri, 14 Feb 2020 17:01:23 -0800 - rev 2657171
Push 493129 by jwalden@mit.edu at Thu, 27 Feb 2020 01:51:49 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
c2957eae24256dac8d67d7f9ec41845e0c6051c0: Bug 1612308. r=bzbarsky draft
Jeff Walden <jwalden@mit.edu> - Fri, 14 Feb 2020 17:01:23 -0800 - rev 2657010
Push 493080 by jwalden@mit.edu at Thu, 27 Feb 2020 00:11:24 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
6b4e6ed6451be73e46957205b23b8598d0c3fd11: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Wed, 26 Feb 2020 23:21:52 +0000 - rev 2656918
Push 493056 by reviewbot at Wed, 26 Feb 2020 23:22:19 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Summary: Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966 Depends on D63570 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1616675 Differential Diff: PHID-DIFF-rokmw4g7qf6tjp6crouk
d9851623b6a199fbb7fd25daf5569199f9abb4ea: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Wed, 26 Feb 2020 23:20:48 +0000 - rev 2656915
Push 493055 by reviewbot at Wed, 26 Feb 2020 23:21:12 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Summary: Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966 Depends on D63570 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1616675 Differential Diff: PHID-DIFF-rokmw4g7qf6tjp6crouk
4a8bd43118895a1b128a2f692f8f7982b72a547c: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Wed, 26 Feb 2020 19:07:32 +0000 - rev 2656221
Push 492860 by reviewbot at Wed, 26 Feb 2020 19:08:38 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Summary: Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966 Depends on D63570 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1616675 Differential Diff: PHID-DIFF-z3vhikyrftv2ewca6qrn
46df3df8771c225dff98eaaf467731151fb18ce1: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Wed, 26 Feb 2020 19:07:36 +0000 - rev 2656217
Push 492859 by reviewbot at Wed, 26 Feb 2020 19:08:27 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Summary: Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966 Depends on D63570 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1616675 Differential Diff: PHID-DIFF-z3vhikyrftv2ewca6qrn
27be30bce26c6cc4a956908d99b3d6712524ea45: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Wed, 26 Feb 2020 17:43:53 +0000 - rev 2656065
Push 492794 by reviewbot at Wed, 26 Feb 2020 17:44:19 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-xhr5mhlfw2snop6obauz
bcf15debf2259553a511613fa3cf002be1b44505: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Mon, 24 Feb 2020 15:12:58 -0700 - rev 2656062
Push 492793 by jjones@mozilla.com at Wed, 26 Feb 2020 17:43:54 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966
a092d4adc1d0e82c6146121246db2b6a1eeaa460: Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky draft
Tom Schuster <evilpies@gmail.com> - Wed, 26 Feb 2020 17:35:03 +0000 - rev 2656040
Push 492785 by reviewbot at Wed, 26 Feb 2020 17:35:36 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r?bzbarsky Summary: I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. There is another issue that Promise.reject does not trigger. Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1549641 Differential Diff: PHID-DIFF-xqulne5766xurr5fssj4
4d13625ba74043f4dace1e750ac669f5225c976f: Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky draft
J.C. Jones <jjones@mozilla.com> - Wed, 26 Feb 2020 15:57:17 +0000 - rev 2655765
Push 492706 by reviewbot at Wed, 26 Feb 2020 15:57:42 +0000
Bug 1616675 - Add isIpAddress to nsIPrincipal r?bzbarsky Summary: Adds an infallable boolean attribute to nsIPrincipal that indicates whether the principal's host is an IP address. Adds a gtest to exercise that part of the nsIPrincipal. /** * Returns if the principal is an IP address. */ [infallible] readonly attribute boolean isIpAddress; Differential Revision: https://phabricator.services.mozilla.com/D63966 Depends on D63570 Test Plan: Reviewers: bzbarsky Subscribers: Bug #: 1616675 Differential Diff: PHID-DIFF-7x6s5mv5umyurnxysmxw