searching for reviewer(baku)
14084268455c5d048b9113a0d21bdd8c1853c6ee: Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku.
nchevobbe <nchevobbe@mozilla.com> - Thu, 28 May 2020 10:01:14 +0000 - rev 2924389
Push 545369 by lsalzman@mozilla.com at Thu, 28 May 2020 22:18:40 +0000
Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku. Differential Revision: https://phabricator.services.mozilla.com/D76792
87b7ec27cb67638b856d8318a9cb1c624f83fadc: Bug 1638389 - make assertion conditional; r=baku draft
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 17:53:20 +0200 - rev 2923789
Push 545186 by xeonchen@gmail.com at Thu, 28 May 2020 18:21:53 +0000
Bug 1638389 - make assertion conditional; r=baku Differential Revision: https://phabricator.services.mozilla.com/D77294
6528d16eaece99304cfd862da519328e1e6bf522: Bug 1638389 - make assertion conditional; r=baku draft
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 16:38:03 +0000 - rev 2923541
Push 545105 by reviewbot at Thu, 28 May 2020 16:38:35 +0000
Bug 1638389 - make assertion conditional; r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D77294 Test Plan: Reviewers: baku Subscribers: Bug #: 1638389 Differential Diff: PHID-DIFF-sftl3e6wvwbsnr5ynqbo
21e1d3b07478c97096dfaeb342ceb80c50e85412: Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku draft
sefeng <sefeng@mozilla.com> - Thu, 28 May 2020 16:08:50 +0000 - rev 2923431
Push 545072 by reviewbot at Thu, 28 May 2020 16:09:12 +0000
Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76193 Test Plan: Reviewers: baku Subscribers: Bug #: 1631346 Differential Diff: PHID-DIFF-lxrk6j7mooxkr4x35li5
292a4681a77b72edaad983f712c08761a892871b: Bug 1638389 - make assertion conditional; r=baku draft
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 16:04:51 +0000 - rev 2923420
Push 545067 by reviewbot at Thu, 28 May 2020 16:05:12 +0000
Bug 1638389 - make assertion conditional; r=baku Summary: Test Plan: Reviewers: baku Subscribers: Bug #: 1638389 Differential Diff: PHID-DIFF-cdxiwx35q4auscgcckmq
ed7ca7bdb28f1b90ab60afc30273803f9285a047: Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku draft
Perry Jiang <perry@mozilla.com> - Thu, 28 May 2020 15:17:19 +0000 - rev 2923183
Push 545013 by reviewbot at Thu, 28 May 2020 15:17:52 +0000
Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku Initially, IPCInternal{Request,Response} had contained IPCStreams which would result in unecessary copying when sending the objects over IPC. The patch makes these streams either: 1) ParentToParentStream (just a UUID) 2) ParentToChildStream (a PIPCBlobInputStream actor, acting as a handle) 3) ChildToParentStream (a real IPCStream) These three types are union-ed together by the BodyStreamVariant IPDL structure. This structure replaces the IPCStream members in IPCInternal{Request,Response} so that, depending on the particular IPDL protocol, we can avoid cloning streams and just pass handles/IDs instead. As a side effect, this makes file-backed Response objects cloneable. Initially, these Responses would be backed by an nsFileInputStream, which is not cloneable outside the parent process. They are now backed by IPCBlobInputStreams, which are cloneable. One thing that's not really satisfactory (IMO), is the manual management of IPCBlobInputStreamStorage so that no streams are leaked, e.g. if we store a stream in the IPCBlobInputStreamStorage but fail to send an IPC message and therefore fail to remove the stream from storage on the other side of the IPC boundary (only parent-to-parent in this case). Differential Revision: https://phabricator.services.mozilla.com/D73173 Differential Diff: PHID-DIFF-dvfd4z6jd52l7v5covqw
8cfeae843c4dd79be3fbfb278f9792e8c1cdb475: Bug 1637143 - Extend storage access API user interaction permission lifetime to 45 days. r=baku draft
Johann Hofmann <jhofmann@mozilla.com> - Thu, 28 May 2020 13:38:55 +0000 - rev 2922944
Push 544939 by reviewbot at Thu, 28 May 2020 13:39:20 +0000
Bug 1637143 - Extend storage access API user interaction permission lifetime to 45 days. r=baku Summary: Test Plan: Reviewers: baku Subscribers: Bug #: 1637143 Differential Diff: PHID-DIFF-ym54hrmspr4jbvhuw6at
3a5f3040fbef3e0c98aa1462c5c3525b96e3a76d: Bug 1639718 - P3. Add testcase r=baku
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:51:32 +0000 - rev 2922578
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1639718 - P3. Add testcase r=baku Differential Revision: https://phabricator.services.mozilla.com/D76838
10a7cc5f1b443a586ae49ad473b503bea89c6d9b: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:51:23 +0000 - rev 2922577
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Differential Revision: https://phabricator.services.mozilla.com/D76837
35567ab8e0ab09f179b2a80ac0a2fdcb304dc318: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:51:15 +0000 - rev 2922576
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836
9e1ecd2a9947b8937dd8319cca74bbbfcb269e40: Bug 1637516 - part 3: update tests; r=timhuang,baku
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 08:55:04 +0000 - rev 2922574
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1637516 - part 3: update tests; r=timhuang,baku Differential Revision: https://phabricator.services.mozilla.com/D75550
a77c31684931c7af28ee09ff66c94d30ca41d4c5: Bug 1637516 - part 2: make first-party domain support site; r=baku,timhuang
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 08:54:31 +0000 - rev 2922573
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1637516 - part 2: make first-party domain support site; r=baku,timhuang Differential Revision: https://phabricator.services.mozilla.com/D75549
0c71a64381d269c3bbf2c320edb32e025c58c7fa: Bug 1637516 - part 1: refine functions for further update; r=timhuang,baku
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 28 May 2020 08:53:13 +0000 - rev 2922572
Push 544845 by wptsync@mozilla.com at Thu, 28 May 2020 10:43:28 +0000
Bug 1637516 - part 1: refine functions for further update; r=timhuang,baku Differential Revision: https://phabricator.services.mozilla.com/D75548
0494052abd84d61f79a078a543dc1c028381e5bc: Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku. draft
nchevobbe <nchevobbe@mozilla.com> - Thu, 28 May 2020 09:23:32 +0000 - rev 2922462
Push 544819 by nchevobbe@mozilla.com at Thu, 28 May 2020 09:59:36 +0000
Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku. Differential Revision: https://phabricator.services.mozilla.com/D76792
07dd6125944421b147449c2dfdee7ff13106a275: Bug 1639718 - P3. Add testcase r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:54:53 +0000 - rev 2922432
Push 544811 by reviewbot at Thu, 28 May 2020 09:55:14 +0000
Bug 1639718 - P3. Add testcase r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76838 Depends on D76837 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-l5uzulwlyzuyi5h6d2qi
b03a79e2a9ed2095edd8800d5febad602a31c945: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:54:50 +0000 - rev 2922431
Push 544811 by reviewbot at Thu, 28 May 2020 09:55:14 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76837 Depends on D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-xj2d7wtd7elvnyp63al4
fa9deb72675a318d38961965de4235143921c7e5: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:54:46 +0000 - rev 2922430
Push 544811 by reviewbot at Thu, 28 May 2020 09:55:14 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-7ggaip3lbs5xfvlwyxkv
8e8cc374d92a106b44c73851c33f377cc36f1d70: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:53:38 +0000 - rev 2922428
Push 544810 by reviewbot at Thu, 28 May 2020 09:54:01 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76837 Depends on D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-xj2d7wtd7elvnyp63al4
87de1907359ac8abbdf5788f6c0cfb1d56b2bbe8: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:53:35 +0000 - rev 2922427
Push 544810 by reviewbot at Thu, 28 May 2020 09:54:01 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-7ggaip3lbs5xfvlwyxkv
a4c8066381f7a842f34dfd4680b9e07fdc5679ae: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Thu, 28 May 2020 09:52:59 +0000 - rev 2922425
Push 544809 by reviewbot at Thu, 28 May 2020 09:53:31 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-7ggaip3lbs5xfvlwyxkv
18532ff2e790c40804c21c528941e6a4012bbc38: Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku. draft
nchevobbe <nchevobbe@mozilla.com> - Thu, 28 May 2020 09:24:22 +0000 - rev 2922367
Push 544790 by reviewbot at Thu, 28 May 2020 09:24:40 +0000
Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku. Summary: Differential Revision: https://phabricator.services.mozilla.com/D76792 Test Plan: Reviewers: baku Subscribers: Bug #: 1639165 Differential Diff: PHID-DIFF-argkltxgonrsh3f6swmb
86df4717f1e5b57d24ebd29a7357ef63d1ce6f89: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 07:44:52 +0000 - rev 2917965
Push 543584 by wptsync@mozilla.com at Tue, 26 May 2020 22:31:51 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
d38f5b6a1d0233d6747d6eed18d0a626dae69a91: Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku draft
sefeng <sefeng@mozilla.com> - Tue, 26 May 2020 22:16:32 +0000 - rev 2917949
Push 543578 by reviewbot at Tue, 26 May 2020 22:16:58 +0000
Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76193 Test Plan: Reviewers: Subscribers: Bug #: 1631346 Differential Diff: PHID-DIFF-ezqhf4mdblgv6yrcdnfq
dfd42de9e16c542f3aeebc77f21e123f6230a552: Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku draft
sefeng <sefeng@mozilla.com> - Tue, 26 May 2020 22:13:44 +0000 - rev 2917902
Push 543575 by reviewbot at Tue, 26 May 2020 22:14:05 +0000
Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76193 Test Plan: Reviewers: Subscribers: Bug #: 1631346 Differential Diff: PHID-DIFF-gofkty2q4c7ss62lkjm3
91f109ef59e869cc9e4737ad9f5de95c48527307: Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku draft
sefeng <sefeng@mozilla.com> - Tue, 26 May 2020 22:06:45 +0000 - rev 2917893
Push 543571 by reviewbot at Tue, 26 May 2020 22:07:12 +0000
Bug 1631346 - Fix a null ptr crash in PerformanceObserver::Observe r=baku Summary: Differential Revision: https://phabricator.services.mozilla.com/D76193 Test Plan: Reviewers: Subscribers: Bug #: 1631346 Differential Diff: PHID-DIFF-fjv6nwmiwtsqvwnynjxp
7a371eb5c63f519e78d9d07466da242de5b468ea: Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku draft
Perry Jiang <perry@mozilla.com> - Wed, 29 Apr 2020 16:53:37 -0700 - rev 2917763
Push 543527 by pjiang@mozilla.com at Tue, 26 May 2020 20:57:38 +0000
Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku Initially, IPCInternal{Request,Response} had contained IPCStreams which would result in unecessary copying when sending the objects over IPC. The patch makes these streams either: 1) ParentToParentStream (just a UUID) 2) ParentToChildStream (a PIPCBlobInputStream actor, acting as a handle) 3) ChildToParentStream (a real IPCStream) These three types are union-ed together by the BodyStreamVariant IPDL structure. This structure replaces the IPCStream members in IPCInternal{Request,Response} so that, depending on the particular IPDL protocol, we can avoid cloning streams and just pass handles/IDs instead. As a side effect, this makes file-backed Response objects cloneable. Initially, these Responses would be backed by an nsFileInputStream, which is not cloneable outside the parent process. They are now backed by IPCBlobInputStreams, which are cloneable. One thing that's not really satisfactory (IMO), is the manual management of IPCBlobInputStreamStorage so that no streams are leaked, e.g. if we store a stream in the IPCBlobInputStreamStorage but fail to send an IPC message and therefore fail to remove the stream from storage on the other side of the IPC boundary (only parent-to-parent in this case). Differential Revision: https://phabricator.services.mozilla.com/D73173
ee410eaed333641c6929769c99553bfaae9e9641: Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku draft
Perry Jiang <perry@mozilla.com> - Tue, 26 May 2020 20:44:53 +0000 - rev 2917712
Push 543506 by reviewbot at Tue, 26 May 2020 20:45:13 +0000
Bug 1622451 - minimize stream copying across IPC boundaries r?asuth,baku Initially, IPCInternal{Request,Response} had contained IPCStreams which would result in unecessary copying when sending the objects over IPC. The patch makes these streams either: 1) ParentToParentStream (just a UUID) 2) ParentToChildStream (a PIPCBlobInputStream actor, acting as a handle) 3) ChildToParentStream (a real IPCStream) These three types are union-ed together by the BodyStreamVariant IPDL structure. This structure replaces the IPCStream members in IPCInternal{Request,Response} so that, depending on the particular IPDL protocol, we can avoid cloning streams and just pass handles/IDs instead. As a side effect, this makes file-backed Response objects cloneable. Initially, these Responses would be backed by an nsFileInputStream, which is not cloneable outside the parent process. They are now backed by IPCBlobInputStreams, which are cloneable. One thing that's not really satisfactory (IMO), is the manual management of IPCBlobInputStreamStorage so that no streams are leaked, e.g. if we store a stream in the IPCBlobInputStreamStorage but fail to send an IPC message and therefore fail to remove the stream from storage on the other side of the IPC boundary (only parent-to-parent in this case). Differential Revision: https://phabricator.services.mozilla.com/D73173 Differential Diff: PHID-DIFF-hjpchqmybhcgv6ebeipn
911176c86134fc8eaa078721f755613a5be2ad63: Bug 1631676 - Part 2: remember FPI state in CookieJarSettings; r=baku,timhuang draft
Liang-Heng Chen <xeonchen@gmail.com> - Tue, 26 May 2020 17:33:56 +0000 - rev 2917302
Push 543349 by reviewbot at Tue, 26 May 2020 17:34:28 +0000
Bug 1631676 - Part 2: remember FPI state in CookieJarSettings; r=baku,timhuang Differential Revision: https://phabricator.services.mozilla.com/D74050 Differential Diff: PHID-DIFF-l7fqe4jjqrx6ykmdsf4f
85e58f1534d4d0c363b086c75d17acd9ab43ae15: Bug 1638826: Exempt pdfjs from being subject to CSP permits function. r=baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 26 May 2020 12:48:15 +0000 - rev 2916889
Push 543209 by wptsync@mozilla.com at Tue, 26 May 2020 14:35:01 +0000
Bug 1638826: Exempt pdfjs from being subject to CSP permits function. r=baku Differential Revision: https://phabricator.services.mozilla.com/D75787
3729b2c288ba46c7d48f5a2bca68f5faafafd60b: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:12 +0000 - rev 2916849
Push 543209 by wptsync@mozilla.com at Tue, 26 May 2020 14:35:01 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
417bff52b7d93341a335bcca69c8510c15d5684d: Bug 1639718 - P3. Add testcase r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 14:50:00 +0200 - rev 2916651
Push 543150 by dlee@mozilla.com at Tue, 26 May 2020 13:09:51 +0000
Bug 1639718 - P3. Add testcase r=baku Differential Revision: https://phabricator.services.mozilla.com/D76838
d2d8277db814b9e77c5e2aed1659c5d788c8bf36: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 09:56:29 +0200 - rev 2916650
Push 543150 by dlee@mozilla.com at Tue, 26 May 2020 13:09:51 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Differential Revision: https://phabricator.services.mozilla.com/D76837
01e22749f42beb82a96d6a6f233f85a18dbc3915: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 09:49:03 +0200 - rev 2916649
Push 543150 by dlee@mozilla.com at Tue, 26 May 2020 13:09:51 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836
4de1a1ef7957e5d6ed732d4907a92e4c34292d83: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:56:23 +0000 - rev 2916609
Push 543134 by reviewbot at Tue, 26 May 2020 12:57:24 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Differential Revision: https://phabricator.services.mozilla.com/D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-akigamp3ud257iooogfe
d0f392bf271e7ccdd9772b532db2ecf67a974174: Bug 1639718 - P3. Add testcase r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:55:03 +0000 - rev 2916603
Push 543131 by reviewbot at Tue, 26 May 2020 12:55:24 +0000
Bug 1639718 - P3. Add testcase r=baku Summary: Depends on D76837 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-vcwkubn6vyyuye7zde3q
0a60d849cf7e5bbfd312a5d2585c71e85e0a0b7c: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:55:00 +0000 - rev 2916602
Push 543131 by reviewbot at Tue, 26 May 2020 12:55:24 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Summary: Depends on D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-vk6gfzoslxyimovy4ald
a061d630fcee6bc7f92fd8c6813105a61f94de7f: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:54:57 +0000 - rev 2916601
Push 543131 by reviewbot at Tue, 26 May 2020 12:55:24 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-u6hlizrhls4vityaozwy
29d1bffaccba1746216c9c4d399b6af6aec68540: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:53:25 +0000 - rev 2916599
Push 543130 by reviewbot at Tue, 26 May 2020 12:54:21 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-u6hlizrhls4vityaozwy
dd6cf93c519dd7213ff75acd6bf14a90c0b7a5b7: Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:53:22 +0000 - rev 2916597
Push 543129 by reviewbot at Tue, 26 May 2020 12:53:43 +0000
Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku Summary: Depends on D76836 Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-vk6gfzoslxyimovy4ald
3f20649502ce3429586dcfdd19e430c4c3889384: Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku draft
Dimi Lee <dlee@mozilla.com> - Tue, 26 May 2020 12:53:20 +0000 - rev 2916596
Push 543129 by reviewbot at Tue, 26 May 2020 12:53:43 +0000
Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku Summary: ChannelClassifierService notifies "urlclassifier-before-block-channel" event when a channel is going to be blocked by protection features. It also provides an API for receivers to "unblock" the channel. Sample usage: this.service = Cc["@mozilla.org/url-classifier/channel-classifier-service;1"].getService( Ci.nsIChannelClassifierService ); if (this.service) { this.service.addListener({ observe(aSubject, aTopic, aData) { switch (aTopic) { case "urlclassifier-before-block-channel": let channel = aSubject.QueryInterface(Ci.nsIUrlClassifierBlockedChannel); channel.unblock(); break; } }, }) } Test Plan: Reviewers: baku Subscribers: Bug #: 1639718 Differential Diff: PHID-DIFF-u6hlizrhls4vityaozwy
7cee2779fb0ee7424ea0d0fcee2cbf797b6c07b1: Bug 1637226 - Part 3: Revert the assertion in ClientSource.cpp back to MOZ_DIAGNOSTIC_ASSERT. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 19:00:32 +0000 - rev 2914756
Push 542701 by reviewbot at Mon, 25 May 2020 19:00:53 +0000
Bug 1637226 - Part 3: Revert the assertion in ClientSource.cpp back to MOZ_DIAGNOSTIC_ASSERT. r?baku,dimi Summary: Depends on D76732 Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-4ifzm2xfejmtcepazlhr
764b04ab71a5b59e3bdc5e8d033bece610940879: Bug 1637226 - Part 2: Make the ContentBlocking::ShouldAllowAccessFor(channel) to check sandbox flag. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 19:00:28 +0000 - rev 2914755
Push 542701 by reviewbot at Mon, 25 May 2020 19:00:53 +0000
Bug 1637226 - Part 2: Make the ContentBlocking::ShouldAllowAccessFor(channel) to check sandbox flag. r?baku,dimi Summary: Depends on D76731 Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-vcsntyunla7ws6ilx5mp
7f54e0493c60b7403bf8ff11395b1a0ac2141a21: Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 19:00:26 +0000 - rev 2914754
Push 542701 by reviewbot at Mon, 25 May 2020 19:00:53 +0000
Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi Summary: Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-hkh2jaw2sc6duip2jb4i
692f06acbb67ded11797fa359c441b4d87f2aab1: Bug 1637226 - Part 2: Make the ContentBlocking::ShouldAllowAccessFor(channel) to check sandbox flag. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 18:59:37 +0000 - rev 2914752
Push 542700 by reviewbot at Mon, 25 May 2020 19:00:04 +0000
Bug 1637226 - Part 2: Make the ContentBlocking::ShouldAllowAccessFor(channel) to check sandbox flag. r?baku,dimi Summary: Depends on D76731 Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-vcsntyunla7ws6ilx5mp
34ab310ec5ea34c75d2f92d3a402802fbb584dd3: Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 18:59:32 +0000 - rev 2914751
Push 542700 by reviewbot at Mon, 25 May 2020 19:00:04 +0000
Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi Summary: Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-hkh2jaw2sc6duip2jb4i
85b28b2ff38e9a4b28b18533f877f38e10c65724: Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 25 May 2020 18:59:14 +0000 - rev 2914749
Push 542699 by reviewbot at Mon, 25 May 2020 18:59:33 +0000
Bug 1637226 - Part 1: Add a test to ensure we won't hit the assertion for a sandbox iframe. r?baku,dimi Summary: Test Plan: Reviewers: baku, dimi Subscribers: Bug #: 1637226 Differential Diff: PHID-DIFF-hkh2jaw2sc6duip2jb4i
597f9b77fb4073be662fd61414dc14077e94702f: Bug 1638826: Exempt pdfjs from being subject to CSP permits function. r=baku draft
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 25 May 2020 16:17:45 +0000 - rev 2914514
Push 542622 by reviewbot at Mon, 25 May 2020 16:18:05 +0000
Bug 1638826: Exempt pdfjs from being subject to CSP permits function. r=baku Differential Diff: PHID-DIFF-wilxvpygf2wgytu3m65u
2b4796470c0b1a73a943c4d882a492bea5383882: Bug 1638826: Make CSP permits function (e.g. restricting base-uri) consult subjectCSP before enforcing CSP. r=baku
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 25 May 2020 08:24:09 +0000 - rev 2914424
Push 542608 by emilio@crisal.io at Mon, 25 May 2020 15:54:08 +0000
Bug 1638826: Make CSP permits function (e.g. restricting base-uri) consult subjectCSP before enforcing CSP. r=baku Differential Revision: https://phabricator.services.mozilla.com/D75787
1f4e018c0af102d5b41b070f7411897cd6441cc5: Bug 1422284 - Upgrade insecure requests should only apply to top-level same-origin redirects. r=baku,valentin,necko-reviewers
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 25 May 2020 08:14:10 +0000 - rev 2914423
Push 542608 by emilio@crisal.io at Mon, 25 May 2020 15:54:08 +0000
Bug 1422284 - Upgrade insecure requests should only apply to top-level same-origin redirects. r=baku,valentin,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D75259
22652da395b6e2d7f7f14d9535579c0d6f06813b: Bug 1638826: Make CSP permits function (e.g. restricting base-uri) consult subjectCSP before enforcing CSP. r=baku draft
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 25 May 2020 08:24:41 +0000 - rev 2913583
Push 542397 by reviewbot at Mon, 25 May 2020 08:25:00 +0000
Bug 1638826: Make CSP permits function (e.g. restricting base-uri) consult subjectCSP before enforcing CSP. r=baku Differential Diff: PHID-DIFF-f7ei3apiv2u45cuvc47n