searching for reviewer(agashlin)
be7f977e348209cac42ec22ac7c684df4e1acf9b: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r=agashlin
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 20:58:46 +0000 - rev 3339776
Push 620330 by reviewbot at Mon, 09 Nov 2020 10:16:48 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r=agashlin Differential Revision: https://phabricator.services.mozilla.com/D95576
fcd75e267fa9b7b8ebfaf9448b1d1286f0e862f1: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r=agashlin
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 20:58:43 +0000 - rev 3339775
Push 620330 by reviewbot at Mon, 09 Nov 2020 10:16:48 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r=agashlin Differential Revision: https://phabricator.services.mozilla.com/D95575
e0b0efa141af79b5da4d4f32e3bff27f89fe08cf: Bug 1674221 - Make skeleton UI pref visible to windows users r=agashlin
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 15:21:19 +0000 - rev 3338919
Push 620080 by nbeleuzu@mozilla.com at Sat, 07 Nov 2020 10:15:26 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r=agashlin This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543
c98182657e6cd5a275af01f0ba66a37c15966577: Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 19:35:20 +0000 - rev 3338918
Push 620080 by nbeleuzu@mozilla.com at Sat, 07 Nov 2020 10:15:26 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin Differential Revision: https://phabricator.services.mozilla.com/D95541
9d128476fb5dfd624f8c197a4d2de190b1b1cf20: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 20:57:47 +0000 - rev 3338323
Push 619919 by reviewbot at Fri, 06 Nov 2020 20:58:31 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95576 Depends on D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-uophc72jzjk5nuvemhkv
afb0fffc4a512ae076362ce92a1552d3e8bde3b2: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 20:57:44 +0000 - rev 3338322
Push 619919 by reviewbot at Fri, 06 Nov 2020 20:58:31 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-tryh6yttd3ow27zl5u2y
15b764b07bd280a93ad05007be99aae2e1e5b558: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 20:57:33 +0000 - rev 3338320
Push 619918 by reviewbot at Fri, 06 Nov 2020 20:57:55 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-tryh6yttd3ow27zl5u2y
3a067ea16950a344dee28272bc5c82a6d2b64150: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 11:50:02 -0600 - rev 3338318
Push 619917 by dothayer@mozilla.com at Fri, 06 Nov 2020 20:57:09 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin Differential Revision: https://phabricator.services.mozilla.com/D95576
648bac50734b24251a0acf9ab44c38740216ff55: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 11:41:10 -0600 - rev 3338317
Push 619917 by dothayer@mozilla.com at Fri, 06 Nov 2020 20:57:09 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Differential Revision: https://phabricator.services.mozilla.com/D95575
582fdf855390032f8d07184f4de04deaf80ca3f9: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 16:10:42 +0000 - rev 3337295
Push 619711 by reviewbot at Fri, 06 Nov 2020 16:11:05 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95576 Depends on D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-6whdiwcjolvyxuhwpuxb
52bb81d5a9401e60df4ecd8afb4e60462e5e27f0: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 16:10:39 +0000 - rev 3337294
Push 619711 by reviewbot at Fri, 06 Nov 2020 16:11:05 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-oln4zkgsgen23vz6ujts
e2ee42e94cab8cb455d7d646a3e41112cb236aeb: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 16:09:17 +0000 - rev 3337292
Push 619710 by reviewbot at Fri, 06 Nov 2020 16:09:55 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-oln4zkgsgen23vz6ujts
385f28bf2baa52f5a5e82a57f8a4dacff5c11243: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 15:22:09 +0000 - rev 3337161
Push 619685 by reviewbot at Fri, 06 Nov 2020 15:22:42 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-uhbu3hctfnkjgwewtufx
1e240d3d8d3e4edfbe27603a0d5558953e86f614: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 15:22:00 +0000 - rev 3337159
Push 619684 by reviewbot at Fri, 06 Nov 2020 15:22:19 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin Summary: This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543 Depends on D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-d3blhuryn3pckp6utfeq
561f68278e8579d39142012504a1e763ade284ae: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 06 Nov 2020 15:21:56 +0000 - rev 3337158
Push 619684 by reviewbot at Fri, 06 Nov 2020 15:22:19 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-uhbu3hctfnkjgwewtufx
5ce7462022d550e985e134c55b5e95d1255e202e: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 10:51:30 -0600 - rev 3337156
Push 619683 by dothayer@mozilla.com at Fri, 06 Nov 2020 15:19:15 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543
30bf3bfee15179471508bb81fa5e04221c847bec: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 10:21:22 -0600 - rev 3337155
Push 619683 by dothayer@mozilla.com at Fri, 06 Nov 2020 15:19:15 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Differential Revision: https://phabricator.services.mozilla.com/D95541
3d9b951db0f4ef78d71a1007e7a4ba83d06ab102: Bug 1674221 - Make skeleton UI pref visible to windows users r=agashlin
Doug Thayer <dothayer@mozilla.com> - Thu, 05 Nov 2020 20:18:18 +0000 - rev 3336481
Push 619515 by reviewbot at Fri, 06 Nov 2020 04:47:38 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r=agashlin This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543
5092fde1ebe1ebe1a9fb30cb8813331e5fab7902: Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin
Doug Thayer <dothayer@mozilla.com> - Thu, 05 Nov 2020 20:18:16 +0000 - rev 3336480
Push 619515 by reviewbot at Fri, 06 Nov 2020 04:47:38 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r=agashlin Differential Revision: https://phabricator.services.mozilla.com/D95541
a30019a5f8021e420ac42e550a8d20277b4089ad: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 05 Nov 2020 20:18:47 +0000 - rev 3335628
Push 619303 by reviewbot at Thu, 05 Nov 2020 20:19:14 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin Summary: This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543 Depends on D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-ogzcev6b45odrfsyryab
2a31e866e2f81582ab1bacd2c19e3b65468713f0: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 05 Nov 2020 20:18:44 +0000 - rev 3335627
Push 619303 by reviewbot at Thu, 05 Nov 2020 20:19:14 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-chehad5bfecmqm2m7aog
b641603a1a8e32a663109a08ba49d57e6e7ad65b: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 05 Nov 2020 20:18:34 +0000 - rev 3335625
Push 619302 by reviewbot at Thu, 05 Nov 2020 20:19:01 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-chehad5bfecmqm2m7aog
24bc3c28d2c0fb386809d764c0294e919a9dfeb4: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 10:51:30 -0600 - rev 3334353
Push 619093 by dothayer@mozilla.com at Thu, 05 Nov 2020 15:52:01 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543
488a09ee111366a60607ca9a0d86d0282cf91b8d: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 10:21:22 -0600 - rev 3334352
Push 619093 by dothayer@mozilla.com at Thu, 05 Nov 2020 15:52:01 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Differential Revision: https://phabricator.services.mozilla.com/D95541
2e89c30bbe879a754838dff2b9f68025032de1f2: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 21:08:22 +0000 - rev 3331062
Push 618635 by reviewbot at Wed, 04 Nov 2020 21:08:59 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin Summary: This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543 Depends on D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-cz2lt5hapqvjgrvax2ms
7824054615796fb72e96e0150d093ef30a2c5bc0: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 21:08:18 +0000 - rev 3331061
Push 618635 by reviewbot at Wed, 04 Nov 2020 21:08:59 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-l6uspoj43cqry7hd2sda
e60786508a3730c19038490b44dd21a6c53a9c23: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 21:06:52 +0000 - rev 3331057
Push 618633 by reviewbot at Wed, 04 Nov 2020 21:07:18 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-l6uspoj43cqry7hd2sda
f12ebd502951ed1be9a0b0af7fcca967fa61fc38: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 19:52:08 +0000 - rev 3330738
Push 618577 by reviewbot at Wed, 04 Nov 2020 19:52:30 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95576 Depends on D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-4ahx2gv5r5jspawexb6h
140dd18f28a3af19a2c7f4e513d7926eeb684994: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 19:52:05 +0000 - rev 3330737
Push 618577 by reviewbot at Wed, 04 Nov 2020 19:52:30 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-faait6tzpyiyhur3js2b
ac268bfe4673c57dc05e21a756cfca14e8f221e2: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Wed, 04 Nov 2020 19:51:51 +0000 - rev 3330735
Push 618576 by reviewbot at Wed, 04 Nov 2020 19:52:10 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-faait6tzpyiyhur3js2b
df5dce707d2b25882809f71256b16175bc4095a1: Bug 1674540 - Remove unused prthread.h include r=agashlin
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 16:03:04 +0000 - rev 3313749
Push 617453 by wptsync@mozilla.com at Mon, 02 Nov 2020 20:32:42 +0000
Bug 1674540 - Remove unused prthread.h include r=agashlin This snuck in after I forgot to delete this upon realizing I couldn't use nspr stuff in mozglue. Differential Revision: https://phabricator.services.mozilla.com/D95530
8138b02261f92b71fba1e4f45bf1cd131a88795b: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:49:42 +0000 - rev 3313631
Push 617419 by reviewbot at Mon, 02 Nov 2020 19:50:45 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin Summary: This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Differential Revision: https://phabricator.services.mozilla.com/D95543 Depends on D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-ylkul4vuqs2flxqqf2fx
a62cc0c8b3a4bee47503c574d30298a33c5d451d: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:49:39 +0000 - rev 3313630
Push 617419 by reviewbot at Mon, 02 Nov 2020 19:50:45 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-q7ip6wtkqilxt7bdygcr
d84ff5798c972eea649f69a2204e5d6fc3baf3a2: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:48:52 +0000 - rev 3313624
Push 617416 by reviewbot at Mon, 02 Nov 2020 19:49:14 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Differential Revision: https://phabricator.services.mozilla.com/D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-q7ip6wtkqilxt7bdygcr
456dfc34ff12ab7ff89b1d7c18e1decc1ba2efee: Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:29:38 +0000 - rev 3313515
Push 617390 by reviewbot at Mon, 02 Nov 2020 19:29:59 +0000
Bug 1666653 - Set sPreXULSkeletonUIEnabled correctly r?agashlin Summary: Depends on D95575 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-62g7ob2t5dud4hnc3qbr
3cb18717b1e8d5f96f5f44245b9611da9a5dbc6b: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:29:35 +0000 - rev 3313514
Push 617390 by reviewbot at Mon, 02 Nov 2020 19:29:59 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-3k64w3zexlryrpgb3pwb
bf30b9acd832b25319ee19299c732d7d8641bd26: Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 19:28:10 +0000 - rev 3313510
Push 617388 by reviewbot at Mon, 02 Nov 2020 19:28:36 +0000
Bug 1666653 - Only draw the skeleton UI when cmdline args are approved r?agashlin Summary: Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666653 Differential Diff: PHID-DIFF-3k64w3zexlryrpgb3pwb
7ff6dadc5d45a42d1a14700ae5ae1b957bcb4651: Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 16:53:51 +0000 - rev 3313186
Push 617277 by reviewbot at Mon, 02 Nov 2020 16:54:19 +0000
Bug 1674221 - Make skeleton UI pref visible to windows users r?agashlin Summary: This is not particularly related to the bug, but it's small enough that it hardly warrants its own bug. Depends on D95541 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-ta6pq3cn5ec7oxq7ityq
fe5c215608c4ac3a62850f252ec9e64bb37761cd: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 16:53:47 +0000 - rev 3313185
Push 617277 by reviewbot at Mon, 02 Nov 2020 16:54:19 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-s5wtuvp7kmj2lkio3sxs
c970943d2ea1872e9da363e978a32abb191aeeb8: Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 16:52:50 +0000 - rev 3313181
Push 617275 by reviewbot at Mon, 02 Nov 2020 16:53:45 +0000
Bug 1674221 - Prefix Skeleton UI reg names with exe path r?agashlin Summary: Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674221 Differential Diff: PHID-DIFF-s5wtuvp7kmj2lkio3sxs
5d0604b0226dd708bcc737b898f823ffa218a9dc: Bug 1674540 - Remove unused prthrad.h include r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Mon, 02 Nov 2020 15:08:01 +0000 - rev 3313038
Push 617235 by reviewbot at Mon, 02 Nov 2020 15:08:32 +0000
Bug 1674540 - Remove unused prthrad.h include r?agashlin Summary: This snuck in after I forgot to delete this upon realizing I couldn't use nspr stuff in mozglue. Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674540 Differential Diff: PHID-DIFF-dyd33ddgstn5xme4fudh
202413fac7013c75e82f0741dfe4cd17508ade81: Bug 1674389 - Implement rounded borders on Skeleton UI rects r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Fri, 30 Oct 2020 19:29:01 +0000 - rev 3301212
Push 616779 by reviewbot at Fri, 30 Oct 2020 19:29:31 +0000
Bug 1674389 - Implement rounded borders on Skeleton UI rects r?agashlin Summary: I'm hoping that the comments in the code are sufficient documentation of this, but here is a quick overview. The mockup we got from design has rounded rects in it, and bordered rounded rects in it, so we need to support drawing those. Initially we tried using the RoundRect function in GDI. However, 1) GDI doesn't support anti-aliasing, which is unfortunately noticeable, 2) we were observing strange issues with only some of the corners being rounded with RoundRect at higher radii / stroke widths. 3) drawing on top of things drawn with RoundRect would be complicated and inefficient unless we switched everything over to GDI calls. As it stands this drawing code is platform agnostic, assuming we have a way of blitting a raw bitmap to the screen on a given platform, which is a nice trait to have and makes me think twice about switching all of the drawing over to direct GDI calls. Differential Revision: https://phabricator.services.mozilla.com/D95317 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1674389 Differential Diff: PHID-DIFF-snetinopqrdcprqxc5ls
23c5d0a4118e891744c4978c78b79f8aac5939ce: Bug 1666874 - Support maximized windows for skeleton UI r=agashlin
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 19:04:02 +0000 - rev 3299923
Push 616436 by reviewbot at Fri, 30 Oct 2020 03:56:13 +0000
Bug 1666874 - Support maximized windows for skeleton UI r=agashlin Most of this patch is a dance to avoid size flickering of the skeleton UI window. We change all Resize/Move/SetSizeMode calls from before the first nsWindow::Show call. Normally those have no effect, since the window isn't shown yet, and if the window is not maximized, they typically match the sizes we've gotten out of the registry anyway. However, if we are maximized, then they produce a lot of visual noise. We can however achieve the desired effect by just calling SetWindowPlacement. Similarly, we switch the window styles of the skeleton UI window to match those of the toplevel Windows window, and adjust the client rect from our window proc in a way that matches the adjustments in nsWindow in the WM_NCCALCSIZE handler. We do this because otherwise we get a flicker as soon as we change the styles and nonclient margins as the fake chrome pops up and then back down. Lastly we also change the extended window styles so that they match. We historically added WS_EX_TOOLWINDOW here to hide the toolbar entry, because it would otherwise switch out to a new toolbar entry when we changed the window styles. However since our new styles match, we no longer need to do this. It was also causing the maximized window to paint over the Windows taskbar. Differential Revision: https://phabricator.services.mozilla.com/D93534
7e7a708a999720f8fccf5b33525484bd9d0fd5a6: Bug 1665455 - Animate the Skeleton UI r=agashlin
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 19:03:59 +0000 - rev 3299922
Push 616436 by reviewbot at Fri, 30 Oct 2020 03:56:13 +0000
Bug 1665455 - Animate the Skeleton UI r=agashlin For a better user experience during slow startups (and to match the design by Markus Jaritz), we want to animate the placeholder elements (the grey rectangles which hold the place of text and icons) with a light moving gradient. A question may arise regarding whether the performance cost of running this animation is worth the improved user experience. My claim is yes, hinging mostly on the observation that the performance cost is small. On my machine, one frame of the animation takes at most 0.15ms, and runs every 16.15ms. This means we eat less than 1% CPU time on one core of the system. It should also be noted that this animation runs primarily during the window wherein we are prefetching dlls, AKA while we are blocked on IO and the CPU is more likely to be idle. On slower systems, one frame may take longer - however, on slower systems we should also be blocked *more* by IO, making the trade favorable. For further anecdotal evidence of this being okay, when I run this on slow reference hardware shortly after OS startup, I do not see any dropped frames, indicating that this has very little trouble completing, and is thus quite cheap. Regarding testing, I will invoke the same logic as for the rest of the skeleton UI patches - it would involve quite a bit of work to test this in automation given our existing frameworks. It may be worth it at some point, but certainly not while this is a feature that we are just experimenting with and which is not enabled by default. Differential Revision: https://phabricator.services.mozilla.com/D91453
967c4cf56fd2d8b8f6875386550bbe51f1ffcf4f: Bug 1666874 - Support maximized windows for skeleton UI r=agashlin
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 14:09:54 +0000 - rev 3289425
Push 616280 by emilio@crisal.io at Thu, 29 Oct 2020 21:16:09 +0000
Bug 1666874 - Support maximized windows for skeleton UI r=agashlin Most of this patch is a dance to avoid size flickering of the skeleton UI window. We change all Resize/Move/SetSizeMode calls from before the first nsWindow::Show call. Normally those have no effect, since the window isn't shown yet, and if the window is not maximized, they typically match the sizes we've gotten out of the registry anyway. However, if we are maximized, then they produce a lot of visual noise. We can however achieve the desired effect by just calling SetWindowPlacement. Similarly, we switch the window styles of the skeleton UI window to match those of the toplevel Windows window, and adjust the client rect from our window proc in a way that matches the adjustments in nsWindow in the WM_NCCALCSIZE handler. We do this because otherwise we get a flicker as soon as we change the styles and nonclient margins as the fake chrome pops up and then back down. Lastly we also change the extended window styles so that they match. We historically added WS_EX_TOOLWINDOW here to hide the toolbar entry, because it would otherwise switch out to a new toolbar entry when we changed the window styles. However since our new styles match, we no longer need to do this. It was also causing the maximized window to paint over the Windows taskbar. Differential Revision: https://phabricator.services.mozilla.com/D93534
e46238e6aabf422eb2fef056aee609cf4bfba786: Bug 1665455 - Animate the Skeleton UI r=agashlin
Doug Thayer <dothayer@mozilla.com> - Wed, 28 Oct 2020 19:22:54 +0000 - rev 3289424
Push 616280 by emilio@crisal.io at Thu, 29 Oct 2020 21:16:09 +0000
Bug 1665455 - Animate the Skeleton UI r=agashlin For a better user experience during slow startups (and to match the design by Markus Jaritz), we want to animate the placeholder elements (the grey rectangles which hold the place of text and icons) with a light moving gradient. A question may arise regarding whether the performance cost of running this animation is worth the improved user experience. My claim is yes, hinging mostly on the observation that the performance cost is small. On my machine, one frame of the animation takes at most 0.15ms, and runs every 16.15ms. This means we eat less than 1% CPU time on one core of the system. It should also be noted that this animation runs primarily during the window wherein we are prefetching dlls, AKA while we are blocked on IO and the CPU is more likely to be idle. On slower systems, one frame may take longer - however, on slower systems we should also be blocked *more* by IO, making the trade favorable. For further anecdotal evidence of this being okay, when I run this on slow reference hardware shortly after OS startup, I do not see any dropped frames, indicating that this has very little trouble completing, and is thus quite cheap. Regarding testing, I will invoke the same logic as for the rest of the skeleton UI patches - it would involve quite a bit of work to test this in automation given our existing frameworks. It may be worth it at some point, but certainly not while this is a feature that we are just experimenting with and which is not enabled by default. Differential Revision: https://phabricator.services.mozilla.com/D91453
aaa1e78bce05c771750f7b9aa890bf71aeb55f8e: Bug 1666874 - Support maximized windows for skeleton UI r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 20:42:37 +0000 - rev 3289281
Push 616242 by reviewbot at Thu, 29 Oct 2020 20:43:01 +0000
Bug 1666874 - Support maximized windows for skeleton UI r?agashlin Summary: Most of this patch is a dance to avoid size flickering of the skeleton UI window. We change all Resize/Move/SetSizeMode calls from before the first nsWindow::Show call. Normally those have no effect, since the window isn't shown yet, and if the window is not maximized, they typically match the sizes we've gotten out of the registry anyway. However, if we are maximized, then they produce a lot of visual noise. We can however achieve the desired effect by just calling SetWindowPlacement. Similarly, we switch the window styles of the skeleton UI window to match those of the toplevel Windows window, and adjust the client rect from our window proc in a way that matches the adjustments in nsWindow in the WM_NCCALCSIZE handler. We do this because otherwise we get a flicker as soon as we change the styles and nonclient margins as the fake chrome pops up and then back down. Lastly we also change the extended window styles so that they match. We historically added WS_EX_TOOLWINDOW here to hide the toolbar entry, because it would otherwise switch out to a new toolbar entry when we changed the window styles. However since our new styles match, we no longer need to do this. It was also causing the maximized window to paint over the Windows taskbar. Differential Revision: https://phabricator.services.mozilla.com/D93534 Depends on D91453 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666874 Differential Diff: PHID-DIFF-72uywideguhrag6bdwyt
9034b61749e63e058ae3d206ae0189f96727e660: Bug 1665455 - Animate the Skeleton UI r=agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 20:42:34 +0000 - rev 3289280
Push 616242 by reviewbot at Thu, 29 Oct 2020 20:43:01 +0000
Bug 1665455 - Animate the Skeleton UI r=agashlin For a better user experience during slow startups (and to match the design by Markus Jaritz), we want to animate the placeholder elements (the grey rectangles which hold the place of text and icons) with a light moving gradient. A question may arise regarding whether the performance cost of running this animation is worth the improved user experience. My claim is yes, hinging mostly on the observation that the performance cost is small. On my machine, one frame of the animation takes at most 0.15ms, and runs every 16.15ms. This means we eat less than 1% CPU time on one core of the system. It should also be noted that this animation runs primarily during the window wherein we are prefetching dlls, AKA while we are blocked on IO and the CPU is more likely to be idle. On slower systems, one frame may take longer - however, on slower systems we should also be blocked *more* by IO, making the trade favorable. For further anecdotal evidence of this being okay, when I run this on slow reference hardware shortly after OS startup, I do not see any dropped frames, indicating that this has very little trouble completing, and is thus quite cheap. Regarding testing, I will invoke the same logic as for the rest of the skeleton UI patches - it would involve quite a bit of work to test this in automation given our existing frameworks. It may be worth it at some point, but certainly not while this is a feature that we are just experimenting with and which is not enabled by default. Differential Revision: https://phabricator.services.mozilla.com/D91453 Differential Diff: PHID-DIFF-cppu5cxgbfcw5xdlrfpx
c881cbade0ba97dd1de8843ed690109eea5bb42f: Bug 1665455 - Animate the Skeleton UI r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 20:41:44 +0000 - rev 3289278
Push 616241 by reviewbot at Thu, 29 Oct 2020 20:42:11 +0000
Bug 1665455 - Animate the Skeleton UI r?agashlin Summary: For a better user experience during slow startups (and to match the design by Markus Jaritz), we want to animate the placeholder elements (the grey rectangles which hold the place of text and icons) with a light moving gradient. A question may arise regarding whether the performance cost of running this animation is worth the improved user experience. My claim is yes, hinging mostly on the observation that the performance cost is small. On my machine, one frame of the animation takes at most 0.15ms, and runs every 16.15ms. This means we eat less than 1% CPU time on one core of the system. It should also be noted that this animation runs primarily during the window wherein we are prefetching dlls, AKA while we are blocked on IO and the CPU is more likely to be idle. On slower systems, one frame may take longer - however, on slower systems we should also be blocked *more* by IO, making the trade favorable. For further anecdotal evidence of this being okay, when I run this on slow reference hardware shortly after OS startup, I do not see any dropped frames, indicating that this has very little trouble completing, and is thus quite cheap. Regarding testing, I will invoke the same logic as for the rest of the skeleton UI patches - it would involve quite a bit of work to test this in automation given our existing frameworks. It may be worth it at some point, but certainly not while this is a feature that we are just experimenting with and which is not enabled by default. Differential Revision: https://phabricator.services.mozilla.com/D91453 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1665455 Differential Diff: PHID-DIFF-sznesi7qtxllsmnejipl
8ff0b9ef2eb501ef7838a7caf0ea32cc89bbf28c: Bug 1666874 - Support maximized windows for skeleton UI r?agashlin draft
Doug Thayer <dothayer@mozilla.com> - Thu, 29 Oct 2020 18:33:12 +0000 - rev 3287884
Push 616112 by reviewbot at Thu, 29 Oct 2020 18:33:35 +0000
Bug 1666874 - Support maximized windows for skeleton UI r?agashlin Summary: Most of this patch is a dance to avoid size flickering of the skeleton UI window. We change all Resize/Move/SetSizeMode calls from before the first nsWindow::Show call. Normally those have no effect, since the window isn't shown yet, and if the window is not maximized, they typically match the sizes we've gotten out of the registry anyway. However, if we are maximized, then they produce a lot of visual noise. We can however achieve the desired effect by just calling SetWindowPlacement. Similarly, we switch the window styles of the skeleton UI window to match those of the toplevel Windows window, and adjust the client rect from our window proc in a way that matches the adjustments in nsWindow in the WM_NCCALCSIZE handler. We do this because otherwise we get a flicker as soon as we change the styles and nonclient margins as the fake chrome pops up and then back down. Lastly we also change the extended window styles so that they match. We historically added WS_EX_TOOLWINDOW here to hide the toolbar entry, because it would otherwise switch out to a new toolbar entry when we changed the window styles. However since our new styles match, we no longer need to do this. It was also causing the maximized window to paint over the Windows taskbar. Differential Revision: https://phabricator.services.mozilla.com/D93534 Depends on D91453 Test Plan: Reviewers: agashlin Subscribers: Bug #: 1666874 Differential Diff: PHID-DIFF-6hftbhwj5ajxaqpthqrt