e479fb42e16d959b3adae5ca1f7798e44916e47e: Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 19:32:00 +0900 - rev 1519020
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 15: Make HTMLEditRules::WillRemoveAbsolutePosition() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: DXzdtPQ01lo
33a617df4fb0e63e154b1334bfa1a586e1443184: Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 19:24:35 +0900 - rev 1519019
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 14: Make HTMLEditRules::WillRelativeChangeZIndex() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 8HEqK3DAPO4
1377189f6066fff600a23419fb36f6932f27bbdf: Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 19:06:07 +0900 - rev 1519018
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 13: Make TextEditRules::WillInsert() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato This patch also makes aCancel of TextEditRules::WillInsert() optional since a lot of callers need to ignore the result. MozReview-Commit-ID: JrvycxMQ9Mm
91c04a08b450c157e79540b2777b9c68758f8cb6: Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 18:49:44 +0900 - rev 1519017
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 12: Make TextEditRules::WillInsertBreak() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: Ia5MJ465Hdf
82a5d2513e1029478163e23a72e64a014371b5b2: Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 18:40:47 +0900 - rev 1519016
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3ulGUfu1af1
88d781c6c2bfb0059737fda7b069fea3dd0d4b99: Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 18:29:54 +0900 - rev 1519015
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: RT0Bi9TBwt
5c342148d0b91aea224c818a4697d9b846c9658e: Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 17:33:55 +0900 - rev 1519014
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 9ksPugTVVqh
375745f60b19fe2cf4042a918dccfd5a6904a878: Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 17:15:53 +0900 - rev 1519013
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato This patch creates internal method for it as DeleteSelectionWithTransaction() because it needs to create SelectionBatcher and destruction of it may cause destroying the editor. Therefore, unfortunately, all callers of DeleteSelectionWithTransaction() needs to check CanHandleEditAction() manually. If we could use try-catch, we could make it safer, though. MozReview-Commit-ID: 13enOQjEzNn
371610003e6cf8df35400ce9adeac0ba653e243e: Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:48:29 +0900 - rev 1519012
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And also this patch removes unnecessary arguments from the method. MozReview-Commit-ID: UKscK4vFVX
352488455e0e9217ca9aa3341ee1c138de6079a4: Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:36:07 +0900 - rev 1519011
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: HpFo0SiTBWJ
916c62d183542c88fe2b753d0467aeb5a8905394: Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:31:53 +0900 - rev 1519010
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: CNTgECam862
6414f60acdd37e015d770b2be16e9ac7542944a5: Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:24:15 +0900 - rev 1519009
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato Note that HTMLEditRules::DocumentModifiedWorker() is a runnable method. So, it cannot return nsresult. Therefore, it just checks the result only with NS_WARNING_ASSERTION(). MozReview-Commit-ID: KBSpv5H5KGU
8ec2eed88db0f0161d499d74c629c5c8860102d0: Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:08:47 +0900 - rev 1519008
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor r?m_kato And also this patch marks it as MOZ_MUST_USE. All callers have to check if the result is NS_ERROR_EDITOR_DESTROYED at least. MozReview-Commit-ID: H4DfU1asPpe
32416d5b8a3f70cbcda73a9bf0bf299fb3ac01f3: Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 15:52:24 +0900 - rev 1519007
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result r?m_kato First, this patch changes TextEditRules::CreateBRInternal() to a private method for making any callers use CreateBR() or CreateMozBR() instead. Then, this patch makes TextEditRules::CreateBRInternal() return both nsresult and created <br> element with CreateElementResult class. Finally, this patch makes all callers of them check if they don't return an error code including NS_ERROR_EDITOR_DESTROYED. MozReview-Commit-ID: 18OvPmbDVHK
c5da34aa0dcaba92d1492d116adce4f707d4c9de: Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 24 Apr 2018 15:23:01 +0900 - rev 1519006
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment r?m_kato This patch defines NS_ERROR_EDITOR_DESTROYED error code as an editor module specific error code. And creates TextEditRules::CanHandleEditAction() to check if the instance can keep handling edit action. MozReview-Commit-ID: 4qECwNBO0yz
8ed8ee55a661f21c80c41432226e4631861da08a: Bug 1463330 - Move CanPasteTransferable and PreDestroy to out of nsIEditor. r?masayuki
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 23 May 2018 12:40:25 +0900 - rev 1519005
Push 273348 by masayuki@d-toybox.com at Wed, 23 May 2018 04:36:11 +0000
Bug 1463330 - Move CanPasteTransferable and PreDestroy to out of nsIEditor. r?masayuki CanPasteTransferable and PreDestroy aren't used from script (inc. comm-central
4642a209179710fd7ac0f322beefbf38a177d308: try: -b o -p linux64 -u mochitest-dt -t damp-e10s --rebuild-talos 6 --artifact
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 23 May 2018 00:27:34 -0400 - rev 1519004
Push 273347 by gabriel.luong@gmail.com at Wed, 23 May 2018 04:27:49 +0000
try: -b o -p linux64 -u mochitest-dt -t damp-e10s --rebuild-talos 6 --artifact Pushed via `mach try syntax`
d17c429bbbce44cf7aa57fe6d3760850a5155c29: Bug 1463566 - Lazy load the inspector search. r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 23 May 2018 00:27:27 -0400 - rev 1519003
Push 273347 by gabriel.luong@gmail.com at Wed, 23 May 2018 04:27:49 +0000
Bug 1463566 - Lazy load the inspector search. r=pbro
5b701b88a450971774171e8378bbe35ecb67f2dd: try: -b do -p win32,win64,linux64,linux -u web-platform-tests-e10s-1[linux64-stylo,Ubuntu,10.10,Windows 10],web-platform-tests-1[linux64-stylo,Ubuntu,10.10,Windows 10] -t none --artifact --try-test-paths web-platform-tests:testing/web-platform/tests/html/semantics/forms/form-submission-0/form-data-set-usv.html
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 23 May 2018 04:25:57 +0000 - rev 1519002
Push 273346 by wptsync@mozilla.com at Wed, 23 May 2018 04:26:38 +0000
try: -b do -p win32,win64,linux64,linux -u web-platform-tests-e10s-1[linux64-stylo,Ubuntu,10.10,Windows 10],web-platform-tests-1[linux64-stylo,Ubuntu,10.10,Windows 10] -t none --artifact --try-test-paths web-platform-tests:testing/web-platform/tests/html/semantics/forms/form-submission-0/form-data-set-usv.html
f3386d72b9fff6aec95afd9547e76dea76eb7238: Bug 1463627 [wpt PR 11113] - Update wpt manifest
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 23 May 2018 04:19:00 +0000 - rev 1519001
Push 273346 by wptsync@mozilla.com at Wed, 23 May 2018 04:26:38 +0000
Bug 1463627 [wpt PR 11113] - Update wpt manifest wpt-pr: 11113 wpt-type: manifest
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip