de02210e1d8bf967831d899bc8233a99f2709c98: WIP: Bug 1733537 - [devtools] Replace usage of NodeFront#getAllSelectors with a command. r=jdescottes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:47:22 +0000 - rev 4030598
Push 741666 by reviewbot at Mon, 18 Oct 2021 08:47:43 +0000
WIP: Bug 1733537 - [devtools] Replace usage of NodeFront#getAllSelectors with a command. r=jdescottes. Summary: `getAllSelectors` was used to retrieve a given nodeFront selector from the top window (e.g. it would go up through documents). This doesn't work with nodeFronts in remote frames, as we wouldn't be able to reach for cross-process parent documents. This patchs adds a new inspector command that computes the selector, reaching the different documents. All usages of `NodeFront#getAllSelectors` are switched to the new command, which allows us to delete the method and another function that was only used there. With the new command doing a bit more work, this highlighted some issue in our codebase. Some consumers were relying on `selectionCssSelectors`, without waiting for it to be updated when a new node was selected. As a result a few tests were failing because of this. So where it's possible and not perf critical, we simply compute the selector again. We also emit a new event, `selection-css-selectors-updated`, so tests can wait until it's properly set before doing further actions. Differential Revision: https://phabricator.services.mozilla.com/D127928 Depends on D128714 Test Plan: Reviewers: Subscribers: Bug #: 1733537 Differential Diff: PHID-DIFF-oyouinkuaqywgzb7s7na
80f27b9aabd896d3217e7c95e6371c2eff85f021: Bug 1734149 - [devtools] Disable browser_inspector-retain test task when EFT is enabled. r=ochameau. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:47:19 +0000 - rev 4030597
Push 741666 by reviewbot at Mon, 18 Oct 2021 08:47:43 +0000
Bug 1734149 - [devtools] Disable browser_inspector-retain test task when EFT is enabled. r=ochameau. With EFT, what's done in the task is not relevant anymore. Differential Revision: https://phabricator.services.mozilla.com/D127541 Differential Diff: PHID-DIFF-vr6rzgbq7cewy3yujy2y
d105be63e9422b8f0f8436ed7c86321d11ef9f6f: try_task_config for https://phabricator.services.mozilla.com/D128714 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 18 Oct 2021 08:46:36 +0000 - rev 4030596
Push 741665 by reviewbot at Mon, 18 Oct 2021 08:46:52 +0000
try_task_config for https://phabricator.services.mozilla.com/D128714 Differential Diff: PHID-DIFF-jkblkjrw7i7szawivgkj
946e46e2cde85840006391d06c6237c85fd7a210: WIP: Bug 1735551 - [devtools] WIP Fix findNodeFront with cross-origin iframes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:46:32 +0000 - rev 4030595
Push 741665 by reviewbot at Mon, 18 Oct 2021 08:46:52 +0000
WIP: Bug 1735551 - [devtools] WIP Fix findNodeFront with cross-origin iframes. Summary: Depends on D128713 Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-jkblkjrw7i7szawivgkj
9d8708df73683df8647f37c154f7b71df10e2c8b: WIP: Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle cross origin iframe. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:46:29 +0000 - rev 4030594
Push 741665 by reviewbot at Mon, 18 Oct 2021 08:46:52 +0000
WIP: Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle cross origin iframe. Summary: This will handle cases when Fission is not enabled. Depends on D128712 Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-wqtr6obgrd3ndyfozs74
955073b81b2b6224ed7458a261d4a4a9d98bb590: WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:46:26 +0000 - rev 4030593
Push 741665 by reviewbot at Mon, 18 Oct 2021 08:46:52 +0000
WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. Summary: The callsites are migrated to the new command, except from the webconsole test in which we replace usage with existing inspector test helper. Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-45dtchvlmf6fe2p2mmhw
2126e4ade6aa6921fada201adb00bbcbbbfd04a1: try_task_config for https://phabricator.services.mozilla.com/D128713 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 18 Oct 2021 08:45:27 +0000 - rev 4030592
Push 741664 by reviewbot at Mon, 18 Oct 2021 08:45:43 +0000
try_task_config for https://phabricator.services.mozilla.com/D128713 Differential Diff: PHID-DIFF-wqtr6obgrd3ndyfozs74
6a1413f6049430c01854823d1b01f195a1c4ab54: WIP: Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle cross origin iframe. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:45:24 +0000 - rev 4030591
Push 741664 by reviewbot at Mon, 18 Oct 2021 08:45:43 +0000
WIP: Bug 1735551 - [devtools] Make NodeActor#waitForFrameLoad handle cross origin iframe. Summary: This will handle cases when Fission is not enabled. Depends on D128712 Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-wqtr6obgrd3ndyfozs74
6f8913f42c926e8ed7c2b6bb2b09632552e1dabf: WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:45:21 +0000 - rev 4030590
Push 741664 by reviewbot at Mon, 18 Oct 2021 08:45:43 +0000
WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. Summary: The callsites are migrated to the new command, except from the webconsole test in which we replace usage with existing inspector test helper. Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-45dtchvlmf6fe2p2mmhw
3f7cf84fd08b66094043dcd131b0aa5a42ed76fa: try_task_config for https://phabricator.services.mozilla.com/D128712 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 18 Oct 2021 08:44:24 +0000 - rev 4030589
Push 741663 by reviewbot at Mon, 18 Oct 2021 08:44:40 +0000
try_task_config for https://phabricator.services.mozilla.com/D128712 Differential Diff: PHID-DIFF-45dtchvlmf6fe2p2mmhw
d408446a7ac3ea220fa76886f644afa8e4ca6b16: WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Oct 2021 08:44:21 +0000 - rev 4030588
Push 741663 by reviewbot at Mon, 18 Oct 2021 08:44:40 +0000
WIP: Bug 1735551 - [devtools] Turn WalkerFront#findNodeFront into a command. r=jdescottes. Summary: The callsites are migrated to the new command, except from the webconsole test in which we replace usage with existing inspector test helper. Test Plan: Reviewers: Subscribers: Bug #: 1735551 Differential Diff: PHID-DIFF-45dtchvlmf6fe2p2mmhw
a0f87e112dee0224bd0c20dfc3107d8cadc16822: try_task_config for https://phabricator.services.mozilla.com/D128601 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 18 Oct 2021 08:29:06 +0000 - rev 4030587
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
try_task_config for https://phabricator.services.mozilla.com/D128601 Differential Diff: PHID-DIFF-eb6sv7vsi7ai7r3xlir7
e2aa3d8dc8da9aafee09b5f07ce08faa24599513: Bug 1731982 - Part 10: Use AntiTrackingUtils::IsThirdPartyContext() to check third party in AntiTrackingUtils::IsThirdPartyWindow() if the channel is not available. r?pbz draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:29:03 +0000 - rev 4030586
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 10: Use AntiTrackingUtils::IsThirdPartyContext() to check third party in AntiTrackingUtils::IsThirdPartyWindow() if the channel is not available. r?pbz Summary: We used to use the ThirdPartyUtil::IsThirdPartyWindow() to check third party if the document or the channel is not available. However, this could be incorrect in the case where the channel is not available because the WindowContext is not ready yet. To address this issue, we use the browingContext of the document to check third party. Differential Revision: https://phabricator.services.mozilla.com/D128601 Depends on D127842 Test Plan: Reviewers: pbz Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-eb6sv7vsi7ai7r3xlir7
31a78b126e2b41e11861b454cd14700c890e3ea6: Bug 1731982 - Part 9: Modify the test browser_partitionedServiceWorkers.js. r?dimi draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:29:01 +0000 - rev 4030585
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 9: Modify the test browser_partitionedServiceWorkers.js. r?dimi Summary: Differential Revision: https://phabricator.services.mozilla.com/D127842 Depends on D127841 Test Plan: Reviewers: dimi Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-elrahnb5xt572iyxg2lg
009cc2d2feac348b686b9d90c217c45da1d85f64: Bug 1731982 - Part 8: Ignoring the partitionKey when verify loadingPrincipal with clientInfo. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:58 +0000 - rev 4030584
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 8: Ignoring the partitionKey when verify loadingPrincipal with clientInfo. r?asuth Summary: Given that we use the partitioned Principal in the third-party context and the loading principal won't have it, we should ignore the partitionKey when doing the verfication. Differential Revision: https://phabricator.services.mozilla.com/D127841 Depends on D127840 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-up75olc64c56uik5ra27
ddbb04b13915d1ec53f155454229d0d654373b66: Bug 1731982 - Part 7: Use the client's principal to verify client in localStorage. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:56 +0000 - rev 4030583
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 7: Use the client's principal to verify client in localStorage. r?asuth Summary: Currently, we use the script principal to verify the client to prevent the principal forgery. After we moving to use foreign partitioned principal for the Client, this no longer works. Instead, we can directly use the client's principal to verify client. Also, the patch rename StoragePrincipalHelper::VerifyValidStoragePrincipalInfoForPrincipalInfo() to StoragePrincipalHelper::VerifyValidPartitionedPrincipalInfoForPrincipalInfo() and fix a problem in the function that it should ignore the PartitionKey instead of the FirstPartyDomain. Differential Revision: https://phabricator.services.mozilla.com/D127840 Depends on D127632 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-j7a2sqou5wv7p3iqbyl4
fba80135ec4f491a7b43b32b46a7d947f81f7438: Bug 1731982 - Part 6: Using foreign partitioned principal when creating clientSource in ServiceWorkerManager. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:54 +0000 - rev 4030582
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 6: Using foreign partitioned principal when creating clientSource in ServiceWorkerManager. r?asuth Summary: Currently, the ServiceWorkerManager creates a content prinipcal based on the regular originAttributes when dispatch the fetch event. This patch changes to use the foreign partitioned originAttributs. Note that we don't add tests for this because the change doesn't change the behavior. And we don't enable partitioned third-party Service Worker. So, the existing test cases is enough for this. Differential Revision: https://phabricator.services.mozilla.com/D127632 Depends on D127631 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-2m7is2mgoninfcd7mc7a
26f4e3931d08f3161e8f8b9865953c1606f24bb5: Bug 1731982 - Part 5: Using StoragePrincipalHelper::GetPrincipal() in ClientChannelHelper. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:52 +0000 - rev 4030581
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 5: Using StoragePrincipalHelper::GetPrincipal() in ClientChannelHelper. r?asuth Summary: To support foreign partitioned prinicpal for Client, we use StoragePrincipalHelper::GetPrincipal() to get the foreign partitioned principal from the channel in the ClientChannelHelper. And use it to create client. Differential Revision: https://phabricator.services.mozilla.com/D127631 Depends on D127630 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-pmyq7r73m3nhtaa2htg7
958dbccc5f27f969f635103e828af680446e4ea2: Bug 1731982 - Part 4: Using foreign partitioned principal when creating clientSource in nsGlobalWindowInner. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:49 +0000 - rev 4030580
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 4: Using foreign partitioned principal when creating clientSource in nsGlobalWindowInner. r?asuth Summary: Currently, we use the node principal to create clientSource in nsGloblaWindowInner. This patch change this to use foreign partitioned principal. Differential Revision: https://phabricator.services.mozilla.com/D127630 Depends on D127629 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-zphyxo3llpchxaudscur
e7909dc63d6e513fa72d0923cc950ca416fd1f2d: Bug 1731982 - Part 3: Use partitioned principal for creating initial client source if needed in nsDocShell. r?asuth draft
Tim Huang <tihuang@mozilla.com> - Mon, 18 Oct 2021 08:28:47 +0000 - rev 4030579
Push 741662 by reviewbot at Mon, 18 Oct 2021 08:30:32 +0000
Bug 1731982 - Part 3: Use partitioned principal for creating initial client source if needed in nsDocShell. r?asuth Summary: Currently, we are using the regular principal and inherited regular principal to create clientSource in nsDocShell. This patch makes the nsDocshell to use the partitioned principal if needed. Differential Revision: https://phabricator.services.mozilla.com/D127629 Depends on D127628 Test Plan: Reviewers: asuth Subscribers: Bug #: 1731982 Differential Diff: PHID-DIFF-zbzcjkohsevvgia2fz7v
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip