d6f6e0e4ea117fa27274e6539112cc7fce23fcc8: Bug 1598164 - Implement transaction inactive state according to spec. r=#dom-workers-and-storage draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:51:28 +0000 - rev 2514411
Push 459908 by reviewbot at Wed, 04 Dec 2019 12:51:53 +0000
Bug 1598164 - Implement transaction inactive state according to spec. r=#dom-workers-and-storage Differential Revision: https://phabricator.services.mozilla.com/D55142 Differential Diff: PHID-DIFF-y4wxsd5oruqnqfvixge2
bd7c43432670facdd2a78244d6de5a871c33aa5d: Bug 1598164 - Made some boolean flags in IDBTransaction FlippedOnce to reduce statefulness. r=dom-workers-and-storage-reviewers,ytausky draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:51:25 +0000 - rev 2514410
Push 459908 by reviewbot at Wed, 04 Dec 2019 12:51:53 +0000
Bug 1598164 - Made some boolean flags in IDBTransaction FlippedOnce to reduce statefulness. r=dom-workers-and-storage-reviewers,ytausky Differential Revision: https://phabricator.services.mozilla.com/D55081 Differential Diff: PHID-DIFF-vt6yqbmlrrk5ukf4hras
7d32f16c841f565534cd2163fba40a319ae679b2: Bug 1598164 - Added FlippedOnce class template to help reducing statefulness of boolean flags. r=dom-workers-and-storage-reviewers,ytausky draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:51:21 +0000 - rev 2514409
Push 459908 by reviewbot at Wed, 04 Dec 2019 12:51:53 +0000
Bug 1598164 - Added FlippedOnce class template to help reducing statefulness of boolean flags. r=dom-workers-and-storage-reviewers,ytausky Differential Revision: https://phabricator.services.mozilla.com/D55080 Differential Diff: PHID-DIFF-jpa3l2tjmphcs3lbaxnq
710674fe9e6b8a520f8a6ec3b0b3ad4d1fe7d446: Bug 1598164 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:51:17 +0000 - rev 2514408
Push 459908 by reviewbot at Wed, 04 Dec 2019 12:51:53 +0000
Bug 1598164 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv Depends on D54322 Differential Revision: https://phabricator.services.mozilla.com/D55079 Differential Diff: PHID-DIFF-62uhzy37bsukgspbcmuv
ee01a7f649cb45564fb2dc12cc57a0d47bd35934: Try Chooser Enhanced (318 tasks selected) draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 21:49:12 +0900 - rev 2514407
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Try Chooser Enhanced (318 tasks selected) Pushed via `mach try chooser`
817c682bf18ddae6b1978d8867edc5515080e83d: Bug 1543315 - part 20: Mark `PresShell::DidCauseReflow()` as `MOZ_CAN_RUN_SCRIPT` r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 16:53:16 +0900 - rev 2514406
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1543315 - part 20: Mark `PresShell::DidCauseReflow()` as `MOZ_CAN_RUN_SCRIPT` r=smaug It removes a script blocker. Therefore, although it depends on the caller whether it causes running script or not. However, we should mark it as `MOZ_CAN_RUN_SCRIPT` for safer code. It's called only by the destructor of `nsAutoCauseReflowNotifier`. Therefore, this patch also marks its constructor as `MOZ_CAN_RUN_SCRIPT` for making each creator method marked as `MOZ_CAN_RUN_SCRIPT` or `MOZ_CAN_RUN_SCRIPT_BOUNDARY`. Most of the creators is mutation listener methods. However, `PresShell` does nothing after destroying `nsAutoCauseReflowNotifier`. Therefore, this patch does not change the callers in MutationObserver.cpp to use `RefPtr<PresShell>` at calling them because changing it may cause performance regression. Perhaps, we should create another methods of `WillCauseReflow()` and `DidCauseReflow()` to avoid unnecessary `MOZ_CAN_RUN_SCRIPT` marking. However, I'm not sure whether most callers may run script or not because of outside of my knowledge.
b9e3b7d03bfb48bfe1fe97c43c09f0bc552f4c25: Bug 1543315 - part 19: Mark `PresShell::ContentStateChanged()` as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 15:52:18 +0900 - rev 2514405
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1543315 - part 19: Mark `PresShell::ContentStateChanged()` as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` r=smaug While it calls `RestyleManager::ContentStateChanged()`, it blocks script with `nsAutoCauseReflowNotifier`. Therefore, it should be marked as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` at least (looks like the other override, `DocAccessible::ContentStateChanged()` does not run script). I'm not sure about the lifetime of `RestyleManager`. It's destroyed when `nsPresContext::DetachPresShell()` is called. It's called by `PresShell::Destroy()` and destructor of `nsPresContext`. The latter is safe since `PresShell` owns `mPresContext`. However, I'm not sure about the former. It might be better to create blocker of synchronous handling of `PresShell::Destroy()`. And also this does not make `Document::ContentStateChanged()` use `RefPtr<PresShell>` at calling it because it might cause performance regression, but it does not do anything after destroying `nsAutoCauseReflowNotifier`.
10db67c4c5263c0f516d1acf4c0242d7c10beb2d: Bug 1543315 - part 18: Mark `PresShell::ReconstructFrames()` as `MOZ_CAN_RUN_SCRIPT` r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 15:20:49 +0900 - rev 2514404
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1543315 - part 18: Mark `PresShell::ReconstructFrames()` as `MOZ_CAN_RUN_SCRIPT` r=smaug It calls `Document::FlushPendingNotification()` so that we should mark it as `MOZ_CAN_RUN_SCRIPT`. And the method calls it of `mDocument` and `mDocument` is never modified after it's initialized. Therefore, we can move the initializer to the constructor and make `RefPtr<Document>` to `RefPtr<Document> const`. Thus, we can avoid unnecessary auto `RefPtr`.
01e8278a60a85fc11cac65c668b4dfd7a420fe97: Bug 1543315 - part 17: Mark `PresShell::FireResizeEvent()` as `MOZ_CAN_RUN_SCRIPT` r=smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 28 Nov 2019 10:30:37 +0900 - rev 2514403
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1543315 - part 17: Mark `PresShell::FireResizeEvent()` as `MOZ_CAN_RUN_SCRIPT` r=smaug It dispatches a DOM event so that it should be marked as `MOZ_CAN_RUN_SCRIPT`.
4c767cd9cb8237dd174afef8d2122ec59dae1235: Bug 1599971 - part 5: Mark `TextControlState::BindToFrame()` and `TextControlState::UnbindFromFrame()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 13:05:13 +0900 - rev 2514402
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1599971 - part 5: Mark `TextControlState::BindToFrame()` and `TextControlState::UnbindFromFrame()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D55776
23a86617e5ae2a227ae654597bcce8b6c097c541: Bug 1599971 - part 4: Mark `TextControlState::GetTextEditor()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 03 Dec 2019 22:28:28 +0900 - rev 2514401
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1599971 - part 4: Mark `TextControlState::GetTextEditor()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! If `PreareEditor()` returns `NS_OK`, but if the instance is deleted at returning from it, `GetTextEditor()` will access `mTextEditor`. Therefore, this patch makes `PrepareEditor()` return error if the instance is destroyed at its end. Differential Revision: https://phabricator.services.mozilla.com/D55775
974adaa889bdcb3b266cb6a38a5d4cefbaeecbac: Bug 1599971 - part 3: Mark `nsITextControlFrame::SetSelectionRange()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 03 Dec 2019 21:42:03 +0900 - rev 2514400
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1599971 - part 3: Mark `nsITextControlFrame::SetSelectionRange()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! Similar to the previous patch, it may notify selection listeners of native anonymous tree in `<input>` and `<textarea>` element. Differential Revision: https://phabricator.services.mozilla.com/D55774
a5472ee9c917b8d7a2460e6aec8c0618cf6c7d87: Bug 1599971 - part 2: Mark `TextControlState::DeleteOrCacheForReuse()` and `TextControlState::Reuse()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 12:32:00 +0900 - rev 2514399
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1599971 - part 2: Mark `TextControlState::DeleteOrCacheForReuse()` and `TextControlState::Reuse()` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! They are really complicated and can run script while the instance is being destroyed. Therefore, they should have their own `AutoTextControlHandlingState` as "kungFuDeathGrip". Differential Revision: https://phabricator.services.mozilla.com/D55773
adc33be8f955dfd479862ded6f7e44be6ec2f060: Bug 1599971 - part 1: Mark constructors of `AutoTextControlHandlingState` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Dec 2019 12:04:54 +0900 - rev 2514398
Push 459907 by masayuki@d-toybox.com at Wed, 04 Dec 2019 12:49:29 +0000
Bug 1599971 - part 1: Mark constructors of `AutoTextControlHandlingState` as `MOZ_CAN_RUN_SCRIPT` r=m_kato! The destructor of `AutoTextControlHandlingState`is marked as `MOZ_CAN_RUN_SCRIPT`, but it's not checked at build time. And this does not need to be created when the method does not run script. Therefore, we should mark its constructor as `MOZ_CAN_RUN_SCRIPT` instead since it's stack only class so that its constructor and destructor are always called from same method. Differential Revision: https://phabricator.services.mozilla.com/D55772
fa83d31a5d26688962cd72a0f39627073a9305c5: try_task_config for https://phabricator.services.mozilla.com/D54963 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 04 Dec 2019 12:47:14 +0000 - rev 2514397
Push 459906 by reviewbot at Wed, 04 Dec 2019 12:47:31 +0000
try_task_config for https://phabricator.services.mozilla.com/D54963 Differential Diff: PHID-DIFF-oxrguktah2wcrmvk6vqh
84d9fd852b4bff59816eaf897284aaffed417db5: Bug 1598164 - Fixed log messages, use serial number of transaction. r=#dom-workers-and-storage draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:47:10 +0000 - rev 2514396
Push 459906 by reviewbot at Wed, 04 Dec 2019 12:47:31 +0000
Bug 1598164 - Fixed log messages, use serial number of transaction. r=#dom-workers-and-storage Differential Revision: https://phabricator.services.mozilla.com/D54963 Differential Diff: PHID-DIFF-oxrguktah2wcrmvk6vqh
a96600d96be1e312fdf3c593dba110b339d95b12: try_task_config for https://phabricator.services.mozilla.com/D44682 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 04 Dec 2019 12:46:16 +0000 - rev 2514395
Push 459905 by reviewbot at Wed, 04 Dec 2019 12:46:37 +0000
try_task_config for https://phabricator.services.mozilla.com/D44682 Differential Diff: PHID-DIFF-sbq6fb53ppeb2cey73lw
239ac494bd999535ea0533423dc7ab559f1312a8: Bug 1577202 - Added test case from fuzzying. r=janv draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:46:10 +0000 - rev 2514394
Push 459905 by reviewbot at Wed, 04 Dec 2019 12:46:37 +0000
Bug 1577202 - Added test case from fuzzying. r=janv Differential Revision: https://phabricator.services.mozilla.com/D44682 Differential Diff: PHID-DIFF-sbq6fb53ppeb2cey73lw
18057afc752621c3431e722417657ecd4076cfa7: try_task_config for https://phabricator.services.mozilla.com/D44683 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 04 Dec 2019 12:46:07 +0000 - rev 2514393
Push 459904 by reviewbot at Wed, 04 Dec 2019 12:46:21 +0000
try_task_config for https://phabricator.services.mozilla.com/D44683 Differential Diff: PHID-DIFF-is7vzmb5jn2ggqbojdld
929b85763af4314ad853817585a57c32ed7c964d: Bug 1577202 - Defer closing of a database while CreateFileOp's are pending. r=janv draft
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Dec 2019 12:46:04 +0000 - rev 2514392
Push 459904 by reviewbot at Wed, 04 Dec 2019 12:46:21 +0000
Bug 1577202 - Defer closing of a database while CreateFileOp's are pending. r=janv Differential Revision: https://phabricator.services.mozilla.com/D44683 Differential Diff: PHID-DIFF-is7vzmb5jn2ggqbojdld
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip