c9fb177ad9aa85f9553cb6aad37264e4939d9592: Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:42 +0000 - rev 2998963
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer Summary: The WebRequest will suspend the channel in nsHttpChannel::PrepareToConnect(), apply the stream filter, send the main thread IPC and resume. That is, PHttpChannel::AttachStreamFilter should be handled in Child before OnStartRequest goes to listener. Differential Revision: https://phabricator.services.mozilla.com/D79770 Depends on D79587 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-fciirls7a22h7tyhm5by
293f9a17da8a5e5993f7eb60b463cc764f79092b: Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:38 +0000 - rev 2998962
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer Summary: Bug 1015466 move them from PContent to Pbg since it believes those events are fine to received before OnStopRequest. Bug 1588241 move it back to PContent since those events are before OnStartRequest. Now we're moving OnStartRequest to pBg, so here's another ping-pong time :) Differential Revision: https://phabricator.services.mozilla.com/D79587 Depends on D77752 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-j6pcnt4ynbbcvtbpomdp
2b95fbbdaadca63c0e734a86b4daa74dd278b34b: Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:35 +0000 - rev 2998961
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer Summary: Depends on D77751 Differential Revision: https://phabricator.services.mozilla.com/D77752 Depends on D77751 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-4u56tdnnldvvjwodjt2i
dd3e734749a00fab9da4b85d19f93fd92f8b2fa7: Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:31 +0000 - rev 2998960
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer Summary: Depends on D77750 Differential Revision: https://phabricator.services.mozilla.com/D77751 Depends on D77750 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-sonahimdmp63ct5nmbur
0f484f3f78b19c732e3dbac4da30c0ac35f6ddbc: Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:27 +0000 - rev 2998959
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer Summary: Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race. For the redirection flow in child process is: (1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here. (2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener. On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead. Resuming the eventQ to prevent leakage. Depends on D77749 Differential Revision: https://phabricator.services.mozilla.com/D77750 Depends on D77749 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-bulykxuv2zgjux47ukgx
a60fd00324415dd0f153d650170aa091228a3564: Bug 1633935 - P7 refactor bitmap test, r=jgilbert draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:24 +0000 - rev 2998958
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P7 refactor bitmap test, r=jgilbert Summary: Given options in createImageBitmap is not supported, the test coverage is the same. Depends on D76973 Differential Revision: https://phabricator.services.mozilla.com/D77749 Depends on D76973 Test Plan: Reviewers: jgilbert Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-wmertl6e46jbr3zgo7mu
3a70254b8ed4fa00a902b92839d07a1be7d198c3: Bug 1633935 - P6 Skip one media track failure caused by performance gain, r=alwu draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:19 +0000 - rev 2998957
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P6 Skip one media track failure caused by performance gain, r=alwu Summary: Depends on D76972 Differential Revision: https://phabricator.services.mozilla.com/D76973 Depends on D76972 Test Plan: Reviewers: alwu Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-zi35yzymr6pgsxvplckr
52f8a350f1483752b4de649ef211608e40fbf416: Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:16 +0000 - rev 2998956
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer Summary: Depends on D76971 Differential Revision: https://phabricator.services.mozilla.com/D76972 Depends on D76971 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-27g44fhxvbt5e3cpitcn
964725582d1cfaf06bfff73f0592885073b244a4: Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:12 +0000 - rev 2998955
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika Summary: We move OnStartRequest from PHttpChannel to PHttpBackgroundChannel, thus adjusting message-metadata.ini Depends on D76970 Differential Revision: https://phabricator.services.mozilla.com/D76971 Depends on D76970 Test Plan: Reviewers: mayhemer, nika Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-k3l4yfq2upszb66ol2ii
3b1ffddc8cac503c227e1c850a38898c17ed0e85: Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,mattwoodrow draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:09 +0000 - rev 2998954
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,mattwoodrow Summary: Depends on D76969 Differential Revision: https://phabricator.services.mozilla.com/D76970 Depends on D76969 Test Plan: Reviewers: mayhemer, mattwoodrow Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-eiywuu6toeu3uq6zkxny
5d5305f90d0ca8c0990f044a6b84f5aa803f4465: Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:05 +0000 - rev 2998953
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer Summary: Depends on D73529 Differential Revision: https://phabricator.services.mozilla.com/D76969 Depends on D73529 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-j2vhifhcfeayxerpiwb7
acc87db07aacee84a3c76d28da981002e8255433: Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:07:02 +0000 - rev 2998952
Push 558341 by reviewbot at Tue, 23 Jun 2020 17:08:03 +0000
Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer Summary: Differential Revision: https://phabricator.services.mozilla.com/D73529 Depends on D79772 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-c645az2pp2ewhn4qqzod
a4d2797fee7e1cb68ecb627413a4276c96d4a0af: try_task_config for https://phabricator.services.mozilla.com/D79587 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 17:06:23 +0000 - rev 2998951
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
try_task_config for https://phabricator.services.mozilla.com/D79587 Differential Diff: PHID-DIFF-j6pcnt4ynbbcvtbpomdp
a1500e02674c2fe252caa67d79c946773c396677: Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:19 +0000 - rev 2998950
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer Summary: Bug 1015466 move them from PContent to Pbg since it believes those events are fine to received before OnStopRequest. Bug 1588241 move it back to PContent since those events are before OnStartRequest. Now we're moving OnStartRequest to pBg, so here's another ping-pong time :) Differential Revision: https://phabricator.services.mozilla.com/D79587 Depends on D77752 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-j6pcnt4ynbbcvtbpomdp
abda439f8be8f1b189d58db371085b5cd6d394d0: Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:16 +0000 - rev 2998949
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer Summary: Depends on D77751 Differential Revision: https://phabricator.services.mozilla.com/D77752 Depends on D77751 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-4u56tdnnldvvjwodjt2i
0d6691439812f00a35b5926d53055bc21a0409c2: Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:13 +0000 - rev 2998948
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer Summary: Depends on D77750 Differential Revision: https://phabricator.services.mozilla.com/D77751 Depends on D77750 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-sonahimdmp63ct5nmbur
ef40d354fd367d63057f70636caaaf0a88bbb78f: Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:11 +0000 - rev 2998947
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer Summary: Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race. For the redirection flow in child process is: (1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here. (2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener. On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead. Resuming the eventQ to prevent leakage. Depends on D77749 Differential Revision: https://phabricator.services.mozilla.com/D77750 Depends on D77749 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-bulykxuv2zgjux47ukgx
69a47458ade8c38f5ad5af2d2b4483e82d91eca5: Bug 1633935 - P7 refactor bitmap test, r=jgilbert draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:07 +0000 - rev 2998946
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P7 refactor bitmap test, r=jgilbert Summary: Given options in createImageBitmap is not supported, the test coverage is the same. Depends on D76973 Differential Revision: https://phabricator.services.mozilla.com/D77749 Depends on D76973 Test Plan: Reviewers: jgilbert Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-wmertl6e46jbr3zgo7mu
f848179e0afcbb8689915f98cd0b5ebf0869d4d0: Bug 1633935 - P6 Skip one media track failure caused by performance gain, r=alwu draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:04 +0000 - rev 2998945
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P6 Skip one media track failure caused by performance gain, r=alwu Summary: Depends on D76972 Differential Revision: https://phabricator.services.mozilla.com/D76973 Depends on D76972 Test Plan: Reviewers: alwu Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-zi35yzymr6pgsxvplckr
5cb2a7fd45d7b80ae2afcd2f0b625d1994c0e074: Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer draft
Junior Hsu <juhsu@mozilla.com> - Tue, 23 Jun 2020 17:06:02 +0000 - rev 2998944
Push 558340 by reviewbot at Tue, 23 Jun 2020 17:06:46 +0000
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer Summary: Depends on D76971 Differential Revision: https://phabricator.services.mozilla.com/D76972 Depends on D76971 Test Plan: Reviewers: mayhemer Subscribers: Bug #: 1633935 Differential Diff: PHID-DIFF-27g44fhxvbt5e3cpitcn
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip