c9282b78fc063915867d61fd09d43c2851f9fd0e: Bug 1591132 - Make the checker's booleans relaxed. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:42:06 +0000 - rev 2396071
Push 439690 by reviewbot at Thu, 24 Oct 2019 16:42:25 +0000
Bug 1591132 - Make the checker's booleans relaxed. r=nika I'm pretty sure they can be relaxed, as they don't guard any other memory, and this should reduce their cost. Also remove useless mutable keywords while at it. The checker is marked as mutable itself. Differential Diff: PHID-DIFF-il2x5zxqybdzkgwkgan4
01599056406018f893caf9bd4aa59661bb3e93bb: Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:42:04 +0000 - rev 2396070
Push 439690 by reviewbot at Thu, 24 Oct 2019 16:42:25 +0000
Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika Put them behind a MOZ_HASH_TABLE_CHECKS_ENABLED define, which right now is only defined in DEBUG builds, preserving behavior. MakeImmutable becomes an empty inline function when disabled, which should be zero-cost. Differential Diff: PHID-DIFF-t4kzjdkwaejb7jlc6xns
b1df5fb7a3eff6921ba1bd50c543f33294336fbd: Bug 1591132 - Remove some useless ifdefs. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:42:01 +0000 - rev 2396069
Push 439690 by reviewbot at Thu, 24 Oct 2019 16:42:25 +0000
Bug 1591132 - Remove some useless ifdefs. r=nika Default constructors of members run if not specified there, and these ifdefs are ugly. Differential Diff: PHID-DIFF-nd3nuui6or5caj4thk6w
529b6e7fbb0925e80ef02273c642066927b7e568: Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:41:59 +0000 - rev 2396068
Push 439690 by reviewbot at Thu, 24 Oct 2019 16:42:25 +0000
Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika I want to maybe enable some of these checks in DIAGNOSTIC_ASSERT builds. The whole type is compiled out in release builds at the moment. Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
d070f1e10809a045c91f0132691b839ae5fd213e: try_task_config for https://phabricator.services.mozilla.com/D50492 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Thu, 24 Oct 2019 16:41:06 +0000 - rev 2396067
Push 439689 by reviewbot at Thu, 24 Oct 2019 16:41:19 +0000
try_task_config for https://phabricator.services.mozilla.com/D50492 Differential Diff: PHID-DIFF-nd3nuui6or5caj4thk6w
e557b0508303131b01d31be9020ddc3d13064fc9: Bug 1591132 - Remove some useless ifdefs. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:41:03 +0000 - rev 2396066
Push 439689 by reviewbot at Thu, 24 Oct 2019 16:41:19 +0000
Bug 1591132 - Remove some useless ifdefs. r=nika Default constructors of members run if not specified there, and these ifdefs are ugly. Differential Diff: PHID-DIFF-nd3nuui6or5caj4thk6w
bc2b048198df85e300b40034cb85b14936f86d89: Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:41:00 +0000 - rev 2396065
Push 439689 by reviewbot at Thu, 24 Oct 2019 16:41:19 +0000
Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika I want to maybe enable some of these checks in DIAGNOSTIC_ASSERT builds. The whole type is compiled out in release builds at the moment. Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
51f04c499b127aae4761ea0f9a4e1e89ea439e3a: try_task_config for https://phabricator.services.mozilla.com/D50494 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Thu, 24 Oct 2019 16:40:11 +0000 - rev 2396064
Push 439688 by reviewbot at Thu, 24 Oct 2019 16:40:25 +0000
try_task_config for https://phabricator.services.mozilla.com/D50494 Differential Diff: PHID-DIFF-il2x5zxqybdzkgwkgan4
d8fa2039f0248015bde9e0ddf3c4884d6631c601: Bug 1591132 - Make the checker's booleans relaxed. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:40:08 +0000 - rev 2396063
Push 439688 by reviewbot at Thu, 24 Oct 2019 16:40:25 +0000
Bug 1591132 - Make the checker's booleans relaxed. r=nika I'm pretty sure they can be relaxed, as they don't guard any other memory, and this should reduce their cost. Also remove useless mutable keywords while at it. The checker is marked as mutable itself. Differential Diff: PHID-DIFF-il2x5zxqybdzkgwkgan4
34fcd66c720a92677037d18cdbb9f569f55539e3: Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:40:06 +0000 - rev 2396062
Push 439688 by reviewbot at Thu, 24 Oct 2019 16:40:25 +0000
Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika Put them behind a MOZ_HASH_TABLE_CHECKS_ENABLED define, which right now is only defined in DEBUG builds, preserving behavior. MakeImmutable becomes an empty inline function when disabled, which should be zero-cost. Differential Diff: PHID-DIFF-t4kzjdkwaejb7jlc6xns
550848907a99045708c52718b1a31c921a1760bc: Bug 1591132 - Remove some useless ifdefs. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:40:04 +0000 - rev 2396061
Push 439688 by reviewbot at Thu, 24 Oct 2019 16:40:25 +0000
Bug 1591132 - Remove some useless ifdefs. r=nika Default constructors of members run if not specified there, and these ifdefs are ugly. Differential Diff: PHID-DIFF-nd3nuui6or5caj4thk6w
cd121b0142e78d79ef090d923c543aa73a10cb7c: Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:40:01 +0000 - rev 2396060
Push 439688 by reviewbot at Thu, 24 Oct 2019 16:40:25 +0000
Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika I want to maybe enable some of these checks in DIAGNOSTIC_ASSERT builds. The whole type is compiled out in release builds at the moment. Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
55d10b12661f306121b1cfcdd2da0168cfeaf6a1: try_task_config for https://phabricator.services.mozilla.com/D50493 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Thu, 24 Oct 2019 16:39:05 +0000 - rev 2396059
Push 439687 by reviewbot at Thu, 24 Oct 2019 16:39:19 +0000
try_task_config for https://phabricator.services.mozilla.com/D50493 Differential Diff: PHID-DIFF-t4kzjdkwaejb7jlc6xns
c13b62b13ce177ae0e959ec612617403b8144556: Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:39:02 +0000 - rev 2396058
Push 439687 by reviewbot at Thu, 24 Oct 2019 16:39:19 +0000
Bug 1591132 - Make it easy to switch on and off these assertions in different build configurations. r=nika Put them behind a MOZ_HASH_TABLE_CHECKS_ENABLED define, which right now is only defined in DEBUG builds, preserving behavior. MakeImmutable becomes an empty inline function when disabled, which should be zero-cost. Differential Diff: PHID-DIFF-t4kzjdkwaejb7jlc6xns
b7e538bcb2281aa8ae4e43c5abbfb826c728c44a: Bug 1591132 - Remove some useless ifdefs. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:39:00 +0000 - rev 2396057
Push 439687 by reviewbot at Thu, 24 Oct 2019 16:39:19 +0000
Bug 1591132 - Remove some useless ifdefs. r=nika Default constructors of members run if not specified there, and these ifdefs are ugly. Differential Diff: PHID-DIFF-nd3nuui6or5caj4thk6w
7a3ec68e4d0987616906f1371e4e6f68f7d55d4f: Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:38:57 +0000 - rev 2396056
Push 439687 by reviewbot at Thu, 24 Oct 2019 16:39:19 +0000
Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika I want to maybe enable some of these checks in DIAGNOSTIC_ASSERT builds. The whole type is compiled out in release builds at the moment. Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
b4b278b30e260c1031ea3b08334c8cddb8394e6f: try_task_config for https://phabricator.services.mozilla.com/D50491 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Thu, 24 Oct 2019 16:37:52 +0000 - rev 2396055
Push 439686 by reviewbot at Thu, 24 Oct 2019 16:38:09 +0000
try_task_config for https://phabricator.services.mozilla.com/D50491 Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
dd0c11e772407806900839149fa125d0bcf54c15: Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 24 Oct 2019 16:37:49 +0000 - rev 2396054
Push 439686 by reviewbot at Thu, 24 Oct 2019 16:38:09 +0000
Bug 1591132 - Make hashtable checker use MOZ_RELEASE_ASSERT. r=nika I want to maybe enable some of these checks in DIAGNOSTIC_ASSERT builds. The whole type is compiled out in release builds at the moment. Differential Diff: PHID-DIFF-bphwveahvqk6ofobz5wg
3886a89df95cec1ba87aa0ba43c24cf25e009b4d: try: none draft
Rob Lemley <rob@thunderbird.net> - Thu, 24 Oct 2019 12:30:14 -0400 - rev 2396053
Push 439685 by thunderbird@calypsoblue.org at Thu, 24 Oct 2019 16:31:30 +0000
try: none
4a8b2d4d0cde82f05cbfb7893a552d02c91d4c9e: merge cbc421450534 (default at 2019-10-24) to THUNDERBIRD_68_VERBRANCH. draft THUNDERBIRD_68_VERBRANCH
Rob Lemley <rob@thunderbird.net> - Thu, 24 Oct 2019 12:29:34 -0400 - rev 2396052
Push 439685 by thunderbird@calypsoblue.org at Thu, 24 Oct 2019 16:31:30 +0000
merge cbc421450534 (default at 2019-10-24) to THUNDERBIRD_68_VERBRANCH.
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip