c1d5364fa11f46cfd4e1412314937fe32fb61e5f: Try Chooser Enhanced (2119 tasks selected) draft
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Tue, 09 Nov 2021 15:35:51 -0500 - rev 4069598
Push 749460 by spohl@mozilla.com at Tue, 09 Nov 2021 20:36:39 +0000
Try Chooser Enhanced (2119 tasks selected) Pushed via `mach try chooser`
11505ae8c49923e8d9f88f5907c82d0294ac3124: Bug 1719427: Fix scrollbar tests. draft
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Mon, 08 Nov 2021 14:00:39 -0500 - rev 4069597
Push 749460 by spohl@mozilla.com at Tue, 09 Nov 2021 20:36:39 +0000
Bug 1719427: Fix scrollbar tests. Differential Revision: https://phabricator.services.mozilla.com/D130672
1d60a9ef9858d97ee84217238309d173e6084dae: Bug 1719427: Move scrollbar size information from prefs to C++ and allow sizing to be overridden via prefs. draft
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 04 Nov 2021 15:43:54 -0400 - rev 4069596
Push 749460 by spohl@mozilla.com at Tue, 09 Nov 2021 20:36:39 +0000
Bug 1719427: Move scrollbar size information from prefs to C++ and allow sizing to be overridden via prefs. Differential Revision: https://phabricator.services.mozilla.com/D130671
ac09dd971475260f6f675fbd61fe10671356a735: Bug 1719427: Add ability to switch between scrollbar implementations via prefs. draft
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Tue, 02 Nov 2021 15:54:30 -0400 - rev 4069595
Push 749460 by spohl@mozilla.com at Tue, 09 Nov 2021 20:36:39 +0000
Bug 1719427: Add ability to switch between scrollbar implementations via prefs. Differential Revision: https://phabricator.services.mozilla.com/D130215
e5005f1d9623819f3c9463e21869ed43361f07b0: Bug 1719427: Refactor scrollbar drawing code across platforms. draft
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Tue, 26 Oct 2021 16:26:22 -0400 - rev 4069594
Push 749460 by spohl@mozilla.com at Tue, 09 Nov 2021 20:36:39 +0000
Bug 1719427: Refactor scrollbar drawing code across platforms. Differential Revision: https://phabricator.services.mozilla.com/D129265
a2823e0100c130f391f99235d8deab17212d7567: try_task_config for https://phabricator.services.mozilla.com/D128753 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 09 Nov 2021 20:33:07 +0000 - rev 4069593
Push 749459 by reviewbot at Tue, 09 Nov 2021 20:33:35 +0000
try_task_config for https://phabricator.services.mozilla.com/D128753 Differential Diff: PHID-DIFF-wrazhe6b35zoib6jy6b2
aee3b2309c81497340cbd44b6047548f07450011: Bug 1699515 - Switching to react for Save to Pocket panels. draft
Scott <scott.downe@gmail.com> - Tue, 09 Nov 2021 20:33:01 +0000 - rev 4069592
Push 749459 by reviewbot at Tue, 09 Nov 2021 20:33:35 +0000
Bug 1699515 - Switching to react for Save to Pocket panels. Summary: Differential Revision: https://phabricator.services.mozilla.com/D128753 Test Plan: Reviewers: Subscribers: Bug #: 1699515 Differential Diff: PHID-DIFF-wrazhe6b35zoib6jy6b2
b3d74c09ecbfa6fb9d8e5a95391782fd02636e4f: try_task_config for https://phabricator.services.mozilla.com/D129553 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 09 Nov 2021 20:31:42 +0000 - rev 4069591
Push 749458 by reviewbot at Tue, 09 Nov 2021 20:31:58 +0000
try_task_config for https://phabricator.services.mozilla.com/D129553 Differential Diff: PHID-DIFF-joy7opgfqbmdcdkry5w4
5d946dfd55fc054246bcaf440659d939bf95a2cb: Bug 1737157 - Allow recording but not uploading in FOG tests r?janerik! draft
Chris H-C <chutten@mozilla.com> - Tue, 09 Nov 2021 20:31:39 +0000 - rev 4069590
Push 749458 by reviewbot at Tue, 09 Nov 2021 20:31:58 +0000
Bug 1737157 - Allow recording but not uploading in FOG tests r?janerik! Summary: See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences for details. Differential Revision: https://phabricator.services.mozilla.com/D129553 Test Plan: Reviewers: janerik! Subscribers: Bug #: 1737157 Differential Diff: PHID-DIFF-joy7opgfqbmdcdkry5w4
2f81ead03ff0cd57162e3a448d49caf4af1e1027: try_task_config for https://phabricator.services.mozilla.com/D129694 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 09 Nov 2021 20:27:40 +0000 - rev 4069589
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
try_task_config for https://phabricator.services.mozilla.com/D129694 Differential Diff: PHID-DIFF-morsoesyrtycr7ugjvjk
eb5a18b4a5d71e6eb885d87f1c89b594f30d1997: Bug 1730712: Group "system python" venv operations draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:35 +0000 - rev 4069588
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Group "system python" venv operations Summary: Define an interface to fetch details about the external Python environment. Moves environment-validation logic from `requirements.py` accordingly. Differential Revision: https://phabricator.services.mozilla.com/D129694 Depends on D129529 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-morsoesyrtycr7ugjvjk
a12a7dac6243dfd14021b6cfe7bed282e4cf860f: Bug 1730712: Split site manager into command and mach managers draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:33 +0000 - rev 4069587
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Split site manager into command and mach managers Summary: The command site manager needs to be able to do ad-hoc pip installations, while the Mach site manager needs to manage the system `sys.path` and conditionally create an on-disk virtualenv. By splitting the class into two, we can now give each use case the attention it deserves. Differential Revision: https://phabricator.services.mozilla.com/D129529 Depends on D129692 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-rxz5law7jmnjiff7itp3
3e008e293f2de79cc48a8d6cf97787dc1d4e59e9: Bug 1730712: Remove pip package check in site.up_to_date() draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:30 +0000 - rev 4069586
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Remove pip package check in site.up_to_date() Summary: Sorry for the flip-flop on technique here :S `validate_environment_packages()` was originally run when checking if a site is up-to-date to ensure that ad-hoc pip installs didn't replace needed packages with those of different versions. However, since it was added, a few notes have come up: 1. The case where requirements change isn't caught by this - that is caught earlier by the cheap "a requirements file has changed on-disk" check. 2. This is really slow, and doing it for most Mach commands is not worth it (as evident by how the `skip_pip_package_check` was already added for the Mach site's use case). 3. Since the tree as-is doesn't have (common) cases where ad-hoc installations break an environment, then this check, though helpful, isn't adding a significant amount of value considering its performance cost. However, these aren't to say that this won't be valuable in the future: I'd like to reach a point where sites are considered "sealed" by default: no ad-hoc pip installations are allowed. However, add the ability to mark sites as unsealed/"allowing ad-hoc pip installations". Then, re-add the pip package check, but only for such flexible, unsealed virtualenvs. Differential Revision: https://phabricator.services.mozilla.com/D129692 Depends on D129691 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-ewniw2wxgy2gqaqje42a
c7e8d7d40a3c87bea7204e4b852e452fec939a6a: Bug 1730712: Remove `metadata_path` parameter from `MozSiteManager` draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:27 +0000 - rev 4069585
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Remove `metadata_path` parameter from `MozSiteManager` Summary: IIRC, this was added prematurely for an upcoming test due to a faulty VCS commit split. Let's temporarily remove this parameter, then re-add it when needed for whatever test consumes it. Differential Revision: https://phabricator.services.mozilla.com/D129691 Depends on D129690 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-5s4r3n2flfwpu5tczjpk
7b641b182bf8fa08bf457331781727cfe1806ce7: Bug 1730712: Remove redundant `__PYVENV_LAUNCHER__` purge draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:24 +0000 - rev 4069584
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Remove redundant `__PYVENV_LAUNCHER__` purge Summary: As of bug 1686168, `__PYVENV_LAUNCHER__` is purged when Mach starts running. Since `MozSiteManager` is only used by Mach, its internal purging of the environment variable is redundant. Differential Revision: https://phabricator.services.mozilla.com/D129690 Depends on D129689 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-lfsbiucducsnkzowarwp
e6a934879337aae775c2c625792ef2cf5758d2c7: Bug 1730712: Remove unused `exe_info_path` from `VirtualenvManager` draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:21 +0000 - rev 4069583
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Remove unused `exe_info_path` from `VirtualenvManager` Summary: The information about the Python executable is now stored with other details in the JSON metadata file we put in each virtualenv. Differential Revision: https://phabricator.services.mozilla.com/D129689 Depends on D129688 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-vzihfkhrteq6eqd5eqvd
4645f175e7e2bdb0bd3e17f113435d4b5020e2b4: Bug 1730712: Ensure virtualenv up-to-date before activation draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:19 +0000 - rev 4069582
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Ensure virtualenv up-to-date before activation Summary: Rather than requiring that consumers remember to `ensure()` before calling `activate()`, we can do so automatically during activation. There isn't a valid use case in which we want obsolete virtualenvs to be activateable. Usages of `MozSiteManager` have been updated accordingly. Differential Revision: https://phabricator.services.mozilla.com/D129688 Depends on D129687 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-kg6x3yp6z7tv3nqra54p
23525274f7d939515c5f7d73558683132fcfd754: Bug 1730712: Inline virtualenv `create()` function draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:16 +0000 - rev 4069581
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Inline virtualenv `create()` function Summary: `create()` was only called from one place, and had more complex logic than necessary. Related to this change, `check=True` is used rather than asserting the return code. Differential Revision: https://phabricator.services.mozilla.com/D129687 Depends on D129686 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-cunrab4a3mzqj6tbaowo
44c240fd963533da17b898c5c820d967e4b4527d: Bug 1730712: Contain virtualenv metadata file management inside of class draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:13 +0000 - rev 4069580
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Contain virtualenv metadata file management inside of class Summary: `MozVirtualenvMetadata` only needs to know the virtualenv it's operating on - the knowledge of its internal metadata filename should not have to be exposed. Differential Revision: https://phabricator.services.mozilla.com/D129686 Depends on D129685 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-5ddawb2uzuq6q47w7zhw
1e4cc69f5e33528e3a42c849edb1dc01d17ea474: Bug 1730712: Split on-disk venv logic from `MozSiteManager` draft
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Nov 2021 20:27:10 +0000 - rev 4069579
Push 749457 by reviewbot at Tue, 09 Nov 2021 20:28:04 +0000
Bug 1730712: Split on-disk venv logic from `MozSiteManager` Summary: The current inheritance-based separation between "general venv details" (`VirtualenvHelper`) and moz site details (`MozSiteManager`) has caused `MozSiteManager` to care about too many details. This patch splits things apart a little more: * The term `VirtualenvHelper` isn't _super_ useful, rename it to `PythonVenv` to show that it represents a Python virtualenv. * Move on-disk virtualenv logic (`activate_path` location, `site-packages` location, `pip install` behaviour) into a contained `MozVirtualenv` class. * Port the inheritance to a "composition" model instead. Differential Revision: https://phabricator.services.mozilla.com/D129685 Depends on D130391 Test Plan: Reviewers: Subscribers: Bug #: 1730712 Differential Diff: PHID-DIFF-yx2lebhe2q7jevcee5vu
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip