bda9def26ee3d0808a87b5d0b9bdd035f3bd77b1: try: -b do -p linux,linux64 -t all -u all --rebuild-talos 10
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Aug 2018 11:43:43 +0900 - rev 1657107
Push 288902 by mh@glandium.org at Fri, 03 Aug 2018 05:56:22 +0000
try: -b do -p linux,linux64 -t all -u all --rebuild-talos 10
0eef9c2b81fd7636aa3ce2107e52d440a2d4de11: try: -b do -p linux,linux64 -t all -u all --rebuild-talos 10
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Aug 2018 11:43:43 +0900 - rev 1657106
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
try: -b do -p linux,linux64 -t all -u all --rebuild-talos 10
d9ac358783a8e1f7c7aea8d286f419f2829cbe3c: Bug 1451104 - follow-up - quiet clang-tidy content checking; r=me
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Jul 2018 17:16:25 -0400 - rev 1657105
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
Bug 1451104 - follow-up - quiet clang-tidy content checking; r=me
bf64a87e9089829c4160e9f8081f21315d6746d8: Bug 1451104 - part 4 - move toolchains off GCC 4.9; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Jul 2018 16:22:26 -0400 - rev 1657104
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
Bug 1451104 - part 4 - move toolchains off GCC 4.9; r=glandium Firefox itself has moved on to GCC 6.x; we can move our toolchains along too.
0b9576c31fdbc6f675d025e0d3b7640d8f6e9cef: Bug 1451104 - part 3 - inform stage2/3 clang about gcc binutils; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Jul 2018 16:22:26 -0400 - rev 1657103
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
Bug 1451104 - part 3 - inform stage2/3 clang about gcc binutils; r=glandium We do this to encourage clang to find an new-enough linker instead of the system one.
ae8abd488d49fd33fbeb60fa4768c3520a60915b: Bug 1451104 - part 2 - force clang to always pick up its local GCC headers and libraries; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Jul 2018 16:22:26 -0400 - rev 1657102
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
Bug 1451104 - part 2 - force clang to always pick up its local GCC headers and libraries; r=glandium We want our clang bootstrap to use the GCC headers we're building with, not whatever sysroot it happens to find on the server we're building on. The -gcc-toolchain argument we specify when building clang will also be picked up by llvm-config, so we need to strip it out when building the plugin. Otherwise, we will get peculiar failures about not being able to find C++ header files.
84d2717f14a328e9ecc450b19060e87fbd752bd4: Bug 1451104 - part 1 - be explicit about our GCC/binutils target and build machine; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Fri, 20 Jul 2018 16:22:26 -0400 - rev 1657101
Push 288901 by mh@glandium.org at Fri, 03 Aug 2018 05:52:12 +0000
Bug 1451104 - part 1 - be explicit about our GCC/binutils target and build machine; r=glandium Explicit is better than implicit, and helps ensure that GCC is always using the binutils we built it with, rather than the system binutils.
f1fb8389db974082c0cca9d0235b96b3dc577f2f: try: -b d -p all -u mochitests[x64] -t none
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 03 Aug 2018 14:29:05 +0900 - rev 1657100
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
try: -b d -p all -u mochitests[x64] -t none Pushed via `mach try syntax`
a1c0ff5318c74d895ede64af8e78c936c3d6ca38: Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 03 Aug 2018 14:28:23 +0900 - rev 1657099
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual r?m_kato HTMLEditor::IsModifiableNode() is enough simple and can be checked in EditorBase. So, we should make it non-virtual and check if instance is HTMLEditor in EditorBase::IsModifiableNode().
b4b639ddff0c1b6445672c697ab86663ea7b690f: Bug 1467373 - part 2: Skip hacks for most TIPs in TSFTextStore::HackNoErrorLayoutBugs() if running on Windows 10 build 17643 or newer r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 02 Aug 2018 14:55:52 +0900 - rev 1657098
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1467373 - part 2: Skip hacks for most TIPs in TSFTextStore::HackNoErrorLayoutBugs() if running on Windows 10 build 17643 or newer r?m_kato At Windows 10 build 17643, Microsoft fixed the bug of TSF which returns E_FAIL to TIP when GetTextExt() returns TS_E_NOLAYOUT. With this fix, most TIPs do not have any problems even if we return TS_E_NOLAYOUT. So, unless active TIP still needs the hack, the method can skip the hack if running on build 17643 or later. Note that we still need to support Japanist 10 and Microsoft Office IME 2010. It confirmed that Japanist 10 has a bug of handling TS_E_NOLAYOUT. On the other hand, we have not tested Microsoft Office IME 2010 since it's installable only into Win7 or Win8 and needs to upgrade it to Win10 for testing, but I do not have the license. After the fix comes into release channel, I'll be able to test it though (my main environment is Win10 and it was installed before upgraded). So, we need to be back after Microsoft releases the fix. MozReview-Commit-ID: 2BzkDvHTKyI
141a18d29c4837e9c5a503927bd255e1a249d946: Bug 1467373 - part 1: Split hack for TS_E_NOLAYOUT part from TSFTextStore::GetTextExt() r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 02 Aug 2018 14:36:03 +0900 - rev 1657097
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1467373 - part 1: Split hack for TS_E_NOLAYOUT part from TSFTextStore::GetTextExt() r?m_kato The block in TSFTextStore::GetTextExt() which decides whether we should return S_OK with unmodified character rectangle rather than TS_E_NOLAYOUT is too big. Additionally, we need to add new condition to check Windows 10's version there. That makes the large block more complicated. So, we should split the block off from TSFTextStore::GetTextExt(). Then, we can use early-return-style to reduce the deep indentations. MozReview-Commit-ID: J2BJMB1QD0T
41d1f5f0b43bc9265448e077e6e06dec82e8bea0: Bug 1480055 - part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 01 Aug 2018 21:30:14 +0900 - rev 1657096
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1480055 - part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer r?m_kato It's always created with non-nullptr. So, making it treat reference of EditorBase makes its implementation simpler. Note that this changes comment in EditorBase::InsertTextWithTransaction() to a MOZ_ASSERT() for detecting bugs. However, the comment is wrong. When the insertion is for updating composition string, callers don't need to create AutoTransactionsConserveSelection since it'll be ignored by CompositionTransaction. So, the new MOZ_ASSERT() checks whether it's in composition or prevented transaction changing Selection. MozReview-Commit-ID: 6jZ4LpksyoD
fd3cb731a11804af8719a68c020f924691722ef3: Bug 1480055 - part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 01 Aug 2018 21:11:44 +0900 - rev 1657095
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1480055 - part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection r?m_kato There is no non-virtual method to modify EditorBase::mAllowsTransactionsToChangeSelection. Therefore, AutoTransactionsConserveSelection calls virtual method, nsIEditor::SetShouldTxnSetSelection() twice (from both constructor and destructor). So, we should save this unnecessary cost. MozReview-Commit-ID: B7TYGnGtuLB
be5de232dafab30b2a30b19e8addd0c333133349: Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 01 Aug 2018 20:53:57 +0900 - rev 1657094
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r?m_kato For explaining what it does clearer, we should rename it and corresponding member. MozReview-Commit-ID: 6U8FgfHBbCL
5b8d000414192b3cd2caf271c990de6c5368a157: Bug 1480055 - part 1: Remove nsIEditor::shouldTxnSetSelection() r?m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 01 Aug 2018 20:16:30 +0900 - rev 1657093
Push 288900 by masayuki@d-toybox.com at Fri, 03 Aug 2018 05:29:23 +0000
Bug 1480055 - part 1: Remove nsIEditor::shouldTxnSetSelection() r?m_kato nsIEditor::ShouldTxnSetSelection() is used only by DeleteRangeTransaction (even if including comm-central and BlueGriffon) and there is a non-virtual method EditorBase::GetShouldTxnSetSelection(). So, we can remove this. MozReview-Commit-ID: JWSCw9k6lI0
3292ad0d67ebd91b8d397782963ceb5d2419da92: try: -b do -p linux64,linux64-pgo -u none -t damp-e10s --rebuild-talos 6 --artifact
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 03 Aug 2018 07:25:03 +0200 - rev 1657092
Push 288899 by nchevobbe@mozilla.com at Fri, 03 Aug 2018 05:25:27 +0000
try: -b do -p linux64,linux64-pgo -u none -t damp-e10s --rebuild-talos 6 --artifact Pushed via `mach try syntax`
ee3e9c44cc017a47f8d9dcc1c6ac2fa684002d76: try: -b do -p all -u all -t none
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Aug 2018 01:24:16 -0400 - rev 1657091
Push 288898 by bzbarsky@mozilla.com at Fri, 03 Aug 2018 05:24:29 +0000
try: -b do -p all -u all -t none Pushed via `mach try syntax`
7d865a9a1de8ea9f5b741f14108e6395e79e3eb0: [mq]: test_wrappers_fixage
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 03 Aug 2018 01:23:40 -0400 - rev 1657090
Push 288898 by bzbarsky@mozilla.com at Fri, 03 Aug 2018 05:24:29 +0000
[mq]: test_wrappers_fixage
8a7b42b524e67bde93eec09e95e603759af3af5d: try: -b do -p linux64,linux64-pgo -u none -t damp-e10s --rebuild-talos 6 --artifact
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 03 Aug 2018 07:23:23 +0200 - rev 1657089
Push 288897 by nchevobbe@mozilla.com at Fri, 03 Aug 2018 05:23:47 +0000
try: -b do -p linux64,linux64-pgo -u none -t damp-e10s --rebuild-talos 6 --artifact Pushed via `mach try syntax`
db4671e0ea9ca42068553943351bf313cbea9e13: rollback codeMirror jsterm
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 03 Aug 2018 07:23:03 +0200 - rev 1657088
Push 288897 by nchevobbe@mozilla.com at Fri, 03 Aug 2018 05:23:47 +0000
rollback codeMirror jsterm
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 +3000000 tip