b8d0a318ce6e34e7ae97bc768f920bf0d3b162e5: Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink draft
Jeff Walden <jwalden@mit.edu> - Tue, 26 Nov 2019 07:27:08 +0000 - rev 2497121
Push 455581 by reviewbot at Tue, 26 Nov 2019 07:27:41 +0000
Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D53921 Differential Diff: PHID-DIFF-7wip4ism52vg24mam3wi
f5a7c1cfdc16981deeb95a6edd4e89f3bc0c3744: try_task_config for https://phabricator.services.mozilla.com/D52461 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 26 Nov 2019 07:26:10 +0000 - rev 2497120
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
try_task_config for https://phabricator.services.mozilla.com/D52461 Differential Diff: PHID-DIFF-exhm2fb7nksqjaijog6c
a18aabe1db1a538d44450143f2db2e23d8b83321: Bug 1590907 - Make ENABLE_INTL_API and ENABLE_TYPED_OBJECTS into js-config macros. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:26:06 +0000 - rev 2497119
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Make ENABLE_INTL_API and ENABLE_TYPED_OBJECTS into js-config macros. r?sfink,jwalden Whether ENABLE_INTL_API and ENABLE_TYPED_OBJECTS are defined, affects the behaviour of JS_FOR_PROTOTYPES for the prototypes of Intl and TypedObject. Therefore, these macros have to be available to embedders. Rename them to JS_HAS_INTL_API and JS_HAS_TYPED_OBJECTS (in line with the existing JS_HAS_CTYPES) everywhere they are used, and add them to js-config.h.in. Differential Revision: https://phabricator.services.mozilla.com/D52461 Differential Diff: PHID-DIFF-exhm2fb7nksqjaijog6c
3f536a5145028aa2c498ceacfc64403276f40455: Bug 1590907 - Remove preprocessor dependence from size of ContextOptions. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:26:03 +0000 - rev 2497118
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Remove preprocessor dependence from size of ContextOptions. r?sfink,jwalden Previously, if SpiderMonkey embedders linked to a copy of libmozjs built with --enable-cranelift, --enable-wasm-gc, or --enable-fuzzing, then the size of the ContextOptions data structure declared in the header file would be different than the size of ContextOptions in the library, likely leading to crashes. This makes all members of ContextOptions independent of preprocessor macros. Any options not compiled into SpiderMonkey will still be no-ops. Differential Revision: https://phabricator.services.mozilla.com/D52460 Differential Diff: PHID-DIFF-gsv74fkpqg55kx5kuznv
2c8e33dc5be446814e75ab921b5b7e4bbfbd9c45: Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:26:01 +0000 - rev 2497117
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden These are configure macros that start with JS_ and have an effect on the public API declared in JSAPI header files, so they should be included in the installed js-config.h header file. Differential Revision: https://phabricator.services.mozilla.com/D52459 Differential Diff: PHID-DIFF-g7bkglh6kbzkxfefphpz
a0b2b369eb238db448e0593870f75b93b3b62dba: Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:25:59 +0000 - rev 2497116
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden If only relying on JS_64BIT to determine whether the system is 64-bits, then the result will be incorrect when the header is installed as a public header for use by embedders, and since JS_BITS_PER_WORD affects the layout of structs in header files, things will go badly wrong. This uses two other ways of determining pointer width, hopefully cross-platform enough. __SIZEOF_POINTER__ is a GCC-ism and probably works in Clang as well. UINTPTR_MAX is hopefully sufficiently cross-platform as a last resort. Differential Revision: https://phabricator.services.mozilla.com/D52458 Differential Diff: PHID-DIFF-32d5g3ztqiexqze63iw5
dbc581e8c3f343ee48cac84093d7431df7e622b3: Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:25:56 +0000 - rev 2497115
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink We should have the same public API available whenever possible, and make it a no-op or make it throw immediately if JS was built without support for it, instead of showing or hiding the API in header files using configure macros. Otherwise embedders can easily get mismatches between a library with functionality and header files without it, or vice versa. There was no good reason why JS_GetErrorType() was nightly-only API, so this also enables it unconditionally. Differential Revision: https://phabricator.services.mozilla.com/D52124 Differential Diff: PHID-DIFF-dd5aoxicw5kqwgjrqch5
68c334da18e753c211d209b858203e3e86c45179: Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink draft
Jeff Walden <jwalden@mit.edu> - Tue, 26 Nov 2019 07:25:54 +0000 - rev 2497114
Push 455580 by reviewbot at Tue, 26 Nov 2019 07:26:24 +0000
Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D53921 Differential Diff: PHID-DIFF-7wip4ism52vg24mam3wi
630e87a834e383e20b0cc07873157214b3c3d3ac: try_task_config for https://phabricator.services.mozilla.com/D52460 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 26 Nov 2019 07:24:58 +0000 - rev 2497113
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
try_task_config for https://phabricator.services.mozilla.com/D52460 Differential Diff: PHID-DIFF-gsv74fkpqg55kx5kuznv
f684702707329ced2948dcc8bd8959901d5243e6: Bug 1590907 - Remove preprocessor dependence from size of ContextOptions. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:24:54 +0000 - rev 2497112
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
Bug 1590907 - Remove preprocessor dependence from size of ContextOptions. r?sfink,jwalden Previously, if SpiderMonkey embedders linked to a copy of libmozjs built with --enable-cranelift, --enable-wasm-gc, or --enable-fuzzing, then the size of the ContextOptions data structure declared in the header file would be different than the size of ContextOptions in the library, likely leading to crashes. This makes all members of ContextOptions independent of preprocessor macros. Any options not compiled into SpiderMonkey will still be no-ops. Differential Revision: https://phabricator.services.mozilla.com/D52460 Differential Diff: PHID-DIFF-gsv74fkpqg55kx5kuznv
7720e5ab02a84c5a6a0738a88f3b15b8cc9e2c5c: Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:24:52 +0000 - rev 2497111
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden These are configure macros that start with JS_ and have an effect on the public API declared in JSAPI header files, so they should be included in the installed js-config.h header file. Differential Revision: https://phabricator.services.mozilla.com/D52459 Differential Diff: PHID-DIFF-g7bkglh6kbzkxfefphpz
8cf372bb462b0bbebd4d8c86e6877bd6bee90f7c: Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:24:49 +0000 - rev 2497110
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden If only relying on JS_64BIT to determine whether the system is 64-bits, then the result will be incorrect when the header is installed as a public header for use by embedders, and since JS_BITS_PER_WORD affects the layout of structs in header files, things will go badly wrong. This uses two other ways of determining pointer width, hopefully cross-platform enough. __SIZEOF_POINTER__ is a GCC-ism and probably works in Clang as well. UINTPTR_MAX is hopefully sufficiently cross-platform as a last resort. Differential Revision: https://phabricator.services.mozilla.com/D52458 Differential Diff: PHID-DIFF-32d5g3ztqiexqze63iw5
35caa5abeb224749a342e7cf53772f67bde49837: Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:24:47 +0000 - rev 2497109
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink We should have the same public API available whenever possible, and make it a no-op or make it throw immediately if JS was built without support for it, instead of showing or hiding the API in header files using configure macros. Otherwise embedders can easily get mismatches between a library with functionality and header files without it, or vice versa. There was no good reason why JS_GetErrorType() was nightly-only API, so this also enables it unconditionally. Differential Revision: https://phabricator.services.mozilla.com/D52124 Differential Diff: PHID-DIFF-dd5aoxicw5kqwgjrqch5
0445f308930c4699a7224bf0232eee284f71880e: Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink draft
Jeff Walden <jwalden@mit.edu> - Tue, 26 Nov 2019 07:24:44 +0000 - rev 2497108
Push 455579 by reviewbot at Tue, 26 Nov 2019 07:25:12 +0000
Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D53921 Differential Diff: PHID-DIFF-7wip4ism52vg24mam3wi
7e6327a888d940c9de19d2e2b7babdba115a46ff: try_task_config for https://phabricator.services.mozilla.com/D52459 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 26 Nov 2019 07:23:50 +0000 - rev 2497107
Push 455578 by reviewbot at Tue, 26 Nov 2019 07:24:04 +0000
try_task_config for https://phabricator.services.mozilla.com/D52459 Differential Diff: PHID-DIFF-g7bkglh6kbzkxfefphpz
ebfb144bf4aab2f2596fb2befcff2b41a55617a5: Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:23:47 +0000 - rev 2497106
Push 455578 by reviewbot at Tue, 26 Nov 2019 07:24:04 +0000
Bug 1590907 - Include JS_FOO macros that influence public API in js-config.h. r?sfink,jwalden These are configure macros that start with JS_ and have an effect on the public API declared in JSAPI header files, so they should be included in the installed js-config.h header file. Differential Revision: https://phabricator.services.mozilla.com/D52459 Differential Diff: PHID-DIFF-g7bkglh6kbzkxfefphpz
d662e5eb98c9c92754881bc1b04a51dcf4b3686f: Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:23:45 +0000 - rev 2497105
Push 455578 by reviewbot at Tue, 26 Nov 2019 07:24:04 +0000
Bug 1590907 - Determine 64-bit in public JS header without configure macro. r?jwalden If only relying on JS_64BIT to determine whether the system is 64-bits, then the result will be incorrect when the header is installed as a public header for use by embedders, and since JS_BITS_PER_WORD affects the layout of structs in header files, things will go badly wrong. This uses two other ways of determining pointer width, hopefully cross-platform enough. __SIZEOF_POINTER__ is a GCC-ism and probably works in Clang as well. UINTPTR_MAX is hopefully sufficiently cross-platform as a last resort. Differential Revision: https://phabricator.services.mozilla.com/D52458 Differential Diff: PHID-DIFF-32d5g3ztqiexqze63iw5
c5f980ff28de15a13aab3c69b05d2baa93cfbc9d: Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink draft
Philip Chimento <philip.chimento@gmail.com> - Tue, 26 Nov 2019 07:23:42 +0000 - rev 2497104
Push 455578 by reviewbot at Tue, 26 Nov 2019 07:24:04 +0000
Bug 1590907 - Stop configure macros from masking function prototypes in public JS headers. r?jwalden,sfink We should have the same public API available whenever possible, and make it a no-op or make it throw immediately if JS was built without support for it, instead of showing or hiding the API in header files using configure macros. Otherwise embedders can easily get mismatches between a library with functionality and header files without it, or vice versa. There was no good reason why JS_GetErrorType() was nightly-only API, so this also enables it unconditionally. Differential Revision: https://phabricator.services.mozilla.com/D52124 Differential Diff: PHID-DIFF-dd5aoxicw5kqwgjrqch5
f64f5642f50541093571c7ea140c0a8017bdf1e4: Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink draft
Jeff Walden <jwalden@mit.edu> - Tue, 26 Nov 2019 07:23:40 +0000 - rev 2497103
Push 455578 by reviewbot at Tue, 26 Nov 2019 07:24:04 +0000
Bug 1590907 - Use a static assert in HashTable that doesn't depend on configure. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D53921 Differential Diff: PHID-DIFF-7wip4ism52vg24mam3wi
daa8515881b9a06f9af3b8779545e54a1d5dd6aa: try_task_config for https://phabricator.services.mozilla.com/D52458 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 26 Nov 2019 07:22:48 +0000 - rev 2497102
Push 455577 by reviewbot at Tue, 26 Nov 2019 07:23:01 +0000
try_task_config for https://phabricator.services.mozilla.com/D52458 Differential Diff: PHID-DIFF-32d5g3ztqiexqze63iw5
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip