aff7327c82b0a7c21ee6099439b6d96222f97ace: Bug 1600362 - Cleanup IntersectionObserver. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Nov 2019 18:51:39 +0100 - rev 2506071
Push 457831 by emilio@crisal.io at Fri, 29 Nov 2019 20:50:34 +0000
Bug 1600362 - Cleanup IntersectionObserver. r=smaug Initially this was going to be a simple cleanup: Remove some useless namespaces here and there and so on, remove `using` statements from the header and so on. But unfortunately, DOMIntersectionObserver.h (which is included in Element.h, unnecessarily) ended up exposing `Element` unnamespaced to a lot of code, so I had to fix that. Differential Revision: https://phabricator.services.mozilla.com/D55316
5a88db4a770e7e7730ba833a9e7ff330e1d413b6: Fuzzy query=web-platform-tests !macosx !shippable&paths=testing/web-platform/tests/web-animations/timing-model/animations/sync-start-times.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-fast.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-slow.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-zero.html draft
moz-wptsync-bot <wptsync@mozilla.com> - Fri, 29 Nov 2019 20:49:22 +0000 - rev 2506070
Push 457830 by wptsync@mozilla.com at Fri, 29 Nov 2019 20:49:44 +0000
Fuzzy query=web-platform-tests !macosx !shippable&paths=testing/web-platform/tests/web-animations/timing-model/animations/sync-start-times.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-fast.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-slow.html:testing/web-platform/tests/web-animations/timing-model/animations/update-playback-rate-zero.html Pushed via `mach try fuzzy`
56aacdea568e5b02b06da2e512ce64f95b82f692: Bug 1600380 [wpt PR 20541] - Add ref tests for web-animation play controls, a=testonly draft
Kevin Ellis <kevers@chromium.org> - Fri, 29 Nov 2019 20:32:45 +0000 - rev 2506069
Push 457830 by wptsync@mozilla.com at Fri, 29 Nov 2019 20:49:44 +0000
Bug 1600380 [wpt PR 20541] - Add ref tests for web-animation play controls, a=testonly This patch adds ref tests for play controls and enables these tests to run as part of a virtual test suite with the compositor enabled. The tests are designed to catch regression that break animation play controls. Tests were added for syncing the compositor start time as well as updating the playback rate. The test for zero playback rate exposed a bug where it should have been disabled on the compositor but wasn't. This bug is also fixed in the patch. Bug: 1029123 Change-Id: I0304d80b93ef273dd2f1dbcd58e2371bc046941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943367 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#720190} wpt-commit: 44023c7e05eee2fe343308c04399bfa0a70776ab wpt-pr: 20541
ea4a93876d5ae6f8aa48b235a0de921397fcb333: Fix play controls for composited animations. (#20492) draft
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> - Fri, 29 Nov 2019 20:32:42 +0000 - rev 2506068
Push 457830 by wptsync@mozilla.com at Fri, 29 Nov 2019 20:49:44 +0000
Fix play controls for composited animations. (#20492) Play controls recently broke for composited animations due to timing differences on when variables are changes. Per spec, the start time is not cleared when pausing an animation until after the animation is ready. This discrepancy lead to a case when PreCommit would not get called when pausing a composited animation. Reverse and updatePlaybackRate were also broken for composited animations. We cannot composite infinite duration animations in the reverse direction. We were using playback rate instead of EffectivePlaybackRate in one of our checks for compositor eligibility, and falling to catch this case. Finally, with changes to when start time is cleared, we can be in a case where it is important to preserve the start time or the current time when starting a composited animation. Fortunately, we can determine when start time is the important factor based in whether the animation is pending. Next step: Add WPT tests that would have caught the regressions. Filed as issue 1029123. Bug: 1028985, 1028986 Change-Id: I4edf851790a860d20962df84944558e7dbc1863a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940885 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720042} wpt-commit: dfcdaf109407d4b8db06e8fbf37b2a0cb80f251f wpt-type: dependency
a69627a0620d206dec8d6b685b03110ef470250e: Fuzzy query='spidermonkey | 'shell-haz&query=!shippable !android 'jittest draft
Iain Ireland <iireland@mozilla.com> - Fri, 29 Nov 2019 15:45:41 -0500 - rev 2506067
Push 457829 by iireland@mozilla.com at Fri, 29 Nov 2019 20:46:14 +0000
Fuzzy query='spidermonkey | 'shell-haz&query=!shippable !android 'jittest Pushed via `mach try fuzzy`
514c0a45038e7add1c6f0197c78d9bbfbb653762: Bug 1592302: Part 3: Update #includes in new regexp files r=mgaudet draft
Iain Ireland <iireland@mozilla.com> - Wed, 30 Oct 2019 12:01:23 -0400 - rev 2506066
Push 457829 by iireland@mozilla.com at Fri, 29 Nov 2019 20:46:14 +0000
Bug 1592302: Part 3: Update #includes in new regexp files r=mgaudet This patch adds a python script to update #includes from V8 to SM, and runs the script over each of the V8 source files. This automates 90%+ of the changes that are necessary to prepare V8 source for inclusion in SM. The remaining changes will come in a subsequent patch. Almost all of those changes simply involve adding a shim #include in the right place. Differential Revision: https://phabricator.services.mozilla.com/D51930
88e5624827e051f1f20afdbd6e5a8b9cd28842ba: Refactor build draft
Iain Ireland <iireland@mozilla.com> - Fri, 29 Nov 2019 15:07:26 -0500 - rev 2506065
Push 457829 by iireland@mozilla.com at Fri, 29 Nov 2019 20:46:14 +0000
Refactor build
d3c75a0ec1f562384983128c52c775a3b497dd67: Fuzzy query=^system-symbol draft
Tom Prince <mozilla@hocat.ca> - Fri, 29 Nov 2019 13:41:35 -0700 - rev 2506064
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Fuzzy query=^system-symbol Pushed via `mach try fuzzy`
53366cdc2a177e3272856717ef56c1fbf10709cf: Bug 1596775: Add tasks to upload symbols to server; r?glandium,marco draft
Tom Prince <mozilla@hocat.ca> - Fri, 29 Nov 2019 13:23:08 -0700 - rev 2506063
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Add tasks to upload symbols to server; r?glandium,marco
70d422b57679a2e2199b68f8ef11c2d0a06beb1f: Bug 1596775: Add some error handling; r?glandium,marco draft
Tom Prince <mozilla@hocat.ca> - Fri, 29 Nov 2019 13:05:53 -0700 - rev 2506062
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Add some error handling; r?glandium,marco
1b68392e0c7acf2c8c0e8deef93d7b855967a818: Bug 1596775: Update liscense headers; r?glandium draft
Tom Prince <mozilla@hocat.ca> - Thu, 28 Nov 2019 13:31:25 -0700 - rev 2506061
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Update liscense headers; r?glandium
142420a3fd5779fd780aaa224f72e981a82c0914: Bug 1596775: Cleanup shellcheck errors on imported code; r?glandium draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 16:45:59 -0700 - rev 2506060
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Cleanup shellcheck errors on imported code; r?glandium
41600ec51b1c77c6c74751488af785070aa29add: Bug 1596775: Cleanup flake8 errors in system-symbol code; r?glandium draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 16:13:49 -0700 - rev 2506059
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Cleanup flake8 errors in system-symbol code; r?glandium
47161e63eb8ab2e029be0ce7032769d5fba58d11: Bug 1596775: Run black on imported code; r?glandium draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 14:10:41 -0700 - rev 2506058
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Run black on imported code; r?glandium
f2f49efca881629b8e601bc95c2ec0e7fffe3042: Bug 1596775: Add tasks from extraction system symbols; r?glandium,marco draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 13:58:56 -0700 - rev 2506057
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Add tasks from extraction system symbols; r?glandium,marco
d0c645e209e4c5868806192be5fd860b8b2afc4f: Bug 1596775: Import scripts for uploading windows system symbols; r?glandium,marco draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 13:13:15 -0700 - rev 2506056
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Import scripts for uploading windows system symbols; r?glandium,marco This imports the code from https://github.com/marco-c/breakpad-win-update-symbols
d6ddef64b556d337d97bd432a46e1b23859dc064: Bug 1596775: Import scripts for downloading macOS system symbols; r?glandium,marco draft
Tom Prince <mozilla@hocat.ca> - Wed, 27 Nov 2019 12:27:14 -0700 - rev 2506055
Push 457828 by mozilla@hocat.ca at Fri, 29 Nov 2019 20:41:49 +0000
Bug 1596775: Import scripts for downloading macOS system symbols; r?glandium,marco Import the code from https://github.com/marco-c/breakpad-mac-update-symbols/ and https://github.com/marco-c/breakpad-scrape-system-symbols
4b36bcbc3d1c9fbfeb6a858e3c2a3cdd902f88f1: try_task_config for https://phabricator.services.mozilla.com/D55320 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Fri, 29 Nov 2019 20:36:54 +0000 - rev 2506054
Push 457827 by reviewbot at Fri, 29 Nov 2019 20:37:12 +0000
try_task_config for https://phabricator.services.mozilla.com/D55320 Differential Diff: PHID-DIFF-lxblxmt5je44ohq7w56r
e6fbd734f171c7ba5205836f109b03feb0b6b923: Bug 1599612 - Various dom/presentation code is infallible. r=kershaw draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Nov 2019 20:36:49 +0000 - rev 2506053
Push 457827 by reviewbot at Fri, 29 Nov 2019 20:37:12 +0000
Bug 1599612 - Various dom/presentation code is infallible. r=kershaw Summary: More could be cleaned up still, but this code seems disabled. Test Plan: Reviewers: kershaw Subscribers: Bug #: 1599612 Differential Diff: PHID-DIFF-lxblxmt5je44ohq7w56r
34e6cd8c1c3cdf76f864345ca25f5e3f4f1a11a1: Try Chooser Enhanced (1238 tasks selected) draft
Tim Huang <tihuang@mozilla.com> - Fri, 29 Nov 2019 21:34:29 +0100 - rev 2506052
Push 457826 by tihuang@mozilla.com at Fri, 29 Nov 2019 20:35:25 +0000
Try Chooser Enhanced (1238 tasks selected) Pushed via `mach try chooser`
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip