a7b18e819c5977d9a7ea2905fc6c49fde16e528c: try_task_config for https://phabricator.services.mozilla.com/D80740 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 01:19:27 +0000 - rev 3000263
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
try_task_config for https://phabricator.services.mozilla.com/D80740 Differential Diff: PHID-DIFF-q3kbjvsvnqbiloxfm5b2
e10b7920c24ef5ada29c9a2ec07dd941074cf3e1: Bug 1647342 - Part 7: Remove unnecessary special-casing of OOM in replaceFrameGuts. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:21 +0000 - rev 3000262
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 7: Remove unnecessary special-casing of OOM in replaceFrameGuts. r=arai! Summary: This patch waits to remove the frame from the "from" map until after it has been added to the "to" map, so that we can rely on the existing scope guard to clean up any frames if we get an OOM. Differential Revision: https://phabricator.services.mozilla.com/D80740 Depends on D80739 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-q3kbjvsvnqbiloxfm5b2
96729fe2291f9c00afd963b062a8915a97e82da0: Bug 1647342 - Part 6: Simplfy code in onResumeFrame. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:17 +0000 - rev 3000261
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 6: Simplfy code in onResumeFrame. r=arai! Summary: There's no reason to create this FrameIter over and over again inside the loop. Similarly, ensureExecutionObservabilityOfFrame is a no-op if "frame.isDebuggee()", and slowPathOnResumeFrame asserts that to be true, so there is no reason to ensure observability here because it already is guaranteed. Differential Revision: https://phabricator.services.mozilla.com/D80739 Depends on D80738 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-vtmty3jilj4hdtecpioc
5fdc2684d4f7a784abb426a742cb6140ddec42b3: Bug 1647342 - Part 5: Move management of the generatorFrames collection. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:13 +0000 - rev 3000260
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 5: Move management of the generatorFrames collection. r=arai! Summary: It is difficult to follow the overall lifecycle of entries in the generatorFrames list when it is mutated in many places across many files. This patch's primary aim is to begin centralizing the handling of this map a little bit by keeping it all inside Debugger.cpp so that the DebuggerFrame instance itself does not actually care whether it is found in that map. Differential Revision: https://phabricator.services.mozilla.com/D80738 Depends on D80737 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-4mkpmb6bbdnaebxdfjm3
68110a3092dee619e8d3f6611c565689eae90f08: Bug 1647342 - Part 4: Convert forEachDebuggerFrame helper to expose Debugger*. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:09 +0000 - rev 3000259
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 4: Convert forEachDebuggerFrame helper to expose Debugger*. r=arai! Summary: This is just a tiny refactor to avoid needing to then get the Debugger* from the frame when we already know it. Differential Revision: https://phabricator.services.mozilla.com/D80737 Depends on D80736 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-a6x6lzo4hgfkgtlxayka
14d04a195998479167d31e5585661e81b7979626: Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:05 +0000 - rev 3000258
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! Summary: I have no idea how long this has been stale. Differential Revision: https://phabricator.services.mozilla.com/D80736 Depends on D80735 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-5mb2ccxp5m5n24dvyva3
9de51160e2f18712f890499d4d192e6ef93ebdfa: Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:19:00 +0000 - rev 3000257
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! Summary: It is guaranteed that this will already be populated because in 1539654 we started properly preserving the debuggee-ness of frames across suspend and resume. With slowPathOnResumeFrame guaranteed to run, we no longer need to try to hande handle the case where the generator has been resumed, but the Debugger.Frame's inner data was not populated. Differential Revision: https://phabricator.services.mozilla.com/D80735 Depends on D80734 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-zb7v2adok4h6dtiv25lb
8ba8dd50b33e688f2123c98e6f3cdbb02c772325: Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:18:57 +0000 - rev 3000256
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! Summary: Exposing frameIterData() and setFrameIterData() isn't great since it makes it harder to follow what state transitions for frame data we expect the frame to have. By hiding this, it helps clarify that frame data can be cleared or replaced, but public usage of the FrameIter::Data object itself isn't expected outside of the class itself. Differential Revision: https://phabricator.services.mozilla.com/D80734 Depends on D80762 Test Plan: Reviewers: arai! Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-dhmfmqn66xpowicdvjn7
96afc21053ff0e30c53c1c042aac69f7d7ba1a4c: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Wed, 24 Jun 2020 01:18:53 +0000 - rev 3000255
Push 558658 by reviewbot at Wed, 24 Jun 2020 01:19:51 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: arai! Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-fh4vivxlaoteqp2ezgnf
bb059ebb3e19963a5472db1acbe2ed4996a263d3: Tasks automatically selected. draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 24 Jun 2020 10:17:59 +0900 - rev 3000254
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Tasks automatically selected. Pushed via `mach try auto`
6de43392a6da3e7799c161d0c62de2651e958f29: Bug 1324591 - Disable partial pre-render for frames in position:sticky subtree. r?botond draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 02 Jun 2020 14:19:26 +0900 - rev 3000253
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Disable partial pre-render for frames in position:sticky subtree. r?botond Differential Revision: https://phabricator.services.mozilla.com/D77774
5ef4f7b10ed87dd765a42f79946817c91c3c9f73: Bug 1324591 - Report janked animations to the main-thread and update them on the main-thread. r?botond!,boris! draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:21 +0900 - rev 3000252
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Report janked animations to the main-thread and update them on the main-thread. r?botond!,boris! The machinery to report janked animations is; 1) Store the partial pre-rendered animation id and the Animation object in a hashtable in LayerManager 2) Store the animation id in the Animation object as well 3) When we detect jank, we send the animation id to the main-thread via an IPC call 4) Find the Animation object with the id in the hashtable and update the Animaiton 5) Whenever the partial pre-rendered Animation stop running on the compositor i.e. the Animation finished normally, the Animation's target element is changed, etc. etc., remove the Animation from the hashtable Differential Revision: https://phabricator.services.mozilla.com/D75732
9deb1a97e28eb09c4f7296162309a362bfd9c1b6: Bug 1324591 - Jank if we are trying to composite area which is outside of the the partial prerender rect on non WebRender. r?botond draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:21 +0900 - rev 3000251
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Jank if we are trying to composite area which is outside of the the partial prerender rect on non WebRender. r?botond Differential Revision: https://phabricator.services.mozilla.com/D75731
4411031d6244491ccf3515a543f0296d28f510ee: Bug 1324591 - Inform the partial prerender rect and the overflowed SideBits to the compositor. r?botond draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:20 +0900 - rev 3000250
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Inform the partial prerender rect and the overflowed SideBits to the compositor. r?botond nsDisplayTransform doesn't have enough room to store the partial prerender rect and the overflowed SideBits unfortunately (it will exceed 512 bytes limit [1]). So we get the partial prerender rect and calculate the overflowed SideBits just before we send transform animation information to the compositor. [1] https://searchfox.org/mozilla-central/rev/fa52bedc4b401c12251513fa1c9df1753a29abb2/layout/painting/nsDisplayList.cpp#7318 Differential Revision: https://phabricator.services.mozilla.com/D75730
b1593da16002b7d021c51c0c94cd5cd90cfd38d4: Bug 1324591 - Store PrerenderDecision in nsDisplayTransform. r?botond draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:20 +0900 - rev 3000249
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Store PrerenderDecision in nsDisplayTransform. r?botond Differential Revision: https://phabricator.services.mozilla.com/D75729
d5f413ef9294e1a9d252deb485c0526841e3f640: Bug 1324591 - Store the corresponding LayersId for each animation on the compositor. r?kats draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:20 +0900 - rev 3000248
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - Store the corresponding LayersId for each animation on the compositor. r?kats Differential Revision: https://phabricator.services.mozilla.com/D75728
1565ea4eacd1867e2ffeb6702d4b35f73ecfdecd: Bug 1324591 - A simple mochitest to make sure partial pre-rendered transform animations run on the compositor. r?boris draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Mon, 18 May 2020 09:27:20 +0900 - rev 3000247
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1324591 - A simple mochitest to make sure partial pre-rendered transform animations run on the compositor. r?boris We just need this regardless of whether there appears checkerboarding or jank. Differential Revision: https://phabricator.services.mozilla.com/D75727
5b7326ebe8431a6ea2608971181251745467b49a: Bug 1646629 - Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r?mattwoodrow,tnikkel draft
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 18 Jun 2020 18:05:49 +0900 - rev 3000246
Push 558657 by hikezoe.birchill@mozilla.com at Wed, 24 Jun 2020 01:19:11 +0000
Bug 1646629 - Set updateCanvasPending explicitly when reftest-wait was removed and take a snapshot of the whole screen if reftest-no-flush is specified. r?mattwoodrow,tnikkel That's because we no longer fire MozAfterPaint event for changes by animations on the compositor. Differential Revision: https://phabricator.services.mozilla.com/D80157
26152ebbf3ebd6727c1eab98d319d4c9fc289c60: try: -b o -p linux64-valgrind -t none -u none draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Jun 2020 09:35:35 +0900 - rev 3000245
Push 558656 by mh@glandium.org at Wed, 24 Jun 2020 01:18:57 +0000
try: -b o -p linux64-valgrind -t none -u none
06c2d5bcf77a4041d356e3beea03561983c3b617: try_task_config for https://phabricator.services.mozilla.com/D80739 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 01:18:07 +0000 - rev 3000244
Push 558655 by reviewbot at Wed, 24 Jun 2020 01:18:26 +0000
try_task_config for https://phabricator.services.mozilla.com/D80739 Differential Diff: PHID-DIFF-vtmty3jilj4hdtecpioc
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip