9216035b9972b7b56a7004e49cc0fbb1a99a5e79: Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 29 Dec 2021 10:13:30 +1100 - rev 4180265
Push 771633 by gsquelart@mozilla.com at Fri, 21 Jan 2022 06:46:59 +0000
Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian Add `ProgressLogger` parameter to most JSON-generating functions. Each function can update the given `ProgressLogger` between 0% and 100%, and create sub-loggers when calling functions. The main goal of this instrumentation is to notice when any progress is made by child processes (when the parent process is gathering profiles), so it needs to go deep enough so that it is not stuck on a progress value for "too long" -- During development, that meant progress was always happening when observed every 10ms; In later patches, the overall timeout for no-progress-made will be at least 1 second. Differential Revision: https://phabricator.services.mozilla.com/D135479
c4db255ef703a4d0abbe7a3ea0c154a18d15600c: Bug 1673513 - ProgressLogger - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Dec 2021 20:43:08 +1100 - rev 4180264
Push 771633 by gsquelart@mozilla.com at Fri, 21 Jan 2022 06:46:59 +0000
Bug 1673513 - ProgressLogger - r?florian Class used to log the progress of long operations, and simplifying the use through nested function calls and loops. Differential Revision: https://phabricator.services.mozilla.com/D135478
3e8f704bd932515b7d935f22ce65f87db5715e27: Bug 1673513 - ProportionValue - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Dec 2021 20:42:39 +1100 - rev 4180263
Push 771633 by gsquelart@mozilla.com at Fri, 21 Jan 2022 06:46:59 +0000
Bug 1673513 - ProportionValue - r?florian Class storing a value between 0 and 1, effectively 0% to 100%. It will be used through a ProgressLogger object to track the progress of JSON profile generation (see following patches). Differential Revision: https://phabricator.services.mozilla.com/D135477
beb9a8fb85e4684795943b1a7f1576b09a1ea723: Fuzzy query=linuxshippa&paths=devtools/client/storage/test/browser_storage_cookies_navigation.js draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 21 Jan 2022 07:43:49 +0100 - rev 4180262
Push 771632 by nchevobbe@mozilla.com at Fri, 21 Jan 2022 06:46:03 +0000
Fuzzy query=linuxshippa&paths=devtools/client/storage/test/browser_storage_cookies_navigation.js Pushed via `mach try fuzzy`
53f27ed7649d3cc015df64a227695f2eaaa0b120: Bug 1747410 - [devtools] Fix intermittent in browser_storage_cookies_navigation.js . r=jdescottes. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 21 Jan 2022 07:39:38 +0100 - rev 4180261
Push 771632 by nchevobbe@mozilla.com at Fri, 21 Jan 2022 06:46:03 +0000
Bug 1747410 - [devtools] Fix intermittent in browser_storage_cookies_navigation.js . r=jdescottes. The test was failing because the toolbox was handling a new target during toolbox destruction. To fix this, we wait for the target data to be displayed in the storage inspector.
bb753d80d60933f04553cae848ca63728764a655: try_task_config for https://phabricator.services.mozilla.com/D135483 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Fri, 21 Jan 2022 06:44:44 +0000 - rev 4180260
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
try_task_config for https://phabricator.services.mozilla.com/D135483 Differential Diff: PHID-DIFF-pobe4n5tj44uxemq5k5a
8b7f8920959719ff516da2e2ff86a968d369fa01: Bug 1673513 - profiler_get_profile_json(SpliceableChunkedJSONWriter&, ...) - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:40 +0000 - rev 4180259
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - profiler_get_profile_json(SpliceableChunkedJSONWriter&, ...) - r?florian Summary: The main goal is to separate the profile generation (in a JSONWriter) from the final allocation needed to output the profile in one block. This will be needed in the next patch, where the profile generation will be done in a new worker thread, but the shmem allocation *must* be done on the original "ProfilerChild" thread that handles IPC responses. Differential Revision: https://phabricator.services.mozilla.com/D135483 Depends on D135482 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-pobe4n5tj44uxemq5k5a
5d00f2f622888288ee1bb89352b894b36ac974bc: Bug 1673513 - Maintain list of pending profiles, each with child pid - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:36 +0000 - rev 4180258
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - Maintain list of pending profiles, each with child pid - r?florian Summary: Instead of just waiting for a certain number of profiles, the parent process now waits for profiles from a predetermined list of child process ids. When receiving a profile, or when something goes wrong with a child process, the corresponding listed id can be removed, until the list is empty. In a later patch, this list will be used to request progress updates from slow processes. Differential Revision: https://phabricator.services.mozilla.com/D135482 Depends on D135481 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-grxugf6u4qj3vv4qq2zf
887dc629c6bb73fe45eefd95979f60f004099760: Bug 1673513 - ProfilerParent::GatherProfiles() also returns the child pid - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:33 +0000 - rev 4180257
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - ProfilerParent::GatherProfiles() also returns the child pid - r?florian Summary: This will be useful to tie profiles to the child process id that generated them. (At the moment, the parent waits for a number of profiles, but doesn't check where received profiles actually come from.) Differential Revision: https://phabricator.services.mozilla.com/D135481 Depends on D135480 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-4lvdv4m55jgde4hyei3v
c98eece99e5ee8a49d99d09ed4bbd5cac0e5cde2: Bug 1673513 - Reserve the array space in advance in ProfilerParent::GatherProfiles - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:29 +0000 - rev 4180256
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - Reserve the array space in advance in ProfilerParent::GatherProfiles - r?florian Summary: A small optimization while working on nearby code, so avoid multiple allocations when we already know how much memory we really need. Differential Revision: https://phabricator.services.mozilla.com/D135480 Depends on D135479 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-vepb4gkxkdfsay4eog7k
399ebe515ab8c7d6bdb0a1feaab105940149bb94: Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:26 +0000 - rev 4180255
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian Summary: Add `ProgressLogger` parameter to most JSON-generating functions. Each function can update the given `ProgressLogger` between 0% and 100%, and create sub-loggers when calling functions. The main goal of this instrumentation is to notice when any progress is made by child processes (when the parent process is gathering profiles), so it needs to go deep enough so that it is not stuck on a progress value for "too long" -- During development, that meant progress was always happening when observed every 10ms; In later patches, the overall timeout for no-progress-made will be at least 1 second. Differential Revision: https://phabricator.services.mozilla.com/D135479 Depends on D135478 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-grcjfjshalt76o6zwaky
82eb009b10006ed415b565fe01633dc4b6e44394: Bug 1673513 - ProgressLogger - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:23 +0000 - rev 4180254
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - ProgressLogger - r?florian Summary: Class used to log the progress of long operations, and simplifying the use through nested function calls and loops. Differential Revision: https://phabricator.services.mozilla.com/D135478 Depends on D135477 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-rtm2vx7a4q55277ybl5k
f85ac966434b41fa15b0794bd243f7c0cc5e69c3: Bug 1673513 - ProportionValue - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:44:19 +0000 - rev 4180253
Push 771631 by reviewbot at Fri, 21 Jan 2022 06:45:07 +0000
Bug 1673513 - ProportionValue - r?florian Summary: Class storing a value between 0 and 1, effectively 0% to 100%. It will be used through a ProgressLogger object to track the progress of JSON profile generation (see following patches). Differential Revision: https://phabricator.services.mozilla.com/D135477 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-jk3uaiae5vprflnpuv64
02e91d7c3f9f543d1f330b7b8aa29cbfca32e98f: try_task_config for https://phabricator.services.mozilla.com/D135481 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Fri, 21 Jan 2022 06:43:35 +0000 - rev 4180252
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
try_task_config for https://phabricator.services.mozilla.com/D135481 Differential Diff: PHID-DIFF-4lvdv4m55jgde4hyei3v
06e56b1db1c7020b4e6dbf2191a9f57e84187a04: Bug 1673513 - ProfilerParent::GatherProfiles() also returns the child pid - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:43:30 +0000 - rev 4180251
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
Bug 1673513 - ProfilerParent::GatherProfiles() also returns the child pid - r?florian Summary: This will be useful to tie profiles to the child process id that generated them. (At the moment, the parent waits for a number of profiles, but doesn't check where received profiles actually come from.) Differential Revision: https://phabricator.services.mozilla.com/D135481 Depends on D135480 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-4lvdv4m55jgde4hyei3v
65ec3dcaeb6a95f76a9e167fbec8945919de2972: Bug 1673513 - Reserve the array space in advance in ProfilerParent::GatherProfiles - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:43:27 +0000 - rev 4180250
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
Bug 1673513 - Reserve the array space in advance in ProfilerParent::GatherProfiles - r?florian Summary: A small optimization while working on nearby code, so avoid multiple allocations when we already know how much memory we really need. Differential Revision: https://phabricator.services.mozilla.com/D135480 Depends on D135479 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-vepb4gkxkdfsay4eog7k
f6d611144bc8e3ea6e4acbe28152a1560d02596f: Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:43:23 +0000 - rev 4180249
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
Bug 1673513 - Use ProgressLogger in Gecko Profiler - r?florian Summary: Add `ProgressLogger` parameter to most JSON-generating functions. Each function can update the given `ProgressLogger` between 0% and 100%, and create sub-loggers when calling functions. The main goal of this instrumentation is to notice when any progress is made by child processes (when the parent process is gathering profiles), so it needs to go deep enough so that it is not stuck on a progress value for "too long" -- During development, that meant progress was always happening when observed every 10ms; In later patches, the overall timeout for no-progress-made will be at least 1 second. Differential Revision: https://phabricator.services.mozilla.com/D135479 Depends on D135478 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-grcjfjshalt76o6zwaky
7d60fa85c898012ef90541ac847968673a60b84b: Bug 1673513 - ProgressLogger - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:43:19 +0000 - rev 4180248
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
Bug 1673513 - ProgressLogger - r?florian Summary: Class used to log the progress of long operations, and simplifying the use through nested function calls and loops. Differential Revision: https://phabricator.services.mozilla.com/D135478 Depends on D135477 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-rtm2vx7a4q55277ybl5k
da8c9aa0527e81cb25310e04c391e6beebdd9eb2: Bug 1673513 - ProportionValue - r?florian draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 21 Jan 2022 06:43:14 +0000 - rev 4180247
Push 771630 by reviewbot at Fri, 21 Jan 2022 06:43:58 +0000
Bug 1673513 - ProportionValue - r?florian Summary: Class storing a value between 0 and 1, effectively 0% to 100%. It will be used through a ProgressLogger object to track the progress of JSON profile generation (see following patches). Differential Revision: https://phabricator.services.mozilla.com/D135477 Test Plan: Reviewers: florian Subscribers: Bug #: 1673513 Differential Diff: PHID-DIFF-jk3uaiae5vprflnpuv64
c589a21bb5400702a6d34e13557f6477499cede0: try_task_config for https://phabricator.services.mozilla.com/D135480 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Fri, 21 Jan 2022 06:42:54 +0000 - rev 4180246
Push 771629 by reviewbot at Fri, 21 Jan 2022 06:43:21 +0000
try_task_config for https://phabricator.services.mozilla.com/D135480 Differential Diff: PHID-DIFF-vepb4gkxkdfsay4eog7k
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip