6b9f2c689d78be4865d7d4a5dc2e4521b6bd9979: Bug 1600211 - Disable content conversion by HttpChannelChild if we have already applied it by the time we get to HttpChannelParent::OnStartRequest. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:47 +0000 - rev 2507071
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Disable content conversion by HttpChannelChild if we have already applied it by the time we get to HttpChannelParent::OnStartRequest. r?mayhemer We normally get HttpChannelParent::OnStartRequest directly from nsHttpChannel::OnStartRequest, where we disable content conversion and ask the child to do it instead. When we install a multipart converter, we defer calling HttpChannelParent::OnStartRequest until we've decoded parts, at which point content conversion is already applied to the stream. This detects that case, and stops the child trying to do it a second time (which fails, and breaks the content). Differential Revision: https://phabricator.services.mozilla.com/D55222 Differential Diff: PHID-DIFF-awckl4j65v4trf36deng
1a255535100f7781c5fdf4d6efddc67708849650: Bug 1600211 - Support multipart channels in DocumentLoadListener. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:42 +0000 - rev 2507070
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Support multipart channels in DocumentLoadListener. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55221 Differential Diff: PHID-DIFF-yguafpcq4gft52znoqnz
f6df524d569fbe5aab25783c326b8d5956659a28: Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:38 +0000 - rev 2507069
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer We can't always know when sending a part if it'll be the last one (either because the channel is later cancelled, or because the response just sends the end boundary without warning). This was initially reported in bug 339610. Differential Revision: https://phabricator.services.mozilla.com/D55220 Differential Diff: PHID-DIFF-hcdo2edmjibjwljpzx24
4d4b78dc2c0ebc614f98918aa43a5dff0adf635c: Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:34 +0000 - rev 2507068
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer This also removes OnStartRequestSent from PHttpBackgroundChannel, since there should never be any messages sent earlier on this channel, so we can just assume the waiting state initially. Differential Revision: https://phabricator.services.mozilla.com/D55219 Differential Diff: PHID-DIFF-w2ih4un6c3gafkr7drdb
ec3d9e3605714a9db50e0115b74d13b1477ff7bc: Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:31 +0000 - rev 2507067
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55218 Differential Diff: PHID-DIFF-pdovgu5hdi3cgiregwbv
c22d64b74377a23eb932e692839c580c7809d056: Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:28 +0000 - rev 2507066
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55217 Differential Diff: PHID-DIFF-zogvnsyijro52gjrelzt
af94f892f3e943e1675347e10bd35caa83313d7d: Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:26 +0000 - rev 2507065
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55216 Differential Diff: PHID-DIFF-cvftix64uuvzf6ei6kk3
e375900959166ddd7990cf20648d0f6e5f4748b6: Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:49:23 +0000 - rev 2507064
Push 458164 by reviewbot at Mon, 02 Dec 2019 02:50:19 +0000
Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55215 Differential Diff: PHID-DIFF-pm5slo5tjedmbylmk33g
8efdfa67f7012d8b2a5d5cb96457846832331485: try_task_config for https://phabricator.services.mozilla.com/D55221 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 02 Dec 2019 02:48:58 +0000 - rev 2507063
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
try_task_config for https://phabricator.services.mozilla.com/D55221 Differential Diff: PHID-DIFF-yguafpcq4gft52znoqnz
f0cfc1f7aa2f008dba65ae095a882a03c6ea6cf6: Bug 1600211 - Support multipart channels in DocumentLoadListener. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:53 +0000 - rev 2507062
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Support multipart channels in DocumentLoadListener. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55221 Differential Diff: PHID-DIFF-yguafpcq4gft52znoqnz
8d2346893d87308c35e59e259215fe4da6366e16: Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:50 +0000 - rev 2507061
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer We can't always know when sending a part if it'll be the last one (either because the channel is later cancelled, or because the response just sends the end boundary without warning). This was initially reported in bug 339610. Differential Revision: https://phabricator.services.mozilla.com/D55220 Differential Diff: PHID-DIFF-hcdo2edmjibjwljpzx24
bf0246aaa1bc2b4dd3af4995c20282ec5bc96799: Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:47 +0000 - rev 2507060
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer This also removes OnStartRequestSent from PHttpBackgroundChannel, since there should never be any messages sent earlier on this channel, so we can just assume the waiting state initially. Differential Revision: https://phabricator.services.mozilla.com/D55219 Differential Diff: PHID-DIFF-w2ih4un6c3gafkr7drdb
19eea044f66057c1731b18e7e467d4fdd7464561: Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:44 +0000 - rev 2507059
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55218 Differential Diff: PHID-DIFF-pdovgu5hdi3cgiregwbv
18656f746e5b2ad58ec4f6dc870f9688c12b9315: Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:40 +0000 - rev 2507058
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55217 Differential Diff: PHID-DIFF-zogvnsyijro52gjrelzt
bd4abfd46e2b50186d68c117351c52e8a57aee40: Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:37 +0000 - rev 2507057
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55216 Differential Diff: PHID-DIFF-cvftix64uuvzf6ei6kk3
48b2543d7ad5afa4daa22fe94b62c774b8352389: Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:48:35 +0000 - rev 2507056
Push 458163 by reviewbot at Mon, 02 Dec 2019 02:49:23 +0000
Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55215 Differential Diff: PHID-DIFF-pm5slo5tjedmbylmk33g
9c3d69a2c8a8e653106e4374857d6f816fb7ab8c: try_task_config for https://phabricator.services.mozilla.com/D55220 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 02 Dec 2019 02:48:00 +0000 - rev 2507055
Push 458162 by reviewbot at Mon, 02 Dec 2019 02:48:33 +0000
try_task_config for https://phabricator.services.mozilla.com/D55220 Differential Diff: PHID-DIFF-hcdo2edmjibjwljpzx24
2fae1f53b81bde5967f678cd4347b9fef7f4c824: Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:47:54 +0000 - rev 2507054
Push 458162 by reviewbot at Mon, 02 Dec 2019 02:48:33 +0000
Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r?mayhemer We can't always know when sending a part if it'll be the last one (either because the channel is later cancelled, or because the response just sends the end boundary without warning). This was initially reported in bug 339610. Differential Revision: https://phabricator.services.mozilla.com/D55220 Differential Diff: PHID-DIFF-hcdo2edmjibjwljpzx24
c3a9ac988f0d64aa3a8c76c6756e1b0b4ee816af: Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:47:50 +0000 - rev 2507053
Push 458162 by reviewbot at Mon, 02 Dec 2019 02:48:33 +0000
Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r?mayhemer This also removes OnStartRequestSent from PHttpBackgroundChannel, since there should never be any messages sent earlier on this channel, so we can just assume the waiting state initially. Differential Revision: https://phabricator.services.mozilla.com/D55219 Differential Diff: PHID-DIFF-w2ih4un6c3gafkr7drdb
8a94d516fa60a9c0732958e9f0fdc27e9984b4ba: Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer draft
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Dec 2019 02:47:46 +0000 - rev 2507052
Push 458162 by reviewbot at Mon, 02 Dec 2019 02:48:33 +0000
Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r?mayhemer Differential Revision: https://phabricator.services.mozilla.com/D55218 Differential Diff: PHID-DIFF-pdovgu5hdi3cgiregwbv
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip