516be887f6862836049f7d8b0999e9237289ecb1: Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs draft
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 10 Dec 2019 20:57:43 +0000 - rev 2527391
Push 463373 by reviewbot at Tue, 10 Dec 2019 20:58:49 +0000
Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs The action should open the SSB UI to show the page. No other custom behaviour is expecgterd at this point. Differential Revision: https://phabricator.services.mozilla.com/D56283 Differential Diff: PHID-DIFF-uvubpubv3znkbm5kqqz7
f6e21f0886458052faa38248c32f389992f20b6b: Fuzzy query='debugger&query='mozlint-eslint&query=!asan 'devtools !shippable | 'linux32 | 'macosx64&query=!android !asan 'linux32 | 'macosx64 | !shippable 'mochitest-chrome&query=!asan !shippable 'linux64/ 'xpcshell&query=!qr !macosx !shippable 'damp draft
Jason Laster <jlaster@mozilla.com> - Tue, 10 Dec 2019 12:58:04 -0800 - rev 2527390
Push 463372 by jlaster@mozilla.com at Tue, 10 Dec 2019 20:58:36 +0000
Fuzzy query='debugger&query='mozlint-eslint&query=!asan 'devtools !shippable | 'linux32 | 'macosx64&query=!android !asan 'linux32 | 'macosx64 | !shippable 'mochitest-chrome&query=!asan !shippable 'linux64/ 'xpcshell&query=!qr !macosx !shippable 'damp Pushed via `mach try fuzzy`
7cf3a8c98df38f9243940b342868b66a1dd12d08: Bug 1602910 - Memoize getBreakpointSources. r=bhackett draft
Jason Laster <jlaster@mozilla.com> - Tue, 10 Dec 2019 09:41:41 -0800 - rev 2527389
Push 463372 by jlaster@mozilla.com at Tue, 10 Dec 2019 20:58:36 +0000
Bug 1602910 - Memoize getBreakpointSources. r=bhackett Differential Revision: https://phabricator.services.mozilla.com/D56614
f9193f1408daf217284a5c909d673821c7f0f12d: try_task_config for https://phabricator.services.mozilla.com/D56614 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 10 Dec 2019 20:57:45 +0000 - rev 2527388
Push 463371 by reviewbot at Tue, 10 Dec 2019 20:58:01 +0000
try_task_config for https://phabricator.services.mozilla.com/D56614 Differential Diff: PHID-DIFF-t27idwzck2mi6r36eyzs
323c4c5c3c2f913cf19f3915ef9acfc11b0ff358: Bug 1602910 - Memoize getBreakpointSources. r=bhackett draft
Jason Laster <jlaster@mozilla.com> - Tue, 10 Dec 2019 20:57:41 +0000 - rev 2527387
Push 463371 by reviewbot at Tue, 10 Dec 2019 20:58:01 +0000
Bug 1602910 - Memoize getBreakpointSources. r=bhackett Differential Diff: PHID-DIFF-t27idwzck2mi6r36eyzs
00f2f8f61c907b529e6462a8c34bd12182562cca: Try Chooser Enhanced (3185 tasks selected) draft
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 10 Dec 2019 22:56:20 +0200 - rev 2527386
Push 463370 by opettay@mozilla.com at Tue, 10 Dec 2019 20:56:34 +0000
Try Chooser Enhanced (3185 tasks selected) Pushed via `mach try chooser`
c09f0703190d094d360eec20d4a1c141433ff76e: try_task_config for https://phabricator.services.mozilla.com/D56510 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 10 Dec 2019 20:55:18 +0000 - rev 2527385
Push 463369 by reviewbot at Tue, 10 Dec 2019 20:55:34 +0000
try_task_config for https://phabricator.services.mozilla.com/D56510 Differential Diff: PHID-DIFF-knk2otnevpgzteeilarl
3cea3af95eb211275fe182b31d7d0ce097b1a9cb: Bug 1579178 Part 4: Update test functions and an existing zoom test to work with new RDM UI. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:55:14 +0000 - rev 2527384
Push 463369 by reviewbot at Tue, 10 Dec 2019 20:55:34 +0000
Bug 1579178 Part 4: Update test functions and an existing zoom test to work with new RDM UI. This patch does several related things: 1) Updates the test helper functions in ui.js to make them sensible for both the old and new RDM UI. 2) Updates the test helper function addRDMTask to return the correct "browser" values for both RDM UIs. Old RDM UI tests that want to spawn a content task should now use ui.getViewportBrowser() for that, and only use the browser value for getting/setting of zoom and any other methods that take browsers as arguments. 3) Updates the test helper function promiseRDM to make it wait on the correct event. 4) Updates a non-zoom test that uses addRDMTask to use the new browser value correctly. 5) Updates a zoom test to use the addRDMTask function, and therefore run the test using the new RDM UI. This test exercises the issue that is the focus of this bug. Differential Revision: https://phabricator.services.mozilla.com/D56510 Differential Diff: PHID-DIFF-knk2otnevpgzteeilarl
bd573c1b449130f347a634c143d2e94f2840bb12: Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:55:11 +0000 - rev 2527383
Push 463369 by reviewbot at Tue, 10 Dec 2019 20:55:34 +0000
Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. The firing of the "ZoomComplete" event is no longer necessary, now that ZoomParent fires a "PostFullZoomChange" event, which serves a similar purpose. The next part of the patch listens for that event. Differential Revision: https://phabricator.services.mozilla.com/D56509 Differential Diff: PHID-DIFF-qz4hr3qjkokpbjh7von7
6ece067fec162d021f2d116ed23c72c541a81d55: Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:55:08 +0000 - rev 2527382
Push 463369 by reviewbot at Tue, 10 Dec 2019 20:55:34 +0000
Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. For the existing RDM UI, the saving and restoring of resolution is done in the content frame script, which is no longer loaded in the new UI. This approach is flexible enough that it will work for BOTH UIs. The next part of the patch contains the removal of the old method. Differential Revision: https://phabricator.services.mozilla.com/D56267 Differential Diff: PHID-DIFF-tyrll2r5mc32gl3sazvl
fbd69b118ae81f389e0ad72b825180a9f9e3f2a4: Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:55:04 +0000 - rev 2527381
Push 463369 by reviewbot at Tue, 10 Dec 2019 20:55:34 +0000
Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. Because the new RDM UI does not retain the width and height of the device, this patch extracts those values from the prefs which are updated in the viewports reducer. There probably should be a more resilient way to maintain those values. Differential Revision: https://phabricator.services.mozilla.com/D54379 Differential Diff: PHID-DIFF-7nbg2zramojytc5hisag
a5b282172d4d2d49f68f0d346066e62e85e8718d: try_task_config for https://phabricator.services.mozilla.com/D56509 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 10 Dec 2019 20:54:36 +0000 - rev 2527380
Push 463368 by reviewbot at Tue, 10 Dec 2019 20:54:54 +0000
try_task_config for https://phabricator.services.mozilla.com/D56509 Differential Diff: PHID-DIFF-qz4hr3qjkokpbjh7von7
02cd0d182594d9398972088060fe15e0a586dc37: Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:54:30 +0000 - rev 2527379
Push 463368 by reviewbot at Tue, 10 Dec 2019 20:54:54 +0000
Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. The firing of the "ZoomComplete" event is no longer necessary, now that ZoomParent fires a "PostFullZoomChange" event, which serves a similar purpose. The next part of the patch listens for that event. Differential Revision: https://phabricator.services.mozilla.com/D56509 Differential Diff: PHID-DIFF-qz4hr3qjkokpbjh7von7
89274209db97db70ffc0e96813be603ed5626240: Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:54:26 +0000 - rev 2527378
Push 463368 by reviewbot at Tue, 10 Dec 2019 20:54:54 +0000
Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. For the existing RDM UI, the saving and restoring of resolution is done in the content frame script, which is no longer loaded in the new UI. This approach is flexible enough that it will work for BOTH UIs. The next part of the patch contains the removal of the old method. Differential Revision: https://phabricator.services.mozilla.com/D56267 Differential Diff: PHID-DIFF-tyrll2r5mc32gl3sazvl
eeebfc08cdf6af8b159bd4448026a90f2ba1b2a8: Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:54:21 +0000 - rev 2527377
Push 463368 by reviewbot at Tue, 10 Dec 2019 20:54:54 +0000
Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. Because the new RDM UI does not retain the width and height of the device, this patch extracts those values from the prefs which are updated in the viewports reducer. There probably should be a more resilient way to maintain those values. Differential Revision: https://phabricator.services.mozilla.com/D54379 Differential Diff: PHID-DIFF-7nbg2zramojytc5hisag
f2cc61e124170973919e9fc9ae0d87b1723d0172: try_task_config for https://phabricator.services.mozilla.com/D56267 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 10 Dec 2019 20:53:42 +0000 - rev 2527376
Push 463367 by reviewbot at Tue, 10 Dec 2019 20:53:58 +0000
try_task_config for https://phabricator.services.mozilla.com/D56267 Differential Diff: PHID-DIFF-tyrll2r5mc32gl3sazvl
c3bb98efc8ec5c62e10965c0f01caa3da8300c0a: Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:53:38 +0000 - rev 2527375
Push 463367 by reviewbot at Tue, 10 Dec 2019 20:53:58 +0000
Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. For the existing RDM UI, the saving and restoring of resolution is done in the content frame script, which is no longer loaded in the new UI. This approach is flexible enough that it will work for BOTH UIs. The next part of the patch contains the removal of the old method. Differential Revision: https://phabricator.services.mozilla.com/D56267 Differential Diff: PHID-DIFF-tyrll2r5mc32gl3sazvl
f7e1c513bfc0f029a535f755f1b6d27981ad32ae: Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. draft
Brad Werth <bwerth@mozilla.com> - Tue, 10 Dec 2019 20:53:34 +0000 - rev 2527374
Push 463367 by reviewbot at Tue, 10 Dec 2019 20:53:58 +0000
Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom. Because the new RDM UI does not retain the width and height of the device, this patch extracts those values from the prefs which are updated in the viewports reducer. There probably should be a more resilient way to maintain those values. Differential Revision: https://phabricator.services.mozilla.com/D54379 Differential Diff: PHID-DIFF-7nbg2zramojytc5hisag
2d38568451c323f08551a15040cde29d43b760a1: try: -b do -p win32,win64,win32-mingwclang,win64-mingwclang -u cppunit -t none draft
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 10 Dec 2019 12:53:12 -0800 - rev 2527373
Push 463366 by tkikuchi@mozilla.com at Tue, 10 Dec 2019 20:53:43 +0000
try: -b do -p win32,win64,win32-mingwclang,win64-mingwclang -u cppunit -t none Pushed via `mach try syntax`
1f9420611c3a9bf4b5bb5c7bb4f09a8ce3ea4753: Address comments draft
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 10 Dec 2019 12:51:30 -0800 - rev 2527372
Push 463366 by tkikuchi@mozilla.com at Tue, 10 Dec 2019 20:53:43 +0000
Address comments
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip