4fcfb2330cc5484d1ae1f34376b5078e2901126d: bug 1543115: remote: rename XPCOM manifest for conformity; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:14:33 +0000 - rev 2395721
Push 439586 by reviewbot at Thu, 24 Oct 2019 14:15:08 +0000
bug 1543115: remote: rename XPCOM manifest for conformity; r=#remote All other XPCOM component manifests are named components.conf and this makes the remote agent's conform with those. It will also become apparent in a later patch in this changeset that we need to register two XPCOM components: one implementing the remote agent service, and one for handling command-line arguments. Differential Revision: https://phabricator.services.mozilla.com/D50280 Differential Diff: PHID-DIFF-glcz5in26t733wsyzk2b
7f7e0a75c86fa3a3919f80333994827c42600370: Try Chooser Enhanced (10 tasks selected) draft
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 24 Oct 2019 17:14:12 +0300 - rev 2395720
Push 439585 by opettay@mozilla.com at Thu, 24 Oct 2019 14:14:27 +0000
Try Chooser Enhanced (10 tasks selected) Pushed via `mach try chooser`
2894e60e1b6a0ab84cdd1baeffc2fe800079f1a7: Bug 1591087 - Add some more HTML*Element sizeof assertions, r=ehsan draft
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 24 Oct 2019 17:11:53 +0300 - rev 2395719
Push 439585 by opettay@mozilla.com at Thu, 24 Oct 2019 14:14:27 +0000
Bug 1591087 - Add some more HTML*Element sizeof assertions, r=ehsan Differential Revision: https://phabricator.services.mozilla.com/D50475
ef1daaf7fe719ac6f0b024bf5c310efa498d0272: try_task_config for https://phabricator.services.mozilla.com/D50287 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Thu, 24 Oct 2019 14:13:17 +0000 - rev 2395718
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
try_task_config for https://phabricator.services.mozilla.com/D50287 Differential Diff: PHID-DIFF-3ms3flny46purkpxrlxx
7cca2043845fd0284334b7072b1455946a4ba9e2: bug 1543115: remote: introduce nsIRemoteAgent XPIDL interface; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:14 +0000 - rev 2395717
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: introduce nsIRemoteAgent XPIDL interface; r=#remote Adds an XPIDL interface for the remote agent which we will later use to initialise and start it from a new command-line handler written in Rust. Differential Revision: https://phabricator.services.mozilla.com/D50287 Differential Diff: PHID-DIFF-3ms3flny46purkpxrlxx
4cfe9592e6d0ad0cef530c7a89b41e995350757e: bug 1543115: remote: make RemoteAgent.listen() accept strings; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:12 +0000 - rev 2395716
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: make RemoteAgent.listen() accept strings; r=#remote Crafting nsIURIs in Rust is complicated. Allow RemoteAgent.listen() to accept both strings and nsIURIs when called in JavaScript. Differential Revision: https://phabricator.services.mozilla.com/D50286 Differential Diff: PHID-DIFF-gua6o2wvsisjkaunohqb
73891cf550c4187c2f2f8509fbe054aacdd14036: bug 1543115: remote: emit "remote-listening" system notification on startup; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:09 +0000 - rev 2395715
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: emit "remote-listening" system notification on startup; r=#remote When calling RemoteAgent.listen() across XPIDL the function is run asynchronously. In order to find out when the remote agent has started listening we introduce a "remote-listening" system observer notification. Differential Revision: https://phabricator.services.mozilla.com/D50285 Differential Diff: PHID-DIFF-4aauaxmhm5rpbtts23kg
f4f18f731d42c75f28311319ddc0671fd8f134f3: bug 1543115: remote: set needed prefs earlier at startup; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:07 +0000 - rev 2395714
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: set needed prefs earlier at startup; r=#remote Although it currently makes no difference, we should ensure the required preferences are set sooner, in case any of the internal remote agent features depend on it. Because we also cannot control when the nsICommandLineHandler for the remote agent is invoked, setting it sooner rather than later, seems a lot safer. Differential Revision: https://phabricator.services.mozilla.com/D50283 Differential Diff: PHID-DIFF-6ctj2dulyf24kcfr3xpp
9b522b861ee929c0029dff0d5342dae13c143f35: bug 1543115: remote: make RemoteAgent.close() safer; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:04 +0000 - rev 2395713
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: make RemoteAgent.close() safer; r=#remote close() is meant to be failsafe in the sense that it should be possible to call without side-effects. We are currently setting up a lot of state in listen() that is not cleaned up if the server eventually fails to start. Calling close() when this happens will ensure any state listen() has accrued is reset. Differential Revision: https://phabricator.services.mozilla.com/D50282 Differential Diff: PHID-DIFF-k7n5lrrui2haqllsm3eg
f16e18f4030a459eed2caf7b1b30e31809ec14f6: bug 1543115: remote: merge init() and listen(); r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:13:02 +0000 - rev 2395712
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: merge init() and listen(); r=#remote Having init() as a separate function leads to inconsistencies about how the required state is checked. init() prevents the remote agent from being loaded when the remote.enabled preference is false or it is attempted loaded into a child process, but listen() already manipulates state before these checks are run. This is probably not the intention, but an easy mistake to make when the code flow is not crystal clear. Since we never have a need to call init() independently, this patch merges init() into listen(). Differential Revision: https://phabricator.services.mozilla.com/D50281 Differential Diff: PHID-DIFF-foimawc37pjvadj5f5co
2f9cbebc2a46483188a7ced5eb0e539467f65f27: bug 1543115: remote: rename XPCOM manifest for conformity; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 14:12:59 +0000 - rev 2395711
Push 439584 by reviewbot at Thu, 24 Oct 2019 14:13:46 +0000
bug 1543115: remote: rename XPCOM manifest for conformity; r=#remote All other XPCOM component manifests are named components.conf and this makes the remote agent's conform with those. It will also become apparent in a later patch in this changeset that we need to register two XPCOM components: one implementing the remote agent service, and one for handling command-line arguments. Differential Revision: https://phabricator.services.mozilla.com/D50280 Differential Diff: PHID-DIFF-glcz5in26t733wsyzk2b
adf9c3c9d0013eadcbecf19233128d6f66d25da1: Fuzzy query='rusttests | 'puppeteer | 'mochitest-remote !asan !shippable draft
Andreas Tolfsen <ato@sny.no> - Thu, 24 Oct 2019 15:12:54 +0100 - rev 2395710
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
Fuzzy query='rusttests | 'puppeteer | 'mochitest-remote !asan !shippable Pushed via `mach try fuzzy`
2e0f6dd2ae40aa3bdd9e7edeeef1156d16ffa684: bug 1543115: remote: bootstrap from Rust; r=#remote,nika draft
Andreas Tolfsen <ato@sny.no> - Tue, 22 Oct 2019 16:24:54 +0100 - rev 2395709
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: bootstrap from Rust; r=#remote,nika This ports the remote agent's implementation of nsICommandLineHandler from JS to Rust in a way faithful This bootstraps the remote agent from Rust so that we have access to write to stderr using the eprintln!() macro. There is a future intention to expand Rust usage in the remote agent by delegating CDP and WebDriver Bi-Di protocol schema validation to serde. The Rust port is faithful to the JS version in terms of functionality, and in some places improves on the original design by enforcing a strict division between flag handling code on one hand, and the remote agent server on the other. Differential Revision: https://phabricator.services.mozilla.com/D50289
877dddab8861cc88e01bb449a31686e7cecaa546: bug 1543115: remote: expose nsIRemoteAgent as XPCOM service; r=#remote,nika draft
Andreas Tolfsen <ato@sny.no> - Mon, 30 Sep 2019 16:53:45 +0100 - rev 2395708
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: expose nsIRemoteAgent as XPCOM service; r=#remote,nika This change makes it possible to access the remote agent service from C++ and Rust. Differential Revision: https://phabricator.services.mozilla.com/D50288
b285763ab80ab00d26277b5aa78fdfe275a051e8: bug 1543115: remote: introduce nsIRemoteAgent XPIDL interface; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Mon, 02 Sep 2019 15:56:18 +0100 - rev 2395707
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: introduce nsIRemoteAgent XPIDL interface; r=#remote Adds an XPIDL interface for the remote agent which we will later use to initialise and start it from a new command-line handler written in Rust. Differential Revision: https://phabricator.services.mozilla.com/D50287
f8c22c334af69eca4812292ef5647b7387d5328e: bug 1543115: remote: make RemoteAgent.listen() accept strings; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Tue, 22 Oct 2019 20:17:08 +0100 - rev 2395706
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: make RemoteAgent.listen() accept strings; r=#remote Crafting nsIURIs in Rust is complicated. Allow RemoteAgent.listen() to accept both strings and nsIURIs when called in JavaScript. Differential Revision: https://phabricator.services.mozilla.com/D50286
e2ff591ca3a03c6301fba33cff57442bbf37e1a2: bug 1543115: remote: emit "remote-listening" system notification on startup; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 17 Oct 2019 13:54:38 +0100 - rev 2395705
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: emit "remote-listening" system notification on startup; r=#remote When calling RemoteAgent.listen() across XPIDL the function is run asynchronously. In order to find out when the remote agent has started listening we introduce a "remote-listening" system observer notification. Differential Revision: https://phabricator.services.mozilla.com/D50285
5279912844fb988e6525d720bb9d989169116b70: bug 1543115: remote: set needed prefs earlier at startup; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 17 Oct 2019 13:22:05 +0100 - rev 2395704
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: set needed prefs earlier at startup; r=#remote Although it currently makes no difference, we should ensure the required preferences are set sooner, in case any of the internal remote agent features depend on it. Because we also cannot control when the nsICommandLineHandler for the remote agent is invoked, setting it sooner rather than later, seems a lot safer. Differential Revision: https://phabricator.services.mozilla.com/D50283
a8bd9b9c4438208150a2d1c97f3df69f82842e94: bug 1543115: remote: make RemoteAgent.close() safer; r=#remote draft
Andreas Tolfsen <ato@sny.no> - Thu, 17 Oct 2019 13:19:13 +0100 - rev 2395703
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: make RemoteAgent.close() safer; r=#remote close() is meant to be failsafe in the sense that it should be possible to call without side-effects. We are currently setting up a lot of state in listen() that is not cleaned up if the server eventually fails to start. Calling close() when this happens will ensure any state listen() has accrued is reset. Differential Revision: https://phabricator.services.mozilla.com/D50282
7da8b2fc7b9edd24ed2cd48ecd169be6fd56f80b: bug 1543115: remote: merge init() and listen(); r=#remote draft
Andreas Tolfsen <ato@sny.no> - Tue, 22 Oct 2019 16:53:35 +0100 - rev 2395702
Push 439583 by ato@sny.no at Thu, 24 Oct 2019 14:13:32 +0000
bug 1543115: remote: merge init() and listen(); r=#remote Having init() as a separate function leads to inconsistencies about how the required state is checked. init() prevents the remote agent from being loaded when the remote.enabled preference is false or it is attempted loaded into a child process, but listen() already manipulates state before these checks are run. This is probably not the intention, but an easy mistake to make when the code flow is not crystal clear. Since we never have a need to call init() independently, this patch merges init() into listen(). Differential Revision: https://phabricator.services.mozilla.com/D50281
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip