32ac2de42955f0e09d331b063fa66a2f34714488: Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:58:23 +0000 - rev 3000000
Push 558601 by reviewbot at Tue, 23 Jun 2020 23:59:03 +0000
Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! Summary: Exposing frameIterData() and setFrameIterData() isn't great since it makes it harder to follow what state transitions for frame data we expect the frame to have. By hiding this, it helps clarify that frame data can be cleared or replaced, but public usage of the FrameIter::Data object itself isn't expected outside of the class itself. Differential Revision: https://phabricator.services.mozilla.com/D80734 Depends on D80762 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-yyvo3sxpaodbm57o36o2
a968a53c10b3ca828c50e1e14943353942410e60: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:58:19 +0000 - rev 2999999
Push 558601 by reviewbot at Tue, 23 Jun 2020 23:59:03 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
e8a059e9c31ae846326c05423d89a5339af94420: try_task_config for https://phabricator.services.mozilla.com/D80737 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:57:32 +0000 - rev 2999998
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
try_task_config for https://phabricator.services.mozilla.com/D80737 Differential Diff: PHID-DIFF-wqjej7u7it56whbdygz3
8d626c34255307cfce66f44ebcf49cfe34afe53c: Bug 1647342 - Part 4: Convert forEachDebuggerFrame helper to expose Debugger*. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:57:28 +0000 - rev 2999997
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
Bug 1647342 - Part 4: Convert forEachDebuggerFrame helper to expose Debugger*. r=arai! Summary: This is just a tiny refactor to avoid needing to then get the Debugger* from the frame when we already know it. Differential Revision: https://phabricator.services.mozilla.com/D80737 Depends on D80736 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-wqjej7u7it56whbdygz3
ac638361f6d7db28c745ddca95eb810c0fa120e2: Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:57:25 +0000 - rev 2999996
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! Summary: I have no idea how long this has been stale. Differential Revision: https://phabricator.services.mozilla.com/D80736 Depends on D80735 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-pm56s2opuy672eaeawhj
f3b5556daf99879be87d69cea6eb556be4a0e6b4: Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:57:23 +0000 - rev 2999995
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! Summary: It is guaranteed that this will already be populated because in 1539654 we started properly preserving the debuggee-ness of frames across suspend and resume. With slowPathOnResumeFrame guaranteed to run, we no longer need to try to hande handle the case where the generator has been resumed, but the Debugger.Frame's inner data was not populated. Differential Revision: https://phabricator.services.mozilla.com/D80735 Depends on D80734 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-ppztbt6hxxpwtvc3wsnw
31f94336e005244b936a9fb43562cec73d6958c6: Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:57:20 +0000 - rev 2999994
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! Summary: Exposing frameIterData() and setFrameIterData() isn't great since it makes it harder to follow what state transitions for frame data we expect the frame to have. By hiding this, it helps clarify that frame data can be cleared or replaced, but public usage of the FrameIter::Data object itself isn't expected outside of the class itself. Differential Revision: https://phabricator.services.mozilla.com/D80734 Depends on D80762 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-yyvo3sxpaodbm57o36o2
16805abc8cd2af48d7586652868004d862f02dac: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:57:17 +0000 - rev 2999993
Push 558600 by reviewbot at Tue, 23 Jun 2020 23:57:49 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
112abc0da8d6e982839ece038b82d9722311bc5d: try_task_config for https://phabricator.services.mozilla.com/D80736 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:56:31 +0000 - rev 2999992
Push 558599 by reviewbot at Tue, 23 Jun 2020 23:56:49 +0000
try_task_config for https://phabricator.services.mozilla.com/D80736 Differential Diff: PHID-DIFF-pm56s2opuy672eaeawhj
04690682b1a26047d9713d64a5be049b92a06ee9: Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:56:26 +0000 - rev 2999991
Push 558599 by reviewbot at Tue, 23 Jun 2020 23:56:49 +0000
Bug 1647342 - Part 3: Remove unused detachAllDebuggersFromGlobal Debugger method. r=arai! Summary: I have no idea how long this has been stale. Differential Revision: https://phabricator.services.mozilla.com/D80736 Depends on D80735 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-pm56s2opuy672eaeawhj
a61f5223b86db8f376af923f15e3a143d2239cca: Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:56:22 +0000 - rev 2999990
Push 558599 by reviewbot at Tue, 23 Jun 2020 23:56:49 +0000
Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! Summary: It is guaranteed that this will already be populated because in 1539654 we started properly preserving the debuggee-ness of frames across suspend and resume. With slowPathOnResumeFrame guaranteed to run, we no longer need to try to hande handle the case where the generator has been resumed, but the Debugger.Frame's inner data was not populated. Differential Revision: https://phabricator.services.mozilla.com/D80735 Depends on D80734 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-ppztbt6hxxpwtvc3wsnw
f980d1520f92c474ebd9579830d9d41b7362ce78: Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:56:18 +0000 - rev 2999989
Push 558599 by reviewbot at Tue, 23 Jun 2020 23:56:49 +0000
Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! Summary: Exposing frameIterData() and setFrameIterData() isn't great since it makes it harder to follow what state transitions for frame data we expect the frame to have. By hiding this, it helps clarify that frame data can be cleared or replaced, but public usage of the FrameIter::Data object itself isn't expected outside of the class itself. Differential Revision: https://phabricator.services.mozilla.com/D80734 Depends on D80762 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-yyvo3sxpaodbm57o36o2
49a5dc8bb0fd6e7177c45f3926f2f2edbcc429fb: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:56:14 +0000 - rev 2999988
Push 558599 by reviewbot at Tue, 23 Jun 2020 23:56:49 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
f961c3a4040efd10733f1e692e86b1bf8d9b8db2: try_task_config for https://phabricator.services.mozilla.com/D80735 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:56:00 +0000 - rev 2999987
Push 558598 by reviewbot at Tue, 23 Jun 2020 23:56:15 +0000
try_task_config for https://phabricator.services.mozilla.com/D80735 Differential Diff: PHID-DIFF-ppztbt6hxxpwtvc3wsnw
f25018e15508ba5c324b7c92c6dd061724b91c5a: Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:55:56 +0000 - rev 2999986
Push 558598 by reviewbot at Tue, 23 Jun 2020 23:56:15 +0000
Bug 1647342 - Part 2: Rely on onResumeFrame to handle marking all frames as on-stack. r=arai! Summary: It is guaranteed that this will already be populated because in 1539654 we started properly preserving the debuggee-ness of frames across suspend and resume. With slowPathOnResumeFrame guaranteed to run, we no longer need to try to hande handle the case where the generator has been resumed, but the Debugger.Frame's inner data was not populated. Differential Revision: https://phabricator.services.mozilla.com/D80735 Depends on D80734 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-ppztbt6hxxpwtvc3wsnw
489dd46f42f9e37751ee84120ba854247ee3bbf4: Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:55:53 +0000 - rev 2999985
Push 558598 by reviewbot at Tue, 23 Jun 2020 23:56:15 +0000
Bug 1647342 - Part 1: Remove FrameIter::Data from DebuggerFrame public API. r=arai! Summary: Exposing frameIterData() and setFrameIterData() isn't great since it makes it harder to follow what state transitions for frame data we expect the frame to have. By hiding this, it helps clarify that frame data can be cleared or replaced, but public usage of the FrameIter::Data object itself isn't expected outside of the class itself. Differential Revision: https://phabricator.services.mozilla.com/D80734 Depends on D80762 Test Plan: Reviewers: Subscribers: Bug #: 1647342 Differential Diff: PHID-DIFF-yyvo3sxpaodbm57o36o2
6c26df452d4038f1d08b5924455b91860efe330d: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:55:50 +0000 - rev 2999984
Push 558598 by reviewbot at Tue, 23 Jun 2020 23:56:15 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
74ded802b485e9932033108134a490705a89cb5f: try_task_config for https://phabricator.services.mozilla.com/D80762 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:54:40 +0000 - rev 2999983
Push 558597 by reviewbot at Tue, 23 Jun 2020 23:55:06 +0000
try_task_config for https://phabricator.services.mozilla.com/D80762 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
f0246a6a8b34f82bed70d9115df0966d83f75300: Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! draft
Logan Smyth <loganfsmyth@gmail.com> - Tue, 23 Jun 2020 23:54:33 +0000 - rev 2999982
Push 558597 by reviewbot at Tue, 23 Jun 2020 23:55:06 +0000
Bug 1577639 - Do not attempt to clean up frames for non-OOM conditions. r=arai! Summary: The core issue is that we run removeFromFrameMapsAndClearBreakpointsIn(cx, from) even for non-OOM paths in this function, which is undesirable because that will remove the breakpoints for evaled scripts. In the non-OOM case there are no Debugger.Frame objects left in the frames map for the "frame" list, so there is no reason to actually call it in that case. This patch merges the two OOM handlers together for simplicity, though it is not technically necessary, it seems like the very minor increase in code run if there is an OOM is worth it to keep things centralized. Differential Revision: https://phabricator.services.mozilla.com/D80762 Test Plan: Reviewers: Subscribers: Bug #: 1577639 Differential Diff: PHID-DIFF-bpfhtg7cbdeoujgbzi7c
0b8b698fc00001ff9ce003718917037c7fddb05f: try_task_config for https://phabricator.services.mozilla.com/D80734 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:54:37 +0000 - rev 2999981
Push 558596 by reviewbot at Tue, 23 Jun 2020 23:54:54 +0000
try_task_config for https://phabricator.services.mozilla.com/D80734 Differential Diff: PHID-DIFF-yyvo3sxpaodbm57o36o2
(0) -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip