1d553e7c4a1b03e189b69b2e093dbc38b30d5ac9: Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
draft
Lee Salzman <lsalzman@mozilla.com> - Tue, 23 Jun 2020 23:38:25 +0000 - rev 2999950
Push
558588 by reviewbot at Tue, 23 Jun 2020 23:38:48 +0000
Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
Summary:
This is a first implementation of a software-only SWGL RenderCompositor
that relies on the existing widget hooks for Basic compositing. It attempts
to lock the widget and get a DT whose underlying data it can supply directly
to SWGL to composite to. Critically, it does not rely on OpenGL or any other
form of HW accel to function. The interface between the RenderCompositor and
SWGL will be further refined in follow-up patches.
Differential Revision:
https://phabricator.services.mozilla.com/D80268
Depends on D80267
Test Plan:
Reviewers: jrmuizel
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-jq2ikgwpolprjs4jzygd
3723a7a671312664a629694617a406fbd4ba66f4: Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
draft
Lee Salzman <lsalzman@mozilla.com> - Tue, 23 Jun 2020 23:38:21 +0000 - rev 2999949
Push
558588 by reviewbot at Tue, 23 Jun 2020 23:38:48 +0000
Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
Summary:
For performance reasons in SWGL software compositors. to avoid unnecessary
full-screen copies of the framembuffer, we need to allow those compositors to
map their underlying widget surfaces and pass that buffer to SWGL so that they
can be directly rendered to. That also requires supporting custom strides, as
we can't always enforce the particular layout of the buffers handed off to us.
To that end, InitDefaultFramebuffer is generalized to take such information
and then many places where we rely on a specific hard-coded SWGL-calculated
stride have been altered to deal with a caller-supplied stride.
Differential Revision:
https://phabricator.services.mozilla.com/D80267
Test Plan:
Reviewers: jimb
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-lpuuvlesv5ekxvsspzw3
dcbad051581a79971415d22d0419ec7046610552: Tasks automatically selected.
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 23 Jun 2020 16:29:46 -0700 - rev 2999948
Push
558587 by nalexander@mozilla.com at Tue, 23 Jun 2020 23:30:09 +0000
Tasks automatically selected.
Pushed via `mach try auto`
6a84a323332b1588c49e8293406b36335a3d0028: Bug 1636539 - Part 4: Use Rust remote settings client to fetch remote kill switch. r?agashlin,bytesized
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 23 Jun 2020 13:20:33 -0700 - rev 2999947
Push
558587 by nalexander@mozilla.com at Tue, 23 Jun 2020 23:30:09 +0000
Bug 1636539 - Part 4: Use Rust remote settings client to fetch remote kill switch. r?agashlin,bytesized
6306f8b70aab00ccafc5bc7f5097c461e33ba289: Bug 1636539 - Part 3: Add defaultagent-static Rust crate fetching remote disabled flag. r?agashlin,bytesized
draft
Nick Alexander <nalexander@mozilla.com> - Wed, 27 May 2020 20:38:20 -0700 - rev 2999946
Push
558587 by nalexander@mozilla.com at Tue, 23 Jun 2020 23:30:09 +0000
Bug 1636539 - Part 3: Add defaultagent-static Rust crate fetching remote disabled flag. r?agashlin,bytesized
This lays out a Rust crate and statically links it into
`windows-default-agent.exe`. It declares a single-method API (which
will be invoked in the next commit).
Strings cross the C/C++ <-> Rust FFI boundary as null-terminated
UTF-8. (This will matter more if and when we use ETag and
If-None-Match to get 304 results.)
Errors are reported as Windows error codes or as the special codes
above 32000 that we use to encode certain classes of failure.
The bulk of the work is in implementing a
[Viaduct](https://github.com/mozilla/application-services/tree/master/components/viaduct)
backend built on top of `wininet.dll`. The motivation is that if and
when this Remote Settings Rust client grows features (say,
Content-Signature: verification), then by using Viaduct there is a
smooth path to consume the client inside Firefox itself, because
Viaduct already has a backend on top of Necko. That makes this
abstraction relatively low friction: it exists, is in-tree already,
and has a path to use in Gecko proper.
It is expected that the layer above this will handle "gracefully
failing", either open or closed; and will mirror Remote Settings
configuration to the registry so that testers can use prod/stage/dev
easily.
TODO:
- Configure logging so that more than `error!` appears. Consider
disabling `env_logger` in non-debug configurations.
- Determine how much error propagation we care to do. Are we going to
report errors to Telemetry?
Differential Revision:
https://phabricator.services.mozilla.com/D78579
f7e4bf2f6ab8b39cdc344856ba320252fa307f3c: Bug 1636539 - Part 2: Mirror preferences for remote settings to Windows Default Browser Agent. r?agashlin,bytesized
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 23 Jun 2020 11:58:53 -0700 - rev 2999945
Push
558587 by nalexander@mozilla.com at Tue, 23 Jun 2020 23:30:09 +0000
Bug 1636539 - Part 2: Mirror preferences for remote settings to Windows Default Browser Agent. r?agashlin,bytesized
This isn't quite ready and tested yet, but I might as well throw it
out for initial comments. This originally mirrored the
`services.settings.server` pref. For WDBA, however, we only care
about one record; and it's quite handy to be able to name that
specific record (say, to one that disables things!). So eventually
I'll make this mirror some new pref with just that URL.
However, there's really no reason to do this in native code; it could
just as easily be JavaScript that runs a little after startup. That
would make it lighter to modify. But this location is next to the
same pattern for the launcher process. Trade offs, trade offs.
Do we have opinions about the form of the pref, and about where this
mirroring logic lives?
cad2666268049084d53788a0d8b30edc589daf86: Bug 1636539 - Part 1: Extract registry helper functions. r?agashlin,bytesized
draft
Nick Alexander <nalexander@mozilla.com> - Tue, 23 Jun 2020 13:09:47 -0700 - rev 2999944
Push
558587 by nalexander@mozilla.com at Tue, 23 Jun 2020 23:30:09 +0000
Bug 1636539 - Part 1: Extract registry helper functions. r?agashlin,bytesized
The pattern with `/mfbt/Poison.cpp` and `IMPL_MFBT` is
well-established in the tree.
fa9b5609f666efb311fa8966e08aaf7925b65732: try_task_config for https://phabricator.services.mozilla.com/D76073
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:25:49 +0000 - rev 2999943
Push
558586 by reviewbot at Tue, 23 Jun 2020 23:26:06 +0000
try_task_config for
https://phabricator.services.mozilla.com/D76073
Differential Diff: PHID-DIFF-6io6bnt5fe6vnbymjilp
2aa9b4abc0433c09f0a540949e17f1676ede40b1: Bug 1638587 - Show dismissed login capture doorhanger when password field is edited and in its own Shadow Root; r=MattN
draft
Bianca Danforth <bdanforth@mozilla.com> - Tue, 23 Jun 2020 23:25:44 +0000 - rev 2999942
Push
558586 by reviewbot at Tue, 23 Jun 2020 23:26:06 +0000
Bug 1638587 - Show dismissed login capture doorhanger when password field is edited and in its own Shadow Root; r=MattN
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D76073
Test Plan:
Reviewers:
Subscribers:
Bug #: 1638587
Differential Diff: PHID-DIFF-6io6bnt5fe6vnbymjilp
79fdaf0b0ec25323c9a71f654ef299ad6109ad08: Try Chooser Enhanced (883 tasks selected)
draft
Edgar Chen <echen@mozilla.com> - Wed, 24 Jun 2020 01:25:03 +0200 - rev 2999941
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Try Chooser Enhanced (883 tasks selected)
Pushed via `mach try again`
b8d12ff560840dd21d40bb22601a6e25d97905a4: Bug 1635784 - Hack fix for test 2;
draft
Edgar Chen <echen@mozilla.com> - Wed, 24 Jun 2020 01:22:32 +0200 - rev 2999940
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Bug 1635784 - Hack fix for test 2;
2698d1ae75b91fe6c9d6021e6bdbd3186b93eb43: Bug 1635784 - Send child exit;
draft
Edgar Chen <echen@mozilla.com> - Wed, 24 Jun 2020 01:18:42 +0200 - rev 2999939
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Bug 1635784 - Send child exit;
7d07e9ac2541b4950abb1b2b6016b6991f2eca20: Bug 1635784 - Hack fix for test;
draft
Edgar Chen <echen@mozilla.com> - Wed, 24 Jun 2020 00:24:07 +0200 - rev 2999938
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Bug 1635784 - Hack fix for test;
68955f3826a87b5c28e04a280d9f6f78efab1771: Bug 1635784 - Send to ancestor;
draft
Edgar Chen <echen@mozilla.com> - Tue, 23 Jun 2020 23:39:38 +0200 - rev 2999937
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Bug 1635784 - Send to ancestor;
5edad6cfdac7b17f1def9b6abd8959bb5e02d667: Bug 1635784 - Add LayersId to top-level mouse exit event;
draft
Edgar Chen <echen@mozilla.com> - Tue, 23 Jun 2020 12:56:36 +0200 - rev 2999936
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
Bug 1635784 - Add LayersId to top-level mouse exit event;
d2ba0faa2c79a7e740e83af71bccce0233d3ce3c: Bug 1635784 - Test to reproduce the bug;
draft
Edgar Chen <echen@mozilla.com> - Tue, 23 Jun 2020 01:00:50 +0200 - rev 2999935
Push
558585 by echen@mozilla.com at Tue, 23 Jun 2020 23:25:37 +0000
7348a86c16777afb6e3dfa9324f596ead2ae512e: try_task_config for https://phabricator.services.mozilla.com/D80528
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:23:41 +0000 - rev 2999934
Push
558584 by reviewbot at Tue, 23 Jun 2020 23:23:54 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80528
Differential Diff: PHID-DIFF-2umiakteaz6pwnge3ivq
b93aaac1a67982d34491dfbb146612919a202fd7: Bug 1618013 - Enable backdrop-filter for early beta r=emilio
draft
Erik Nordin <nordzilla@mozilla.com> - Tue, 23 Jun 2020 23:23:36 +0000 - rev 2999933
Push
558584 by reviewbot at Tue, 23 Jun 2020 23:23:54 +0000
Bug 1618013 - Enable backdrop-filter for early beta r=emilio
Summary:
Resolution from intent-to-ship discussion is to release for early beta or earlier.
Differential Revision:
https://phabricator.services.mozilla.com/D80528
Test Plan:
Reviewers: emilio
Subscribers:
Bug #: 1618013
Differential Diff: PHID-DIFF-2umiakteaz6pwnge3ivq
978f870dd05e108a17d170b3f87f9b51c14fad21: try_task_config for https://phabricator.services.mozilla.com/D80765
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Tue, 23 Jun 2020 23:16:16 +0000 - rev 2999932
Push
558583 by reviewbot at Tue, 23 Jun 2020 23:16:43 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80765
Differential Diff: PHID-DIFF-4evtkaxmc6asimavrfwc
1a0a40ca3c49ffc439f54ed019adffbb6b2ebf99: Bug 1631991 - stop wasting minutes of infra time waiting for the startup cache in gtests, r?Mossop!,dthayer!
draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 23 Jun 2020 23:16:09 +0000 - rev 2999931
Push
558583 by reviewbot at Tue, 23 Jun 2020 23:16:43 +0000
Bug 1631991 - stop wasting minutes of infra time waiting for the startup cache in gtests, r?Mossop!,dthayer!
Summary:
Test Plan:
Reviewers: Mossop!, dthayer!
Subscribers:
Bug #: 1631991
Differential Diff: PHID-DIFF-4evtkaxmc6asimavrfwc