1b3fa97cca4c63b291a91239f18fbb9bd5d29c40: Bug 1655389 - part 1: Move `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` into `AutoBlockElementJoiner` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:23 +0000 - rev 3100990
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655389 - part 1: Move `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` into `AutoBlockElementJoiner` r=m_kato!
Summary:
Same as the patch for
bug 1655391, this patch splits the method to 2 parts.
One is to consider content nodes to join or a `<br>` element to delete instead.
Note that this patch changes the behavior a little. That is, when the other
block is not editable, it throws an exception here:
https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/editor/libeditor/HTMLEditSubActionHandler.cpp#3124
But it should just cancel the edit action. Therefore, some tests in
BrowserScope are fixed by this patch. I.e., result of DOM tree in the
situation isn't changed, but stops throwing unnecessary exception.
Depends on D85567
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655389
Differential Diff: PHID-DIFF-rh5qimiyk5fh2jnpimy5
620d38fcfbbedfcf777c6a3b649e909b1370c7d2: Bug 1655391 - Make new stack only class handle deletion at current block boundary r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:21 +0000 - rev 3100989
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655391 - Make new stack only class handle deletion at current block boundary r=m_kato!
Summary:
This patch creates new stack only class, `HTMLEditor::AutoBlockElementsJoiner`
and splits `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()`
to considering the content nodes to be joined part and doing join the nodes
part.
Depends on D85534
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655391
Differential Diff: PHID-DIFF-xpmj3xrkj7njgekgfnzh
f17ad39c80d61a78ac08dd50396f9444936e9dac: Bug 1655706 - part 3-2: Move `AutoTransactionsConserveSelection` in `HTMLEditor::TryToJoinBlocksWithTransaction()` into each `WhiteSpaceVisibilityKeeper` method r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:18 +0000 - rev 3100988
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 3-2: Move `AutoTransactionsConserveSelection` in `HTMLEditor::TryToJoinBlocksWithTransaction()` into each `WhiteSpaceVisibilityKeeper` method r=m_kato!
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D85534
Depends on D85533
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-iyzh572evtldimtm4frv
b155a4ba1f64be2b3c7431a8a97fc2c242985063: Bug 1655706 - part 3-1: Move the last block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:15 +0000 - rev 3100987
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 3-1: Move the last block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato!
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D85533
Depends on D85532
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-gwdy2hn2eke5iz2c2kgj
b634a4cf37fa35187e5d0d541fdc89ae6b05fdb7: Bug 1655706 - part 2-2: Move 2nd block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:12 +0000 - rev 3100986
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 2-2: Move 2nd block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato!
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D85532
Depends on D85531
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-4lr3n27eckpmwv776rak
e5397cb7d6cafff2bc5adf3fc7f74821f3a4d540: Bug 1655706 - part 2-1: Make `HTMLEditor::TryToJoinBlocksWithTransaction()` stop using `leftListElement` and `rightListElement` after initializing `newListElementTagNameOfRightListElement` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:09 +0000 - rev 3100985
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 2-1: Make `HTMLEditor::TryToJoinBlocksWithTransaction()` stop using `leftListElement` and `rightListElement` after initializing `newListElementTagNameOfRightListElement` r=m_kato!
Summary:
`rightListElement` is not used, so, we can put it into smaller scope.
`leftListElement` is used for storing original `leftBlockElement` when
`newListElementTagNameOfRightListElement` is some. Therefore, we can
stop using it with caching the original `leftBlockElement` before
maybe modified its value.
Differential Revision:
https://phabricator.services.mozilla.com/D85531
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-wncrlbyae3ol3qoef36u
17a73e7f17f01ae620eb238bab8af6a5eca00e11: Bug 1655706 - part 1-3: Get rid of `WhiteSpaceVisibilityKeeper::PrepareToJoinNodes()` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:06 +0000 - rev 3100984
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 1-3: Get rid of `WhiteSpaceVisibilityKeeper::PrepareToJoinNodes()` r=m_kato!
Summary:
Now, the new method,
`WhiteSpaceVisibilityKeeper::MergeFirstLineOfRightBlockElementIntoLeftBlockElement()`
is the only user of the method so that we can get rid of it since it does enough
simple thing.
Depends on D85529
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-dvlxxxnsnuq66whatm4w
c85a1e81a3499a335680154f801ee7df2f27ff8e: Bug 1655706 - part 1-2: Move last part of `HTMLEditor::TryToJoinBlocksWithTransaction()` to `WhiteSpaceVisibilityKeeper` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:03 +0000 - rev 3100983
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 1-2: Move last part of `HTMLEditor::TryToJoinBlocksWithTransaction()` to `WhiteSpaceVisibilityKeeper` r=m_kato!
Summary:
Depends on D85528
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-7bikskduw4mplmmiajdc
0da654536411a75368ebf067e16867d9ae7c8d74: Bug 1655706 - part 1-1: Move `HTMLEditor::GetInvisibleBRElementAt()` to `WSRunScanner` r=m_kato!
draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:56:00 +0000 - rev 3100982
Push
577961 by reviewbot at Sun, 02 Aug 2020 12:56:49 +0000
Bug 1655706 - part 1-1: Move `HTMLEditor::GetInvisibleBRElementAt()` to `WSRunScanner` r=m_kato!
Summary:
And the name is wrong. It depends on `aPoint` whether the `<br>` element is
visible or invisible because it just scans preceding `<br>` element but
stop doing it when it meets a visible content. Therefore, this patch renames
it to explain what it does.
Test Plan:
Reviewers: m_kato!
Subscribers:
Bug #: 1655706
Differential Diff: PHID-DIFF-toygl3fsgenaegnr33w6
d54918402f765dbe6fcc1c64f2350d26d2f78cae: try_task_config for https://phabricator.services.mozilla.com/D85680
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 12:50:55 +0000 - rev 3100981
Push
577960 by reviewbot at Sun, 02 Aug 2020 12:51:13 +0000
try_task_config for
https://phabricator.services.mozilla.com/D85680
Differential Diff: PHID-DIFF-g6totzk3eebn4es6v2qu
ecdaef9f1f1d1b4b4970a5bf6b204862f3e3535c: Bug 1651090 - Disable marAppApplyUpdateAppBinInUseStageSuccessSvc_win.js on ccov cause of permafailing. r=bytesized,aryx
draft
Cosmin Sabou <csabou@mozilla.com> - Sun, 02 Aug 2020 12:50:51 +0000 - rev 3100980
Push
577960 by reviewbot at Sun, 02 Aug 2020 12:51:13 +0000
Bug 1651090 - Disable marAppApplyUpdateAppBinInUseStageSuccessSvc_win.js on ccov cause of permafailing. r=bytesized,aryx
Summary:
Test Plan:
Reviewers: bytesized, aryx
Subscribers:
Bug #: 1651090
Differential Diff: PHID-DIFF-g6totzk3eebn4es6v2qu
3303a77b3812b3757e63084c37d2bdf420244227: try_task_config for https://phabricator.services.mozilla.com/D85679
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 12:47:20 +0000 - rev 3100979
Push
577959 by reviewbot at Sun, 02 Aug 2020 12:47:37 +0000
try_task_config for
https://phabricator.services.mozilla.com/D85679
Differential Diff: PHID-DIFF-3get37eqbrka5jixjaed
db8b771a4f41206b78550d929499470dd63801d2: Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio
draft
Sylvestre Ledru <sledru@mozilla.com> - Sun, 02 Aug 2020 12:47:16 +0000 - rev 3100978
Push
577959 by reviewbot at Sun, 02 Aug 2020 12:47:37 +0000
Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio
Summary:
# ignore-this-changeset
Depends on D85678
Test Plan:
Reviewers: emilio
Subscribers:
Bug #: 1617369
Differential Diff: PHID-DIFF-3get37eqbrka5jixjaed
967b2bf5f833a85289636dda648e503bc5f530c1: Bug 1519636 - Reformat recent changes to the Google coding style r?andi
draft
Sylvestre Ledru <sledru@mozilla.com> - Sun, 02 Aug 2020 12:47:12 +0000 - rev 3100977
Push
577959 by reviewbot at Sun, 02 Aug 2020 12:47:37 +0000
Bug 1519636 - Reformat recent changes to the Google coding style r?andi
Summary:
# ignore-this-changeset
Test Plan:
Reviewers: andi
Subscribers:
Bug #: 1519636
Differential Diff: PHID-DIFF-44eg7cstilhduep74bus
2ec85a793775ce323809da553cdeff3ddcb62206: try_task_config for https://phabricator.services.mozilla.com/D85678
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 12:46:21 +0000 - rev 3100976
Push
577958 by reviewbot at Sun, 02 Aug 2020 12:46:36 +0000
try_task_config for
https://phabricator.services.mozilla.com/D85678
Differential Diff: PHID-DIFF-44eg7cstilhduep74bus
d7795b19273e472da36eb87c85867493cc4af45f: Bug 1519636 - Reformat recent changes to the Google coding style r?andi
draft
Sylvestre Ledru <sledru@mozilla.com> - Sun, 02 Aug 2020 12:46:17 +0000 - rev 3100975
Push
577958 by reviewbot at Sun, 02 Aug 2020 12:46:36 +0000
Bug 1519636 - Reformat recent changes to the Google coding style r?andi
Summary:
# ignore-this-changeset
Test Plan:
Reviewers: andi
Subscribers:
Bug #: 1519636
Differential Diff: PHID-DIFF-44eg7cstilhduep74bus
dee9a3fb15366ad034ba9410839c204877af12a3: try_task_config for https://phabricator.services.mozilla.com/D85579
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 11:59:10 +0000 - rev 3100974
Push
577957 by reviewbot at Sun, 02 Aug 2020 11:59:30 +0000
try_task_config for
https://phabricator.services.mozilla.com/D85579
Differential Diff: PHID-DIFF-cknl5tjnvrmaudllvv4z
818f5426853a3863aadd6abd090e539da522fb93: Bug 1653436 - Some urlbar providers should check whether the query was canceled in isActive. r=adw
draft
Marco Bonardo <mbonardo@mozilla.com> - Sun, 02 Aug 2020 11:59:07 +0000 - rev 3100973
Push
577957 by reviewbot at Sun, 02 Aug 2020 11:59:30 +0000
Bug 1653436 - Some urlbar providers should check whether the query was canceled in isActive. r=adw
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D85579
Test Plan:
Reviewers: adw
Subscribers:
Bug #: 1653436
Differential Diff: PHID-DIFF-cknl5tjnvrmaudllvv4z
207ad8091100ea6dfe36b060d867ea89990d2b58: try_task_config for https://phabricator.services.mozilla.com/D85579
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 11:56:01 +0000 - rev 3100972
Push
577956 by reviewbot at Sun, 02 Aug 2020 11:56:16 +0000
try_task_config for
https://phabricator.services.mozilla.com/D85579
Differential Diff: PHID-DIFF-oe3fjmey6txoqtzru3u5
8bfbf55c786c75141af616f2cb8d3c7946656bb7: Bug 1653436 - Some urlbar providers should check whether the query was canceled in isActive. r=adw
draft
Marco Bonardo <mbonardo@mozilla.com> - Sun, 02 Aug 2020 11:55:57 +0000 - rev 3100971
Push
577956 by reviewbot at Sun, 02 Aug 2020 11:56:16 +0000
Bug 1653436 - Some urlbar providers should check whether the query was canceled in isActive. r=adw
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D85579
Test Plan:
Reviewers: adw
Subscribers:
Bug #: 1653436
Differential Diff: PHID-DIFF-oe3fjmey6txoqtzru3u5
