14f3d193f41ad370afd6464a92ecd10e7468abb0: Bug 1688092 - Update ODoHConfigs when the TTL expires r=necko-reviewers,valentin
Kershaw Chang <kershaw@mozilla.com> - Thu, 25 Feb 2021 13:07:04 +0000 - rev 3567578
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1688092 - Update ODoHConfigs when the TTL expires r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D106075
42a0836eca0b23e2408167a2f986591a936cccb3: Bug 1688864 - P2: Add more tests for ODoH r=necko-reviewers,valentin
Kershaw Chang <kershaw@mozilla.com> - Thu, 25 Feb 2021 13:07:04 +0000 - rev 3567577
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1688864 - P2: Add more tests for ODoH r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D106074
06cec62d607c0c7e8dae51b5f24584a96913d112: Bug 1688864 - P1: Reduce duplicate test code for ODoH r=valentin
Kershaw Chang <kershaw@mozilla.com> - Thu, 25 Feb 2021 13:07:03 +0000 - rev 3567576
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1688864 - P1: Reduce duplicate test code for ODoH r=valentin Differential Revision: https://phabricator.services.mozilla.com/D106073
1b7367a27d9ab527d63ef8eac7af1111ab0eb7b9: Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:16 +0000 - rev 3567575
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694886 - [devtools] Extract test helper getTargetForTab(tab) to shared-head.js r=nchevobbe Depends on D106037 Differential Revision: https://phabricator.services.mozilla.com/D106405
d5a70a3143adb4cfee1e63f0da10f56abee6289f: Bug 1694140 - [devtools] Rename TargetFactory to TabTargetFactory and update filename r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:16 +0000 - rev 3567574
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Rename TargetFactory to TabTargetFactory and update filename r=ochameau Depends on D106032 Differential Revision: https://phabricator.services.mozilla.com/D106037
74adaced5c0a1ee324ac02332fb8cbdf6f765732: Bug 1694140 - [devtools] Stop using TargetFactory:forTab in netmonitor to retrieve the parent toolbox r=bomsy,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:15 +0000 - rev 3567573
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Stop using TargetFactory:forTab in netmonitor to retrieve the parent toolbox r=bomsy,ochameau Depends on D106002 The goal is to reduce the usage of the getToolbox(target) API. It feels like exposing toolbox on the connector should be a more straightforward way of achieving the same thing? Differential Revision: https://phabricator.services.mozilla.com/D106032
0b8f857e3f90697a7c74b5c4a81ea4e2c1bbdda5: Bug 1694140 - [devtools] Remove unused getTargetForTab helper on gDevTools r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:15 +0000 - rev 3567572
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Remove unused getTargetForTab helper on gDevTools r=ochameau Depends on D106001 This is only used internally: https://searchfox.org/mozilla-central/search?path=&q=getTargetForTab Can be inlined and removed from DevToolsShim Differential Revision: https://phabricator.services.mozilla.com/D106002
45a8dc952abadb4d70d16d8b35eee3c1b34bcf09: Bug 1694140 - [devtools] Stop using TargetFactory.forTab outside of devtools r=rpl,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:14 +0000 - rev 3567571
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Stop using TargetFactory.forTab outside of devtools r=rpl,ochameau Depends on D106000 Differential Revision: https://phabricator.services.mozilla.com/D106001
299f17e9cb6f978cc1c9d8e8a1ef7af062454230: Bug 1694140 - [devtools] Stop using TargetFactory forTab in devtools browser mochitests r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:14 +0000 - rev 3567570
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Stop using TargetFactory forTab in devtools browser mochitests r=nchevobbe Depends on D105999 This patch is mostly a mechanical rewrite of: ```lang=javascript const target = await TargetFactory.forTab(tab); const toolbox = await gDevTools.showToolbox(target, "inspector"); ``` to ```lang=javascript const toolbox = await gDevTools.showToolboxForTab(tab, { toolId: "inspector" }); ``` The main changes are: - if the target was actually used in the test, it is now retrieved from toolbox.target - the arguments for showToolboxForTab are using an option argument, to avoid the occasional showToolbox("inspector", null, null, null, startTime, null, reason); I suspect that any signature rewrite mistake would have been caught on try. There a few less mechanical changes: - devtools/client/framework/test/browser_toolbox_screenshot_tool.js the toolId "console" was omitted because this id doesn't match any tool (author probably meant "webconsole") - a few tests were: 1/ first creating a target, 2/ looping on tool definitions to get supported tools 3/ opening the toolbox with each supported tool. To support this I extracted a helper called `getSupportedToolIds` which opens a temporary toolbox to list all supported tool ids - all the tests under storage/ use a single helper to start the test, which can open toolboxes for both tab targets and other targets. This made it more complicated to refactor. We could also drop this part and just refactor each test when we actually modify forTab/showToolbox to only work with descriptors All in all the goal of this stack is to pave the way to stop handling targets when using forTab/showToolbox, and behind the scenes stop replying on targets to cache open toolboxes. We don't aim to kill all the call sites, just get them to a smaller number so that the next refactors will be easier. Differential Revision: https://phabricator.services.mozilla.com/D106000
6beb9dd48ef31efa258e021ad630f74ffaad502c: Bug 1694140 - [devtools] Stop using TargetFactory.forTab in devtools code r=perftest-reviewers,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:14 +0000 - rev 3567569
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Stop using TargetFactory.forTab in devtools code r=perftest-reviewers,ochameau Depends on D105998 Differential Revision: https://phabricator.services.mozilla.com/D105999
5f6688e8fe4c74aba67a6e317cd2d52480c38051: Bug 1694140 - [devtools] Add getToolboxForTab and closeToolboxForTab helpers on gDevTools r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:13 +0000 - rev 3567568
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694140 - [devtools] Add getToolboxForTab and closeToolboxForTab helpers on gDevTools r=ochameau Depends on D105743 Differential Revision: https://phabricator.services.mozilla.com/D105998
ae1fa0484c9198e35dd5220ca6a994d42608ce34: Bug 1688688 - Use showToolboxTab to open DevTools in wpt marionetteexecutor r=jgraham
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:13 +0000 - rev 3567567
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1688688 - Use showToolboxTab to open DevTools in wpt marionetteexecutor r=jgraham Depends on D105740 WPT runner can target several older versions of Firefox, so only use the new showToolboxForTab when the API is available on DevToolsShim Differential Revision: https://phabricator.services.mozilla.com/D105743
8a0f5c24ed9a7ce205cdc6d48bada3e302b60aaf: Bug 1688688 - [devtools] Add a simple helper to start devtools for wptrunner r=ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 25 Feb 2021 12:58:12 +0000 - rev 3567566
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1688688 - [devtools] Add a simple helper to start devtools for wptrunner r=ladybenko The webplatform test runner recently added an option to open devtools during their tests. The current implementation relies on TargetFactory::forTab and gDevTools::showToolbox. Those methods will most likely change as we move away from targets and start using descriptors. See previous WPT PR at https://github.com/web-platform-tests/wpt/pull/27309 Differential Revision: https://phabricator.services.mozilla.com/D105740
598f53de79bad32d07bdc1d7312944ef43f55b72: Bug 1694457 - Add pref for reporting confirmation event telemetry r=nhnt11,necko-reviewers,dragana
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 25 Feb 2021 12:52:28 +0000 - rev 3567565
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1694457 - Add pref for reporting confirmation event telemetry r=nhnt11,necko-reviewers,dragana Differential Revision: https://phabricator.services.mozilla.com/D106264
50e993a9a4a972df1c5fdeca2167d01fb0d92d4f: Backed out 2 changesets (bug 1684139) for causing xpcshell failures in test_subprocess.js
Mihai Alexandru Michis <malexandru@mozilla.com> - Thu, 25 Feb 2021 14:47:15 +0200 - rev 3567564
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Backed out 2 changesets (bug 1684139) for causing xpcshell failures in test_subprocess.js CLOSED TREE Backed out changeset 52cfd9509136 (bug 1684139) Backed out changeset 23e0fa285d90 (bug 1684139)
fd7b7fe57ef1c66b51a74cef195a04e438979b6e: Bug 1692330 - Hide the 'Add a keyword for this search' when inside of a login form. r=Gijs
Jared Wein <jwein@mozilla.com> - Thu, 25 Feb 2021 12:15:23 +0000 - rev 3567563
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1692330 - Hide the 'Add a keyword for this search' when inside of a login form. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D106314
36b76c196497ca9fa8ac4a95a651feffa5cad7ad: Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Neil Deakin <neil@mozilla.com> - Thu, 25 Feb 2021 12:00:39 +0000 - rev 3567562
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D105750
e400022129beb9b14d46cf6cede7c0c23beec3c6: Bug 1690570 - Batch JS Shell tests on Android to run a single ADB command. r=tcampbell
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Thu, 25 Feb 2021 11:47:27 +0000 - rev 3567561
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1690570 - Batch JS Shell tests on Android to run a single ADB command. r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D105039
6ce356a954731ef79c6986567679c29f4d6aad2e: Bug 1690570 - Fix python style in gdb/run-tests.py . r=tcampbell
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Thu, 25 Feb 2021 11:47:27 +0000 - rev 3567560
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1690570 - Fix python style in gdb/run-tests.py . r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D105038
ac8e8e6cf77ca55513756b737568c1732204fc11: Bug 1692253 - Create a thread to handle ADB process timeout. r=jmaher,gbrown
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Thu, 25 Feb 2021 11:47:26 +0000 - rev 3567559
Push 660125 by wptsync@mozilla.com at Thu, 25 Feb 2021 15:04:10 +0000
Bug 1692253 - Create a thread to handle ADB process timeout. r=jmaher,gbrown This change add the ability to yield the output as it is produced, by creating a thread responsible for killing the process if it takes too long. This way we can loop with blocking I/O on stdout in python, while the process is running concurrently. The loop ends when the process exit either by itself or after being killed by the timeout. Differential Revision: https://phabricator.services.mozilla.com/D105037
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip