0f288622573965bb5a69c94bb77bbf1572ea0ae8: Bug 1502355 - React to a read promise that rejects. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:39:40 +0000 - rev 3000090
Push
558621 by reviewbot at Wed, 24 Jun 2020 00:40:00 +0000
Bug 1502355 - React to a read promise that rejects. r=arai!
Summary:
Depends on D80779
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-rwipdgl4644wo3qc6kgq
eb30b1a744195c7123b74b59db3ce50a28488897: Bug 1502355 - Implement |WritableStreamDefaultWriterCloseWithErrorPropagation|. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:39:37 +0000 - rev 3000089
Push
558621 by reviewbot at Wed, 24 Jun 2020 00:40:00 +0000
Bug 1502355 - Implement |WritableStreamDefaultWriterCloseWithErrorPropagation|. r=arai!
Summary:
Depends on D80778
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-nghuh7k5ub5dlbs6sp44
73c1350cea85b0a31d0d600ad024e909f0f71656: Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:39:35 +0000 - rev 3000088
Push
558621 by reviewbot at Wed, 24 Jun 2020 00:40:00 +0000
Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
Summary:
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-haffbf46h7omjf6badf6
da5cc4b7ae53ae612d0baa1c678a44f0ae9413b4: try_task_config for https://phabricator.services.mozilla.com/D80779
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 00:39:03 +0000 - rev 3000087
Push
558620 by reviewbot at Wed, 24 Jun 2020 00:39:19 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80779
Differential Diff: PHID-DIFF-nghuh7k5ub5dlbs6sp44
abb77af91a95c1c5545f95fb85b024257d8863cb: Bug 1502355 - Implement |WritableStreamDefaultWriterCloseWithErrorPropagation|. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:39:00 +0000 - rev 3000086
Push
558620 by reviewbot at Wed, 24 Jun 2020 00:39:19 +0000
Bug 1502355 - Implement |WritableStreamDefaultWriterCloseWithErrorPropagation|. r=arai!
Summary:
Depends on D80778
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-nghuh7k5ub5dlbs6sp44
6d8e8bf4af24a082d420a5a48578acec018f1689: Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:38:57 +0000 - rev 3000085
Push
558620 by reviewbot at Wed, 24 Jun 2020 00:39:19 +0000
Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
Summary:
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-haffbf46h7omjf6badf6
af11935335eaea21ddc338d63f0430b8eb805d27: try_task_config for https://phabricator.services.mozilla.com/D80778
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 00:37:44 +0000 - rev 3000084
Push
558619 by reviewbot at Wed, 24 Jun 2020 00:38:21 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80778
Differential Diff: PHID-DIFF-haffbf46h7omjf6badf6
77d91c3506173507864fe937b9250671f3dfd43c: Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
draft
Jeff Walden <jwalden@mit.edu> - Wed, 24 Jun 2020 00:37:41 +0000 - rev 3000083
Push
558619 by reviewbot at Wed, 24 Jun 2020 00:38:21 +0000
Bug 1502355 - Allow handler functions to store an extra *value*, not merely an extra T* that's an object. r=arai!
Summary:
Test Plan:
Reviewers: arai!
Subscribers:
Bug #: 1502355
Differential Diff: PHID-DIFF-haffbf46h7omjf6badf6
1e565fe1762650ee9ce286704114a10296856969: try_task_config for https://phabricator.services.mozilla.com/D80273
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 00:37:44 +0000 - rev 3000082
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80273
Differential Diff: PHID-DIFF-efqfz73nzin7mqlny2ra
fa5435d78ecbe1d8e8be40231ab2936b58f7bde6: Bug 1646835 - move SWGL context creation into specific SWGL RenderCompositors. r?jrmuizel
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:37:40 +0000 - rev 3000081
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
Bug 1646835 - move SWGL context creation into specific SWGL RenderCompositors. r?jrmuizel
Summary:
Currently RendererOGL has mixed-in details of SWGL context creation which becomes messy
and slightly unanticipated based on the nomenclature and structure of RendererOGL. Based
on other work in
bug 1646835, it becomes more natural to move this context creation into
the specific SWGL RenderCompositors so that RendererOGL can be agnostic to any SWGL
details.
Differential Revision:
https://phabricator.services.mozilla.com/D80273
Test Plan:
Reviewers: jrmuizel
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-efqfz73nzin7mqlny2ra
4be8b47f0b55e1ba42b10c4d797b52afd0351a7e: Bug 1646835 - refactor RenderCompositorOGL into RenderCompositorNative. r?mstange
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:37:37 +0000 - rev 3000080
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
Bug 1646835 - refactor RenderCompositorOGL into RenderCompositorNative. r?mstange
Summary:
RenderCompositorOGL currently has many responsibilities including supporting
OpenGL compositor for Linux, whole-window compositing for Mac NativeLayerCA,
and per-cache-tile compositing for Mac NativeLayerCA. With the addition of
support for SWGL, this becomes even further complicated.
It becomes advantageous to separate out RenderCompositorOGL specifically as
only the basic OpenGL compositing case, as that naturally yields a simple and
isolated RenderCompositor.
What is left over becomes RenderCompositorNative, a basis for implementing
NativeLayer-based RenderCompositors. To cleanly isolate state and details of
when HW compositing or SW compositing is being used, these are further split
off into RCNativeOGL and RCNativeSWGL versions that deal with specific
isolated details of OpenGL and SWGL respectively.
RCNativeOGL deals with just setting up OpenGL FBOs for NativeLayers.
RCNativeSWGL's new task is just to deal mapping NativeLayers and providing
SWGL FBOs for them without involving OpenGL.
Differential Revision:
https://phabricator.services.mozilla.com/D80270
Depends on D80269
Test Plan:
Reviewers: mstange
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-tx6ulmxbj5afhsucaav6
3ad9af93ad667a30c71448e2240b8f5e2d2acf1e: Bug 1646835 - add MapTile/UnmapTile hooks to the WR compositor. r?mstange,gw
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:37:33 +0000 - rev 3000079
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
Bug 1646835 - add MapTile/UnmapTile hooks to the WR compositor. r?mstange,gw
Summary:
RenderCompositors for SWGL that wish to provide accelerated compositing need to
subvert the existing Bind/Unbind hooks in the WR compositor. These compositors
need to keep track of their HW tiles without actually binding an OpenGL FBO
for WR to render picture cache tiles. SWGL needs to intervene and get a backing
buffer for tile from the RenderCompositor so that it can create a SWGL FBO for
WR to render the picture cache tile to.
To that end, this adds MapTile/UnmapTile as a replacement for Bind/Unbind for
those scenarios. This is done in a way that it affects only the WrCompositor of
webrender_bindings without actually altering WR's Compositor interface. This is
beneficial because WR does not have to understand the details of SWGL
integration and also so as not to complicate other users of WR such as Servo
who are not currently utilizing SWGL at all.
RenderCompositorOGL is initially modified to use these hooks in this patch. It
later became more convenient to restructure that in a follow-up patch.
Differential Revision:
https://phabricator.services.mozilla.com/D80269
Test Plan:
Reviewers: mstange, gw
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-hsxc6o5kmmmamde7bfcj
0a6cb1d0c7171097eaf99231e8c0169aed08cd38: Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:37:30 +0000 - rev 3000078
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
Summary:
This is a first implementation of a software-only SWGL RenderCompositor
that relies on the existing widget hooks for Basic compositing. It attempts
to lock the widget and get a DT whose underlying data it can supply directly
to SWGL to composite to. Critically, it does not rely on OpenGL or any other
form of HW accel to function. The interface between the RenderCompositor and
SWGL will be further refined in follow-up patches.
Differential Revision:
https://phabricator.services.mozilla.com/D80268
Test Plan:
Reviewers: jrmuizel
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-njisgt2upwp6yjsqjkw2
b5e94a08dda2af7889c5f506ad4a5de4e158f9ac: Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:37:26 +0000 - rev 3000077
Push
558618 by reviewbot at Wed, 24 Jun 2020 00:38:07 +0000
Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
Summary:
For performance reasons in SWGL software compositors. to avoid unnecessary
full-screen copies of the framembuffer, we need to allow those compositors to
map their underlying widget surfaces and pass that buffer to SWGL so that they
can be directly rendered to. That also requires supporting custom strides, as
we can't always enforce the particular layout of the buffers handed off to us.
To that end, InitDefaultFramebuffer is generalized to take such information
and then many places where we rely on a specific hard-coded SWGL-calculated
stride have been altered to deal with a caller-supplied stride.
Differential Revision:
https://phabricator.services.mozilla.com/D80267
Test Plan:
Reviewers: jimb
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-lpuuvlesv5ekxvsspzw3
442719d769272656328fcaa190f40f2caf770df5: Try Chooser Enhanced (10 tasks selected)
draft
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 24 Jun 2020 12:36:54 +1200 - rev 3000076
Push
558617 by mwoodrow@mozilla.com at Wed, 24 Jun 2020 00:37:32 +0000
Try Chooser Enhanced (10 tasks selected)
Pushed via `mach try chooser`
9742846cc5c2e3d0bcd1982da1f153949119bdf2: fix
draft
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 24 Jun 2020 12:35:33 +1200 - rev 3000075
Push
558617 by mwoodrow@mozilla.com at Wed, 24 Jun 2020 00:37:32 +0000
fix
00b605625f24a20995fd4ebfc7c3ed1207eaa076: try_task_config for https://phabricator.services.mozilla.com/D80268
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 24 Jun 2020 00:36:13 +0000 - rev 3000074
Push
558616 by reviewbot at Wed, 24 Jun 2020 00:36:36 +0000
try_task_config for
https://phabricator.services.mozilla.com/D80268
Differential Diff: PHID-DIFF-njisgt2upwp6yjsqjkw2
cd2bf6c7df3703ff4c8dd98ba144cb6f57b4c2fa: Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:36:09 +0000 - rev 3000073
Push
558616 by reviewbot at Wed, 24 Jun 2020 00:36:36 +0000
Bug 1646835 - implement basic SWGL compositor. r?jrmuizel
Summary:
This is a first implementation of a software-only SWGL RenderCompositor
that relies on the existing widget hooks for Basic compositing. It attempts
to lock the widget and get a DT whose underlying data it can supply directly
to SWGL to composite to. Critically, it does not rely on OpenGL or any other
form of HW accel to function. The interface between the RenderCompositor and
SWGL will be further refined in follow-up patches.
Differential Revision:
https://phabricator.services.mozilla.com/D80268
Test Plan:
Reviewers: jrmuizel
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-njisgt2upwp6yjsqjkw2
875ca9832d5711d7c64de3573628849ace2a0e6e: Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
draft
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Jun 2020 00:36:05 +0000 - rev 3000072
Push
558616 by reviewbot at Wed, 24 Jun 2020 00:36:36 +0000
Bug 1646835 - allow specifying backing data and stride for SWGL default framebuffer. r?jimb
Summary:
For performance reasons in SWGL software compositors. to avoid unnecessary
full-screen copies of the framembuffer, we need to allow those compositors to
map their underlying widget surfaces and pass that buffer to SWGL so that they
can be directly rendered to. That also requires supporting custom strides, as
we can't always enforce the particular layout of the buffers handed off to us.
To that end, InitDefaultFramebuffer is generalized to take such information
and then many places where we rely on a specific hard-coded SWGL-calculated
stride have been altered to deal with a caller-supplied stride.
Differential Revision:
https://phabricator.services.mozilla.com/D80267
Test Plan:
Reviewers: jimb
Subscribers:
Bug #: 1646835
Differential Diff: PHID-DIFF-lpuuvlesv5ekxvsspzw3
d5967f92710804ce819faa58ff8ac5d44def1c39: try: -b o -p linux64-valgrind -t none -u none
draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Jun 2020 09:35:35 +0900 - rev 3000071
Push
558615 by mh@glandium.org at Wed, 24 Jun 2020 00:35:57 +0000
try: -b o -p linux64-valgrind -t none -u none