0c182ea7924882a085c06a4d581b0fa716e82fb3: Bug 1693032 - SVG text reflow can flow through multiple outer svg elements try: -b d -p linux64 -u reftest,crashtest,mochitests,web-platform-tests -t none
draft bug1693032
longsonr <longsonr@gmail.com> - Tue, 16 Feb 2021 19:54:23 +0000 - rev 3545293
Push
656177 by longsonr@gmail.com at Wed, 17 Feb 2021 13:25:41 +0000
Bug 1693032 - SVG text reflow can flow through multiple outer svg elements try: -b d -p linux64 -u reftest,crashtest,mochitests,web-platform-tests -t none
5f37c98690fcebbcac99ce97c2434869c7eb1151: Fuzzy query=web-platform-tests !macosx !shippable !asan !fis&paths=testing/web-platform/tests/infrastructure/
draft
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 17 Feb 2021 13:22:05 +0000 - rev 3545292
Push
656176 by wptsync@mozilla.com at Wed, 17 Feb 2021 13:22:37 +0000
Fuzzy query=web-platform-tests !macosx !shippable !asan !fis&paths=testing/web-platform/tests/infrastructure/
Pushed via `mach try fuzzy`
d8df89aee6ddad3d1af6f009b0f16e4409cfb8ed: Bug 1692689 [wpt PR 27620] - [appmanifest] add CORS/CSP tests for icons and shortcuts, a=testonly
draft
Christian Liebel <christian.liebel@thinktecture.com> - Wed, 17 Feb 2021 13:19:08 +0000 - rev 3545291
Push
656176 by wptsync@mozilla.com at Wed, 17 Feb 2021 13:22:37 +0000
Bug 1692689 [wpt PR 27620] - [appmanifest] add CORS/CSP tests for icons and shortcuts, a=testonly
SKIP_BMO_CHECK
wpt-commit: e6731a3248163a7fc5b6ace00937c792c4ca7a83
wpt-pr: 27620
8aea41d8d3ea9179d23c7e4d3a1565d505bd57d5: Bug 1693032 - SVG text reflow can flow through multiple outer svg elements try: -b d -p linux64 -u crashtest -t none
draft
longsonr <longsonr@gmail.com> - Tue, 16 Feb 2021 19:54:23 +0000 - rev 3545290
Push
656175 by longsonr@gmail.com at Wed, 17 Feb 2021 13:20:27 +0000
Bug 1693032 - SVG text reflow can flow through multiple outer svg elements try: -b d -p linux64 -u crashtest -t none
e4d47d943ce622b4adad46e6bbae2ee970d3b4bd: try_task_config for https://phabricator.services.mozilla.com/D104538
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 13:09:07 +0000 - rev 3545289
Push
656174 by reviewbot at Wed, 17 Feb 2021 13:09:47 +0000
try_task_config for
https://phabricator.services.mozilla.com/D104538
Differential Diff: PHID-DIFF-l5mk5e2ogoexaeo4hyh6
060e8340f4916c04571a459af4bdf39596930e0a: Bug 1677474 - wpt test;
draft
Edgar Chen <echen@mozilla.com> - Wed, 17 Feb 2021 13:09:03 +0000 - rev 3545288
Push
656174 by reviewbot at Wed, 17 Feb 2021 13:09:47 +0000
Bug 1677474 - wpt test;
Summary:
Differential Revision:
https://phabricator.services.mozilla.com/D104538
Test Plan:
Reviewers:
Subscribers:
Bug #: 1677474
Differential Diff: PHID-DIFF-l5mk5e2ogoexaeo4hyh6
a01d6f470cc70cb245e59424538b1054e5b8d590: try_task_config for https://phabricator.services.mozilla.com/D105464
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 13:07:22 +0000 - rev 3545287
Push
656173 by reviewbot at Wed, 17 Feb 2021 13:07:48 +0000
try_task_config for
https://phabricator.services.mozilla.com/D105464
Differential Diff: PHID-DIFF-cdvnzr4szqyldfpgbjcc
94becf525d8e44a86aea95b8078c1a9b41095419: Bug 1650705 - Don't dispatch unnecessary input event when we dispatch composition start with selected text. r=#geckoview-reviewers
draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 17 Feb 2021 13:07:13 +0000 - rev 3545286
Push
656173 by reviewbot at Wed, 17 Feb 2021 13:07:48 +0000
Bug 1650705 - Don't dispatch unnecessary input event when we dispatch composition start with selected text. r=#geckoview-reviewers
Summary:
Actually, before starting composition, we always remove current selected
text. So it causes that input event is fired by this operation. This is
different of Blink.
`TextEventDispatcher` can set composition string using selected text when
starting composition. So we can reduce this input event.
Also, I mistake
bug 1499076 fix. By this fix, we always fires input event
when having selected text even if it is unnecessary. This changeset has
this fix too.
Test Plan:
Reviewers: #geckoview-reviewers
Subscribers:
Bug #: 1650705
Differential Diff: PHID-DIFF-cdvnzr4szqyldfpgbjcc
426b97348853bbaed066bd7d9ea47aafab20bef2: Fuzzy query=web-platform-tests !macosx !shippable !asan !fis&paths=testing/web-platform/tests/signed-exchange/appcache/sxg-inner-resp-over-appcache.tentative.https.html:testing/web-platform/tests/signed-exchange/appcache/sxg-served-from-appcache.tentative.https.html:testing/web-platform/tests/signed-exchange/check-cert-request.tentative.html:testing/web-platform/tests/signed-exchange/fallback-to-another-sxg.tentative.html:testing/web-platform/tests/signed-exchange/nested-sxg.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-failed-zero-success-fraction.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-invalid_integrity_header.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-mi_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok-no-referrer.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok-origin-referrer.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-failed-zero-success-feaction.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-invalid_integrity_header.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-mi_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-ok.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/service-workers/sxg-sw-register-after-fallback.tentative.https.html:testing/web-platform/tests/signed-exchange/service-workers/sxg-sw-register.tentative.https.html:testing/web-platform/tests/signed-exchange/subresource/sxg-subresource-header-integrity-mismatch.tentative.html:testing/web-platform/tests/signed-exchange/subresource/sxg-subresource.tentative.html:testing/web-platform/tests/signed-exchange/sxg-data-cert-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-double-prefetch.tentative.html:testing/web-platform/tests/signed-exchange/sxg-fallback-with-fragment.tentative.html:testing/web-platform/tests/signed-exchange/sxg-hsts.tentative.html:testing/web-platform/tests/signed-exchange/sxg-inner-url-bom.tentative.html:testing/web-platform/tests/signed-exchange/sxg-invalid-utf8-inner-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-invalid-validity-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-location-fragment.tentative.html:testing/web-platform/tests/signed-exchange/sxg-location.tentative.html:testing/web-platform/tests/signed-exchange/sxg-merkle-integrity-error.tentative.html:testing/web-platform/tests/signed-exchange/sxg-navigation-timing.tentative.html:testing/web-platform/tests/signed-exchange/sxg-non-secure-origin.tentative.html:testing/web-platform/tests/signed-exchange/sxg-noncacheable.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch-merkle-integrity-error.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch-resource-timing.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-policy-header.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-remote-physical-remote-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-remote-physical-same-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-same-physical-remote-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-same-physical-same-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-utf8-inner-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-variants-match.tentative.html:testing/web-platform/tests/signed-exchange/sxg-variants-mismatch.tentative.html:testing/web-platform/tests/signed-exchange/sxg-version1b2.tentative.html
draft
moz-wptsync-bot <wptsync@mozilla.com> - Wed, 17 Feb 2021 12:58:06 +0000 - rev 3545285
Push
656172 by wptsync@mozilla.com at Wed, 17 Feb 2021 12:59:26 +0000
Fuzzy query=web-platform-tests !macosx !shippable !asan !fis&paths=testing/web-platform/tests/signed-exchange/appcache/sxg-inner-resp-over-appcache.tentative.https.html:testing/web-platform/tests/signed-exchange/appcache/sxg-served-from-appcache.tentative.https.html:testing/web-platform/tests/signed-exchange/check-cert-request.tentative.html:testing/web-platform/tests/signed-exchange/fallback-to-another-sxg.tentative.html:testing/web-platform/tests/signed-exchange/nested-sxg.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_fetch_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-cert_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-failed-zero-success-fraction.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-invalid_integrity_header.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-mi_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok-no-referrer.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok-origin-referrer.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-ok.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-navigation-signature_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_fetch_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-cert_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-failed-zero-success-feaction.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-invalid_integrity_header.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-mi_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-ok.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-parse_error.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error-downgraded.tentative.html:testing/web-platform/tests/signed-exchange/reporting/sxg-reporting-prefetch-signature_verification_error.tentative.html:testing/web-platform/tests/signed-exchange/service-workers/sxg-sw-register-after-fallback.tentative.https.html:testing/web-platform/tests/signed-exchange/service-workers/sxg-sw-register.tentative.https.html:testing/web-platform/tests/signed-exchange/subresource/sxg-subresource-header-integrity-mismatch.tentative.html:testing/web-platform/tests/signed-exchange/subresource/sxg-subresource.tentative.html:testing/web-platform/tests/signed-exchange/sxg-data-cert-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-double-prefetch.tentative.html:testing/web-platform/tests/signed-exchange/sxg-fallback-with-fragment.tentative.html:testing/web-platform/tests/signed-exchange/sxg-hsts.tentative.html:testing/web-platform/tests/signed-exchange/sxg-inner-url-bom.tentative.html:testing/web-platform/tests/signed-exchange/sxg-invalid-utf8-inner-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-invalid-validity-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-location-fragment.tentative.html:testing/web-platform/tests/signed-exchange/sxg-location.tentative.html:testing/web-platform/tests/signed-exchange/sxg-merkle-integrity-error.tentative.html:testing/web-platform/tests/signed-exchange/sxg-navigation-timing.tentative.html:testing/web-platform/tests/signed-exchange/sxg-non-secure-origin.tentative.html:testing/web-platform/tests/signed-exchange/sxg-noncacheable.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch-merkle-integrity-error.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch-resource-timing.tentative.html:testing/web-platform/tests/signed-exchange/sxg-prefetch.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-policy-header.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-remote-physical-remote-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-remote-physical-same-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-same-physical-remote-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-referrer-same-physical-same-logical.tentative.https.html:testing/web-platform/tests/signed-exchange/sxg-utf8-inner-url.tentative.html:testing/web-platform/tests/signed-exchange/sxg-variants-match.tentative.html:testing/web-platform/tests/signed-exchange/sxg-variants-mismatch.tentative.html:testing/web-platform/tests/signed-exchange/sxg-version1b2.tentative.html
Pushed via `mach try fuzzy`
58c04f54591f5440b35564318d6330287de3dbe7: Bug 1692938 [wpt PR 27637] - Increase timeout of openSXGInIframeAndWaitForMessage, a=testonly
draft
Tsuyoshi Horo <horo@chromium.org> - Wed, 17 Feb 2021 12:55:21 +0000 - rev 3545284
Push
656172 by wptsync@mozilla.com at Wed, 17 Feb 2021 12:59:26 +0000
Bug 1692938 [wpt PR 27637] - Increase timeout of openSXGInIframeAndWaitForMessage, a=testonly
SKIP_BMO_CHECK
Some tests which use openSXGInIframeAndWaitForMessage() fail on mac
10.15 debug bots. This is because the debug binary is very slow.
So loading a cross origin iframe that requires a new process takes
longer than 3000 ms.
This CL changes openSXGInIframeAndWaitForMessage() to use 10 sec timeout
same as service-workers/service-worker/fetch-frame-resource.https.html.
And also adds <meta name="timeout" content="long"> tag in some tests
where the iframe load is expected to fail.
Bug: 1177883
Change-Id: Iee8a94bddf58d5f9a8113f30c14cff43a6119d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2694296
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854144}
wpt-commit: 0f7132e3cc841c99f8f6406779502bab2af2fd00
wpt-pr: 27637
82dba868ed57830e37db29989b10aab1fed8848b: try_task_config for https://phabricator.services.mozilla.com/D105301
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 12:58:20 +0000 - rev 3545283
Push
656171 by reviewbot at Wed, 17 Feb 2021 12:59:13 +0000
try_task_config for
https://phabricator.services.mozilla.com/D105301
Differential Diff: PHID-DIFF-il44i5tocepvtkq6tl54
51cef2d1cfeebe8415625922c4405fcefb54d368: Bug 1692903 - Add gtest. r?padenot
draft
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Feb 2021 12:58:15 +0000 - rev 3545282
Push
656171 by reviewbot at Wed, 17 Feb 2021 12:59:13 +0000
Bug 1692903 - Add gtest. r?padenot
Differential Revision:
https://phabricator.services.mozilla.com/D105301
Differential Diff: PHID-DIFF-il44i5tocepvtkq6tl54
f58a402829c0b8deb2fd8b7a77a32f149dc27649: No try selector specified, use "Add New Jobs" to select tasks.
draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 17 Feb 2021 23:58:08 +1100 - rev 3545281
Push
656170 by gsquelart@mozilla.com at Wed, 17 Feb 2021 12:58:29 +0000
No try selector specified, use "Add New Jobs" to select tasks.
Pushed via `mach try empty`
74f5710c7dc4356a9ef91e78bafd57ac0f20dac6: try_task_config for https://phabricator.services.mozilla.com/D105463
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 12:57:29 +0000 - rev 3545280
Push
656169 by reviewbot at Wed, 17 Feb 2021 12:57:55 +0000
try_task_config for
https://phabricator.services.mozilla.com/D105463
Differential Diff: PHID-DIFF-7ab2soohzbvdobcutztp
d99762a70e86617b9be3f2a26d471da00463567b: Bug 1693144 - [devtools] Fallback to the initial javascriptEnabled value from the target
draft
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Feb 2021 12:57:19 +0000 - rev 3545279
Push
656169 by reviewbot at Wed, 17 Feb 2021 12:57:55 +0000
Bug 1693144 - [devtools] Fallback to the initial javascriptEnabled value from the target
Differential Diff: PHID-DIFF-7ab2soohzbvdobcutztp
68faf4e68935d6abce523973922ed7215deac903: try_task_config for https://phabricator.services.mozilla.com/D105301
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 12:54:37 +0000 - rev 3545278
Push
656168 by reviewbot at Wed, 17 Feb 2021 12:55:03 +0000
try_task_config for
https://phabricator.services.mozilla.com/D105301
Differential Diff: PHID-DIFF-o65fa7iwvoc5oiesantp
ecc31eb5a986f7ae393c9d086770fcbb4d9ee2f3: Bug 1692903 - Add gtest. r?padenot
draft
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Feb 2021 12:54:28 +0000 - rev 3545277
Push
656168 by reviewbot at Wed, 17 Feb 2021 12:55:03 +0000
Bug 1692903 - Add gtest. r?padenot
Differential Revision:
https://phabricator.services.mozilla.com/D105301
Differential Diff: PHID-DIFF-o65fa7iwvoc5oiesantp
530bef81dfb9647a7492ddb5af12b3bf78b0f17f: try_task_config for https://phabricator.services.mozilla.com/D105302
draft
libmozevent <release-mgmt-analysis@mozilla.com> - Wed, 17 Feb 2021 12:54:01 +0000 - rev 3545276
Push
656167 by reviewbot at Wed, 17 Feb 2021 12:54:22 +0000
try_task_config for
https://phabricator.services.mozilla.com/D105302
Differential Diff: PHID-DIFF-ick4oska22towsuq4jkl
a052beb91549f9fe9007c7edc562ead435fa9a92: Bug 1692903 - Set mLiveFramesAppended in NotifyInputData instead of the first Pull. r?padenot
draft
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Feb 2021 12:53:57 +0000 - rev 3545275
Push
656167 by reviewbot at Wed, 17 Feb 2021 12:54:22 +0000
Bug 1692903 - Set mLiveFramesAppended in NotifyInputData instead of the first Pull. r?padenot
In a case where the packetizer is used and NotifyInputData receives less than a
full packet on the first notification, the first Pull of input data will not
happen during the same iteration.
During the iteration where the first Pull of input data happens, commonly the
following iteration, the appropriate amount of buffering will be calculated.
This calculation will fail to accomodate the silence added in the Pulls since
input data was added to the packetizer but where no input data was pulled.
Thus when input data is pulled we get more than expected out of the packetizer,
and this sets off an assert.
In practice on a non-debug build this patch means that latency is consistently
low (10ms + 128 frames with the packetizer, 128 frames without). Without this
patch it could be up to a packet (10ms) higher when using the packetizer.
Differential Revision:
https://phabricator.services.mozilla.com/D105302
Differential Diff: PHID-DIFF-ick4oska22towsuq4jkl
eecd73beefe52f585982c30cdb4dbe2f00be2007: Bug 1692903 - Add gtest. r?padenot
draft
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Feb 2021 12:53:54 +0000 - rev 3545274
Push
656167 by reviewbot at Wed, 17 Feb 2021 12:54:22 +0000
Bug 1692903 - Add gtest. r?padenot
Differential Revision:
https://phabricator.services.mozilla.com/D105301
Differential Diff: PHID-DIFF-o65fa7iwvoc5oiesantp