0bfe17ea1d787b594703ea6d389783247b012f31: Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r?gw draft
Timothy Nikkel <tnikkel@gmail.com> - Sat, 01 Aug 2020 17:23:53 -0500 - rev 3100950
Push 577950 by tnikkel@gmail.com at Sun, 02 Aug 2020 08:05:57 +0000
Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r?gw Pretty straight forward, mostly just plumbing stuff through. Differential Revision: https://phabricator.services.mozilla.com/D85666
c4609a6751065fdb37bb8c915b1a29a8291b22ee: try_task_config for https://phabricator.services.mozilla.com/D85666 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Sun, 02 Aug 2020 08:02:30 +0000 - rev 3100949
Push 577949 by reviewbot at Sun, 02 Aug 2020 08:02:46 +0000
try_task_config for https://phabricator.services.mozilla.com/D85666 Differential Diff: PHID-DIFF-zvou7q6pgdkk6xj5wca6
09a83f91bfaa27edc00e5ff2844b8dd7881a0e6c: Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r?gw draft
Timothy Nikkel <tnikkel@gmail.com> - Sun, 02 Aug 2020 08:02:26 +0000 - rev 3100948
Push 577949 by reviewbot at Sun, 02 Aug 2020 08:02:46 +0000
Bug 1656711. Support hardware accelerated <feGaussianBlur> SVG filters if the x and y radius are not equal with webrender. r?gw Summary: Pretty straight forward, mostly just plumbing stuff through. Differential Revision: https://phabricator.services.mozilla.com/D85666 Test Plan: Reviewers: gw Subscribers: Bug #: 1656711 Differential Diff: PHID-DIFF-zvou7q6pgdkk6xj5wca6
2c9b9792e31ac9a790403c65bf966a2b0cea7182: Bug 1524314 - Use RAII notifier classes to simplify code try: -b do -p linux64 -u reftest,crashtest,mochitests,web-platform-tests -t none draft
longsonr <longsonr@gmail.com> - Mon, 20 Jul 2020 18:58:33 +0100 - rev 3100947
Push 577948 by longsonr@gmail.com at Sun, 02 Aug 2020 07:26:26 +0000
Bug 1524314 - Use RAII notifier classes to simplify code try: -b do -p linux64 -u reftest,crashtest,mochitests,web-platform-tests -t none Reviewers: dholbert Tags: #secure-revision Bug #: 1524314 Differential Revision: https://phabricator.services.mozilla.com/D84229
275090b8d1d0154f0658109a8a0a6b573d6dbbaa: Try Chooser Enhanced (273 tasks selected) draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 14:57:35 +0900 - rev 3100946
Push 577947 by masayuki@d-toybox.com at Sun, 02 Aug 2020 05:57:59 +0000
Try Chooser Enhanced (273 tasks selected) Pushed via `mach try chooser`
7c6ebb59223baa8825ea26f8b39ef313154ef4b7: Bug 1656430 - part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 14:47:19 +0900 - rev 3100945
Push 577947 by masayuki@d-toybox.com at Sun, 02 Aug 2020 05:57:59 +0000
Bug 1656430 - part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato This patch makes `EditorBase::DeleteSelectionWithTransaction()` a wrapper of `EditorBase::DeleteRangesWithTransaction()`.
67556ca22ca7fd11df661138eb474413ec08422c: Bug 1656430 - part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 14:03:53 +0900 - rev 3100944
Push 577947 by masayuki@d-toybox.com at Sun, 02 Aug 2020 05:57:59 +0000
Bug 1656430 - part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato This new class will be used for treating selection ranges without modifying it temporarily.
0321899ea708963551fcc844a0f512c9a0dda94c: Bug 1656430 - part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 13:22:22 +0900 - rev 3100943
Push 577947 by masayuki@d-toybox.com at Sun, 02 Aug 2020 05:57:59 +0000
Bug 1656430 - part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato
073fadf1d3486729135e7ff01dfa63e9c0d33a47: Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:33:59 +0900 - rev 3100942
Push 577947 by masayuki@d-toybox.com at Sun, 02 Aug 2020 05:57:59 +0000
Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato
cde554dc8c3431311a5b9f3054db3a442b4ab2d2: Try Chooser Enhanced (558 tasks selected) draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:36:52 +0900 - rev 3100941
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Try Chooser Enhanced (558 tasks selected) Pushed via `mach try chooser`
fa37b73769f1a37c7f3ef5c11f46a54fa5c79bf7: Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:33:59 +0900 - rev 3100940
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato
81362ab3bafa74f21637d3da24fbc0cbc74007f9: Bug 1656432 - part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` r=Gijs draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:12:50 +0900 - rev 3100939
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1656432 - part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` r=Gijs For making editor performance better and editor code simpler, I want to stop modifying `Selection` as far as possible. Therefore, I'd like to get rid of `nsIEditActionListener`. Instead, there is new API, `nsIEditActionListener::WillDeleteRanges()`. This patch rewrites `FinderHighlighter#WillDeleteSelection()` to `FinderHighlighter#WillDeleteRanges()`.
a647bd5fc48e1f46b6a45af84d5b36a62d942671: Bug 1656432 - part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:04:24 +0900 - rev 3100938
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1656432 - part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato Currently, `nsIEditActionListener::WillDeleteSelection()` notifies `FinderHighliter` of deleting selection ranges. But it's referred only the ranges, not selection object itself and editor shouldn't modify `Selection` as far as possible for reducing the runtime cost. Therefore, it should be replaced with this new API. Then, `EditorBase::WillDeleteSelectionWithTransaction()` can be rewritten as `EditorBase::WillDeleteRangesWithTransaction()` later.
4b50df7c8bdf70fedb59b2ab8f1efe576e9a0467: Bug 1655389 - part 3: Split the case deleting `<br>` element off from `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtOtherBlockBoundary()` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Jul 2020 15:22:54 +0900 - rev 3100937
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655389 - part 3: Split the case deleting `<br>` element off from `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtOtherBlockBoundary()` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85578
777169a36da17208f2f2b234f9e5092b7e1f3afc: Bug 1655389 - part 2: Move recursive call in `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` to `HTMLEditor::HandleDeleteAroundCollapsedSelection()` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Jul 2020 15:13:38 +0900 - rev 3100936
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655389 - part 2: Move recursive call in `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` to `HTMLEditor::HandleDeleteAroundCollapsedSelection()` r=m_kato! The recursive call is not safe. We should do it more carefully. For now, we should not hide the recursive call into the leaf handler. Differential Revision: https://phabricator.services.mozilla.com/D85573
c4e16ed46e007e529e43ff7b53eb506036c13fa9: Bug 1655389 - part 1: Move `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` into `AutoBlockElementJoiner` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Jul 2020 14:54:31 +0900 - rev 3100935
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655389 - part 1: Move `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` into `AutoBlockElementJoiner` r=m_kato! Same as the patch for bug 1655391, this patch splits the method to 2 parts. One is to consider content nodes to join or a `<br>` element to delete instead. Note that this patch changes the behavior a little. That is, when the other block is not editable, it throws an exception here: https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/editor/libeditor/HTMLEditSubActionHandler.cpp#3124 But it should just cancel the edit action. Therefore, some tests in BrowserScope are fixed by this patch. I.e., result of DOM tree in the situation isn't changed, but stops throwing unnecessary exception. Differential Revision: https://phabricator.services.mozilla.com/D85569
7f40abd0d85735392223abdf8ffafbefee4d98be: Bug 1655391 - Make new stack only class handle deletion at current block boundary r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 31 Jul 2020 13:36:27 +0900 - rev 3100934
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655391 - Make new stack only class handle deletion at current block boundary r=m_kato! This patch creates new stack only class, `HTMLEditor::AutoBlockElementsJoiner` and splits `HTMLEditor::HandleDeleteCollapsedSelectionAtCurrentBlockBoundary()` to considering the content nodes to be joined part and doing join the nodes part. Differential Revision: https://phabricator.services.mozilla.com/D85567
2b91c79e48a17c1cb627c261f3b1f5e4dd07d59e: Bug 1655706 - part 3-2: Move `AutoTransactionsConserveSelection` in `HTMLEditor::TryToJoinBlocksWithTransaction()` into each `WhiteSpaceVisibilityKeeper` method r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Jul 2020 19:57:49 +0900 - rev 3100933
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655706 - part 3-2: Move `AutoTransactionsConserveSelection` in `HTMLEditor::TryToJoinBlocksWithTransaction()` into each `WhiteSpaceVisibilityKeeper` method r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85534
325407b8f47287043674164adb5fc0618175b8b9: Bug 1655706 - part 3-1: Move the last block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Jul 2020 19:53:58 +0900 - rev 3100932
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655706 - part 3-1: Move the last block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85533
8f033bafeb9b7db4a9d4f44eb7b8666b21a57eb5: Bug 1655706 - part 2-2: Move 2nd block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Jul 2020 19:24:35 +0900 - rev 3100931
Push 577946 by masayuki@d-toybox.com at Sun, 02 Aug 2020 03:37:14 +0000
Bug 1655706 - part 2-2: Move 2nd block of `HTMLEditor::TryToJoinBlocksWithTransaction()` into `WhiteSpaceVisibilityKeeper` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85532
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip