0324c8343a37f504a981c20ee32658fbe227c09d: Bug 1656802. Add a comment explaining how overlay scrollbars work with their negative margin. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:00:59 +0000 - rev 3101270
Push 578019 by reviewbot at Mon, 03 Aug 2020 02:09:29 +0000
Bug 1656802. Add a comment explaining how overlay scrollbars work with their negative margin. r?emilio Summary: Depends on D85702 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-qocxmoilj6zta36uforq
28d688d8a6466a54914dca5f08efc207b61d9dae: Bug 1656802. Add state variables to the scroll frame to track when scrollbars are only created to scroll the visual viewport within the layout viewport. r?emilio,kats draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:00:55 +0000 - rev 3101269
Push 578019 by reviewbot at Mon, 03 Aug 2020 02:09:29 +0000
Bug 1656802. Add state variables to the scroll frame to track when scrollbars are only created to scroll the visual viewport within the layout viewport. r?emilio,kats Summary: We need to distinguish these special scrollbars for several different reasons in upcoming patches. Depends on D85701 Test Plan: Reviewers: emilio, kats Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-kgq6zqt6a7a5vberv7dr
3b99467c0edacfbb99b7d2bc453163426695bc42: Bug 1656802. Calculate if we need scrollbars to scroll the visual viewport. r?emilio,kats draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:00:51 +0000 - rev 3101268
Push 578019 by reviewbot at Mon, 03 Aug 2020 02:09:29 +0000
Bug 1656802. Calculate if we need scrollbars to scroll the visual viewport. r?emilio,kats Summary: This fixes the regression we created with the first patch. Depends on D85700 Test Plan: Reviewers: emilio, kats Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-glcac7fa5ttaf7dzffvl
1f6d4fce4c196bac8266a7bf5d2f0ac992bc4e98: Bug 1656802. Add flags that let us differentiate not showing scrollbars because something is overflow hidden from not showing scrollbars for other reasons. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:00:47 +0000 - rev 3101267
Push 578019 by reviewbot at Mon, 03 Aug 2020 02:09:29 +0000
Bug 1656802. Add flags that let us differentiate not showing scrollbars because something is overflow hidden from not showing scrollbars for other reasons. r?emilio Summary: For the former we are still allowed to show scrollbars if we need to scroll the visual viewport inside the layout viewport (as long as they take up no layout space). For the latter we still do not want to show scrollbars. The ShowScrollbar enum is now only from layouts perspective and doesn't take into account anything about the visual viewport. Depends on D85699 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-kb3odo5pwuze4tfkefli
cf24e95699ddf77af8fce4ea540458e91c55021d: Bug 1656802. When deciding if we want a scrollbar we need to consider only if the scrolled rect overflows the scrollport (not the visual viewport). r?emilio,kats draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:00:44 +0000 - rev 3101266
Push 578019 by reviewbot at Mon, 03 Aug 2020 02:09:29 +0000
Bug 1656802. When deciding if we want a scrollbar we need to consider only if the scrolled rect overflows the scrollport (not the visual viewport). r?emilio,kats Summary: This will actually regress behaviour when overflow is auto and pinch zooming creates scrollable overflow (scrolling the visual viewport inside the layout viewport). We will fix that in later patches. The reason that this is necessary is that the code as-is is incorrect if we have layout scrollbars (scrollbars that take up space). If we have layout scrollbars and we pinch zoom and we go from not needing a scrollbar to needing a scrollbar that scrollbar cannot take up layout space (even though it is a layout scrollbar). The scrollbar cannot change the size of the layout viewport (it does, however change the size of the visual viewport). In later patches we fix this situation as well as the situation with an overflow hidden document (which also needs to create scrollbars when pinch zoomed). Test Plan: Reviewers: emilio, kats Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-zmqtpsi67dh4vnm4u2uq
3f0d7b9b09a499a7f1e4f96eb499a65cbd7b7dd8: Try Chooser Enhanced (108 tasks selected) draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Aug 2020 11:08:30 +0900 - rev 3101265
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Try Chooser Enhanced (108 tasks selected) Pushed via `mach try chooser`
872772d389a62794d85d8a686abbce5732fc7bf8: Bug 1656799 - part 1: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` store selection ranges with `AutoRangeArray` first r=m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Aug 2020 10:04:37 +0900 - rev 3101264
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656799 - part 1: Make `HTMLEditor::HandleDeleteNonCollapsedSelection()` store selection ranges with `AutoRangeArray` first r=m_kato
a9e5f4accfd55dcb5aeffefc170d41737840e623: Bug 1656430 - part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 14:47:19 +0900 - rev 3101263
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656430 - part 3: Create `EditorBase::DeleteRangesWithTransaction()` r=m_kato! This patch makes `EditorBase::DeleteSelectionWithTransaction()` a wrapper of `EditorBase::DeleteRangesWithTransaction()`. Differential Revision: https://phabricator.services.mozilla.com/D85686
f2135a3190a3e331004f7aee4947afe23976815a: Bug 1656430 - part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 14:03:53 +0900 - rev 3101262
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656430 - part 2: Add `AutoRangeArray` for alternative class of `Selection` r=m_kato! This new class will be used for treating selection ranges without modifying it temporarily. Differential Revision: https://phabricator.services.mozilla.com/D85685
7c562c2c0749ff5ae2119d6670e1a2552835afc4: Bug 1656430 - part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 13:22:22 +0900 - rev 3101261
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656430 - part 1: Rename `AutoRangeArray` to `AutoSelectionRangeArray` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85684
72c9d42edaa5d6edd76845984c65a6c990546ed2: Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:33:59 +0900 - rev 3101260
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656432 - part 3: Get rid of `nsIEditActionListener::WillDeleteSelection()` r=m_kato! Differential Revision: https://phabricator.services.mozilla.com/D85683
fad0828a3d19a8508667d573a76b6aa65bdcd64f: Bug 1656432 - part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:12:50 +0900 - rev 3101259
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656432 - part 2: Make `FinderHighlighter` use `nsIEditActionListener::WillDeleteRanges()` instead of `nsIEditActionListener::WillDeleteSelection()` For making editor performance better and editor code simpler, I want to stop modifying `Selection` as far as possible. Therefore, I'd like to get rid of `nsIEditActionListener`. Instead, there is new API, `nsIEditActionListener::WillDeleteRanges()`. This patch rewrites `FinderHighlighter#WillDeleteSelection()` to `FinderHighlighter#WillDeleteRanges()`. Differential Revision: https://phabricator.services.mozilla.com/D85682
e793f276e3180d970e6d9d88e9531af3ad52fa0d: Bug 1656432 - part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato! draft
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 02 Aug 2020 12:04:24 +0900 - rev 3101258
Push 578018 by masayuki@d-toybox.com at Mon, 03 Aug 2020 02:08:50 +0000
Bug 1656432 - part 1: Create `nsIEditActionListener::WillDeleteRanges()` r=m_kato! Currently, `nsIEditActionListener::WillDeleteSelection()` notifies `FinderHighliter` of deleting selection ranges. But it's referred only the ranges, not selection object itself and editor shouldn't modify `Selection` as far as possible for reducing the runtime cost. Therefore, it should be replaced with this new API. Then, `EditorBase::WillDeleteSelectionWithTransaction()` can be rewritten as `EditorBase::WillDeleteRangesWithTransaction()` later. Differential Revision: https://phabricator.services.mozilla.com/D85681
4b1c37d78777f1c25f11c634ca0d7c88dc6cb8c5: try_task_config for https://phabricator.services.mozilla.com/D85707 draft
libmozevent <release-mgmt-analysis@mozilla.com> - Mon, 03 Aug 2020 02:07:05 +0000 - rev 3101257
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
try_task_config for https://phabricator.services.mozilla.com/D85707 Differential Diff: PHID-DIFF-cm3ym3e4x2segf2g2ye7
690c37f2f53b8260876a3f5cf3810b67adc10e62: Bug 1656802. If both scrollbars are layout and present and only for the visual viewport they need to be adjusted to not overlap. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:07:01 +0000 - rev 3101256
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. If both scrollbars are layout and present and only for the visual viewport they need to be adjusted to not overlap. r?emilio Summary: The existing calculation will make them overlap. The AdjustOverlappingScrollbars code was written with overlay scrollbars in mind but it looks like it will work just fine for this case. Depends on D85706 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-cm3ym3e4x2segf2g2ye7
2b2a10ef7702e107c7ca276f2b37ec86d4fff11a: Bug 1656802. Position the scrollcorner if we have both layout scrollbars and they are both for the visual viewport only. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:06:58 +0000 - rev 3101255
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. Position the scrollcorner if we have both layout scrollbars and they are both for the visual viewport only. r?emilio Summary: Otherwise the calculation above would lead to an empty rect for the scroll corner. The scrollbar rects as computed now still overlap each other and the scroll corner, the next patch fixes that. Depends on D85705 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-okzlfgqarn7rpjb6shgh
26aa3d01bf34c4429a449b2f1e9ab6d24367d030: Bug 1656802. In LayoutScrollbars move the calculation of the scrollbar rects to the first thing in the function. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:06:55 +0000 - rev 3101254
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. In LayoutScrollbars move the calculation of the scrollbar rects to the first thing in the function. r?emilio Summary: There is no dependency in this code as far as I can tell. The next patch needs the scrollbar rects for the scroll corner calculation. Depends on D85704 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-wetx5ss2ayufb4tvupc4
aa3ccfb5f7e91b18c2cfced9326bfefbed4b471b: Bug 1656802. Shift back in layout scrollbars that are only for the visual viewport so they are visible. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:06:53 +0000 - rev 3101253
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. Shift back in layout scrollbars that are only for the visual viewport so they are visible. r?emilio Summary: Layout scrollbars that were only created for the visual viewport had no space reserved for them, so we need to shift them back in like overlay scrollbars. Otherwise they sit just outside of the scroll port and are not visible. Depends on D85703 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-q54cak7ncryp6shmie34
d723b66f7009cd62da014fe47dfca570cfa17de1: Bug 1656802. Add a comment explaining how overlay scrollbars work with their negative margin. r?emilio draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:06:50 +0000 - rev 3101252
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. Add a comment explaining how overlay scrollbars work with their negative margin. r?emilio Summary: Depends on D85702 Test Plan: Reviewers: emilio Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-qocxmoilj6zta36uforq
3f2fe8c1fb00473b254b44883ef5ccfcd87dc033: Bug 1656802. Add state variables to the scroll frame to track when scrollbars are only created to scroll the visual viewport within the layout viewport. r?emilio,kats draft
Timothy Nikkel <tnikkel@gmail.com> - Mon, 03 Aug 2020 02:06:47 +0000 - rev 3101251
Push 578017 by reviewbot at Mon, 03 Aug 2020 02:07:37 +0000
Bug 1656802. Add state variables to the scroll frame to track when scrollbars are only created to scroll the visual viewport within the layout viewport. r?emilio,kats Summary: We need to distinguish these special scrollbars for several different reasons in upcoming patches. Depends on D85701 Test Plan: Reviewers: emilio, kats Subscribers: Bug #: 1656802 Differential Diff: PHID-DIFF-kgq6zqt6a7a5vberv7dr
(0) -3000000 -1000000 -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 +1000000 tip