Bug 1593438 - Remove the non-functional navigation buttons in the add-ons manager. r=darktrojan DONTBUILD
authorRichard Marti <richard.marti@gmail.com>
Fri, 08 Nov 2019 10:47:33 +0100
changeset 81035 c9940c8a906127b111583461c97825cb4b1e247e
parent 81032 e4f02a3ecd47591b520920f3278da204cec3f4d8
child 81036 c44b970bf13016003b9d31eac32d7ea71ba687f0
child 81042 9460d3d076b9e6e451dc2e29e18e5f91d82aa98a
child 81044 199e47f75010f624d0097106dbf29280da1bb50b
child 81046 2b2791f094a64c3b498cd149ab5b8b24f6c13537
child 81126 e03bdc21d912cc216622bafe52c144fa8dca033b
push id9740
push userthunderbird@calypsoblue.org
push dateFri, 08 Nov 2019 18:16:43 +0000
treeherdertry-comm-central@f7b186621abf [default view] [failures only]
reviewersdarktrojan
bugs1593438
Bug 1593438 - Remove the non-functional navigation buttons in the add-ons manager. r=darktrojan DONTBUILD
mail/base/content/aboutAddonsExtra.css
mail/base/content/aboutAddonsExtra.js
mail/locales/en-US/chrome/messenger/extensionsOverlay.properties
mail/themes/shared/mail/incontentprefs/preferences.css
--- a/mail/base/content/aboutAddonsExtra.css
+++ b/mail/base/content/aboutAddonsExtra.css
@@ -13,49 +13,16 @@
     }
   }
 }
 
 #category-box {
   background-color: var(--in-content-categories-background);
 }
 
-.nav-button {
-  -moz-appearance: none;
-  list-style-image: url(chrome://messenger/skin/icons/navigation.svg);
-  margin-top: 15px;
-  margin-bottom: 10px;
-  border: 1px solid transparent;
-  border-radius: 2px;
-  -moz-context-properties: fill;
-  fill: currentColor;
-}
-
-.nav-button[disabled="true"] > .toolbarbutton-icon {
-  opacity: 0.4;
-}
-
-.nav-button:not([disabled="true"]):hover {
-  background-color: #bebebe;
-  cursor: pointer;
-}
-
-.nav-button > .toolbarbutton-text {
-  display: none;
-}
-
-#back-btn:-moz-locale-dir(rtl),
-#forward-btn:-moz-locale-dir(ltr) {
-  transform: scaleX(-1);
-}
-
-#categories {
-  padding-top: 0;
-}
-
 #preferencesButton {
   margin-bottom: 36px;
 }
 
 .sidebar-footer-button.help-button {
   display: none;
 }
 
--- a/mail/base/content/aboutAddonsExtra.js
+++ b/mail/base/content/aboutAddonsExtra.js
@@ -21,48 +21,16 @@ var extensionsNeedingRestart = new Set()
 (async function() {
   if (window.location.href == "about:addons") {
     let contentStylesheet = document.createProcessingInstruction(
       "xml-stylesheet",
       'href="chrome://messenger/content/aboutAddonsExtra.css" type="text/css"'
     );
     document.insertBefore(contentStylesheet, document.documentElement);
 
-    // Add navigation buttons for back and forward on the addons page.
-    let hbox = document.createXULElement("hbox");
-    hbox.setAttribute("id", "nav-header");
-    hbox.setAttribute("align", "center");
-    hbox.setAttribute("pack", "center");
-
-    let backButton = document.createXULElement("toolbarbutton");
-    backButton.setAttribute("id", "back-btn");
-    backButton.setAttribute("class", "nav-button");
-    backButton.setAttribute("command", "cmd_back");
-    backButton.setAttribute(
-      "tooltiptext",
-      mailExtBundle.GetStringFromName("cmdBackTooltip")
-    );
-    backButton.setAttribute("disabled", "true");
-
-    let forwardButton = document.createXULElement("toolbarbutton");
-    forwardButton.setAttribute("id", "forward-btn");
-    forwardButton.setAttribute("class", "nav-button");
-    forwardButton.setAttribute("command", "cmd_forward");
-    forwardButton.setAttribute(
-      "tooltiptext",
-      mailExtBundle.GetStringFromName("cmdForwardTooltip")
-    );
-    forwardButton.setAttribute("disabled", "true");
-    hbox.appendChild(backButton);
-    hbox.appendChild(forwardButton);
-
-    document
-      .getElementById("category-box")
-      .insertBefore(hbox, document.getElementById("categories"));
-
     // Fix the "Search on addons.mozilla.org" placeholder text in the searchbox.
     let browser = document.getElementById("html-view-browser");
     let textbox = browser.contentDocument.getElementById("search-addons");
     let placeholder = textbox.getAttribute("placeholder");
     placeholder = placeholder.replace(
       "addons.mozilla.org",
       "addons.thunderbird.net"
     );
--- a/mail/locales/en-US/chrome/messenger/extensionsOverlay.properties
+++ b/mail/locales/en-US/chrome/messenger/extensionsOverlay.properties
@@ -1,15 +1,12 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-cmdBackTooltip=Go back one page
-cmdForwardTooltip=Go forward one page
-
 # LOCALIZATION NOTE (warnLegacyUpgrade, warnLegacyDowngrade, warnLegacyEnable, warnLegacyDisable, warnLegacyInstall, warnLegacyUninstall)
 # %1$S is the add-on name, %2$S is brand name
 warnLegacyUpgrade=%1$S will be upgraded after you restart %2$S.
 warnLegacyDowngrade=%1$S will be downgraded after you restart %2$S.
 warnLegacyEnable=%1$S will be enabled after you restart %2$S.
 warnLegacyDisable=%1$S will be disabled after you restart %2$S.
 warnLegacyInstall=%1$S will be installed after you restart %2$S.
 warnLegacyUninstall=%1$S will be uninstalled after you restart %2$S.
--- a/mail/themes/shared/mail/incontentprefs/preferences.css
+++ b/mail/themes/shared/mail/incontentprefs/preferences.css
@@ -103,17 +103,17 @@ tabpanel > hbox > description {
   margin-inline: 5px 8px;
   width: 16px;
   height: 16px;
 }
 
 /* Category List */
 
 .paneSelector {
-  padding: 54px 0 0;
+  padding: 71px 0 0;
   margin: 0;
 }
 
 radio[pane] {
   -moz-box-orient: horizontal;
   -moz-box-align: center;
   -moz-appearance: none;
   width: 240px;