Bug 1542477 - Lint XUL files now that the linter supports doing so. r=jorgk(non-calendar) rs=bustage-fix,jorgk(calendar)
authorGeoff Lankow <geoff@darktrojan.net>
Sun, 07 Apr 2019 09:42:55 +1200
changeset 72561 590eeb7031d3b1130a728ead475801a1cb8de971
parent 72560 332e06b58769e1ac0b8ff7d9327e4b6681572f63
child 72562 ae01508231f613f622353d5ff7f5a69177b0680c
push id8127
push useracelists@atlas.sk
push dateSat, 06 Apr 2019 22:11:29 +0000
treeherdertry-comm-central@daa530aaba9f [default view] [failures only]
reviewersjorgk, bustage-fix, jorgk
bugs1542477
Bug 1542477 - Lint XUL files now that the linter supports doing so. r=jorgk(non-calendar) rs=bustage-fix,jorgk(calendar)
.eslintignore
calendar/base/content/calendar-unifinder.xul
calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
calendar/base/content/dialogs/calendar-summary-dialog.xul
calendar/base/content/dialogs/chooseCalendarDialog.xul
calendar/base/content/preferences/alarms.inc.xul
calendar/base/content/preferences/general.inc.xul
calendar/base/content/today-pane.xul
calendar/lightning/content/imip-bar-overlay.xul
mail/base/content/mainPopupSet.inc.xul
mail/base/content/msgAttachmentView.inc.xul
mail/base/content/msgHdrView.inc.xul
mail/components/addrbook/content/addressbook.xul
mail/components/compose/content/editFormatButtons.inc.xul
mail/components/compose/content/messengercompose.xul
--- a/.eslintignore
+++ b/.eslintignore
@@ -11,16 +11,21 @@ obj*/**
 mozilla/**
 
 # These directories don't contain any js and are not meant to
 config/**
 db/**
 other-licenses/**
 testing/**
 
+# Temporarily disabled until the XUL parser is fixed.
+calendar/base/content/calendar-calendars-list.xul
+calendar/providers/gdata/content/gdata-calendar-creation.xul
+common/src/viewSource.xul
+
 # We ignore all these directories by default, until we get them enabled.
 # If you are enabling a directory, please add directory specific exclusions
 # below.
 build/**
 editor/**
 ldap/**
 suite/**
 
--- a/calendar/base/content/calendar-unifinder.xul
+++ b/calendar/base/content/calendar-unifinder.xul
@@ -118,20 +118,20 @@
                    itemproperty="calendar"
                    label="&calendar.unifinder.tree.calendarname.label;"
                    tooltiptext="&calendar.unifinder.tree.calendarname.tooltip2;"/>
         </treecols>
 
         <!-- on mousedown here happens before onclick above -->
         <treechildren tooltip="eventTreeTooltip"
                       context="calendar-item-context-menu"
-                      onkeypress="if (event.key == 'Enter') unifinderEditCommand();"
+                      onkeypress="if (event.key == 'Enter') { unifinderEditCommand(); }"
                       ondragenter="return false;"
                       ondblclick="unifinderDoubleClick(event)"
-                      onfocus="focusFirstItemIfNoSelection( );"/>
+                      onfocus="focusFirstItemIfNoSelection();"/>
       </tree>
     </vbox>
     <splitter id="calendar-view-splitter"
               insertbefore="calendar-nav-control"
               resizebefore="closest"
               resizeafter="farthest"
               persist="state"
               class="chromeclass-extrachrome sidebar-splitter calendar-splitter"
--- a/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
+++ b/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul
@@ -87,17 +87,17 @@
                      autocompletesearch="addrbook ldap"
                      autocompletesearchparam="{}"
                      timeout="300"
                      maxrows="4"
                      completedefaultindex="true"
                      forcecomplete="true"
                      completeselectedindex="true"
                      minresultsforpopup="1"
-                     onblur="if (this.localName == 'textbox') this.closest(&quot;attendees-list&quot;).returnHit(this, true)"
+                     onblur="if (this.localName == 'textbox') { this.closest(&quot;attendees-list&quot;).returnHit(this, true); }"
                      ignoreblurwhilesearching="true"
                      oninput="this.setAttribute('dirty', 'true');"
                      ontextentered="this.closest(&quot;attendees-list&quot;).returnHit(this);">
             </textbox>
           </hbox>
         </richlistitem>
       </attendees-list>
       <box class="attendee-spacer-bottom"/>
--- a/calendar/base/content/dialogs/calendar-summary-dialog.xul
+++ b/calendar/base/content/dialogs/calendar-summary-dialog.xul
@@ -65,17 +65,17 @@
       <toolbarbutton id="saveandcloseButton"
                      tooltiptext="&summary.dialog.saveclose.tooltiptext;"
                      label="&summary.dialog.saveclose.label;"
                      oncommand="saveAndClose();"
                      class="cal-event-toolbarbutton toolbarbutton-1 saveandcloseButton"/>
       <toolbarbutton id="acceptButton"
                      tooltiptext="&summary.dialog.accept.tooltiptext;"
                      label="&summary.dialog.accept.label;"
-                     oncommand="if (event.target.id == this.id) reply('AUTO', 'ACCEPTED');"
+                     oncommand="if (event.target.id == this.id) { reply('AUTO', 'ACCEPTED'); }"
                      value="ACCEPTED"
                      type="menu-button"
                      class="cal-event-toolbarbutton toolbarbutton-1 replyButton">
         <menupopup id="acceptDropdown">
           <menuitem id="acceptButton_Send"
                     tooltiptext="&summary.dialog.send.tooltiptext;"
                     label="&summary.dialog.send.label;"
                     oncommand="reply('AUTO', 'ACCEPTED');"/>
@@ -83,17 +83,17 @@
                     tooltiptext="&summary.dialog.dontsend.tooltiptext;"
                     label="&summary.dialog.dontsend.label;"
                     oncommand="reply('NONE', 'ACCEPTED');"/>
         </menupopup>
       </toolbarbutton>
       <toolbarbutton id="tentativeButton"
                      tooltiptext="&summary.dialog.tentative.tooltiptext;"
                      label="&summary.dialog.tentative.label;"
-                     oncommand="if (event.target.id == this.id) reply('AUTO', 'TENTATIVE');"
+                     oncommand="if (event.target.id == this.id) { reply('AUTO', 'TENTATIVE'); }"
                      value="TENTATIVE"
                      type="menu-button"
                      class="cal-event-toolbarbutton toolbarbutton-1 replyButton">
         <menupopup id="tentativeDropdown">
           <menuitem id="tenatativeButton_Send"
                     tooltiptext="&summary.dialog.send.tooltiptext;"
                     label="&summary.dialog.send.label;"
                     oncommand="reply('AUTO', 'TENTATIVE');"/>
@@ -101,17 +101,17 @@
                     tooltiptext="&summary.dialog.dontsend.tooltiptext;"
                     label="&summary.dialog.dontsend.label;"
                     oncommand="reply('NONE', 'TENTATIVE');"/>
         </menupopup>
       </toolbarbutton>
       <toolbarbutton id="declineButton"
                      tooltiptext="&summary.dialog.decline.tooltiptext;"
                      label="&summary.dialog.decline.label;"
-                     oncommand="if (event.target.id == this.id) reply('AUTO', 'DECLINED');"
+                     oncommand="if (event.target.id == this.id) { reply('AUTO', 'DECLINED'); }"
                      type="menu-button"
                      value="DECLINED"
                      class="cal-event-toolbarbutton toolbarbutton-1 replyButton">
         <menupopup id="declineDropdown">
           <menuitem id="declineButton_Send"
                     tooltiptext="&summary.dialog.send.tooltiptext;"
                     label="&summary.dialog.send.label;"
                     oncommand="reply('AUTO', 'DECLINED');"/>
--- a/calendar/base/content/dialogs/chooseCalendarDialog.xul
+++ b/calendar/base/content/dialogs/chooseCalendarDialog.xul
@@ -11,17 +11,17 @@
     <!ENTITY % dtd1 SYSTEM "chrome://calendar/locale/calendar.dtd" > %dtd1;
 ]>
 
 <dialog id="chooseCalendar"
         title="&calendar.select.dialog.title;"
         windowtype="Calendar:CalendarPicker"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml"
         buttons="accept,cancel"
-        onload="setTimeout('loadCalendars()',0);"
+        onload="setTimeout(loadCalendars, 0);"
         persist="screenX screenY height width">
 
     <script type="application/javascript" src="chrome://calendar/content/calendar-ui-utils.js"/>
     <script type="application/javascript" src="chrome://calendar/content/chooseCalendarDialog.js"/>
 
     <vbox id="dialog-box" flex="1">
         <label id="prompt" control="calendar-list"/>
         <richlistbox id="calendar-list" flex="1" seltype="single"/>
--- a/calendar/base/content/preferences/alarms.inc.xul
+++ b/calendar/base/content/preferences/alarms.inc.xul
@@ -63,18 +63,18 @@
                     <html:td width="30%">
                         <hbox align="center">
                             <textbox id="defaultsnoozelength"
                                      preference="calendar.alarms.defaultsnoozelength"
                                      type="number"
                                      min="0"
                                      maxlength="4"
                                      size="3"
-                                     onselect="updateUnitLabelPlural('defaultsnoozelength','defaultsnoozelengthunit','minutes')"
-                                     oninput="updateUnitLabelPlural('defaultsnoozelength','defaultsnoozelengthunit','minutes')"/>
+                                     onselect="updateUnitLabelPlural('defaultsnoozelength', 'defaultsnoozelengthunit', 'minutes')"
+                                     oninput="updateUnitLabelPlural('defaultsnoozelength', 'defaultsnoozelengthunit', 'minutes')"/>
                             <label id="defaultsnoozelengthunit"/>
                         </hbox>
                     </html:td>
                 </html:tr>
                 <html:tr>
                     <html:td>
                         <label value="&pref.defalarm4events.label;"
                                accesskey="&pref.defalarm4events.accesskey;"
@@ -128,18 +128,18 @@
                         <hbox class="defaultTimeBox"
                               align="center"
                               flex="1">
                             <textbox id="eventdefalarmlen"
                                       preference="calendar.alarms.eventalarmlen"
                                       type="number"
                                       min="0"
                                       size="3"
-                                      onselect="updateMenuLabelsPlural('eventdefalarmlen','eventdefalarmunit')"
-                                      oninput="updateMenuLabelsPlural('eventdefalarmlen','eventdefalarmunit')"/>
+                                      onselect="updateMenuLabelsPlural('eventdefalarmlen', 'eventdefalarmunit')"
+                                      oninput="updateMenuLabelsPlural('eventdefalarmlen', 'eventdefalarmunit')"/>
                             <menulist id="eventdefalarmunit"
                                       flex="1"
                                       crop="none"
                                       preference="calendar.alarms.eventalarmunit">
                                 <menupopup id="eventdefalarmunitpopup">
                                     <menuitem id="eventdefalarmunitmin"
                                               value="minutes"
                                               selected="true"/>
@@ -162,18 +162,18 @@
                         <hbox class="defaultTimeBox"
                               align="center"
                               flex="1">
                             <textbox id="tododefalarmlen"
                                       preference="calendar.alarms.todoalarmlen"
                                       type="number"
                                       min="0"
                                       size="3"
-                                      onselect="updateMenuLabelsPlural('tododefalarmlen','tododefalarmunit')"
-                                      oninput="updateMenuLabelsPlural('tododefalarmlen','tododefalarmunit')"/>
+                                      onselect="updateMenuLabelsPlural('tododefalarmlen', 'tododefalarmunit')"
+                                      oninput="updateMenuLabelsPlural('tododefalarmlen', 'tododefalarmunit')"/>
                             <menulist id="tododefalarmunit"
                                       flex="1"
                                       crop="none"
                                       preference="calendar.alarms.todoalarmunit">
                                 <menupopup id="tododefalarmunitpopup">
                                     <menuitem id="tododefalarmunitmin"
                                               value="minutes"
                                               selected="true"/>
--- a/calendar/base/content/preferences/general.inc.xul
+++ b/calendar/base/content/preferences/general.inc.xul
@@ -47,18 +47,18 @@
                             accesskey="&pref.default_event_length.accesskey;"
                             control="defaultlength"/>
                     <textbox id="defaultlength"
                               preference="calendar.event.defaultlength"
                               type="number"
                               min="0"
                               maxlength="3"
                               size="3"
-                              onselect="updateUnitLabelPlural('defaultlength','defaultlengthunit','minutes')"
-                              oninput="updateUnitLabelPlural('defaultlength','defaultlengthunit','minutes')"/>
+                              onselect="updateUnitLabelPlural('defaultlength', 'defaultlengthunit', 'minutes')"
+                              oninput="updateUnitLabelPlural('defaultlength', 'defaultlengthunit', 'minutes')"/>
                     <label id="defaultlengthunit"/>
                 </hbox>
                 <label><html:h3>&pref.tasks.label;</html:h3></label>
                 <html:table id="defaults-task-table">
                     <html:tr id="defaults-task-start-row">
                         <html:td>
                             <label id="default-task-start-label"
                                     value="&read.only.task.start.label;"
--- a/calendar/base/content/today-pane.xul
+++ b/calendar/base/content/today-pane.xul
@@ -103,26 +103,26 @@
                     <label/>
                     <label/>
                   </deck>
                   <spacer id="weekspacer" flex="1"/>
                   <hbox pack="end">
                     <toolbarbutton id="previous-day-button"
                                    class="miniday-nav-buttons"
                                    tooltiptext="&onedaybackward.tooltip;"
-                                   onmousedown="TodayPane.onMousedown(event, parseInt(this.getAttribute('dir')));"
+                                   onmousedown="TodayPane.onMousedown(event, -1);"
                                    dir="-1"/>
                     <toolbarbutton id="today-button"
                                    class="miniday-nav-buttons"
                                    tooltiptext="&showToday.tooltip;"
                                    oncommand="TodayPane.setDay(cal.dtz.now());"/>
                     <toolbarbutton id="next-day-button"
                                    class="miniday-nav-buttons"
                                    tooltiptext="&onedayforward.tooltip;"
-                                   onmousedown="TodayPane.onMousedown(event, parseInt(this.getAttribute('dir')));"
+                                   onmousedown="TodayPane.onMousedown(event, 1);"
                                    dir="1"/>
                   </hbox>
                 </hbox>
                 <hbox pack="start">
                   <label id="monthNameContainer" class="monthlabel"
                          ondblclick="TodayPane.onDoubleClick(event);"/>
                   <label id="currentWeek-label" class="monthlabel"
                          ondblclick="TodayPane.onDoubleClick(event);"/>
--- a/calendar/lightning/content/imip-bar-overlay.xul
+++ b/calendar/lightning/content/imip-bar-overlay.xul
@@ -134,17 +134,17 @@
                              class="toolbarbutton-1 msgHeaderView-button imipReconfirmButton"
                              oncommand="ltnImipBar.executeAction()"
                              hidden="true"/>
 
               <!-- accept -->
               <toolbarbutton id="imipAcceptButton"
                              tooltiptext="&lightning.imipbar.btnAccept2.tooltiptext;"
                              label="&lightning.imipbar.btnAccept.label;"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('ACCEPTED', 'AUTO');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('ACCEPTED', 'AUTO'); }"
                              type="menu-button"
                              class="imip-button toolbarbutton-1 msgHeaderView-button imipAcceptButton"
                              hidden="true">
                 <menupopup id="imipAcceptDropdown">
                   <label id="imipAcceptButton_AcceptLabel"
                          class="imipAcceptLabel"
                          tooltiptext="&lightning.imipbar.btnAccept2.tooltiptext;"
                          value="&lightning.imipbar.btnAccept.label;"/>
@@ -172,17 +172,17 @@
                   <!-- add here more menuitem as needed -->
                 </menupopup>
               </toolbarbutton>
 
               <!-- accept recurrences -->
               <toolbarbutton id="imipAcceptRecurrencesButton"
                              tooltiptext="&lightning.imipbar.btnAcceptRecurrences2.tooltiptext;"
                              label="&lightning.imipbar.btnAcceptRecurrences.label;"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('ACCEPTED', 'AUTO');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('ACCEPTED', 'AUTO'); }"
                              type="menu-button"
                              class="imip-button toolbarbutton-1 msgHeaderView-button imipAcceptRecurrencesButton"
                              hidden="true">
                 <menupopup id="imipAcceptRecurrencesDropdown">
                   <label id="imipAcceptRecurrencesButton_AcceptLabel"
                          class="imipAcceptLabel"
                          tooltiptext="&lightning.imipbar.btnAcceptRecurrences2.tooltiptext;"
                          value="&lightning.imipbar.btnAcceptRecurrences.label;"/>
@@ -212,17 +212,17 @@
               </toolbarbutton>
 
               <!-- tentative; should only be used, if no imipMoreButton is used and
                  - imipDeclineButton/imipAcceptButton have no visible menuitems //-->
               <toolbarbutton id="imipTentativeButton"
                              label="&lightning.imipbar.btnTentative.label;"
                              tooltiptext="&lightning.imipbar.btnTentative2.tooltiptext;"
                              class="toolbarbutton-1 msgHeaderView-button imipTentativeButton"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('TENTATIVE', 'AUTO');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('TENTATIVE', 'AUTO'); }"
                              type="menu-button"
                              hidden="true">
                 <menupopup id="imipTentativeDropdown">
                   <menuitem id="imipTentativeButton_Tentative"
                             tooltiptext="&lightning.imipbar.btnSend.tooltiptext;"
                             label="&lightning.imipbar.btnSend.label;"
                             oncommand="ltnImipBar.executeAction('TENTATIVE', 'AUTO');"/>
                   <menuitem id="imipTentativeButton_TentativeDontSend"
@@ -234,17 +234,17 @@
               </toolbarbutton>
 
               <!-- tentative recurrences; should only be used, if no imipMoreButton is used and
                  - imipDeclineRecurrencesButton/imipAcceptRecurrencesButton have no visible menuitems //-->
               <toolbarbutton id="imipTentativeRecurrencesButton"
                              label="&lightning.imipbar.btnTentativeRecurrences.label;"
                              tooltiptext="&lightning.imipbar.btnTentativeRecurrences2.tooltiptext;"
                              class="toolbarbutton-1 msgHeaderView-button imipTentativeRecurrencesButton"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('TENTATIVE', 'AUTO');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('TENTATIVE', 'AUTO'); }"
                              type="menu-button"
                              hidden="true">
                 <menupopup id="imipTentativeRecurrencesDropdown">
                   <menuitem id="imipTentativeRecurrencesButton_Tentative"
                             tooltiptext="&lightning.imipbar.btnSendSeries.tooltiptext;"
                             label="&lightning.imipbar.btnSend.label;"
                             oncommand="ltnImipBar.executeAction('TENTATIVE', 'AUTO');"/>
                   <menuitem id="imipTentativeRecurrencesButton_TentativeDontSend"
@@ -254,17 +254,17 @@
                   <!-- add here more menuitem as needed -->
                 </menupopup>
               </toolbarbutton>
 
               <!-- decline -->
               <toolbarbutton id="imipDeclineButton"
                              tooltiptext="&lightning.imipbar.btnDecline2.tooltiptext;"
                              label="&lightning.imipbar.btnDecline.label;"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('DECLINED', 'AUTO');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('DECLINED', 'AUTO'); }"
                              type="menu-button"
                              class="toolbarbutton-1 msgHeaderView-button imipDeclineButton"
                              hidden="true">
                 <menupopup id="imipDeclineDropdown">
                   <menuitem id="imipDeclineButton_Decline"
                             tooltiptext="&lightning.imipbar.btnSend.tooltiptext;"
                             label="&lightning.imipbar.btnSend.label;"
                             oncommand="ltnImipBar.executeAction('DECLINED', 'AUTO');"/>
@@ -275,17 +275,17 @@
                   <!-- add here more menuitem as needed -->
                 </menupopup>
               </toolbarbutton>
 
               <!-- decline recurrences -->
               <toolbarbutton id="imipDeclineRecurrencesButton"
                              tooltiptext="&lightning.imipbar.btnDeclineRecurrences2.tooltiptext;"
                              label="&lightning.imipbar.btnDeclineRecurrences.label;"
-                             oncommand="if (event.target.id == this.id) ltnImipBar.executeAction('DECLINED');"
+                             oncommand="if (event.target.id == this.id) { ltnImipBar.executeAction('DECLINED'); }"
                              type="menu-button"
                              class="toolbarbutton-1 msgHeaderView-button imipDeclineRecurrencesButton"
                              hidden="true">
                 <menupopup id="imipDeclineRecurrencesDropdown">
                   <menuitem id="imipDeclineRecurrencesButton_DeclineAll"
                             tooltiptext="&lightning.imipbar.btnSendSeries.tooltiptext;"
                             label="&lightning.imipbar.btnSend.label;"
                             oncommand="ltnImipBar.executeAction('DECLINED');"/>
--- a/mail/base/content/mainPopupSet.inc.xul
+++ b/mail/base/content/mainPopupSet.inc.xul
@@ -1606,17 +1606,17 @@
     <menuseparator id="folderPaneContext-sepPause"/>
     <menuitem id="folderPaneContext-openNewTab"
               label="&folderContextOpenNewTab.label;"
               accesskey="&folderContextOpenNewTab.accesskey;"
               oncommand="FolderPaneContextMenuNewTab(event);"/>
     <menuitem id="folderPaneContext-openNewWindow"
               label="&folderContextOpenInNewWindow.label;"
               accesskey="&folderContextOpenInNewWindow.accesskey;"
-              oncommand="MsgOpenNewWindowForFolder(null,-1);"/>
+              oncommand="MsgOpenNewWindowForFolder(null, -1);"/>
     <menuitem id="folderPaneContext-searchMessages"
               label="&folderContextSearchForMessages.label;"
               accesskey="&folderContextSearchForMessages.accesskey;"
               oncommand="gFolderTreeController.searchMessages();"/>
     <menuitem id="folderPaneContext-subscribe"
               label="&folderContextSubscribe.label;"
               accesskey="&folderContextSubscribe.accesskey;"
               oncommand="MsgSubscribe();"/>
@@ -1679,17 +1679,17 @@
     <menuseparator id="folderPaneContext-sep4"/>
     <menuitem id="folderPaneContext-settings"
               label="&folderContextSettings2.label;"
               accesskey="&folderContextSettings2.accesskey;"
               oncommand="gFolderTreeController.editFolder();"/>
   </menupopup>
 
   <menupopup id="aboutPagesContext"
-             onpopupshowing="goUpdateCommand('cmd_copy');goUpdateCommand('cmd_selectAll');">
+             onpopupshowing="goUpdateCommand('cmd_copy'); goUpdateCommand('cmd_selectAll');">
     <menuitem id="aboutPagesContext-copy"
               label="&copyCmd.label;"
               accesskey="&copyCmd.accesskey;"
               command="cmd_copy"/>
     <menuitem id="aboutPagesContext-selectall"
               label="&selectAllCmd.label;"
               accesskey="&selectAllCmd.accesskey;"
               command="cmd_selectAll"/>
--- a/mail/base/content/msgAttachmentView.inc.xul
+++ b/mail/base/content/msgAttachmentView.inc.xul
@@ -14,17 +14,17 @@
                           <hbox align="center" id="attachmentInfo" flex="1">
                             <image id="attachmentIcon"/>
                             <label id="attachmentCount"/>
                             <label id="attachmentName" crop="center" flex="1"
                                    role="button"
                                    tooltiptext="&openAttachment.tooltip;"
                                    tooltiptextopen="&openAttachment.tooltip;"
                                    onclick="OpenAttachmentFromBar(event);"
-                                   ondragstart="nsDragAndDrop.startDrag(event,attachmentNameDNDObserver);"/>
+                                   ondragstart="nsDragAndDrop.startDrag(event, attachmentNameDNDObserver);"/>
                             <label id="attachmentSize"/>
                           </hbox>
                           <!-- Use a very large flex value here so that attachmentCount doesn't take
                                up more space than necessary, but still crops itself if there's not
                                enough space. -->
                           <spacer flex="9999"/>
 
                           <toolbox id="attachment-view-toolbox"
@@ -104,10 +104,10 @@
                         <richlistbox id="attachmentList"
                                      class="attachmentList"
                                      orient="horizontal"
                                      flex="1"
                                      seltype="multiple"
                                      context="attachmentListContext"
                                      itemcontext="attachmentItemContext"
                                      role="listbox"
-                                     ondragstart="nsDragAndDrop.startDrag(event,attachmentListDNDObserver);"
+                                     ondragstart="nsDragAndDrop.startDrag(event, attachmentListDNDObserver);"
                                      ondragover="nsDragAndDrop.dragOver(event, attachmentListDNDObserver);"/>
--- a/mail/base/content/msgHdrView.inc.xul
+++ b/mail/base/content/msgHdrView.inc.xul
@@ -31,27 +31,27 @@
                                          controller -->
 
                                     <!-- XXXdmose need to audit our shortcut/a11y setup and make sure
                                          these buttons are doing the right thing -->
 
                                     <toolbarbutton id="hdrForwardButton"
                                                    label="&hdrForwardButton1.label;"
                                                    tooltiptext="&hdrForwardButton1.tooltip;"
-                                                   oncommand="MsgForwardMessage(event);RestoreFocusAfterHdrButton();"
+                                                   oncommand="MsgForwardMessage(event); RestoreFocusAfterHdrButton();"
                                                    observes="button_forward"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrForwardButton"/>
                                     <toolbaritem id="hdrMenuForwardButton" label="&hdrMenuForwardButton.label;">
                                     <!-- This toolbaritem is a dummy and should only be shown when
                                          customizing the toolbar to distinguish the forward button
                                          from the forward dual-button. -->
                                       <toolbarbutton id="hdrDualForwardButton"
                                                      label="&hdrForwardButton1.label;"
                                                      tooltiptext="&hdrForwardButton1.tooltip;"
-                                                     oncommand="MsgForwardMessage(event);RestoreFocusAfterHdrButton();"
+                                                     oncommand="MsgForwardMessage(event); RestoreFocusAfterHdrButton();"
                                                      observes="button_forward"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrForwardButton"
                                                      type="menu-button">
                                         <menupopup id="hdrForwardDropdown">
                                           <menuitem id="hdrForwardAsInlineMenu"
                                                     label="&buttonMenuForwardAsInline.label;"
                                                     tooltiptext="&forwardAsInline.tooltip;"
                                                     command="cmd_forwardInline"/>
@@ -60,58 +60,58 @@
                                                     tooltiptext="&forwardAsAttachment.tooltip;"
                                                     command="cmd_forwardAttachment"/>
                                         </menupopup>
                                       </toolbarbutton>
                                     </toolbaritem>
                                     <toolbarbutton id="hdrArchiveButton"
                                                    label="&hdrArchiveButton1.label;"
                                                    tooltiptext="&hdrArchiveButton1.tooltip;"
-                                                   oncommand="MsgArchiveSelectedMessages(event);RestoreFocusAfterHdrButton();"
+                                                   oncommand="MsgArchiveSelectedMessages(event); RestoreFocusAfterHdrButton();"
                                                    observes="button_archive"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrArchiveButton"/>
                                     <toolbarbutton id="hdrJunkButton" label="&hdrJunkButton1.label;"
                                                    tooltiptext="&hdrJunkButton1.tooltip;"
                                                    observes="button_junk"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrJunkButton"
-                                                   oncommand="goDoCommand('button_junk');RestoreFocusAfterHdrButton();"/>
+                                                   oncommand="goDoCommand('button_junk'); RestoreFocusAfterHdrButton();"/>
                                     <toolbarbutton id="hdrTrashButton"
                                                    label="&hdrTrashButton1.label;"
                                                    tooltiptext="&hdrTrashButton1.tooltip;"
                                                    observes="button_delete"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrTrashButton"
                                                    oncommand="goDoCommand(event.shiftKey ? 'button_shiftDelete' :
-                                                                          'button_delete');RestoreFocusAfterHdrButton();"/>
+                                                                          'button_delete'); RestoreFocusAfterHdrButton();"/>
                                     <toolbarbutton id="hdrOpenConversationButton"
                                                    label="&hdrOpenConversationButton1.label;"
                                                    tooltiptext="&hdrOpenConversationButton1.tooltip;"
                                                    observes="button_showconversation"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrConversationButton"
-                                                   oncommand="gConversationOpener.openConversationForMessages(gFolderDisplay.selectedMessages);RestoreFocusAfterHdrButton();"/>
+                                                   oncommand="gConversationOpener.openConversationForMessages(gFolderDisplay.selectedMessages); RestoreFocusAfterHdrButton();"/>
                                     <toolbarbutton id="hdrReplyToSenderButton" label="&hdrReplyButton1.label;"
                                                    tooltiptext="&hdrReplyButton2.tooltip;"
-                                                   oncommand="MsgReplySender(event);RestoreFocusAfterHdrButton();"
+                                                   oncommand="MsgReplySender(event); RestoreFocusAfterHdrButton();"
                                                    observes="button_reply"
                                                    class="toolbarbutton-1 msgHeaderView-button hdrReplyToSenderButton"/>
                                     <toolbaritem id="hdrSmartReplyButton" label="&hdrSmartReplyButton1.label;">
                                       <!-- This button is a dummy and should only be shown when
                                            customizing the toolbar to distinguish the smart reply
                                            button from the reply to sender button. -->
                                       <toolbarbutton id="hdrDummyReplyButton" label="&hdrSmartReplyButton1.label;"
                                                      hidden="true"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrDummyReplyButton"/>
                                       <toolbarbutton id="hdrReplyButton" label="&hdrReplyButton1.label;"
                                                      tooltiptext="&hdrReplyButton2.tooltip;"
-                                                     oncommand="MsgReplySender(event);RestoreFocusAfterHdrButton();"
+                                                     oncommand="MsgReplySender(event); RestoreFocusAfterHdrButton();"
                                                      observes="button_reply"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrReplyButton"/>
                                       <toolbarbutton id="hdrReplyAllButton"
                                                      label="&hdrReplyAllButton1.label;"
                                                      tooltiptext="&hdrReplyAllButton1.tooltip;"
-                                                     oncommand="MsgReplyToAllMessage(event);RestoreFocusAfterHdrButton();"
+                                                     oncommand="MsgReplyToAllMessage(event); RestoreFocusAfterHdrButton();"
                                                      observes="button_replyall"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrReplyButton hdrReplyAllButton"
                                                      type="menu-button"
                                                      hidden="true">
                                         <menupopup id="hdrReplyAllDropdown">
                                           <menuitem id="hdrReplyAll_ReplyAllSubButton"
                                                     label="&hdrReplyAllButton1.label;"
                                                     tooltiptext="&hdrReplyAllButton1.tooltip;"
@@ -123,17 +123,17 @@
                                                     observes="button_reply"
                                                     oncommand="MsgReplySender(event); event.stopPropagation();
                                                                RestoreFocusAfterHdrButton();"/>
                                         </menupopup>
                                       </toolbarbutton>
                                       <toolbarbutton id="hdrReplyListButton"
                                                      label="&hdrReplyListButton1.label;"
                                                      tooltiptext="&hdrReplyListButton1.tooltip;"
-                                                     oncommand="MsgReplyToListMessage(event);RestoreFocusAfterHdrButton();"
+                                                     oncommand="MsgReplyToListMessage(event); RestoreFocusAfterHdrButton();"
                                                      observes="button_replylist"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrReplyButton hdrReplyListButton"
                                                      type="menu-button"
                                                      hidden="true">
                                         <menupopup id="hdrReplyListDropdown">
                                           <menuitem id="hdrReplyList_ReplyListSubButton"
                                                     label="&hdrReplyListButton1.label;"
                                                     tooltiptext="&hdrReplyListButton1.tooltip;"
@@ -150,17 +150,17 @@
                                                     tooltiptext="&hdrReplyButton2.tooltip;"
                                                     observes="button_reply"
                                                     oncommand="MsgReplySender(event); event.stopPropagation();
                                                                RestoreFocusAfterHdrButton();"/>
                                         </menupopup>
                                       </toolbarbutton>
                                       <toolbarbutton id="hdrFollowupButton" label="&hdrFollowupButton1.label;"
                                                      tooltiptext="&hdrFollowupButton1.tooltip;"
-                                                     oncommand="MsgReplyGroup(event);RestoreFocusAfterHdrButton();"
+                                                     oncommand="MsgReplyGroup(event); RestoreFocusAfterHdrButton();"
                                                      observes="button_followup"
                                                      class="toolbarbutton-1 msgHeaderView-button hdrFollowupButton"
                                                      type="menu-button">
                                         <menupopup id="hdrFollowupDropdown">
                                           <menuitem id="hdrFollowup_FollowupSubButton"
                                                     label="&hdrFollowupButton1.label;"
                                                     tooltiptext="&hdrFollowupButton1.tooltip;"
                                                     observes="button_followup"/>
--- a/mail/components/addrbook/content/addressbook.xul
+++ b/mail/components/addrbook/content/addressbook.xul
@@ -670,17 +670,17 @@
     <vbox id="dirTreeBox" persist="width collapsed">
       <!-- FIX ME - remove document.commandDispatcher.updateCommands() when tree selection calls this automatically -->
       <tree id="dirTree" class="abDirectory plain" seltype="single" minwidth="150" flex="1" persist="width"
             hidecolumnpicker="true"
             context="dirTreeContext"
             onselect="DirPaneSelectionChange(); document.commandDispatcher.updateCommands('addrbook-select');"
             ondblclick="DirPaneDoubleClick(event);"
             onclick="DirPaneClick(event);"
-            onblur="goOnEvent(this,'blur')">
+            onblur="goOnEvent(this, 'blur')">
 
         <treecols>
           <treecol id="DirCol" flex="1" primary="true" hideheader="true"
                    crop="center" persist="width" ignoreincolumnpicker="true"/>
         </treecols>
         <treechildren/>
       </tree>
     </vbox>
--- a/mail/components/compose/content/editFormatButtons.inc.xul
+++ b/mail/components/compose/content/editFormatButtons.inc.xul
@@ -241,41 +241,41 @@
 
         <toolbarbutton id="smileButtonMenu"
                        class="formatting-button"
                        tooltiptext="&SmileButton.tooltip;"
                        type="menu"
                        observes="cmd_smiley">
           <menupopup id="smilyPopup">
             <menuitem id="smileySmile" class="menuitem-iconic" label="&smiley1Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-)'  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-)')"/>
             <menuitem id="smileyFrown" class="menuitem-iconic" label="&smiley2Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-('  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-(')"/>
             <menuitem id="smileyWink" class="menuitem-iconic" label="&smiley3Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ';-)'  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ';-)')"/>
             <menuitem id="smileyTongue" class="menuitem-iconic" label="&smiley4Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-P'  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-P')"/>
             <menuitem id="smileyLaughing" class="menuitem-iconic" label="&smiley5Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-D'  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-D')"/>
             <menuitem id="smileyEmbarassed" class="menuitem-iconic" label="&smiley6Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-['  )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-[')"/>
             <menuitem id="smileyUndecided" class="menuitem-iconic" label="&smiley7Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-\\' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-\\')"/>
             <menuitem id="smileySurprise" class="menuitem-iconic" label="&smiley8Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', '=-O' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', '=-O')"/>
             <menuitem id="smileyKiss" class="menuitem-iconic" label="&smiley9Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-*' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-*')"/>
             <menuitem id="smileyYell" class="menuitem-iconic" label="&smiley10Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', '>:o' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', '>:o')"/>
             <menuitem id="smileyCool" class="menuitem-iconic" label="&smiley11Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', '8-)' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', '8-)')"/>
             <menuitem id="smileyMoney" class="menuitem-iconic" label="&smiley12Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-$' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-$')"/>
             <menuitem id="smileyFoot" class="menuitem-iconic" label="&smiley13Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-!' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-!')"/>
             <menuitem id="smileyInnocent" class="menuitem-iconic" label="&smiley14Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', 'O:-)' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', 'O:-)')"/>
             <menuitem id="smileyCry" class="menuitem-iconic" label="&smiley15Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':\'(' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':\'(')"/>
             <menuitem id="smileySealed" class="menuitem-iconic" label="&smiley16Cmd.label;"
-                      oncommand="doStatefulCommand('cmd_smiley', ':-X' )"/>
+                      oncommand="doStatefulCommand('cmd_smiley', ':-X')"/>
           </menupopup>
         </toolbarbutton>
--- a/mail/components/compose/content/messengercompose.xul
+++ b/mail/components/compose/content/messengercompose.xul
@@ -1981,17 +1981,17 @@
             </richlistitem>
           </richlistbox>
           <hbox id="subject-box">
             <hbox class="aw-firstColBox"/>
             <hbox align="center" pack="end" style="&headersSpace.style;">
               <label id="subjectLabel" value="&subject.label;" accesskey="&subject.accesskey;" control="msgSubject"/>
             </hbox>
             <textbox id="msgSubject" flex="1" class="toolbar" disableonsend="true" spellcheck="true"
-                     oninput="gContentChanged=true;SetComposeWindowTitle();"
+                     oninput="gContentChanged = true; SetComposeWindowTitle();"
                      onkeypress="subjectKeyPress(event);" />
           </hbox>
         </vbox>
         <splitter id="attachmentbucket-sizer"
                   collapsed="true"
                   collapse="after"
                   onmouseup="attachmentBucketSizerOnMouseUp();"/>
         <vbox id="attachments-box" collapsed="true" persist="width">