Bug 1139560 - Fix mochitest expectations for currentSrc. r=orange for a CLOSED TREE
☠☠ backed out by dcc49f2ed016 ☠ ☠
authorJosh Matthews <josh@joshmatthews.net>
Fri, 27 Mar 2015 15:36:18 -0400
changeset 266593 ffcb5e699ef5cfcc7ed12bd252c323af00d7b02d
parent 266592 6e2c1ed29f14c44d4f56984240a58aebefa147b1
child 266594 48b5fffff1ec30277cab3755cf07601fcb7c1f39
push id830
push userraliiev@mozilla.com
push dateFri, 19 Jun 2015 19:24:37 +0000
treeherdermozilla-release@932614382a68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersorange
bugs1139560
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1139560 - Fix mochitest expectations for currentSrc. r=orange for a CLOSED TREE
dom/tests/mochitest/general/test_img_mutations.html
dom/tests/mochitest/general/test_picture_mutations.html
--- a/dom/tests/mochitest/general/test_img_mutations.html
+++ b/dom/tests/mochitest/general/test_img_mutations.html
@@ -64,17 +64,17 @@
       info("test 1");
       img.src = testPNG50;
       is(img.currentSrc, testPNG50, "Should have synchronously selected source");
 
       img.src = "non_existent_image.404";
       ok(img.currentSrc.endsWith("non_existent_image.404"), "Should have synchronously selected source");
 
       img.removeAttribute("src");
-      is(img.currentSrc, null, "Should have dropped currentSrc");
+      is(img.currentSrc, '', "Should have dropped currentSrc");
 
       // Load another image while previous load is still pending
       img.src = testPNG200;
       is(img.currentSrc, testPNG200, "Should have synchronously selected source");
 
       // No events should have fired synchronously, now we should get just one load (and no 404 error)
       expectEvents(1, 0, nextTest);
     });
--- a/dom/tests/mochitest/general/test_picture_mutations.html
+++ b/dom/tests/mochitest/general/test_picture_mutations.html
@@ -60,17 +60,17 @@
       }
     }
 
     // Setup image outside the tree dom, make sure it loads
     tests.push(function() {
       info("test 1");
       img.srcset = testPNG100;
       img.src = testPNG50;
-      is(img.currentSrc, null, "Should not have synchronously selected source");
+      is(img.currentSrc, '', "Should not have synchronously selected source");
 
       // No events should have fired synchronously, now we should get just one load (and no 404 error)
       expectEvents(1, 0, nextTest);
     });
 
     // Binding to an empty picture should trigger an event, even if source doesn't change
     tests.push(function() {
       info("test 2");