Bug 1499222 - Fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
authoraceman <acelists@atlas.sk>
Mon, 15 Oct 2018 15:39:00 +0300
changeset 500053 fdfa6fafe6a92e227839353e4eb2195016eca135
parent 500052 89189817c169f830f2b880df11ac88569582a67e
child 500054 04c3f543129b1aa54b9beae33304c881bb33d5e2
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskmag
bugs1499222
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1499222 - Fix typo of node.listChild in extensions.js, fixing sorting of addons in addon manager. r=kmag
toolkit/mozapps/extensions/content/extensions.js
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -1636,18 +1636,18 @@ function sortElements(aElements, aSortBy
 
   });
 }
 
 function sortList(aList, aSortBy, aAscending) {
   var elements = Array.slice(aList.childNodes, 0);
   sortElements(elements, [aSortBy], aAscending);
 
-  while (aList.listChild)
-    aList.removeChild(aList.lastChild);
+  while (aList.lastChild)
+    aList.lastChild.remove();
 
   for (let element of elements)
     aList.appendChild(element);
 }
 
 async function getAddonsAndInstalls(aType, aCallback) {
   let addons = null, installs = null;
   let types = (aType != null) ? [aType] : null;