author | Sylvestre Ledru <sledru@mozilla.com> |
Thu, 29 Aug 2019 16:44:31 +0000 | |
changeset 554433 | fcc8383a1c4f04e0309463c778d6aeaa9aa7acdf |
parent 554432 | 08faaf9d4ef714eea2daea43c137cd02609830e5 |
child 554434 | a4768bd82d57d0560d9f55750d0dc61822d4138d |
push id | 2165 |
push user | ffxbld-merge |
push date | Mon, 14 Oct 2019 16:30:58 +0000 |
treeherder | mozilla-release@0eae18af659f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | jandem |
bugs | 1577236 |
milestone | 70.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/js/src/gc/Nursery.cpp +++ b/js/src/gc/Nursery.cpp @@ -1374,17 +1374,17 @@ void js::Nursery::maybeResizeNursery(JS: // relationship that works for all programs and can be predicted in // advance doesn't exist. static const float GrowThreshold = 0.03f; static const float ShrinkThreshold = 0.01f; static const float PromotionGoal = (GrowThreshold + ShrinkThreshold) / 2.0f; const float factor = promotionRate / PromotionGoal; MOZ_ASSERT(factor >= 0.0f); - MOZ_ASSERT((float(capacity()) * factor) <= SIZE_MAX); + MOZ_ASSERT((float(capacity()) * factor) <= float(SIZE_MAX)); size_t newCapacity = size_t(float(capacity()) * factor); const size_t minNurseryBytes = roundSize(tunables().gcMinNurseryBytes()); MOZ_ASSERT(minNurseryBytes >= ArenaSize); // If one of these conditions is true then we always shrink or grow the // nursery. This way the thresholds still have an effect even if the goal // seeking says the current size is ideal.