Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in /js/ r=jandem
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 29 Aug 2019 16:44:31 +0000
changeset 554433 fcc8383a1c4f04e0309463c778d6aeaa9aa7acdf
parent 554432 08faaf9d4ef714eea2daea43c137cd02609830e5
child 554434 a4768bd82d57d0560d9f55750d0dc61822d4138d
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1577236
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in /js/ r=jandem Differential Revision: https://phabricator.services.mozilla.com/D43783
js/src/gc/Nursery.cpp
--- a/js/src/gc/Nursery.cpp
+++ b/js/src/gc/Nursery.cpp
@@ -1374,17 +1374,17 @@ void js::Nursery::maybeResizeNursery(JS:
   // relationship that works for all programs and can be predicted in
   // advance doesn't exist.
   static const float GrowThreshold = 0.03f;
   static const float ShrinkThreshold = 0.01f;
   static const float PromotionGoal = (GrowThreshold + ShrinkThreshold) / 2.0f;
   const float factor = promotionRate / PromotionGoal;
   MOZ_ASSERT(factor >= 0.0f);
 
-  MOZ_ASSERT((float(capacity()) * factor) <= SIZE_MAX);
+  MOZ_ASSERT((float(capacity()) * factor) <= float(SIZE_MAX));
   size_t newCapacity = size_t(float(capacity()) * factor);
 
   const size_t minNurseryBytes = roundSize(tunables().gcMinNurseryBytes());
   MOZ_ASSERT(minNurseryBytes >= ArenaSize);
 
   // If one of these conditions is true then we always shrink or grow the
   // nursery. This way the thresholds still have an effect even if the goal
   // seeking says the current size is ideal.