author | shindli <shindli@mozilla.com> |
Tue, 24 Apr 2018 16:01:29 +0300 | |
changeset 471380 | fc39571cc03ac7f5fcff5f7ec047638331d09165 |
parent 471379 | f8cac1a891b5a7343b4ae359d4a987a58f025cda |
child 471381 | 05f610551597897caff8addc87f33179ae2ba8e7 |
push id | 1728 |
push user | jlund@mozilla.com |
push date | Mon, 18 Jun 2018 21:12:27 +0000 |
treeherder | mozilla-release@c296fde26f5f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
bugs | 1455275 |
milestone | 61.0a1 |
backs out | 6e691c7ff5dd229d4ad84177e52d51e512bb0a92 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/devtools/client/framework/toolbox.js +++ b/devtools/client/framework/toolbox.js @@ -1992,22 +1992,16 @@ Toolbox.prototype = { * @returns {Promise} a promise that resolves once the tool has been * closed. */ closeSplitConsole: function() { this._splitConsole = false; Services.prefs.setBoolPref(SPLITCONSOLE_ENABLED_PREF, false); this._refreshConsoleDisplay(); this.component.setIsSplitConsoleActive(false); - - this._telemetry.recordEvent("devtools.main", "deactivate", "split_console", null, { - "host": this._getTelemetryHostString(), - "width": Math.ceil(this.win.outerWidth / 50) * 50 - }); - this.emit("split-console"); if (this._lastFocusedElement) { this._lastFocusedElement.focus(); } return promise.resolve(); },
--- a/devtools/client/responsive.html/manager.js +++ b/devtools/client/responsive.html/manager.js @@ -147,25 +147,16 @@ const ResponsiveUIManager = exports.Resp async closeIfNeeded(window, tab, options = {}) { if (this.isActiveForTab(tab)) { let ui = this.activeTabs.get(tab); let destroyed = await ui.destroy(options); if (!destroyed) { // Already in the process of destroying, abort. return; } - const toolbox = gDevTools.getToolbox(TargetFactory.forTab(tab)); - const hostType = toolbox ? toolbox.hostType : "none"; - - const t = this._telemetry; - t.recordEvent("devtools.main", "deactivate", "responsive_design", null, { - "host": hostType, - "width": Math.ceil(window.outerWidth / 50) * 50 - }); - this.activeTabs.delete(tab); if (!this.isActiveForWindow(window)) { this.removeMenuCheckListenerFor(window); } this.emit("off", { tab }); await this.setMenuCheckFor(tab, window); }
--- a/toolkit/components/telemetry/Events.yaml +++ b/toolkit/components/telemetry/Events.yaml @@ -223,19 +223,8 @@ devtools.main: notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"] record_in_processes: ["main"] description: User activates the responsive_design or split_console in the devtools toolbox. release_channel_collection: opt-out expiry_version: never extra_keys: host: "Toolbox host (positioning): bottom, side, window or other." width: Toolbox width rounded up to the nearest 50px. - deactivate: - objects: ["responsive_design", "split_console"] - bug_numbers: [1455275] - notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"] - record_in_processes: ["main"] - description: User deactivates the responsive_design or split_console in the devtools toolbox. - release_channel_collection: opt-out - expiry_version: never - extra_keys: - host: "Toolbox host (positioning): bottom, side, window or other." - width: Toolbox width rounded up to the nearest 50px.