Bug 1549761 - Require user interaction for push notification permission prompts (with post-prompting) in Beta. r=Ehsan
authorJohann Hofmann <jhofmann@mozilla.com>
Tue, 07 May 2019 17:15:18 +0000
changeset 534822 fbdbe72f12e42fc3937c89768f24a50ff709f1c2
parent 534821 45f82a11656c33e633132d8c4d54841e42cc97dc
child 534823 6c0d9bd9f398bcff4da0dc15a49a87d060dff9be
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersEhsan
bugs1549761
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549761 - Require user interaction for push notification permission prompts (with post-prompting) in Beta. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D30219
browser/app/profile/firefox.js
modules/libpref/init/StaticPrefList.h
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -406,17 +406,17 @@ pref("permissions.manager.defaultsUrl", 
 // Set default fallback values for site permissions we want
 // the user to be able to globally change.
 pref("permissions.default.camera", 0);
 pref("permissions.default.microphone", 0);
 pref("permissions.default.geo", 0);
 pref("permissions.default.desktop-notification", 0);
 pref("permissions.default.shortcuts", 0);
 
-#ifdef NIGHTLY_BUILD
+#ifdef EARLY_BETA_OR_EARLIER
 pref("permissions.desktop-notification.postPrompt.enabled", true);
 #else
 pref("permissions.desktop-notification.postPrompt.enabled", false);
 #endif
 
 pref("permissions.postPrompt.animate", true);
 
 // This is primarily meant to be enabled for studies.
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -361,17 +361,17 @@ VARCACHE_PREF(
 )
 
 VARCACHE_PREF(
   "dom.webnotifications.allowinsecure",
    dom_webnotifications_allowinsecure,
   RelaxedAtomicBool, false
 )
 
-#ifdef NIGHTLY_BUILD
+#ifdef EARLY_BETA_OR_EARLIER
 # define PREF_VALUE  true
 #else
 # define PREF_VALUE  false
 #endif
 VARCACHE_PREF(
   "dom.webnotifications.requireuserinteraction",
    dom_webnotifications_requireuserinteraction,
   RelaxedAtomicBool, PREF_VALUE