Bug 1457242 [wpt PR 10663] - Remove WPT failure expectations for (now enabled by default) CORB., a=testonly
authorLukasz Anforowicz <lukasza@chromium.org>
Tue, 01 May 2018 15:05:19 +0000
changeset 472679 fbad24e30c7eed89eb231d1216af610740ff561a
parent 472678 daddee6041de32db93792fcb062fc0b307549918
child 472680 b3567cea932e4e39c2e37be43abc4af184aa6211
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1457242, 10663, 802835, 1030612, 554192
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457242 [wpt PR 10663] - Remove WPT failure expectations for (now enabled by default) CORB., a=testonly Automatic update from web-platform-testsRemove WPT failure expectations for (now enabled by default) CORB. The failure expectations for some wpt/fetch/corb/*tentative* tests were only needed while CORB was still disabled by default. These test expectations can be removed now, because CORB is enabled by default since r553830. Bug: 802835 Change-Id: If09646e3cfec268e2a9ec72aa870d8fa2a4460e3 Reviewed-on: https://chromium-review.googlesource.com/1030612 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#554192} -- wpt-commits: 4f397167b4ed552a02201c92d363cfaecfe2c7f0 wpt-pr: 10663
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/fetch/corb/README.md
testing/web-platform/tests/fetch/corb/img-mime-types-coverage.tentative.sub.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -558400,29 +558400,29 @@
    "e44dd96e3b44815ff44551b6682ed6640f905928",
    "testharness"
   ],
   "fetch/content-encoding/resources/bad-gzip-body.py": [
    "b6053e53d641cd7f6575096cbf6854c52be82d20",
    "support"
   ],
   "fetch/corb/README.md": [
-   "7f3ebd888c16f457c7f137362cff620ae2cc82b3",
+   "d532c359cdb1359f88ef79afff88052b3387dbf6",
    "support"
   ],
   "fetch/corb/img-html-correctly-labeled.sub-expected.html": [
    "a252054121e7f50a3bcb949ae5a40f278c842c04",
    "support"
   ],
   "fetch/corb/img-html-correctly-labeled.sub.html": [
    "699a8b2c8bb1f089f3ef1827bf8cfe1873849bf8",
    "reftest"
   ],
   "fetch/corb/img-mime-types-coverage.tentative.sub.html": [
-   "ccceb2eab638a0e7c88c6e3eed45c51148e0f406",
+   "58422f923455c1f62e0c4e743b1c900061657146",
    "testharness"
   ],
   "fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub-expected.html": [
    "1980633a4167993d90636be2ebba2aa8d72299b7",
    "support"
   ],
   "fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html": [
    "7169e4ebe99797d15f006f6787e84093780fbaa6",
--- a/testing/web-platform/tests/fetch/corb/README.md
+++ b/testing/web-platform/tests/fetch/corb/README.md
@@ -21,28 +21,18 @@ sure that CORB doesn't change the existi
 valuable independently from CORB's standardization efforts.
 
 Tests that cover behavior that is changed by CORB have to be marked as
 [tentative](http://web-platform-tests.org/writing-tests/file-names.html)
 (using `.tentative` substring in their filename) until CORB
 is included in the official
 [Fetch spec](https://fetch.spec.whatwg.org/).  Such tests may fail unless
 CORB is enabled.  In practice this means that:
-* Such tests will fail in default Chromium and have to be listed
-  in `third_party/WebKit/LayoutTests/TestExpectations` and associated
-  with https://crbug.com/802835.
-* Such tests will pass in Chromium when either
-  1) CORB is explicitly, manually enabled by passing extra cmdline flags to
-     `run-webkit-tests`:
-     `--additional-driver-flag=--enable-features=CrossSiteDocumentBlockingAlways` and
-     `--additional-expectations=third_party/WebKit/LayoutTests/FlagExpectations/site-per-process`.
-  2) CORB is implicitly enabled via Site Isolation (e.g. in
-     `site_per_process_webkit_layout_tests` step on the test bots).  The
-     expectations that the tests pass in this mode is controlled by the
-     `third_party/WebKit/LayoutTests/FlagExpectations/site-per-process` file.
+* Such tests will pass in Chromium
+  (where CORB is enabled by default [since M68](https://crrev.com/553830)).
 * Such tests may fail in other browsers.
 
 
 ### Limitations of WPT test coverage
 
 CORB is a defense-in-depth and in general should not cause changes in behavior
 that can be observed by web features or by end users.  This makes CORB difficult
 or even impossible to test via WPT.
--- a/testing/web-platform/tests/fetch/corb/img-mime-types-coverage.tentative.sub.html
+++ b/testing/web-platform/tests/fetch/corb/img-mime-types-coverage.tentative.sub.html
@@ -23,17 +23,17 @@
       // MIME types that may seem to be JSON or XML, but really aren't - i.e.
       // these MIME types are not covered by:
       // - https://mimesniff.spec.whatwg.org/#json-mime-type
       // - https://mimesniff.spec.whatwg.org/#xml-mime-type
       // - https://tools.ietf.org/html/rfc6839
       // - https://tools.ietf.org/html/rfc7303
       "text/x-json", "text/json+blah", "application/json+blah",
       "text/xml+blah", "application/xml+blah",
-      "application/blahjson", "text/blahxml",
+      "application/blahjson", "text/blahxml"]
 
   var fails = [
       // CORB-protected MIME-types - i.e. ones covered by:
       // - https://mimesniff.spec.whatwg.org/#html-mime-type
       // - https://mimesniff.spec.whatwg.org/#json-mime-type
       // - https://mimesniff.spec.whatwg.org/#xml-mime-type
       "text/html",
       "text/json", "application/json", "text/xml", "application/xml",