Bug 1511795 - Convert TestMainTabScalars to use unittest TestCase assert methods; r=chutten
authorRaphael Pierzina <rpierzina@mozilla.com>
Wed, 05 Dec 2018 14:14:48 +0000
changeset 508630 fb51ef38b61ba4989e4b178b8984c1376e57eaf3
parent 508629 65a44b43b7b69c066abcb864076003252abc475e
child 508631 7c58f1010e376df70c61afd96dfb531ca9145374
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschutten
bugs1511795
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1511795 - Convert TestMainTabScalars to use unittest TestCase assert methods; r=chutten Differential Revision: https://phabricator.services.mozilla.com/D13668
toolkit/components/telemetry/tests/marionette/tests/client/test_main_tab_scalars.py
--- a/toolkit/components/telemetry/tests/marionette/tests/client/test_main_tab_scalars.py
+++ b/toolkit/components/telemetry/tests/marionette/tests/client/test_main_tab_scalars.py
@@ -23,15 +23,16 @@ class TestMainTabScalars(TelemetryTestCa
 
             self.browser.tabbar.close_tab(tab3, force=True)
             self.browser.tabbar.close_tab(tab2, force=True)
 
             self.browser.tabbar.switch_to(tab1)
 
         ping = self.wait_for_ping(self.restart_browser, MAIN_SHUTDOWN_PING)
 
-        assert ping["type"] == "main"
-        assert ping["clientId"] == self.client_id
+        self.assertEqual(ping["type"], "main")
+        self.assertEqual(ping["clientId"], self.client_id)
 
         scalars = ping["payload"]["processes"]["parent"]["scalars"]
-        assert scalars["browser.engagement.max_concurrent_tab_count"] == 3
-        assert scalars["browser.engagement.tab_open_event_count"] == 2
-        assert scalars["browser.engagement.max_concurrent_window_count"] == 1
+
+        self.assertEqual(scalars["browser.engagement.max_concurrent_tab_count"], 3)
+        self.assertEqual(scalars["browser.engagement.tab_open_event_count"], 2)
+        self.assertEqual(scalars["browser.engagement.max_concurrent_window_count"], 1)