Mark ShallowCopy as override to fix bustage (bug 1399692, r=me)
☠☠ backed out by b2375c59ecd9 ☠ ☠
authorRyan Hunt <rhunt@eqrion.net>
Thu, 02 Nov 2017 17:43:52 -0400
changeset 443208 fac6f595967bd6d876b2dc23854fa3a9297b8698
parent 443207 f46a10fded3e8a2a445893223ec7af0410361d93
child 443209 f3f80a126bbbca1df7c8421febf2e42454a290a2
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1399692
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Mark ShallowCopy as override to fix bustage (bug 1399692, r=me) MozReview-Commit-ID: 2LIxzNFrcA3
gfx/layers/RotatedBuffer.h
--- a/gfx/layers/RotatedBuffer.h
+++ b/gfx/layers/RotatedBuffer.h
@@ -333,17 +333,17 @@ public:
   virtual already_AddRefed<gfx::SourceSurface> GetSourceSurface(ContextSource aSource) const override;
 
   virtual gfx::DrawTarget* GetDTBuffer() const override;
   virtual gfx::DrawTarget* GetDTBufferOnWhite() const override;
 
   virtual TextureClient* GetClient() const override { return mClient; }
   virtual TextureClient* GetClientOnWhite() const override { return mClientOnWhite; }
 
-  virtual RefPtr<RotatedBuffer> ShallowCopy() const {
+  virtual RefPtr<RotatedBuffer> ShallowCopy() const override {
     return new RemoteRotatedBuffer {
       mClient, mClientOnWhite,
       mTarget, mTargetOnWhite,
       mBufferRect, mBufferRotation
     };
   }
 
   void SyncWithObject(SyncObjectClient* aSyncObject);
@@ -392,17 +392,17 @@ public:
 
   virtual gfx::SurfaceFormat GetFormat() const override;
 
   virtual already_AddRefed<gfx::SourceSurface> GetSourceSurface(ContextSource aSource) const override;
 
   virtual gfx::DrawTarget* GetDTBuffer() const override;
   virtual gfx::DrawTarget* GetDTBufferOnWhite() const override;
 
-  virtual RefPtr<RotatedBuffer> ShallowCopy() const {
+  virtual RefPtr<RotatedBuffer> ShallowCopy() const override {
     return new DrawTargetRotatedBuffer {
         mTarget, mTargetOnWhite,
         mBufferRect, mBufferRotation
       };
   }
 
 private:
   RefPtr<gfx::DrawTarget> mTarget;
@@ -433,17 +433,17 @@ public:
   virtual gfx::SurfaceFormat GetFormat() const override;
 
   virtual bool HaveBuffer() const override { return !!mSource; }
   virtual bool HaveBufferOnWhite() const override { return !!mSourceOnWhite; }
 
   virtual gfx::DrawTarget* GetDTBuffer() const override { return nullptr; }
   virtual gfx::DrawTarget* GetDTBufferOnWhite() const override { return nullptr; }
 
-  virtual RefPtr<RotatedBuffer> ShallowCopy() const {
+  virtual RefPtr<RotatedBuffer> ShallowCopy() const override {
     return nullptr;
   }
 
 private:
   RefPtr<gfx::SourceSurface> mSource;
   RefPtr<gfx::SourceSurface> mSourceOnWhite;
 };