Bug 1509211 [wpt PR 14173] - [LayoutNG] Rebaseline quirky test that actually passes., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Tue, 27 Nov 2018 20:12:06 +0000
changeset 507938 f95c3eb84ad6fe9b33766df8ff54a1580f67aa89
parent 507937 48ab9c0a88dd621d6ab0bbecd20746943a6383dc
child 507939 3716a1d0c0c110e1cfe801429e001f59d80cce77
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1509211, 14173, 845902, 1346465, 610216
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1509211 [wpt PR 14173] - [LayoutNG] Rebaseline quirky test that actually passes., a=testonly Automatic update from web-platform-tests[LayoutNG] Rebaseline quirky test that actually passes. (writing-mode has nothing to do with it, FWIW) Legacy layout is buggy here, so the expected rendering was wrong. Also wrote a new wpt test for this. When calculating quirky line height, the legacy engine makes room for whitespace that is to be collapsed. Bug: 845902 Change-Id: I004d024578bb147d4f70c58fc1e3213a14174fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1346465 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610216} -- wpt-commits: f5a1cc435d35fbe72fd29f89ecea9fdc8168bec7 wpt-pr: 14173
testing/web-platform/tests/quirks/line-height-trailing-collapsable-whitespace-ref.html
testing/web-platform/tests/quirks/line-height-trailing-collapsable-whitespace.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/quirks/line-height-trailing-collapsable-whitespace-ref.html
@@ -0,0 +1,4 @@
+<!-- quirks mode -->
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="width:100px; height:100px; background:green;"></div>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/quirks/line-height-trailing-collapsable-whitespace.html
@@ -0,0 +1,12 @@
+<!-- quirks mode -->
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://quirks.spec.whatwg.org/#the-blocks-ignore-line-height-quirk">
+<link rel="match" href="line-height-trailing-collapsable-whitespace-ref.html">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="font-size:100px;">
+  <div style="display:inline-block; width:100px; height:50px; background:green;"></div>
+  <!-- Having collapsable whitespace here triggers a bug in Blink.
+       See crbug.com/845902#c2 -->
+  <br>
+  <div style="width:100px; height:50px; background:green;"></div>
+</div>