Bug 1166646 - WINDOW_ENABLED telemetry key is falsy, thus not working. Check for its type properly. r=Standard8, a=lizzard
--- a/browser/components/loop/content/shared/js/otSdkDriver.js
+++ b/browser/components/loop/content/shared/js/otSdkDriver.js
@@ -847,17 +847,17 @@ loop.OTSdkDriver = (function() {
*/
_noteSharingState: function(type, enabled) {
if (!this.mozLoop) {
return;
}
var bucket = this.mozLoop.SHARING_STATE_CHANGE[type.toUpperCase() + "_" +
(enabled ? "ENABLED" : "DISABLED")];
- if (!bucket) {
+ if (typeof bucket === "undefined") {
console.error("No sharing state bucket found for '" + type + "'");
return;
}
this.mozLoop.telemetryAddValue("LOOP_SHARING_STATE_CHANGE_1", bucket);
}
};
--- a/browser/components/loop/test/shared/otSdkDriver_test.js
+++ b/browser/components/loop/test/shared/otSdkDriver_test.js
@@ -65,26 +65,26 @@ describe("loop.OTSdkDriver", function ()
ExceptionCodes: {
UNABLE_TO_PUBLISH: 1500
}
};
mozLoop = {
telemetryAddValue: sinon.stub(),
TWO_WAY_MEDIA_CONN_LENGTH: {
- SHORTER_THAN_10S: "SHORTER_THAN_10S",
- BETWEEN_10S_AND_30S: "BETWEEN_10S_AND_30S",
- BETWEEN_30S_AND_5M: "BETWEEN_30S_AND_5M",
- MORE_THAN_5M: "MORE_THAN_5M"
+ SHORTER_THAN_10S: 0,
+ BETWEEN_10S_AND_30S: 1,
+ BETWEEN_30S_AND_5M: 2,
+ MORE_THAN_5M: 3
},
SHARING_STATE_CHANGE: {
- WINDOW_ENABLED: "WINDOW_ENABLED",
- WINDOW_DISABLED: "WINDOW_DISABLED",
- BROWSER_ENABLED: "BROWSER_ENABLED",
- BROWSER_DISABLED: "BROWSER_DISABLED"
+ WINDOW_ENABLED: 0,
+ WINDOW_DISABLED: 1,
+ BROWSER_ENABLED: 2,
+ BROWSER_DISABLED: 3
}
};
driver = new loop.OTSdkDriver({
dispatcher: dispatcher,
sdk: sdk,
mozLoop: mozLoop,
isDesktop: true