Bug 1607716 - Re-add the mozCollapsed static atom. r=heycam, a=pascalc
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 01 Jan 1970 00:00:00 +0000
changeset 579431 f875f6df03c56211dc9b1751258157563e5d7729
parent 579430 07eaadc8461984cadfcd835f6ad27b5fc5596305
child 579432 47bc0dc40c851e869295e0c6b16050eb8c21f4c9
push id2278
push userryanvm@gmail.com
push dateTue, 03 Mar 2020 21:15:57 +0000
treeherdermozilla-release@f875f6df03c5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam, pascalc
bugs1607716, 1434087
Bug 1607716 - Re-add the mozCollapsed static atom. r=heycam, a=pascalc In theory this shouldn't be needed - we removed the atom alongside the selector using it in minimal-xul.css at the same time in Bug 1434087: https://hg.mozilla.org/mozilla-central/rev/53ebedebdb63 But somehow it is - we are seeing crashes on release 72 that imply the style system is encountering the removed `[moz-collapsed="true"]` selector. As best as we can tell, this means that we are loading an outdated version of chrome://global/content/minimal-xul.css at startup. This patch should fix the crash by re-adding the static atom, which allows the style system to work again. Differential Revision: https://phabricator.services.mozilla.com/D59192
--- a/xpcom/ds/StaticAtoms.py
+++ b/xpcom/ds/StaticAtoms.py
@@ -655,16 +655,17 @@ STATIC_ATOMS = [
     Atom("messagemanagergroup", "messagemanagergroup"),
     Atom("mod", "mod"),
     Atom("mode", "mode"),
     Atom("modifiers", "modifiers"),
     Atom("monochrome", "monochrome"),
     Atom("mouseover", "mouseover"),
     Atom("mozAccessiblecaret", "moz-accessiblecaret"),
     Atom("mozCustomContentContainer", "moz-custom-content-container"),
+    Atom("mozCollapsed", "moz-collapsed"),
     Atom("mozGrabber", "mozGrabber"),
     Atom("mozNativeAnonymous", "-moz-native-anonymous"),
     Atom("mozNativeAnonymousNoSpecificity", "-moz-native-anonymous-no-specificity"),
     Atom("mozprivatebrowsing", "mozprivatebrowsing"),
     Atom("mozResizer", "mozResizer"),
     Atom("mozResizingInfo", "mozResizingInfo"),
     Atom("mozResizingShadow", "mozResizingShadow"),
     Atom("mozTableAddColumnAfter", "mozTableAddColumnAfter"),