Bug 1520310 - Disable SANDBOX_EXPORTS for the mingw-clang build as well r=bobowen
authorTom Ritter <tom@mozilla.com>
Mon, 21 Jan 2019 11:42:03 -0600
changeset 514792 f83bdfcf0804d0e294fd41497208f92e418ad213
parent 514791 44be6c1eb581bdd91023174d70f5b49052904945
child 514793 f0c23db0d035dbe81e23eb4d619e493e38582d24
child 514814 d358a9083413cb023f6875a8432ead7bafa1f1d2
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen
bugs1520310
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520310 - Disable SANDBOX_EXPORTS for the mingw-clang build as well r=bobowen
security/sandbox/moz.build
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -154,17 +154,17 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
     for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
-    if CONFIG['CC_TYPE'] != 'gcc':
+    if CONFIG['CC_TYPE'] not in ('gcc', 'clang'):
         DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()