Bug 1330240 - Limit -Wthread-safety to WebRTC due to lack of annotations. r=cpeterson,froydnj,jesup a=gchang
authorJan Beich <jbeich@FreeBSD.org>
Wed, 11 Jan 2017 16:50:18 +0000
changeset 379194 f6e3c8ec61337e3cdea66a60dc4ba6e5ffb51fd2
parent 379193 2bbf316c5d61239405d741d66424549ff06e94ab
child 379195 264bb4d0c084c21885d95191250b0401274dba9f
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpeterson, froydnj, jesup, gchang
bugs1330240
milestone53.0
Bug 1330240 - Limit -Wthread-safety to WebRTC due to lack of annotations. r=cpeterson,froydnj,jesup a=gchang MozReview-Commit-ID: HuoXFwZkdYo
build/moz.configure/warnings.configure
media/webrtc/trunk/webrtc/build/common.gypi
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -73,19 +73,16 @@ check_and_add_gcc_warning('-Wimplicit-fa
 # --enable-warnings-as-errors is specified so that no unexpected fatal
 # warnings are produced.
 check_and_add_gcc_warning('-Werror=non-literal-null-conversion',
                           when='--enable-warnings-as-errors')
 
 # catches string literals used in boolean expressions
 check_and_add_gcc_warning('-Wstring-conversion')
 
-# catches inconsistent use of mutexes
-check_and_add_gcc_warning('-Wthread-safety')
-
 # we inline 'new' and 'delete' in mozalloc
 check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 
 # Prevent the following GCC warnings from being treated as errors:
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
 # we don't want our builds held hostage when a platform-specific API
--- a/media/webrtc/trunk/webrtc/build/common.gypi
+++ b/media/webrtc/trunk/webrtc/build/common.gypi
@@ -321,16 +321,19 @@
               '-Woverloaded-virtual',
             ],
           }],
           ['clang==1', {
             'cflags': [
               '-Wimplicit-fallthrough',
               '-Wthread-safety',
             ],
+            'cflags_mozilla': [
+              '-Wthread-safety',
+            ],
           }],
         ],
       }],
       ['target_arch=="arm64"', {
         'defines': [
           'WEBRTC_ARCH_ARM64',
           'WEBRTC_HAS_NEON',
         ],