Bug 1042163 - Visual issues with the global indicator for screen/device sharing, r=Gijs, a=sledru.
authorFlorian Quèze <florian@queze.net>
Fri, 01 Aug 2014 15:18:29 +0200
changeset 217370 f6a784dd39871cd2127df3cfbd228fb598ab89d7
parent 217369 27bf19b959fc93ee0eea7577c40d8332ce418022
child 217371 2597220a5926ef85476b09d09f2475956cc32c7c
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, sledru
bugs1042163
milestone33.0a2
Bug 1042163 - Visual issues with the global indicator for screen/device sharing, r=Gijs, a=sledru.
browser/base/content/webrtcIndicator.js
browser/themes/shared/webrtc/indicator.css
--- a/browser/base/content/webrtcIndicator.js
+++ b/browser/base/content/webrtcIndicator.js
@@ -87,28 +87,27 @@ function onPopupMenuShowing(event) {
   let activeStreams;
   if (type == "Devices")
     activeStreams = webrtcUI.getActiveStreams(true, true, false);
   else
     activeStreams = webrtcUI.getActiveStreams(false, false, true);
 
   if (activeStreams.length == 1) {
     webrtcUI.showSharingDoorhanger(activeStreams[0], type);
-    return false;
+    event.preventDefault();
+    return;
   }
 
   for (let stream of activeStreams) {
     let item = document.createElement("menuitem");
     item.setAttribute("label", stream.browser.contentTitle || stream.uri);
     item.setAttribute("tooltiptext", stream.uri);
     item.stream = stream;
     popup.appendChild(item);
   }
-
-  return true;
 }
 
 function onPopupMenuHiding(event) {
   let popup = event.target;
   while (popup.firstChild)
     popup.firstChild.remove();
 }
 
--- a/browser/themes/shared/webrtc/indicator.css
+++ b/browser/themes/shared/webrtc/indicator.css
@@ -104,8 +104,13 @@ window[sharingaudio][sharingvideo] > #au
   z-index: 1;
   display: none;
 }
 
 window[sharingscreen][sharingvideo] > #shareSeparator,
 window[sharingscreen][sharingaudio] > #shareSeparator {
   display: -moz-box;
 }
+
+:-moz-any(#audioVideoButton, #screenShareButton,
+          #firefoxButton):-moz-focusring > .button-box {
+  border: none;
+}