Bug 1046839 - Unnecessary double cloneInto in mozSettings, r=bholley
authorAndrea Marchesini <amarchesini@mozilla.com>
Thu, 31 Jul 2014 17:46:23 +0100
changeset 219958 f644ef79d9eeaab96efd61fd089e050305aa500c
parent 219957 47bba71f4c666a84a1301b19c154d730da6158f3
child 219959 3069d118d21d9b4c238c8dc202fa296809a619e7
push id583
push userbhearsum@mozilla.com
push dateMon, 24 Nov 2014 19:04:58 +0000
treeherdermozilla-release@c107e74250f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbholley
bugs1046839
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1046839 - Unnecessary double cloneInto in mozSettings, r=bholley
dom/settings/SettingsManager.js
--- a/dom/settings/SettingsManager.js
+++ b/dom/settings/SettingsManager.js
@@ -138,18 +138,17 @@ SettingsLock.prototype = {
             }
 
             let results = {};
 
             for (var i in event.target.result) {
               let result = event.target.result[i];
               var name = result.settingName;
               if (DEBUG) debug("VAL: " + result.userValue +", " + result.defaultValue + "\n");
-              var value = result.userValue !== undefined ? result.userValue : result.defaultValue;
-              results[name] = this._wrap(value);
+              results[name] = result.userValue !== undefined ? result.userValue : result.defaultValue;
             }
 
             this._open = true;
             Services.DOMRequest.fireSuccess(request, this._wrap(results));
             this._open = false;
           }.bind(lock);
 
           getReq.onerror = function() {