Bug 1507914 - Report actual invalid value if heap-unclassified is negative. r=erahm
authorKartikaya Gupta <kgupta@mozilla.com>
Mon, 26 Nov 2018 17:49:03 +0000
changeset 507286 f61bf65fceaa591e9b3d6516457ab4039dd71a96
parent 507220 f38d34679027acdcb303231cadbc7aef1849af53
child 507287 725677ef4b8ede4401b7ffb71dd627be2a8ccea5
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1507914
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507914 - Report actual invalid value if heap-unclassified is negative. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D12169
testing/awsy/awsy/parse_about_memory.py
--- a/testing/awsy/awsy/parse_about_memory.py
+++ b/testing/awsy/awsy/parse_about_memory.py
@@ -59,17 +59,17 @@ def path_total(data, path):
         # Memory reports should always include heap-allocated. If it's missing
         # just assert.
         assert process in heap_allocated
 
         unclassified = heap_allocated[process] - explicit_heap[process]
 
         # Make sure the value is sane. A misbehaving reporter could lead to
         # negative values.
-        assert unclassified >= 0
+        assert unclassified >= 0, "heap-unclassified was negative: %d" % unclassified
 
         return unclassified
 
 
     needs_bookkeeping = path in ("explicit/", "explicit/heap-unclassified")
 
     # Process all the reports.
     for report in data["reports"]: