Bug 1550582 - Add wrench reftest r=gw
authorJamie Nicol <jnicol@mozilla.com>
Wed, 15 May 2019 10:45:25 +0000
changeset 535805 f613e818e43507bc9f900f3756a6921890427775
parent 535804 93299787ec39d62a5832b7494fd3cf5dcdcbca7c
child 535806 f6ae1491321623380e67115dc649d6b22ff84c6d
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgw
bugs1550582
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550582 - Add wrench reftest r=gw Rename the old overlapping corners testcase and add comments to make the tests' purposes clearer: * The existing one is testing that a corner is clipped correctly when it overlaps with an adjacent corner. * The new one is testing that corners and segments are clipped correctly when opposite edges of the border overlap. Depends on D30814 Differential Revision: https://phabricator.services.mozilla.com/D30815
gfx/wr/wrench/reftests/border/border-overlapping-corner-ref.yaml
gfx/wr/wrench/reftests/border/border-overlapping-corner.yaml
gfx/wr/wrench/reftests/border/border-overlapping-edge-ref.yaml
gfx/wr/wrench/reftests/border/border-overlapping-edge.yaml
gfx/wr/wrench/reftests/border/border-overlapping-ref.yaml
gfx/wr/wrench/reftests/border/border-overlapping.yaml
gfx/wr/wrench/reftests/border/reftest.list
rename from gfx/wr/wrench/reftests/border/border-overlapping-ref.yaml
rename to gfx/wr/wrench/reftests/border/border-overlapping-corner-ref.yaml
rename from gfx/wr/wrench/reftests/border/border-overlapping.yaml
rename to gfx/wr/wrench/reftests/border/border-overlapping-corner.yaml
--- a/gfx/wr/wrench/reftests/border/border-overlapping.yaml
+++ b/gfx/wr/wrench/reftests/border/border-overlapping-corner.yaml
@@ -1,9 +1,9 @@
----
+--- # Checks that corners are clipped correctly when they overlap with an adjacent corner
 root:
   items:
     - type: stacking-context
       bounds: [0, 0, 200, 200]
       items:
         - type: border
           bounds: [ 10, 10, 180, 180 ]
           width: 90
new file mode 100644
--- /dev/null
+++ b/gfx/wr/wrench/reftests/border/border-overlapping-edge-ref.yaml
@@ -0,0 +1,9 @@
+---
+root:
+  items:
+    - type: stacking-context
+      bounds: [0, 0, 120, 40]
+      items:
+        - type: rect
+          bounds: [ 10, 10, 100, 20 ]
+          color: [ 0, 0, 255, 0.5 ]
new file mode 100644
--- /dev/null
+++ b/gfx/wr/wrench/reftests/border/border-overlapping-edge.yaml
@@ -0,0 +1,12 @@
+--- # Checks that segments are clipped correctly when opposite edges of the border overlap
+root:
+  items:
+    - type: stacking-context
+      bounds: [0, 0, 120, 40]
+      items:
+        - type: border
+          bounds: [ 10, 10, 100, 20 ]
+          width: 15
+          border-type: normal
+          style: solid
+          color: [ [0, 0, 255, 0.5] ]
--- a/gfx/wr/wrench/reftests/border/reftest.list
+++ b/gfx/wr/wrench/reftests/border/reftest.list
@@ -1,16 +1,17 @@
 platform(linux,mac) == border-clamp-corner-radius.yaml border-clamp-corner-radius.png
 fuzzy(1,790) == border-gradient-simple.yaml border-gradient-simple-ref.yaml
 platform(linux,mac) == border-gradient-nine-patch.yaml border-gradient-nine-patch.png
 == border-radial-gradient-simple.yaml border-radial-gradient-simple-ref.yaml
 platform(linux,mac) == border-radial-gradient-nine-patch.yaml border-radial-gradient-nine-patch.png
 == border-radii.yaml border-radii.png
 == border-none.yaml border-none-ref.yaml
-fuzzy(1,68) == border-overlapping.yaml border-overlapping-ref.yaml
+fuzzy(1,68) == border-overlapping-corner.yaml border-overlapping-corner-ref.yaml
+== border-overlapping-edge.yaml border-overlapping-edge-ref.yaml
 == border-invisible.yaml border-invisible-ref.yaml
 platform(linux,mac) == border-suite.yaml border-suite.png
 platform(linux,mac) fuzzy(8,8) == border-suite-2.yaml border-suite-2.png
 platform(linux,mac) == border-suite-3.yaml border-suite-3.png
 == border-double-simple.yaml border-double-simple-ref.yaml
 == border-double-simple-2.yaml border-double-simple-2-ref.yaml
 fuzzy(64,24) == border-groove-simple.yaml border-groove-simple-ref.yaml
 fuzzy(64,24) == border-ridge-simple.yaml border-ridge-simple-ref.yaml