Bug 1039776 - http response version telemetry r=sworkman
authorPatrick McManus <mcmanus@ducksong.com>
Thu, 17 Jul 2014 21:54:04 -0400
changeset 216721 f5ed82bd6e6d1a03d0bdda0782f86a063bcd70bb
parent 216720 14c7a4ee44fcd6b34aee4a4f442e41d6ad4aabb0
child 216722 8ec752af1db9b704c9d68bb48a94df246a69f0d1
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssworkman
bugs1039776
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1039776 - http response version telemetry r=sworkman
netwerk/protocol/http/nsHttpChannel.cpp
toolkit/components/telemetry/Histograms.json
--- a/netwerk/protocol/http/nsHttpChannel.cpp
+++ b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -1363,16 +1363,18 @@ nsHttpChannel::ProcessResponse()
     if (!mDidReval)
         cacheDisposition = kCacheMissed;
     else if (successfulReval)
         cacheDisposition = kCacheHitViaReval;
     else
         cacheDisposition = kCacheMissedViaReval;
 
     AccumulateCacheHitTelemetry(cacheDisposition);
+    Telemetry::Accumulate(Telemetry::HTTP_RESPONSE_VERSION,
+                          mResponseHead->Version());
 
     return rv;
 }
 
 nsresult
 nsHttpChannel::ContinueProcessResponse(nsresult rv)
 {
     bool doNotRender = DoNotRender3xxBody(rv);
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -1266,16 +1266,22 @@
     "description": "Websockets Handshake Results (ws-ok-plain, ws-ok-proxy, ws-failed-plain, ws-failed-proxy, wss-ok-plain, wss-ok-proxy, wss-failed-plain, wss-failed-proxy)"
   },
   "SPDY_VERSION2": {
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 48,
     "description": "SPDY: Protocol Version Used"
   },
+  "HTTP_RESPONSE_VERSION": {
+    "expires_in_version": "never",
+    "kind": "enumerated",
+    "n_values": 48,
+    "description": "HTTP: Protocol Version Used on Response from nsHttp.h"
+  },
   "SPDY_PARALLEL_STREAMS": {
     "expires_in_version": "never",
     "kind": "exponential",
     "high": "1000",
     "n_buckets": 50,
     "extended_statistics_ok": true,
     "description": "SPDY: Streams concurrent active per connection"
   },