Bug 1521982 - Adjust callers of nsIFrame::List() in nsBidiPresUtils to stop passing 0 as a const char* argument. r=dholbert
authorTing-Yu Lin <aethanyc@gmail.com>
Wed, 23 Jan 2019 02:24:46 +0000
changeset 515187 f5e26b338d78849ec75c0fe26cd9ca8f82a4b780
parent 515186 5ddf079de2d371f2b5ee0d383f8dbdc1746afd60
child 515188 862a9e4f4cc877826d51acbcd3a6fbbd03d4f4d2
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1521982, 1503420
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521982 - Adjust callers of nsIFrame::List() in nsBidiPresUtils to stop passing 0 as a const char* argument. r=dholbert This patch is similar to Bug 1503420 Part 1. nsIFrame::List()'s second argument should be a const char*, not an integer. It'll crash if we pass 0 as const char*. Fix the bug by omitting the argument because the default value of the argument is an empty string. Differential Revision: https://phabricator.services.mozilla.com/D17300
layout/base/nsBidiPresUtils.cpp
--- a/layout/base/nsBidiPresUtils.cpp
+++ b/layout/base/nsBidiPresUtils.cpp
@@ -743,17 +743,17 @@ nsresult nsBidiPresUtils::ResolveParagra
 #  ifdef NOISY_BIDI
   printf(
       "Before Resolve(), mCurrentBlock=%p, mBuffer='%s', frameCount=%d, "
       "runCount=%d\n",
       (void*)aBpd->mCurrentBlock, NS_ConvertUTF16toUTF8(aBpd->mBuffer).get(),
       frameCount, runCount);
 #    ifdef REALLY_NOISY_BIDI
   printf(" block frame tree=:\n");
-  aBpd->mCurrentBlock->List(stdout, 0);
+  aBpd->mCurrentBlock->List(stdout);
 #    endif
 #  endif
 #endif
 
   if (runCount == 1 && frameCount == 1 && aBpd->GetDirection() == NSBIDI_LTR &&
       aBpd->GetParaLevel() == 0) {
     // We have a single left-to-right frame in a left-to-right paragraph,
     // without bidi isolation from the surrounding text.
@@ -976,17 +976,17 @@ nsresult nsBidiPresUtils::ResolveParagra
         JoinInlineAncestors(frame);
       }
     }
   }  // for
 
 #ifdef DEBUG
 #  ifdef REALLY_NOISY_BIDI
   printf("---\nAfter Resolve(), frameTree =:\n");
-  aBpd->mCurrentBlock->List(stdout, 0);
+  aBpd->mCurrentBlock->List(stdout);
   printf("===\n");
 #  endif
 #endif
 
   return rv;
 }
 
 void nsBidiPresUtils::TraverseFrames(nsBlockInFlowLineIterator* aLineIter,