Backed out changeset 5d6aca60d59c (bug 1216607) for failing on own test
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Mon, 26 Oct 2015 12:24:55 +0100
changeset 304673 f54d8e29d4876fbabef4f90dab37a374ba08d00b
parent 304672 724ce80732b9b15b137123bfb01d4391a9abbf1b
child 304674 56cd0fae8910c2387b5cc41d5f94dffd3a3a1c9e
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1216607
milestone44.0a1
backs out5d6aca60d59c0d2eeb77be6dce944a9b92fff092
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 5d6aca60d59c (bug 1216607) for failing on own test
js/src/jit-test/tests/gc/bug-1216607.js
js/src/jit/CompactBuffer.h
deleted file mode 100644
--- a/js/src/jit-test/tests/gc/bug-1216607.js
+++ /dev/null
@@ -1,16 +0,0 @@
-enableSPSProfilingWithSlowAssertions();
-try {
-(function() {
-   while (n--) {
-   }
-})();
-} catch(exc1) {}
-function arrayProtoOutOfRange() {
-    function f(obj) {}
-    function test() {
-        for (var i = 0; i < 1000; i++)
-            var r = f(i % 2 ? a : b);
-    }
-    test();
-}
-oomTest(arrayProtoOutOfRange);
--- a/js/src/jit/CompactBuffer.h
+++ b/js/src/jit/CompactBuffer.h
@@ -163,17 +163,17 @@ class CompactBufferWriter
         writeByte((value >> 24) & 0xFF);
     }
     void writeFixedUint16_t(uint16_t value) {
         writeByte(value & 0xFF);
         writeByte(value >> 8);
     }
     void writeNativeEndianUint32_t(uint32_t value) {
         // Must be at 4-byte boundary
-        MOZ_ASSERT_IF(!oom(), length() % sizeof(uint32_t) == 0);
+        MOZ_ASSERT(length() % sizeof(uint32_t) == 0);
         writeFixedUint32_t(0);
         if (oom())
             return;
         uint8_t* endPtr = buffer() + length();
         reinterpret_cast<uint32_t*>(endPtr)[-1] = value;
     }
     size_t length() const {
         return buffer_.length();