Bug 1148543 - Remove the add-on author from the install confirmation doorhanger. r=dtownsend
authorDão Gottwald <dao@mozilla.com>
Fri, 27 Mar 2015 23:02:06 +0100
changeset 266549 f3b29bc194825323d3caf53917d5eb8fc83967f9
parent 266548 af3c990c586542fedc067aa0ea311c403321c001
child 266550 230000accfbef06b7c892f507a03cfcbf7b379fa
push id830
push userraliiev@mozilla.com
push dateFri, 19 Jun 2015 19:24:37 +0000
treeherdermozilla-release@932614382a68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdtownsend
bugs1148543
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1148543 - Remove the add-on author from the install confirmation doorhanger. r=dtownsend
browser/base/content/browser-addons.js
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/base/content/browser-addons.js
+++ b/browser/base/content/browser-addons.js
@@ -174,27 +174,20 @@ const gXPInstallObserver = {
             this.acceptInstallation = null;
             break;
           case "shown":
             let addonList = document.getElementById("addon-install-confirmation-content");
             while (addonList.firstChild)
               addonList.firstChild.remove();
 
             for (let install of installInfo.installs) {
-              let container = document.createElement("hbox");
               let name = document.createElement("label");
-              let author = document.createElement("label");
               name.setAttribute("value", install.addon.name);
-              author.setAttribute("value", !install.addon.creator ? "" :
-                gNavigatorBundle.getFormattedString("addonConfirmInstall.author", [install.addon.creator]));
               name.setAttribute("class", "addon-install-confirmation-name");
-              author.setAttribute("class", "addon-install-confirmation-author");
-              container.appendChild(name);
-              container.appendChild(author);
-              addonList.appendChild(container);
+              addonList.appendChild(name);
             }
 
             this.acceptInstallation = () => {
               for (let install of installInfo.installs)
                 install.install();
               installInfo = null;
 
               Services.telemetry
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -43,19 +43,16 @@ addonInstall.acceptButton.label=Install
 addonInstall.acceptButton.accesskey=I
 
 # LOCALIZATION NOTE (addonConfirmInstallMessage):
 # Semicolon-separated list of plural forms. See:
 # http://developer.mozilla.org/en/docs/Localization_and_Plurals
 # #1 is brandShortName
 # #2 is the number of add-ons being installed
 addonConfirmInstall.message=This site would like to install an add-on in #1:;This site would like to install #2 add-ons in #1:
-# LOCALIZATION NOTE (addonConfirmInstall.author):
-# %S is the add-on author's name
-addonConfirmInstall.author=by %S
 
 addonwatch.slow=%1$S might be making %2$S run slowly
 addonwatch.disable.label=Disable %S
 addonwatch.disable.accesskey=D
 addonwatch.ignoreSession.label=Ignore for now
 addonwatch.ignoreSession.accesskey=I
 addonwatch.ignorePerm.label=Ignore permanently
 addonwatch.ignorePerm.accesskey=p